Linaro-mm-sig

linaro-mm-sig@lists.linaro.org

19 participants
3646 discussions

Re: [Linaro-mm-sig] [EXTERNAL] Re: [PATCH] sync_file: Return reasonable timestamp when merging signaled fences

by Chris Wilson

Quoting Michael Yang (2019-05-14 08:55:37) > On Thu, May 09, 2019 at 12:46:05PM +0100, Chris Wilson wrote: > > Quoting Michael Yang (2019-05-09 05:34:11) > > > If all the sync points were signaled in both fences a and b, > > > there was only one sync point in merged fence which is a_fence[0]. > > > The Fence structure in android framework might be confused about > > > timestamp if there were any sync points which were signaled after > > > a_fence[0]. It might be more reasonable to use timestamp of last signaled > > > sync point to represent the merged fence. > > > The issue can be found from EGL extension ANDROID_get_frame_timestamps. > > > Sometimes the return value of EGL_READS_DONE_TIME_ANDROID is head of > > > the return value of EGL_RENDERING_COMPLETE_TIME_ANDROID. > > > That means display/composition had been completed before rendering > > > was completed that is incorrect. > > > > > > Some discussion can be found at: > > > https://urldefense.proofpoint.com/v2/url?u=https-3A__android-2Dreview.googl… > > > > > > Signed-off-by: Michael Yang <michael.yang(a)imgtec.com> > > > --- > > > Hi, > > > I didn't get response since I previously sent this a month ago. > > > Could someone have a chance to look at it please? > > > Thanks. > > > drivers/dma-buf/sync_file.c | 25 +++++++++++++++++++++++-- > > > 1 file changed, 23 insertions(+), 2 deletions(-) > > > > > > diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c > > > index 4f6305c..d46bfe1 100644 > > > --- a/drivers/dma-buf/sync_file.c > > > +++ b/drivers/dma-buf/sync_file.c > > > @@ -274,8 +274,29 @@ static struct sync_file *sync_file_merge(const char *name, struct sync_file *a, > > > for (; i_b < b_num_fences; i_b++) > > > add_fence(fences, &i, b_fences[i_b]); > > > > > > - if (i == 0) > > > - fences[i++] = dma_fence_get(a_fences[0]); > > > + /* If all the sync pts were signaled, then adding the sync_pt who > > > + * was the last signaled to the fence. > > > + */ > > > + if (i == 0) { > > > + struct dma_fence *last_signaled_sync_pt = a_fences[0]; > > > + int iter; > > > + > > > + for (iter = 1; iter < a_num_fences; iter++) { > > > > If there is more than one fence, sync_file->fence is a fence_array and > > its timestamp is what you want. If there is one fence, sync_file->fence > > is a pointer to that fence, and naturally has the right timestamp. > > > > In short, this should be handled by dma_fence_array_create() when given > > a complete set of signaled fences, it too should inherit the signaled > > status with the timestamp being taken from the last fence. It should > > also be careful to inherit the error status. > > -Chris > Thanks Chris for the inputs. For this case, there will be only one fence > in sync_file->fence after doing sync_file_merge(). Regarding to the current > implementation, dma_fence_array_create() is not called as num_fences is equal > to 1. I was wondering do you suggest that we pass a complete set of signaled > fences to sync_file_set_fence() and handle it in dma_fence_array_create(). > Thanks. No, in the case there is only one fence, we just inherit its timestamp along with its fence status. (A single fence is the degenerate case of a fence array.) -Chris

7 years, 5 months

Re: [Linaro-mm-sig] [PATCH] sync_file: Return reasonable timestamp when merging signaled fences

by Chris Wilson

Quoting Michael Yang (2019-05-09 05:34:11) > If all the sync points were signaled in both fences a and b, > there was only one sync point in merged fence which is a_fence[0]. > The Fence structure in android framework might be confused about > timestamp if there were any sync points which were signaled after > a_fence[0]. It might be more reasonable to use timestamp of last signaled > sync point to represent the merged fence. > The issue can be found from EGL extension ANDROID_get_frame_timestamps. > Sometimes the return value of EGL_READS_DONE_TIME_ANDROID is head of > the return value of EGL_RENDERING_COMPLETE_TIME_ANDROID. > That means display/composition had been completed before rendering > was completed that is incorrect. > > Some discussion can be found at: > https://android-review.googlesource.com/c/kernel/common/+/907009 > > Signed-off-by: Michael Yang <michael.yang(a)imgtec.com> > --- > Hi, > I didn't get response since I previously sent this a month ago. > Could someone have a chance to look at it please? > Thanks. > drivers/dma-buf/sync_file.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma-buf/sync_file.c b/drivers/dma-buf/sync_file.c > index 4f6305c..d46bfe1 100644 > --- a/drivers/dma-buf/sync_file.c > +++ b/drivers/dma-buf/sync_file.c > @@ -274,8 +274,29 @@ static struct sync_file *sync_file_merge(const char *name, struct sync_file *a, > for (; i_b < b_num_fences; i_b++) > add_fence(fences, &i, b_fences[i_b]); > > - if (i == 0) > - fences[i++] = dma_fence_get(a_fences[0]); > + /* If all the sync pts were signaled, then adding the sync_pt who > + * was the last signaled to the fence. > + */ > + if (i == 0) { > + struct dma_fence *last_signaled_sync_pt = a_fences[0]; > + int iter; > + > + for (iter = 1; iter < a_num_fences; iter++) { If there is more than one fence, sync_file->fence is a fence_array and its timestamp is what you want. If there is one fence, sync_file->fence is a pointer to that fence, and naturally has the right timestamp. In short, this should be handled by dma_fence_array_create() when given a complete set of signaled fences, it too should inherit the signaled status with the timestamp being taken from the last fence. It should also be careful to inherit the error status. -Chris

7 years, 5 months

Re: [Linaro-mm-sig] [PATCH] staging: ion: solve warning symbol was not declared

by Dan Carpenter

On Mon, Apr 22, 2019 at 08:49:27PM +0200, Oscar Gomez Fuente wrote: > These changes solve warning symbol was not declared in the functions: > ion_carveout_heap_create and ion_chunk_heap_create > > Signed-off-by: Oscar Gomez Fuente <oscargomezf(a)gmail.com> > --- > drivers/staging/android/ion/ion_carveout_heap.c | 2 +- > drivers/staging/android/ion/ion_chunk_heap.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/android/ion/ion_carveout_heap.c b/drivers/staging/android/ion/ion_carveout_heap.c > index bb9d614..3f359ae 100644 > --- a/drivers/staging/android/ion/ion_carveout_heap.c > +++ b/drivers/staging/android/ion/ion_carveout_heap.c > @@ -103,7 +103,7 @@ static struct ion_heap_ops carveout_heap_ops = { > .unmap_kernel = ion_heap_unmap_kernel, > }; > > -struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size) > +static inline struct ion_heap *ion_carveout_heap_create(phys_addr_t base, size_t size) Why are you making it inline? Btw, normally we just leave it for the compiler to choose which functions to make inline. regards, dan carpenter

7 years, 5 months

Re: [Linaro-mm-sig] dynamic DMA-buf sharing between devices

by Christian König

On top of those I have 6 more patches in the pipeline to enable VRAM P2P with DMA-buf. So that is not the end of the patch set :) Christian. Am 17.04.19 um 15:52 schrieb Chunming Zhou: > Thanks Christian, great job. I will verify it this week when I finish my > current work on hand. > > -David > > 在 2019/4/17 2:38, Christian König wrote: >> Hi everybody, >> >> core idea in this patch set is that DMA-buf importers can now provide an optional invalidate callback. Using this callback and the reservation object exporters can now avoid pinning DMA-buf memory for a long time while sharing it between devices. >> >> I've already send out an older version roughly a year ago, but didn't had time to further look into cleaning this up. >> >> The last time a major problem was that we would had to fix up all drivers implementing DMA-buf at once. >> >> Now I avoid this by allowing mappings to be cached in the DMA-buf attachment and so driver can optionally move over to the new interface one by one. >> >> This is also a prerequisite to my patchset enabling sharing of device memory with DMA-buf. >> >> Please review and/or comment, >> Christian. >> >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel(a)lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel

7 years, 6 months

Re: [Linaro-mm-sig] [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

by Laura Abbott

On 3/29/19 7:26 PM, Zengtao (B) wrote: > Hi laura: > >> -----Original Message----- >> From: Laura Abbott [mailto:labbott@redhat.com] >> Sent: Friday, March 29, 2019 9:27 PM >> To: Zengtao (B) <prime.zeng(a)hisilicon.com>; sumit.semwal(a)linaro.org >> Cc: Greg Kroah-Hartman <gregkh(a)linuxfoundation.org>; Arve Hjønnevåg >> <arve(a)android.com>; Todd Kjos <tkjos(a)android.com>; Martijn Coenen >> <maco(a)android.com>; Joel Fernandes <joel(a)joelfernandes.org>; >> Christian Brauner <christian(a)brauner.io>; devel(a)driverdev.osuosl.org; >> dri-devel(a)lists.freedesktop.org; linaro-mm-sig(a)lists.linaro.org; >> linux-kernel(a)vger.kernel.org >> Subject: Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel >> driver use >> >> On 3/29/19 11:40 AM, Zeng Tao wrote: >>> There are two reasons for this patch: >>> 1. There are some potential requirements for ion_alloc in kernel >>> space, some media drivers need to allocate media buffers from ion >>> instead of buddy or dma framework, this is more convient and clean >>> very for media drivers. And In that case, ion is the only media buffer >>> provider, it's more easier to maintain. >>> 2. Fd is only needed by user processes, not the kernel space, so >>> dma_buf should be returned instead of fd for kernel space, and >>> dma_buf_fd should be called only for userspace api. >>> >> >> I really want to just NAK this because it doesn't seem like something >> that's necessary. The purpose of Ion is to provide buffers to userspace >> because there's no other way for userspace to get access to the memory. >> The kernel already has other APIs to access the memory. This also >> complicates the re-work that's been happening where the requirement is >> only userspace. >> >> Can you be more detailed about which media drivers you are referring to >> and why they can't just use other APIs? >> > > I think I 've got your point, the ION is designed for usespace, but for kernel > space, we are really lacking of someone which plays the same role,(allocate > media memory, share the memory using dma_buf, provide debug and statistics > for media memory). > > In fact, for kernel space, we have the dma framework, dma-buf, etc.. > And we can work on top of such apis, but some duplicate jobs(everyone has > to maintain its own buffer sharing, debug and statistics). > So we need to have some to do the common things(ION's the best choice now) > Keep in mind that Ion is a thin shell of what it was as most of the debugging and statistics was removed because it was buggy. Most of that should end up going at the dma_buf layer since it's really a dma_buf allocation API. > When the ION was introduced, a lot of media memory frameworks existed, the > dma framework was not so good, so ION heaps, integrated buffer sharing, statistics > and usespace api were the required features, but now dma framework is more powerful, > we don't even need ION heaps now, but the userspace api, buffer sharing, statistics are > still needed, and the buffer sharing, statistics can be re-worked and export to kernel space, > not only used by userspace, , and that is my point. > I see what you are getting at but I don't think the same thing applies to the kernel as it does userspace. We can enforce a single way of using the dma_buf fd in userspace but the kernel has a variety of ways to use dma_buf because each driver and framework has its own needs. I'm still not convinced that adding Ion APIs in the kernel is the right option since as you point out we don't really need the heaps. That mostly leaves Ion as a wrapper to handle doing the export. Maybe we could benefit from that but I think it might require more thought. I'd rather see a proposal in the media API itself showing what you think is necessary but without using Ion. That would be a good start so we could fully review what might make sense to pull out of Ion into something common. Thanks, Laura >> >>> Signed-off-by: Zeng Tao <prime.zeng(a)hisilicon.com> >>> --- >>> drivers/staging/android/ion/ion.c | 32 >> +++++++++++++++++--------------- >>> 1 file changed, 17 insertions(+), 15 deletions(-) >>> >>> diff --git a/drivers/staging/android/ion/ion.c >>> b/drivers/staging/android/ion/ion.c >>> index 92c2914..e93fb49 100644 >>> --- a/drivers/staging/android/ion/ion.c >>> +++ b/drivers/staging/android/ion/ion.c >>> @@ -387,13 +387,13 @@ static const struct dma_buf_ops >> dma_buf_ops = { >>> .unmap = ion_dma_buf_kunmap, >>> }; >>> >>> -static int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned >>> int flags) >>> +struct dma_buf *ion_alloc(size_t len, unsigned int heap_id_mask, >>> + unsigned int flags) >>> { >>> struct ion_device *dev = internal_dev; >>> struct ion_buffer *buffer = NULL; >>> struct ion_heap *heap; >>> DEFINE_DMA_BUF_EXPORT_INFO(exp_info); >>> - int fd; >>> struct dma_buf *dmabuf; >>> >>> pr_debug("%s: len %zu heap_id_mask %u flags %x\n", __func__, >> @@ >>> -407,7 +407,7 @@ static int ion_alloc(size_t len, unsigned int >> heap_id_mask, unsigned int flags) >>> len = PAGE_ALIGN(len); >>> >>> if (!len) >>> - return -EINVAL; >>> + return ERR_PTR(-EINVAL); >>> >>> down_read(&dev->lock); >>> plist_for_each_entry(heap, &dev->heaps, node) { @@ -421,10 >> +421,10 >>> @@ static int ion_alloc(size_t len, unsigned int heap_id_mask, >> unsigned int flags) >>> up_read(&dev->lock); >>> >>> if (!buffer) >>> - return -ENODEV; >>> + return ERR_PTR(-ENODEV); >>> >>> if (IS_ERR(buffer)) >>> - return PTR_ERR(buffer); >>> + return ERR_PTR(PTR_ERR(buffer)); >>> >>> exp_info.ops = &dma_buf_ops; >>> exp_info.size = buffer->size; >>> @@ -432,17 +432,12 @@ static int ion_alloc(size_t len, unsigned int >> heap_id_mask, unsigned int flags) >>> exp_info.priv = buffer; >>> >>> dmabuf = dma_buf_export(&exp_info); >>> - if (IS_ERR(dmabuf)) { >>> + if (IS_ERR(dmabuf)) >>> _ion_buffer_destroy(buffer); >>> - return PTR_ERR(dmabuf); >>> - } >>> >>> - fd = dma_buf_fd(dmabuf, O_CLOEXEC); >>> - if (fd < 0) >>> - dma_buf_put(dmabuf); >>> - >>> - return fd; >>> + return dmabuf; >>> } >>> +EXPORT_SYMBOL(ion_alloc); >>> >>> static int ion_query_heaps(struct ion_heap_query *query) >>> { >>> @@ -539,12 +534,19 @@ static long ion_ioctl(struct file *filp, unsigned >> int cmd, unsigned long arg) >>> case ION_IOC_ALLOC: >>> { >>> int fd; >>> + struct dma_buf *dmabuf; >>> >>> - fd = ion_alloc(data.allocation.len, >>> + dmabuf = ion_alloc(data.allocation.len, >>> data.allocation.heap_id_mask, >>> data.allocation.flags); >>> - if (fd < 0) >>> + if (IS_ERR(dmabuf)) >>> + return PTR_ERR(dmabuf); >>> + >>> + fd = dma_buf_fd(dmabuf, O_CLOEXEC); >>> + if (fd < 0) { >>> + dma_buf_put(dmabuf); >>> return fd; >>> + } >>> >>> data.allocation.fd = fd; >>> >>> >

7 years, 6 months

[PATCH] staging: android: ion: fix err_cast.cocci warnings

by kbuild test robot

From: kbuild test robot <lkp(a)intel.com> drivers/staging/android/ion/ion.c:427:9-16: WARNING: ERR_CAST can be used with buffer Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) Generated by: scripts/coccinelle/api/err_cast.cocci Fixes: d51f182d188a ("staging: android: ion: refactory ion_alloc for kernel driver use") CC: Zeng Tao <prime.zeng(a)hisilicon.com> Signed-off-by: kbuild test robot <lkp(a)intel.com> --- url: https://github.com/0day-ci/linux/commits/Zeng-Tao/staging-android-ion-refac… ion.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/staging/android/ion/ion.c +++ b/drivers/staging/android/ion/ion.c @@ -424,7 +424,7 @@ struct dma_buf *ion_alloc(size_t len, un return ERR_PTR(-ENODEV); if (IS_ERR(buffer)) - return ERR_PTR(PTR_ERR(buffer)); + return ERR_CAST(buffer); exp_info.ops = &dma_buf_ops; exp_info.size = buffer->size;

7 years, 6 months

Re: [Linaro-mm-sig] [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

by kbuild test robot

Hi Zeng, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on staging/staging-testing] [also build test WARNING on v5.1-rc2 next-20190329] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Zeng-Tao/staging-android-ion-refac… coccinelle warnings: (new ones prefixed by >>) >> drivers/staging/android/ion/ion.c:427:9-16: WARNING: ERR_CAST can be used with buffer Please review and possibly fold the followup patch. --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation

7 years, 6 months

Re: [Linaro-mm-sig] [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

by Greg Kroah-Hartman

On Sat, Mar 30, 2019 at 02:32:35AM +0000, Zengtao (B) wrote: > >-----Original Message----- > >From: Greg Kroah-Hartman [mailto:gregkh@linuxfoundation.org] > >Sent: Saturday, March 30, 2019 12:04 AM > >To: Zengtao (B) <prime.zeng(a)hisilicon.com> > >Cc: labbott(a)redhat.com; sumit.semwal(a)linaro.org; > >devel(a)driverdev.osuosl.org; Todd Kjos <tkjos(a)android.com>; > >linux-kernel(a)vger.kernel.org; dri-devel(a)lists.freedesktop.org; > >linaro-mm-sig(a)lists.linaro.org; Arve Hjønnevåg <arve(a)android.com>; > >Joel Fernandes <joel(a)joelfernandes.org>; Martijn Coenen > ><maco(a)android.com>; Christian Brauner <christian(a)brauner.io> > >Subject: Re: [PATCH] staging: android: ion: refactory ion_alloc for kernel > >driver use > > > >On Sat, Mar 30, 2019 at 02:40:16AM +0800, Zeng Tao wrote: > >> There are two reasons for this patch: > >> 1. There are some potential requirements for ion_alloc in kernel > >> space, some media drivers need to allocate media buffers from ion > >> instead of buddy or dma framework, this is more convient and clean > >> very for media drivers. And In that case, ion is the only media buffer > >> provider, it's more easier to maintain. > > > >As this really is just DMA, what is wrong with the existing dma framework > >that makes it hard to use? You have seen all of the changes recently to it, > >right? > > The current dma framework is powerful enough(to me, and more complex ^_^) > , CMA, IOMMU are all integrated, it's good. But buffer sharing, statistics, debug, > are not so friendly for media drivers(each driver has to do all, but duplicate jobs). Then go add statistics and debugging to the dma code so that everyone benefits! thanks, greg k-h

7 years, 6 months

Re: [Linaro-mm-sig] [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

by Greg Kroah-Hartman

7 years, 6 months

Re: [Linaro-mm-sig] [PATCH] staging: android: ion: refactory ion_alloc for kernel driver use

by Greg Kroah-Hartman

On Sat, Mar 30, 2019 at 02:40:16AM +0800, Zeng Tao wrote: > There are two reasons for this patch: > 1. There are some potential requirements for ion_alloc in kernel space, > some media drivers need to allocate media buffers from ion instead of > buddy or dma framework, this is more convient and clean very for media > drivers. And In that case, ion is the only media buffer provider, it's > more easier to maintain. > 2. Fd is only needed by user processes, not the kernel space, so dma_buf > should be returned instead of fd for kernel space, and dma_buf_fd should > be called only for userspace api. > > Signed-off-by: Zeng Tao <prime.zeng(a)hisilicon.com> > --- > drivers/staging/android/ion/ion.c | 32 +++++++++++++++++--------------- > 1 file changed, 17 insertions(+), 15 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 92c2914..e93fb49 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -387,13 +387,13 @@ static const struct dma_buf_ops dma_buf_ops = { > .unmap = ion_dma_buf_kunmap, > }; > > -static int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned int flags) > +struct dma_buf *ion_alloc(size_t len, unsigned int heap_id_mask, > + unsigned int flags) > { > struct ion_device *dev = internal_dev; > struct ion_buffer *buffer = NULL; > struct ion_heap *heap; > DEFINE_DMA_BUF_EXPORT_INFO(exp_info); > - int fd; > struct dma_buf *dmabuf; > > pr_debug("%s: len %zu heap_id_mask %u flags %x\n", __func__, > @@ -407,7 +407,7 @@ static int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned int flags) > len = PAGE_ALIGN(len); > > if (!len) > - return -EINVAL; > + return ERR_PTR(-EINVAL); > > down_read(&dev->lock); > plist_for_each_entry(heap, &dev->heaps, node) { > @@ -421,10 +421,10 @@ static int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned int flags) > up_read(&dev->lock); > > if (!buffer) > - return -ENODEV; > + return ERR_PTR(-ENODEV); > > if (IS_ERR(buffer)) > - return PTR_ERR(buffer); > + return ERR_PTR(PTR_ERR(buffer)); > > exp_info.ops = &dma_buf_ops; > exp_info.size = buffer->size; > @@ -432,17 +432,12 @@ static int ion_alloc(size_t len, unsigned int heap_id_mask, unsigned int flags) > exp_info.priv = buffer; > > dmabuf = dma_buf_export(&exp_info); > - if (IS_ERR(dmabuf)) { > + if (IS_ERR(dmabuf)) > _ion_buffer_destroy(buffer); > - return PTR_ERR(dmabuf); > - } > > - fd = dma_buf_fd(dmabuf, O_CLOEXEC); > - if (fd < 0) > - dma_buf_put(dmabuf); > - > - return fd; > + return dmabuf; > } > +EXPORT_SYMBOL(ion_alloc); If you are going to do this (and personally I'm with Laura in that I don't think you need it) this should be EXPORT_SYMBOL_GPL() please. thanks, greg k-h

7 years, 6 months

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig