Linaro-mm-sig

linaro-mm-sig@lists.linaro.org

20 participants
2957 discussions

Re: [Linaro-mm-sig] [PATCH 03/40] drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s 'job' param

by Alex Deucher

On Mon, Nov 23, 2020 at 6:19 AM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c:127: warning: Function parameter or member 'job' not described in 'amdgpu_ib_schedule' > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > index c69af9b86cc60..024d0a563a652 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c > @@ -106,6 +106,7 @@ void amdgpu_ib_free(struct amdgpu_device *adev, struct amdgpu_ib *ib, > * @ring: ring index the IB is associated with > * @num_ibs: number of IBs to schedule > * @ibs: IB objects to schedule > + * @job: job to schedule > * @f: fence created during this submission > * > * Schedule an IB on the associated ring (all asics). > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 02/40] drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags'

by Alex Deucher

On Mon, Nov 23, 2020 at 6:19 AM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c:1214: warning: Function parameter or member 'page_flags' not described in 'amdgpu_ttm_tt_create' > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: Jerome Glisse <glisse(a)freedesktop.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > index 5fcdd67e5a913..debbcef961dd5 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c > @@ -1199,6 +1199,7 @@ static void amdgpu_ttm_backend_destroy(struct ttm_bo_device *bdev, > * amdgpu_ttm_tt_create - Create a ttm_tt object for a given BO > * > * @bo: The buffer object to create a GTT ttm_tt object around > + * @page_flags: Page flags to be added to the ttm_tt object > * > * Called by ttm_tt_create(). > */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 00/40] [Set 8] Rid W=1 warnings from GPU

by Christian König

Only skimmed over them, but over all looks sane to me. Series is Acked-by: Christian König <christian.koenig(a)amd.com> Thanks, Christian. Am 23.11.20 um 12:18 schrieb Lee Jones: > This set is part of a larger effort attempting to clean-up W=1 > kernel builds, which are currently overwhelmingly riddled with > niggly little warnings. > > Only 900 (from 5000) to go! > > Lee Jones (40): > drm/radeon/radeon_device: Consume our own header where the prototypes > are located > drm/amd/amdgpu/amdgpu_ttm: Add description for 'page_flags' > drm/amd/amdgpu/amdgpu_ib: Provide docs for 'amdgpu_ib_schedule()'s > 'job' param > drm/amd/amdgpu/amdgpu_virt: Correct possible copy/paste or doc-rot > misnaming issue > drm/amd/amdgpu/cik_ih: Supply description for 'ih' in > 'cik_ih_{get,set}_wptr()' > drm/amd/amdgpu/uvd_v4_2: Fix some kernel-doc misdemeanours > drm/amd/amdgpu/dce_v8_0: Supply description for 'async' > drm/amd/amdgpu/cik_sdma: Supply some missing function param > descriptions > drm/amd/amdgpu/gfx_v7_0: Clean-up a bunch of kernel-doc related issues > drm/msm/disp/dpu1/dpu_core_perf: Fix kernel-doc formatting issues > drm/msm/disp/dpu1/dpu_hw_blk: Add one missing and remove an extra > param description > drm/msm/disp/dpu1/dpu_formats: Demote non-conformant kernel-doc header > drm/msm/disp/dpu1/dpu_hw_catalog: Remove duplicated initialisation of > 'max_linewidth' > drm/msm/disp/dpu1/dpu_hw_catalog: Move definitions to the only place > they are used > drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc > drm/amd/amdgpu/si_dma: Fix a bunch of function documentation issues > drm/amd/amdgpu/gfx_v6_0: Supply description for > 'gfx_v6_0_ring_test_ib()'s 'timeout' param > drm/msm/disp/dpu1/dpu_encoder: Fix a few parameter/member formatting > issues > drm/msm/disp/dpu1/dpu_hw_lm: Fix misnaming of parameter 'ctx' > drm/msm/disp/dpu1/dpu_hw_sspp: Fix kernel-doc formatting abuse > drm/amd/amdgpu/uvd_v3_1: Fix-up some documentation issues > drm/amd/amdgpu/dce_v6_0: Fix formatting and missing parameter > description issues > drm/amd/include/vega20_ip_offset: Mark top-level IP_BASE definition as > __maybe_unused > drm/amd/include/navi10_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/arct_ip_offset: Mark top-level IP_BASE definition as > __maybe_unused > drm/amd/include/navi14_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/navi12_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/sienna_cichlid_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/vangogh_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/amd/include/dimgrey_cavefish_ip_offset: Mark top-level IP_BASE as > __maybe_unused > drm/msm/disp/dpu1/dpu_rm: Fix formatting issues and supply > 'global_state' description > drm/msm/disp/dpu1/dpu_vbif: Fix a couple of function param > descriptions > drm/amd/amdgpu/cik_sdma: Add one and remove another function param > description > drm/amd/amdgpu/uvd_v4_2: Add one and remove another function param > description > drm/msm/disp/dpu1/dpu_plane: Fix some spelling and missing function > param descriptions > drm/amd/amdgpu/gmc_v7_0: Add some missing kernel-doc descriptions > drm/amd/amdgpu/gmc_v8_0: Fix more issues attributed to copy/paste > drm/msm/msm_drv: Make '_msm_ioremap()' static > drm/amd/amdgpu/gmc_v9_0: Remove unused table > 'ecc_umc_mcumc_status_addrs' > drm/amd/amdgpu/gmc_v9_0: Suppy some missing function doc descriptions > > drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 1 + > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 12 +- > drivers/gpu/drm/amd/amdgpu/cik_ih.c | 2 + > drivers/gpu/drm/amd/amdgpu/cik_sdma.c | 18 ++- > drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 2 +- > drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v6_0.c | 1 + > drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c | 33 +++-- > drivers/gpu/drm/amd/amdgpu/gmc_v7_0.c | 7 +- > drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 5 + > drivers/gpu/drm/amd/amdgpu/gmc_v9_0.c | 38 +---- > drivers/gpu/drm/amd/amdgpu/si_dma.c | 14 +- > drivers/gpu/drm/amd/amdgpu/uvd_v3_1.c | 10 +- > drivers/gpu/drm/amd/amdgpu/uvd_v4_2.c | 10 +- > drivers/gpu/drm/amd/include/arct_ip_offset.h | 4 +- > .../amd/include/dimgrey_cavefish_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi10_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi12_ip_offset.h | 2 +- > .../gpu/drm/amd/include/navi14_ip_offset.h | 2 +- > .../amd/include/sienna_cichlid_ip_offset.h | 2 +- > .../gpu/drm/amd/include/vangogh_ip_offset.h | 2 +- > .../gpu/drm/amd/include/vega20_ip_offset.h | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 17 +-- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 15 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_blk.c | 2 +- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 75 +++++++++- > .../drm/msm/disp/dpu1/dpu_hw_catalog_format.h | 88 ------------ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_lm.c | 2 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.c | 4 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 19 ++- > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 5 +- > drivers/gpu/drm/msm/disp/dpu1/dpu_vbif.c | 2 +- > drivers/gpu/drm/msm/msm_drv.c | 4 +- > .../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 136 +++++++++--------- > drivers/gpu/drm/radeon/radeon_device.c | 1 + > 37 files changed, 277 insertions(+), 268 deletions(-) > delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog_format.h > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: Ben Skeggs <bskeggs(a)redhat.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Drew Davenport <ddavenport(a)chromium.org> > Cc: dri-devel(a)lists.freedesktop.org > Cc: freedreno(a)lists.freedesktop.org > Cc: Fritz Koenig <frkoenig(a)google.com> > Cc: Hawking Zhang <Hawking.Zhang(a)amd.com> > Cc: Huang Rui <ray.huang(a)amd.com> > Cc: Jerome Glisse <glisse(a)freedesktop.org> > Cc: Jiansong Chen <Jiansong.Chen(a)amd.com> > Cc: Jonathan Marek <jonathan(a)marek.ca> > Cc: Kalyan Thota <kalyan_t(a)codeaurora.org> > Cc: Likun Gao <Likun.Gao(a)amd.com> > Cc: linaro-mm-sig(a)lists.linaro.org > Cc: linux-arm-msm(a)vger.kernel.org > Cc: linux-media(a)vger.kernel.org > Cc: Luben Tuikov <luben.tuikov(a)amd.com> > Cc: nouveau(a)lists.freedesktop.org > Cc: Qinglang Miao <miaoqinglang(a)huawei.com> > Cc: Rob Clark <robdclark(a)gmail.com> > Cc: Sean Paul <sean(a)poorly.run> > Cc: Sonny Jiang <sonny.jiang(a)amd.com> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: Tao Zhou <tao.zhou1(a)amd.com>

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH] drm/ttm: remove unused varibles

by Christian König

Am 20.11.20 um 07:49 schrieb Tian Tao: > fixed the following warnings > drivers/gpu/drm/nouveau/nouveau_bo.c:1227:17: warning: variable ‘dev’ > set but not used [-Wunused-but-set-variable] > drivers/gpu/drm/nouveau/nouveau_bo.c:1251:17: warning: variable ‘dev’ > set but not used [-Wunused-but-set-variable] > > Signed-off-by: Tian Tao <tiantao6(a)hisilicon.com> The subject should read drm/nouveau instead of drm/ttm, but apart from that the patch is Acked-by: Christian König <christian.koenig(a)amd.com> > --- > drivers/gpu/drm/nouveau/nouveau_bo.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_bo.c > index 7aa4286..9465f56 100644 > --- a/drivers/gpu/drm/nouveau/nouveau_bo.c > +++ b/drivers/gpu/drm/nouveau/nouveau_bo.c > @@ -1228,7 +1228,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev, > { > struct ttm_tt *ttm_dma = (void *)ttm; > struct nouveau_drm *drm; > - struct device *dev; > bool slave = !!(ttm->page_flags & TTM_PAGE_FLAG_SG); > > if (ttm_tt_is_populated(ttm)) > @@ -1242,7 +1241,6 @@ nouveau_ttm_tt_populate(struct ttm_bo_device *bdev, > } > > drm = nouveau_bdev(bdev); > - dev = drm->dev->dev; > > return ttm_pool_alloc(&drm->ttm.bdev.pool, ttm, ctx); > }

4 years, 7 months

cleanup a fix and add the vma_set_file function

by Christian König

Hi Andrew, can I get you Acked-by to merge this cleanup through the drm-misc-next branch? The affected drivers are mostly from the DRM subsystem. The fix for the other problem you pointed out in mmap_region() has already shown up in that branch. Thanks in advance, Christian.

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 1/9] dt-binding: soc: xilinx: ai-engine: Add AI engine binding

by Rob Herring

On Wed, 18 Nov 2020 00:06:12 -0800, Wendy Liang wrote: > Xilinx AI engine array can be partitioned statically for different > applications. In the device tree, there will be device node for the AI > engine device, and device nodes for the statically configured AI engine > partitions. Each of the statically configured partition has a partition > ID in the system. > > Signed-off-by: Wendy Liang <wendy.liang(a)xilinx.com> > --- > .../bindings/soc/xilinx/xlnx,ai-engine.yaml | 119 +++++++++++++++++++++ > 1 file changed, 119 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml:10:2: [warning] wrong indentation: expected 2 but found 1 (indentation) dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml: 'additionalProperties' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/soc/xilinx/xlnx,ai-engine.yaml See https://patchwork.ozlabs.org/patch/1402008 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 31/42] drm/ttm/ttm_bo: Fix one function header - demote lots of kernel-doc abuses

by Christian König

Am 16.11.20 um 18:41 schrieb Lee Jones: > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/ttm/ttm_bo.c:51: warning: Function parameter or member 'ttm_global_mutex' not described in 'DEFINE_MUTEX' > drivers/gpu/drm/ttm/ttm_bo.c:286: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_memtype_use' > drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'bo' not described in 'ttm_bo_cleanup_refs' > drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'interruptible' not described in 'ttm_bo_cleanup_refs' > drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'no_wait_gpu' not described in 'ttm_bo_cleanup_refs' > drivers/gpu/drm/ttm/ttm_bo.c:359: warning: Function parameter or member 'unlock_resv' not described in 'ttm_bo_cleanup_refs' > drivers/gpu/drm/ttm/ttm_bo.c:424: warning: Function parameter or member 'bdev' not described in 'ttm_bo_delayed_delete' > drivers/gpu/drm/ttm/ttm_bo.c:424: warning: Function parameter or member 'remove_all' not described in 'ttm_bo_delayed_delete' > drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'bo' not described in 'ttm_bo_evict_swapout_allowable' > drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'ctx' not described in 'ttm_bo_evict_swapout_allowable' > drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'locked' not described in 'ttm_bo_evict_swapout_allowable' > drivers/gpu/drm/ttm/ttm_bo.c:635: warning: Function parameter or member 'busy' not described in 'ttm_bo_evict_swapout_allowable' > drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'bo' not described in 'ttm_bo_add_move_fence' > drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'man' not described in 'ttm_bo_add_move_fence' > drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'mem' not described in 'ttm_bo_add_move_fence' > drivers/gpu/drm/ttm/ttm_bo.c:769: warning: Function parameter or member 'no_wait_gpu' not described in 'ttm_bo_add_move_fence' > drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'bo' not described in 'ttm_bo_mem_force_space' > drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'place' not described in 'ttm_bo_mem_force_space' > drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'mem' not described in 'ttm_bo_mem_force_space' > drivers/gpu/drm/ttm/ttm_bo.c:806: warning: Function parameter or member 'ctx' not described in 'ttm_bo_mem_force_space' > drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'bo' not described in 'ttm_bo_mem_space' > drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'placement' not described in 'ttm_bo_mem_space' > drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'mem' not described in 'ttm_bo_mem_space' > drivers/gpu/drm/ttm/ttm_bo.c:872: warning: Function parameter or member 'ctx' not described in 'ttm_bo_mem_space' > drivers/gpu/drm/ttm/ttm_bo.c:1387: warning: Function parameter or member 'ctx' not described in 'ttm_bo_swapout' > > Cc: Christian Koenig <christian.koenig(a)amd.com> > Cc: Huang Rui <ray.huang(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Reviewed-by: Christian König <christian.koenig(a)amd.com> Going to pick that one up for upstreaming. Thanks, Christian. > --- > drivers/gpu/drm/ttm/ttm_bo.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c > index e6bcbfe530ecc..9a03c7834b1ed 100644 > --- a/drivers/gpu/drm/ttm/ttm_bo.c > +++ b/drivers/gpu/drm/ttm/ttm_bo.c > @@ -45,7 +45,7 @@ > > static void ttm_bo_global_kobj_release(struct kobject *kobj); > > -/** > +/* > * ttm_global_mutex - protecting the global BO state > */ > DEFINE_MUTEX(ttm_global_mutex); > @@ -278,7 +278,7 @@ static int ttm_bo_handle_move_mem(struct ttm_buffer_object *bo, > return ret; > } > > -/** > +/* > * Call bo::reserved. > * Will release GPU memory type usage on destruction. > * This is the place to put in driver specific hooks to release > @@ -352,9 +352,10 @@ static void ttm_bo_flush_all_fences(struct ttm_buffer_object *bo) > * Must be called with lru_lock and reservation held, this function > * will drop the lru lock and optionally the reservation lock before returning. > * > - * @interruptible Any sleeps should occur interruptibly. > - * @no_wait_gpu Never wait for gpu. Return -EBUSY instead. > - * @unlock_resv Unlock the reservation lock as well. > + * @bo: The buffer object to clean-up > + * @interruptible: Any sleeps should occur interruptibly. > + * @no_wait_gpu: Never wait for gpu. Return -EBUSY instead. > + * @unlock_resv: Unlock the reservation lock as well. > */ > > static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, > @@ -420,7 +421,7 @@ static int ttm_bo_cleanup_refs(struct ttm_buffer_object *bo, > return 0; > } > > -/** > +/* > * Traverse the delayed list, and call ttm_bo_cleanup_refs on all > * encountered buffers. > */ > @@ -628,7 +629,7 @@ bool ttm_bo_eviction_valuable(struct ttm_buffer_object *bo, > } > EXPORT_SYMBOL(ttm_bo_eviction_valuable); > > -/** > +/* > * Check the target bo is allowable to be evicted or swapout, including cases: > * > * a. if share same reservation object with ctx->resv, have assumption > @@ -767,7 +768,7 @@ int ttm_mem_evict_first(struct ttm_bo_device *bdev, > return ret; > } > > -/** > +/* > * Add the last move fence to the BO and reserve a new shared slot. > */ > static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, > @@ -803,7 +804,7 @@ static int ttm_bo_add_move_fence(struct ttm_buffer_object *bo, > return 0; > } > > -/** > +/* > * Repeatedly evict memory from the LRU for @mem_type until we create enough > * space, or we've evicted everything and there isn't enough space. > */ > @@ -865,7 +866,7 @@ static int ttm_bo_mem_placement(struct ttm_buffer_object *bo, > return 0; > } > > -/** > +/* > * Creates space for memory region @mem according to its type. > * > * This function first searches for free space in compatible memory types in > @@ -1430,7 +1431,7 @@ int ttm_bo_wait(struct ttm_buffer_object *bo, > } > EXPORT_SYMBOL(ttm_bo_wait); > > -/** > +/* > * A buffer object shrink method that tries to swap out the first > * buffer object on the bo_global::swap_lru list. > */

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 40/43] drm/radeon/cik: Move 'vce_v2_0_enable_mgcg()'s prototype to shared header

by Alex Deucher

On Mon, Nov 16, 2020 at 12:38 PM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/vce_v2_0.c:111:6: warning: no previous prototype for ‘vce_v2_0_enable_mgcg’ [-Wmissing-prototypes] > 111 | void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable) > | ^~~~~~~~~~~~~~~~~~~~ > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/cik.c | 2 +- > drivers/gpu/drm/radeon/vce.h | 1 + > drivers/gpu/drm/radeon/vce_v2_0.c | 1 + > 3 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > index 2af76463906ad..8b7a4f7b75766 100644 > --- a/drivers/gpu/drm/radeon/cik.c > +++ b/drivers/gpu/drm/radeon/cik.c > @@ -41,6 +41,7 @@ > #include "radeon_audio.h" > #include "radeon_ucode.h" > #include "si.h" > +#include "vce.h" > > #define SH_MEM_CONFIG_GFX_DEFAULT \ > ALIGNMENT_MODE(SH_MEM_ALIGNMENT_MODE_UNALIGNED) > @@ -129,7 +130,6 @@ MODULE_FIRMWARE("radeon/mullins_rlc.bin"); > MODULE_FIRMWARE("radeon/mullins_sdma.bin"); > > static u32 cik_get_cu_active_bitmap(struct radeon_device *rdev, u32 se, u32 sh); > -extern void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable); > static void cik_rlc_stop(struct radeon_device *rdev); > static void cik_pcie_gen3_enable(struct radeon_device *rdev); > static void cik_program_aspm(struct radeon_device *rdev); > diff --git a/drivers/gpu/drm/radeon/vce.h b/drivers/gpu/drm/radeon/vce.h > index 1eb4f5715202e..ccc9c00f0d02c 100644 > --- a/drivers/gpu/drm/radeon/vce.h > +++ b/drivers/gpu/drm/radeon/vce.h > @@ -30,5 +30,6 @@ > struct radeon_device; > > void vce_v1_0_enable_mgcg(struct radeon_device *rdev, bool enable); > +void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable); > > #endif /* __VCE_H__ */ > diff --git a/drivers/gpu/drm/radeon/vce_v2_0.c b/drivers/gpu/drm/radeon/vce_v2_0.c > index d6fde3659e65f..163c9bfc03da8 100644 > --- a/drivers/gpu/drm/radeon/vce_v2_0.c > +++ b/drivers/gpu/drm/radeon/vce_v2_0.c > @@ -30,6 +30,7 @@ > #include "radeon.h" > #include "radeon_asic.h" > #include "cikd.h" > +#include "vce.h" > > #define VCE_V2_0_FW_SIZE (256 * 1024) > #define VCE_V2_0_STACK_SIZE (64 * 1024) > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 38/43] drm/radeon/cik: Move 'Move 'cik_sdma_*()'s prototypes to shared header

by Alex Deucher

On Mon, Nov 16, 2020 at 12:38 PM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/cik_sdma.c:331:6: warning: no previous prototype for ‘cik_sdma_enable’ [-Wmissing-prototypes] > 331 | void cik_sdma_enable(struct radeon_device *rdev, bool enable) > | ^~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/cik_sdma.c:528:5: warning: no previous prototype for ‘cik_sdma_resume’ [-Wmissing-prototypes] > 528 | int cik_sdma_resume(struct radeon_device *rdev) > | ^~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/cik_sdma.c:557:6: warning: no previous prototype for ‘cik_sdma_fini’ [-Wmissing-prototypes] > 557 | void cik_sdma_fini(struct radeon_device *rdev) > | ^~~~~~~~~~~~~ > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/cik.c | 3 --- > drivers/gpu/drm/radeon/cik.h | 3 +++ > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > index cef0f3111cd3a..2af76463906ad 100644 > --- a/drivers/gpu/drm/radeon/cik.c > +++ b/drivers/gpu/drm/radeon/cik.c > @@ -129,9 +129,6 @@ MODULE_FIRMWARE("radeon/mullins_rlc.bin"); > MODULE_FIRMWARE("radeon/mullins_sdma.bin"); > > static u32 cik_get_cu_active_bitmap(struct radeon_device *rdev, u32 se, u32 sh); > -extern int cik_sdma_resume(struct radeon_device *rdev); > -extern void cik_sdma_enable(struct radeon_device *rdev, bool enable); > -extern void cik_sdma_fini(struct radeon_device *rdev); > extern void vce_v2_0_enable_mgcg(struct radeon_device *rdev, bool enable); > static void cik_rlc_stop(struct radeon_device *rdev); > static void cik_pcie_gen3_enable(struct radeon_device *rdev); > diff --git a/drivers/gpu/drm/radeon/cik.h b/drivers/gpu/drm/radeon/cik.h > index 420207d19de52..d1bf541da5923 100644 > --- a/drivers/gpu/drm/radeon/cik.h > +++ b/drivers/gpu/drm/radeon/cik.h > @@ -34,4 +34,7 @@ void cik_init_cp_pg_table(struct radeon_device *rdev); > u32 cik_get_csb_size(struct radeon_device *rdev); > void cik_get_csb_buffer(struct radeon_device *rdev, volatile u32 *buffer); > > +int cik_sdma_resume(struct radeon_device *rdev); > +void cik_sdma_enable(struct radeon_device *rdev, bool enable); > +void cik_sdma_fini(struct radeon_device *rdev); > #endif /* __CIK_H__ */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Re: [Linaro-mm-sig] [PATCH 31/43] drm/radeon/cik: Move 'si_*()'s prototypes to shared header

by Alex Deucher

On Mon, Nov 16, 2020 at 12:38 PM Lee Jones <lee.jones(a)linaro.org> wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/gpu/drm/radeon/si.c:4186:6: warning: no previous prototype for ‘si_vram_gtt_location’ [-Wmissing-prototypes] > 4186 | void si_vram_gtt_location(struct radeon_device *rdev, > | ^~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/si.c:5186:6: warning: no previous prototype for ‘si_init_uvd_internal_cg’ [-Wmissing-prototypes] > 5186 | void si_init_uvd_internal_cg(struct radeon_device *rdev) > | ^~~~~~~~~~~~~~~~~~~~~~~ > drivers/gpu/drm/radeon/si.c:5801:6: warning: no previous prototype for ‘si_rlc_reset’ [-Wmissing-prototypes] > 5801 | void si_rlc_reset(struct radeon_device *rdev) > | ^~~~~~~~~~~~ > > Cc: Alex Deucher <alexander.deucher(a)amd.com> > Cc: "Christian König" <christian.koenig(a)amd.com> > Cc: David Airlie <airlied(a)linux.ie> > Cc: Daniel Vetter <daniel(a)ffwll.ch> > Cc: Sumit Semwal <sumit.semwal(a)linaro.org> > Cc: amd-gfx(a)lists.freedesktop.org > Cc: dri-devel(a)lists.freedesktop.org > Cc: linux-media(a)vger.kernel.org > Cc: linaro-mm-sig(a)lists.linaro.org > Signed-off-by: Lee Jones <lee.jones(a)linaro.org> Applied. Thanks! Alex > --- > drivers/gpu/drm/radeon/cik.c | 4 +--- > drivers/gpu/drm/radeon/si.h | 4 ++++ > 2 files changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/drivers/gpu/drm/radeon/cik.c > index ae020ad7b3185..cef0f3111cd3a 100644 > --- a/drivers/gpu/drm/radeon/cik.c > +++ b/drivers/gpu/drm/radeon/cik.c > @@ -40,6 +40,7 @@ > #include "radeon_asic.h" > #include "radeon_audio.h" > #include "radeon_ucode.h" > +#include "si.h" > > #define SH_MEM_CONFIG_GFX_DEFAULT \ > ALIGNMENT_MODE(SH_MEM_ALIGNMENT_MODE_UNALIGNED) > @@ -127,9 +128,6 @@ MODULE_FIRMWARE("radeon/mullins_mec.bin"); > MODULE_FIRMWARE("radeon/mullins_rlc.bin"); > MODULE_FIRMWARE("radeon/mullins_sdma.bin"); > > -extern void si_vram_gtt_location(struct radeon_device *rdev, struct radeon_mc *mc); > -extern void si_rlc_reset(struct radeon_device *rdev); > -extern void si_init_uvd_internal_cg(struct radeon_device *rdev); > static u32 cik_get_cu_active_bitmap(struct radeon_device *rdev, u32 se, u32 sh); > extern int cik_sdma_resume(struct radeon_device *rdev); > extern void cik_sdma_enable(struct radeon_device *rdev, bool enable); > diff --git a/drivers/gpu/drm/radeon/si.h b/drivers/gpu/drm/radeon/si.h > index a1751ae560f02..f483a64d17050 100644 > --- a/drivers/gpu/drm/radeon/si.h > +++ b/drivers/gpu/drm/radeon/si.h > @@ -25,8 +25,12 @@ > #define __SI_H__ > > struct radeon_device; > +struct radeon_mc; > > int si_mc_load_microcode(struct radeon_device *rdev); > u32 si_gpu_check_soft_reset(struct radeon_device *rdev); > +void si_vram_gtt_location(struct radeon_device *rdev, struct radeon_mc *mc); > +void si_rlc_reset(struct radeon_device *rdev); > +void si_init_uvd_internal_cg(struct radeon_device *rdev); > > #endif /* __SI_H__ */ > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel(a)lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel

4 years, 7 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig