- Linaro-mm-sig - lists.linaro.org

Re: [PATCH] misc: sram: Add dma-heap-export reserved SRAM area type

by Christian Gmeiner

Hi Andrew > > > Okay, will split for v2. > > Was there a follow-up v2 of this patchset? AFAICT this series did not make it into the mainline kernel. Do you have any plans to work on it? If not I would like to help out as we have a use case where we want to use a dma-buf sram exporter. -- greets -- Christian Gmeiner, MSc https://christian-gmeiner.info/privacypolicy

2 years, 1 month

2
4
0 0

Linux 6.2.1 hits a display driver bug (list_del corruption, ffff88811b4af298->next is NULL)

by Ammar Faizi

Hi, Linux 6.2.1 hits a display driver bug (list_del corruption, ffff88811b4af298->next is NULL). Unfortunately, I don't know the last good commit and the first bad commit. Kernel cmdline: BOOT_IMAGE=/boot/vmlinuz-6.2.1-2023-03-02+ root=UUID=7fde1a94-25e3-4995-adfc-654939cc8442 ro mitigations=off pti=off log_buf_len=32M modprobe.blacklist=bluetooth intel_iommu=igfx_off Kernel version: Linux 6.2.1 (with Ubuntu 22.04) Hardware info: integral2 description: Notebook product: HP Laptop 14s-dq2xxx (308Z6PA#AR6) vendor: HP version: Chassis Version serial: 5CD1409WC1 width: 64 bits capabilities: smbios-3.3.0 dmi-3.3.0 smp vsyscall32 configuration: boot=normal chassis=notebook family=103C_5335KV HP Notebook sku=308Z6PA#AR6 uuid=31444335-3034-5739-4331-315730344435 *-display description: VGA compatible controller product: TigerLake-LP GT2 [Iris Xe Graphics] vendor: Intel Corporation physical id: 2 bus info: pci@0000:00:02.0 logical name: /dev/fb0 version: 01 width: 64 bits clock: 33MHz capabilities: pciexpress msi pm vga_controller bus_master cap_list rom fb configuration: depth=32 driver=i915 latency=0 mode=1920x1080 resolution=1920,1080 visual=truecolor xres=1920 yres=1080 resources: iomemory:600-5ff iomemory:400-3ff irq:143 memory:6002000000-6002ffffff memory:4000000000-400fffffff ioport:4000(size=64) memory:c0000-dffff memory:4010000000-4016ffffff memory:4020000000-40ffffffff It hits this bug and it immediately kills the GUI (full dmesg log attached as a file, dmesg.txt): <6>[ 70.743338] Console: switching to colour dummy device 80x25 <4>[ 70.904380] ------------[ cut here ]------------ <4>[ 70.904383] WARNING: CPU: 2 PID: 1256 at drivers/gpu/drm/drm_mode_config.c:505 drm_mode_config_cleanup+0x245/0x310 [drm] <4>[ 70.904409] Modules linked in: nvme_fabrics ccm r8153_ecm cdc_ether usbnet r8152 uas usb_storage mii xt_CHECKSUM xt_MASQUERADE xt_conntrack ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc snd_ctl_led snd_soc_skl_hda_dsp snd_soc_hdac_hdmi snd_soc_intel_hda_dsp_common snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_hdac_hda snd_sof_intel_hda soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof rtw88_8822ce rtw88_8822c snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match rtw88_pci snd_soc_acpi soundwire_bus rtw88_core snd_soc_core snd_compress mac80211 ac97_bus snd_pcm_dmaengine snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec snd_hda_core uvcvideo snd_hwdep snd_pcm <4>[ 70.904460] x86_pkg_temp_thermal intel_powerclamp videobuf2_vmalloc snd_seq_midi coretemp videobuf2_memops snd_seq_midi_event nls_iso8859_1 videobuf2_v4l2 snd_rawmidi kvm_intel videodev processor_thermal_device_pci_legacy snd_seq processor_thermal_device hid_multitouch processor_thermal_rfim crct10dif_pclmul iTCO_wdt crc32_pclmul processor_thermal_mbox snd_seq_device ghash_clmulni_intel intel_pmc_bxt mei_hdcp ee1004 intel_rapl_msr iTCO_vendor_support snd_timer videobuf2_common processor_thermal_rapl btrfs cfg80211 sha512_ssse3 snd mc intel_lpss_pci mei_me i2c_i801 intel_rapl_common intel_lpss serio_raw mei libarc4 soundcore wmi_bmof i2c_smbus idma64 intel_soc_dts_iosf i2c_hid_acpi i2c_hid int3403_thermal int3400_thermal acpi_thermal_rel acpi_pad int340x_thermal_zone dptf_pch_fivr sch_fq_codel kvmgt mdev kvm parport_pc ppdev lp parport ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 raid10 raid456 libcrc32c async_raid6_recov async_pq raid6_pq async_xor xor <4>[ 70.904494] async_memcpy async_tx raid1 raid0 multipath linear dm_mirror dm_region_hash dm_log joydev hid_generic usbhid hid nvme nvme_core i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper sysimgblt syscopyarea sysfillrect aesni_intel drm crypto_simd cryptd xhci_pci input_leds xhci_pci_renesas vmd video wmi pinctrl_tigerlake mac_hid <4>[ 70.904507] CPU: 2 PID: 1256 Comm: rpc-libvirtd Not tainted 6.2.1-2023-03-02+ #1 be1c0ea3c87f9b2d4a6dfee589899950dc18f771 <4>[ 70.904509] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 <4>[ 70.904510] RIP: 0010:drm_mode_config_cleanup+0x245/0x310 [drm] <4>[ 70.904520] Code: 21 3d c3 e1 48 8b 83 b8 01 00 00 48 81 c3 b8 01 00 00 48 39 d8 0f 85 c1 00 00 00 48 83 c4 30 5b 41 5c 41 5d 41 5e 41 5f 5d c3 <0f> 0b 48 89 1c 24 48 c7 44 24 08 00 00 00 00 49 89 e6 4c 89 f7 e8 <4>[ 70.904521] RSP: 0018:ffff888108e2bc88 EFLAGS: 00010202 <4>[ 70.904522] RAX: ffff888124e18270 RBX: ffff888124e18000 RCX: ffff888126a85020 <4>[ 70.904523] RDX: 0000000000000000 RSI: 0000000000000002 RDI: ffff888108e2bc30 <4>[ 70.904523] RBP: 0000000000000000 R08: ffff8881073a0000 R09: 0000000000000100 <4>[ 70.904524] R10: 0000000000000100 R11: 0000000000000100 R12: ffff888126a87000 <4>[ 70.904525] R13: ffffffffa072ad40 R14: ffff888108e2bc88 R15: ffff888126a87050 <4>[ 70.904525] FS: 00007fa5985fe640(0000) GS:ffff889036a80000(0000) knlGS:0000000000000000 <4>[ 70.904526] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 70.904527] CR2: 0000560b7d3c33c8 CR3: 0000000108ada002 CR4: 0000000000770ee0 <4>[ 70.904528] PKRU: 55555554 <4>[ 70.904528] Call Trace: <4>[ 70.904530] <TASK> <4>[ 70.904531] ? intel_atomic_global_obj_cleanup+0x4a/0xf0 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.904564] intel_modeset_driver_remove_noirq+0xea/0x160 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.904588] i915_driver_remove+0x155/0x360 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.904616] i915_pci_remove+0x15/0x30 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.904651] pci_device_remove+0x6d/0x110 <4>[ 70.904654] device_release_driver_internal+0x30e/0x520 <4>[ 70.904658] unbind_store+0x17f/0x200 <4>[ 70.904660] ? klist_devices_get+0x10/0x10 <4>[ 70.904662] kernfs_fop_write_iter+0x18b/0x2c0 <4>[ 70.904665] vfs_write+0x324/0x3e0 <4>[ 70.904669] ksys_write+0x50/0xc0 <4>[ 70.904671] do_syscall_64+0x2b/0x50 <4>[ 70.904673] entry_SYSCALL_64_after_hwframe+0x24/0x8e <4>[ 70.904676] RIP: 0033:0x7fa59cf14a6f <4>[ 70.904678] Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 19 c0 f7 ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 5c c0 f7 ff 48 <4>[ 70.904679] RSP: 002b:00007fa5985fd2e0 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 <4>[ 70.904681] RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007fa59cf14a6f <4>[ 70.904682] RDX: 000000000000000c RSI: 00007fa5880461c0 RDI: 000000000000001d <4>[ 70.904682] RBP: 00007fa5880461c0 R08: 0000000000000000 R09: 000000007fffffff <4>[ 70.904683] R10: 0000000000000000 R11: 0000000000000293 R12: 000000000000001d <4>[ 70.904684] R13: 000000000000001d R14: 0000000000000000 R15: 00007fa588048340 <4>[ 70.904685] </TASK> <4>[ 70.904686] ---[ end trace 0000000000000000 ]--- <3>[ 70.904688] [drm:drm_mode_config_cleanup [drm]] *ERROR* connector HDMI-A-1 leaked! <4>[ 70.904745] ------------[ cut here ]------------ <4>[ 70.904745] i915 0000:00:02.0: drm_WARN_ON(plane_state->ggtt_vma) <4>[ 70.904781] WARNING: CPU: 2 PID: 1256 at drivers/gpu/drm/i915/display/intel_atomic_plane.c:134 intel_plane_destroy_state+0x7a/0xd0 [i915] <4>[ 70.904822] Modules linked in: nvme_fabrics ccm r8153_ecm cdc_ether usbnet r8152 uas usb_storage mii xt_CHECKSUM xt_MASQUERADE xt_conntrack ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc snd_ctl_led snd_soc_skl_hda_dsp snd_soc_hdac_hdmi snd_soc_intel_hda_dsp_common snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_hdac_hda snd_sof_intel_hda soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof rtw88_8822ce rtw88_8822c snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match rtw88_pci snd_soc_acpi soundwire_bus rtw88_core snd_soc_core snd_compress mac80211 ac97_bus snd_pcm_dmaengine snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec snd_hda_core uvcvideo snd_hwdep snd_pcm <4>[ 70.904847] x86_pkg_temp_thermal intel_powerclamp videobuf2_vmalloc snd_seq_midi coretemp videobuf2_memops snd_seq_midi_event nls_iso8859_1 videobuf2_v4l2 snd_rawmidi kvm_intel videodev processor_thermal_device_pci_legacy snd_seq processor_thermal_device hid_multitouch processor_thermal_rfim crct10dif_pclmul iTCO_wdt crc32_pclmul processor_thermal_mbox snd_seq_device ghash_clmulni_intel intel_pmc_bxt mei_hdcp ee1004 intel_rapl_msr iTCO_vendor_support snd_timer videobuf2_common processor_thermal_rapl btrfs cfg80211 sha512_ssse3 snd mc intel_lpss_pci mei_me i2c_i801 intel_rapl_common intel_lpss serio_raw mei libarc4 soundcore wmi_bmof i2c_smbus idma64 intel_soc_dts_iosf i2c_hid_acpi i2c_hid int3403_thermal int3400_thermal acpi_thermal_rel acpi_pad int340x_thermal_zone dptf_pch_fivr sch_fq_codel kvmgt mdev kvm parport_pc ppdev lp parport ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 raid10 raid456 libcrc32c async_raid6_recov async_pq raid6_pq async_xor xor <4>[ 70.904868] async_memcpy async_tx raid1 raid0 multipath linear dm_mirror dm_region_hash dm_log joydev hid_generic usbhid hid nvme nvme_core i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper sysimgblt syscopyarea sysfillrect aesni_intel drm crypto_simd cryptd xhci_pci input_leds xhci_pci_renesas vmd video wmi pinctrl_tigerlake mac_hid <4>[ 70.904879] CPU: 2 PID: 1256 Comm: rpc-libvirtd Tainted: G W 6.2.1-2023-03-02+ #1 be1c0ea3c87f9b2d4a6dfee589899950dc18f771 <4>[ 70.904881] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 <4>[ 70.904881] RIP: 0010:intel_plane_destroy_state+0x7a/0xd0 [i915] <4>[ 70.904904] Code: e1 49 8b 0e 48 8b 49 08 48 8b 51 50 48 85 d2 75 03 48 8b 11 48 c7 c7 4e 09 64 a0 48 89 c6 48 c7 c1 bf 4f 65 a0 e8 56 22 b5 e0 <0f> 0b 48 83 bb c8 00 00 00 00 74 97 49 8b 06 48 8b 78 08 e8 fe de <4>[ 70.904905] RSP: 0018:ffff888108e2bc40 EFLAGS: 00010286 <4>[ 70.904905] RAX: 0000000000000035 RBX: ffff88811b4aee00 RCX: 0000000000000027 <4>[ 70.904906] RDX: ffff888108e2bb40 RSI: 00000000ffefffff RDI: ffff889036a9d988 <4>[ 70.904906] RBP: 0000000000000000 R08: 00000000000fffff R09: ffff88907c3fe000 <4>[ 70.904907] R10: 00000000002ffffd R11: 0000000000000004 R12: ffff888126a87000 <4>[ 70.904907] R13: ffffffffa072ad40 R14: ffff888126a89400 R15: ffff888124e18000 <4>[ 70.904908] FS: 00007fa5985fe640(0000) GS:ffff889036a80000(0000) knlGS:0000000000000000 <4>[ 70.904909] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 70.904909] CR2: 0000560b7d3c33c8 CR3: 0000000108ada002 CR4: 0000000000770ee0 <4>[ 70.904910] PKRU: 55555554 <4>[ 70.904910] Call Trace: <4>[ 70.904911] <TASK> <4>[ 70.904912] drm_plane_cleanup+0xe9/0x140 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 70.904924] intel_plane_destroy+0x9/0x20 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.904947] drm_mode_config_cleanup+0x141/0x310 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 70.904957] ? intel_atomic_global_obj_cleanup+0x4a/0xf0 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.904980] intel_modeset_driver_remove_noirq+0xea/0x160 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905003] i915_driver_remove+0x155/0x360 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905028] i915_pci_remove+0x15/0x30 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905060] pci_device_remove+0x6d/0x110 <4>[ 70.905061] device_release_driver_internal+0x30e/0x520 <4>[ 70.905063] unbind_store+0x17f/0x200 <4>[ 70.905065] ? klist_devices_get+0x10/0x10 <4>[ 70.905066] kernfs_fop_write_iter+0x18b/0x2c0 <4>[ 70.905068] vfs_write+0x324/0x3e0 <4>[ 70.905070] ksys_write+0x50/0xc0 <4>[ 70.905071] do_syscall_64+0x2b/0x50 <4>[ 70.905073] entry_SYSCALL_64_after_hwframe+0x24/0x8e <4>[ 70.905074] RIP: 0033:0x7fa59cf14a6f <4>[ 70.905075] Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 19 c0 f7 ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 5c c0 f7 ff 48 <4>[ 70.905076] RSP: 002b:00007fa5985fd2e0 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 <4>[ 70.905077] RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007fa59cf14a6f <4>[ 70.905077] RDX: 000000000000000c RSI: 00007fa5880461c0 RDI: 000000000000001d <4>[ 70.905077] RBP: 00007fa5880461c0 R08: 0000000000000000 R09: 000000007fffffff <4>[ 70.905078] R10: 0000000000000000 R11: 0000000000000293 R12: 000000000000001d <4>[ 70.905078] R13: 000000000000001d R14: 0000000000000000 R15: 00007fa588048340 <4>[ 70.905079] </TASK> <4>[ 70.905079] ---[ end trace 0000000000000000 ]--- <4>[ 70.905139] ------------[ cut here ]------------ <4>[ 70.905139] WARNING: CPU: 2 PID: 1256 at drivers/gpu/drm/drm_mode_config.c:539 drm_mode_config_cleanup+0x27a/0x310 [drm] <4>[ 70.905158] Modules linked in: nvme_fabrics ccm r8153_ecm cdc_ether usbnet r8152 uas usb_storage mii xt_CHECKSUM xt_MASQUERADE xt_conntrack ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc snd_ctl_led snd_soc_skl_hda_dsp snd_soc_hdac_hdmi snd_soc_intel_hda_dsp_common snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_hdac_hda snd_sof_intel_hda soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof rtw88_8822ce rtw88_8822c snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match rtw88_pci snd_soc_acpi soundwire_bus rtw88_core snd_soc_core snd_compress mac80211 ac97_bus snd_pcm_dmaengine snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec snd_hda_core uvcvideo snd_hwdep snd_pcm <4>[ 70.905176] x86_pkg_temp_thermal intel_powerclamp videobuf2_vmalloc snd_seq_midi coretemp videobuf2_memops snd_seq_midi_event nls_iso8859_1 videobuf2_v4l2 snd_rawmidi kvm_intel videodev processor_thermal_device_pci_legacy snd_seq processor_thermal_device hid_multitouch processor_thermal_rfim crct10dif_pclmul iTCO_wdt crc32_pclmul processor_thermal_mbox snd_seq_device ghash_clmulni_intel intel_pmc_bxt mei_hdcp ee1004 intel_rapl_msr iTCO_vendor_support snd_timer videobuf2_common processor_thermal_rapl btrfs cfg80211 sha512_ssse3 snd mc intel_lpss_pci mei_me i2c_i801 intel_rapl_common intel_lpss serio_raw mei libarc4 soundcore wmi_bmof i2c_smbus idma64 intel_soc_dts_iosf i2c_hid_acpi i2c_hid int3403_thermal int3400_thermal acpi_thermal_rel acpi_pad int340x_thermal_zone dptf_pch_fivr sch_fq_codel kvmgt mdev kvm parport_pc ppdev lp parport ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 raid10 raid456 libcrc32c async_raid6_recov async_pq raid6_pq async_xor xor <4>[ 70.905194] async_memcpy async_tx raid1 raid0 multipath linear dm_mirror dm_region_hash dm_log joydev hid_generic usbhid hid nvme nvme_core i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper sysimgblt syscopyarea sysfillrect aesni_intel drm crypto_simd cryptd xhci_pci input_leds xhci_pci_renesas vmd video wmi pinctrl_tigerlake mac_hid <4>[ 70.905205] CPU: 2 PID: 1256 Comm: rpc-libvirtd Tainted: G W 6.2.1-2023-03-02+ #1 be1c0ea3c87f9b2d4a6dfee589899950dc18f771 <4>[ 70.905206] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 <4>[ 70.905206] RIP: 0010:drm_mode_config_cleanup+0x27a/0x310 [drm] <4>[ 70.905216] Code: 00 00 00 00 49 89 e6 4c 89 f7 e8 41 4d fe ff 48 85 c0 0f 84 96 00 00 00 48 8b 70 60 48 c7 c7 50 85 31 a0 e8 f8 8f 00 00 eb dd <0f> 0b 4d 8b 75 00 4d 39 ee 0f 84 72 ff ff ff 4c 8d 7c 24 10 4d 8d <4>[ 70.905217] RSP: 0018:ffff888108e2bc88 EFLAGS: 00010287 <4>[ 70.905218] RAX: ffff88811b4af208 RBX: ffff888124e18000 RCX: 0000000000000296 <4>[ 70.905218] RDX: ffffea000451be00 RSI: 0000000000000000 RDI: ffff888100042a00 <4>[ 70.905218] RBP: 0000000000000000 R08: ffffea000410f900 R09: 0000000000000003 <4>[ 70.905219] R10: 0000000000000002 R11: 0000000000000002 R12: ffff888124e183a8 <4>[ 70.905219] R13: ffff888124e18248 R14: ffff8881146fbc10 R15: ffff888124e183a8 <4>[ 70.905220] FS: 00007fa5985fe640(0000) GS:ffff889036a80000(0000) knlGS:0000000000000000 <4>[ 70.905221] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 70.905221] CR2: 0000560b7d3c33c8 CR3: 0000000108ada002 CR4: 0000000000770ee0 <4>[ 70.905222] PKRU: 55555554 <4>[ 70.905222] Call Trace: <4>[ 70.905223] <TASK> <4>[ 70.905223] ? intel_atomic_global_obj_cleanup+0x4a/0xf0 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905250] intel_modeset_driver_remove_noirq+0xea/0x160 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905273] i915_driver_remove+0x155/0x360 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905299] i915_pci_remove+0x15/0x30 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905334] pci_device_remove+0x6d/0x110 <4>[ 70.905335] device_release_driver_internal+0x30e/0x520 <4>[ 70.905338] unbind_store+0x17f/0x200 <4>[ 70.905339] ? klist_devices_get+0x10/0x10 <4>[ 70.905341] kernfs_fop_write_iter+0x18b/0x2c0 <4>[ 70.905343] vfs_write+0x324/0x3e0 <4>[ 70.905345] ksys_write+0x50/0xc0 <4>[ 70.905347] do_syscall_64+0x2b/0x50 <4>[ 70.905348] entry_SYSCALL_64_after_hwframe+0x24/0x8e <4>[ 70.905350] RIP: 0033:0x7fa59cf14a6f <4>[ 70.905351] Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 19 c0 f7 ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 5c c0 f7 ff 48 <4>[ 70.905352] RSP: 002b:00007fa5985fd2e0 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 <4>[ 70.905353] RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007fa59cf14a6f <4>[ 70.905354] RDX: 000000000000000c RSI: 00007fa5880461c0 RDI: 000000000000001d <4>[ 70.905354] RBP: 00007fa5880461c0 R08: 0000000000000000 R09: 000000007fffffff <4>[ 70.905355] R10: 0000000000000000 R11: 0000000000000293 R12: 000000000000001d <4>[ 70.905356] R13: 000000000000001d R14: 0000000000000000 R15: 00007fa588048340 <4>[ 70.905357] </TASK> <4>[ 70.905357] ---[ end trace 0000000000000000 ]--- <7>[ 70.905358] [leaked fb] framebuffer[362]: <7>[ 70.905359] [leaked fb] allocated by = Xorg <7>[ 70.905360] [leaked fb] refcount=1 <7>[ 70.905361] [leaked fb] format=XR24 little-endian (0x34325258) <7>[ 70.905362] [leaked fb] modifier=0x100000000000001 <7>[ 70.905363] [leaked fb] size=1920x1080 <7>[ 70.905364] [leaked fb] layers: <7>[ 70.905364] [leaked fb] size[0]=1920x1080 <7>[ 70.905366] [leaked fb] pitch[0]=7680 <7>[ 70.905367] [leaked fb] offset[0]=0 <7>[ 70.905367] [leaked fb] obj[0]: <7>[ 70.905368] [leaked fb] name=0 <7>[ 70.905369] [leaked fb] refcount=4 <7>[ 70.905370] [leaked fb] start=00000000 <7>[ 70.905371] [leaked fb] size=8388608 <7>[ 70.905371] [leaked fb] imported=no <4>[ 70.905373] ------------[ cut here ]------------ <4>[ 70.905374] i915 0000:00:02.0: drm_WARN_ON(atomic_read(&front->bits)) <4>[ 70.905399] WARNING: CPU: 2 PID: 1256 at drivers/gpu/drm/i915/display/intel_frontbuffer.c:231 intel_frontbuffer_put+0x133/0x160 [i915] <4>[ 70.905440] Modules linked in: nvme_fabrics ccm r8153_ecm cdc_ether usbnet r8152 uas usb_storage mii xt_CHECKSUM xt_MASQUERADE xt_conntrack ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc snd_ctl_led snd_soc_skl_hda_dsp snd_soc_hdac_hdmi snd_soc_intel_hda_dsp_common snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_hdac_hda snd_sof_intel_hda soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof rtw88_8822ce rtw88_8822c snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match rtw88_pci snd_soc_acpi soundwire_bus rtw88_core snd_soc_core snd_compress mac80211 ac97_bus snd_pcm_dmaengine snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec snd_hda_core uvcvideo snd_hwdep snd_pcm <4>[ 70.905465] x86_pkg_temp_thermal intel_powerclamp videobuf2_vmalloc snd_seq_midi coretemp videobuf2_memops snd_seq_midi_event nls_iso8859_1 videobuf2_v4l2 snd_rawmidi kvm_intel videodev processor_thermal_device_pci_legacy snd_seq processor_thermal_device hid_multitouch processor_thermal_rfim crct10dif_pclmul iTCO_wdt crc32_pclmul processor_thermal_mbox snd_seq_device ghash_clmulni_intel intel_pmc_bxt mei_hdcp ee1004 intel_rapl_msr iTCO_vendor_support snd_timer videobuf2_common processor_thermal_rapl btrfs cfg80211 sha512_ssse3 snd mc intel_lpss_pci mei_me i2c_i801 intel_rapl_common intel_lpss serio_raw mei libarc4 soundcore wmi_bmof i2c_smbus idma64 intel_soc_dts_iosf i2c_hid_acpi i2c_hid int3403_thermal int3400_thermal acpi_thermal_rel acpi_pad int340x_thermal_zone dptf_pch_fivr sch_fq_codel kvmgt mdev kvm parport_pc ppdev lp parport ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 raid10 raid456 libcrc32c async_raid6_recov async_pq raid6_pq async_xor xor <4>[ 70.905491] async_memcpy async_tx raid1 raid0 multipath linear dm_mirror dm_region_hash dm_log joydev hid_generic usbhid hid nvme nvme_core i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper sysimgblt syscopyarea sysfillrect aesni_intel drm crypto_simd cryptd xhci_pci input_leds xhci_pci_renesas vmd video wmi pinctrl_tigerlake mac_hid <4>[ 70.905502] CPU: 2 PID: 1256 Comm: rpc-libvirtd Tainted: G W 6.2.1-2023-03-02+ #1 be1c0ea3c87f9b2d4a6dfee589899950dc18f771 <4>[ 70.905503] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 <4>[ 70.905504] RIP: 0010:intel_frontbuffer_put+0x133/0x160 [i915] <4>[ 70.905538] Code: 49 8b 4e 08 48 8b 49 08 48 8b 51 50 48 85 d2 75 03 48 8b 11 48 c7 c7 4e 09 64 a0 48 89 c6 48 c7 c1 57 7e 67 a0 e8 2d c2 af e0 <0f> 0b e9 fc fe ff ff 4c 89 f7 be 03 00 00 00 e8 c9 03 12 e1 48 85 <4>[ 70.905539] RSP: 0018:ffff888108e2bc58 EFLAGS: 00010282 <4>[ 70.905540] RAX: 0000000000000039 RBX: ffff8881db8cc840 RCX: 0000000000000027 <4>[ 70.905541] RDX: ffff888108e2bb60 RSI: 00000000ffefffff RDI: ffff889036a9d988 <4>[ 70.905542] RBP: ffff888124e18248 R08: 00000000000fffff R09: ffff88907c3fe000 <4>[ 70.905543] R10: 00000000002ffffd R11: 0000000000000004 R12: ffff88811b4af200 <4>[ 70.905544] R13: ffff888124e18248 R14: ffff8881272c9540 R15: ffff888108e2bc98 <4>[ 70.905544] FS: 00007fa5985fe640(0000) GS:ffff889036a80000(0000) knlGS:0000000000000000 <4>[ 70.905545] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 70.905546] CR2: 0000560b7d3c33c8 CR3: 0000000108ada002 CR4: 0000000000770ee0 <4>[ 70.905547] PKRU: 55555554 <4>[ 70.905548] Call Trace: <4>[ 70.905548] <TASK> <4>[ 70.905549] intel_user_framebuffer_destroy+0x62/0x80 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905588] drm_mode_config_cleanup+0x2ea/0x310 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 70.905606] ? __drm_printfn_err+0x20/0x20 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 70.905623] intel_modeset_driver_remove_noirq+0xea/0x160 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905660] i915_driver_remove+0x155/0x360 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905697] i915_pci_remove+0x15/0x30 [i915 1a16f678887c5c6625f3e451fd91db00b38001bb] <4>[ 70.905734] pci_device_remove+0x6d/0x110 <4>[ 70.905735] device_release_driver_internal+0x30e/0x520 <4>[ 70.905738] unbind_store+0x17f/0x200 <4>[ 70.905739] ? klist_devices_get+0x10/0x10 <4>[ 70.905741] kernfs_fop_write_iter+0x18b/0x2c0 <4>[ 70.905743] vfs_write+0x324/0x3e0 <4>[ 70.905745] ksys_write+0x50/0xc0 <4>[ 70.905747] do_syscall_64+0x2b/0x50 <4>[ 70.905749] entry_SYSCALL_64_after_hwframe+0x24/0x8e <4>[ 70.905751] RIP: 0033:0x7fa59cf14a6f <4>[ 70.905752] Code: 89 54 24 18 48 89 74 24 10 89 7c 24 08 e8 19 c0 f7 ff 48 8b 54 24 18 48 8b 74 24 10 41 89 c0 8b 7c 24 08 b8 01 00 00 00 0f 05 <48> 3d 00 f0 ff ff 77 31 44 89 c7 48 89 44 24 08 e8 5c c0 f7 ff 48 <4>[ 70.905753] RSP: 002b:00007fa5985fd2e0 EFLAGS: 00000293 ORIG_RAX: 0000000000000001 <4>[ 70.905754] RAX: ffffffffffffffda RBX: 000000000000000c RCX: 00007fa59cf14a6f <4>[ 70.905754] RDX: 000000000000000c RSI: 00007fa5880461c0 RDI: 000000000000001d <4>[ 70.905755] RBP: 00007fa5880461c0 R08: 0000000000000000 R09: 000000007fffffff <4>[ 70.905755] R10: 0000000000000000 R11: 0000000000000293 R12: 000000000000001d <4>[ 70.905756] R13: 000000000000001d R14: 0000000000000000 R15: 00007fa588048340 <4>[ 70.905756] </TASK> <4>[ 70.905757] ---[ end trace 0000000000000000 ]--- <6>[ 71.017755] vfio-pci 0000:00:02.0: vgaarb: deactivate vga console <6>[ 71.017759] vfio-pci 0000:00:02.0: vgaarb: changed VGA decodes: olddecodes=io+mem,decodes=io+mem:owns=io+mem <4>[ 71.017780] vfio-pci: probe of 0000:00:02.0 failed with error -22 <6>[ 71.036734] i915 0000:00:02.0: vgaarb: deactivate vga console <6>[ 71.036796] i915 0000:00:02.0: [drm] Using Transparent Hugepages <6>[ 71.040718] mei_hdcp 0000:00:16.0-b638ab7e-94e2-4ea2-a552-d1c54b627f04: bound 0000:00:02.0 (ops i915_hdcp_component_ops [i915]) <7>[ 71.046344] rfkill: input handler enabled <6>[ 71.055484] i915 0000:00:02.0: [drm] Finished loading DMC firmware i915/tgl_dmc_ver2_12.bin (v2.12) <6>[ 71.308992] [drm] Initialized i915 1.6.0 20201103 for 0000:00:02.0 on minor 1 <6>[ 71.310227] ACPI: video: Video Device [GFX0] (multi-head: yes rom: no post: no) <6>[ 71.310436] input: Video Bus as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/LNXVIDEO:00/input/input24 <6>[ 71.310556] sof-audio-pci-intel-tgl 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915]) <6>[ 71.348945] fbcon: i915drmfb (fb0) is primary device <6>[ 71.779214] Console: switching to colour frame buffer device 240x67 <6>[ 71.798775] i915 0000:00:02.0: [drm] fb0: i915drmfb frame buffer device <7>[ 75.385307] rfkill: input handler disabled <3>[ 76.067662] list_del corruption, ffff88811b4af298->next is NULL <4>[ 76.067686] ------------[ cut here ]------------ <2>[ 76.067686] kernel BUG at lib/list_debug.c:50! <4>[ 76.067697] invalid opcode: 0000 [#1] PREEMPT SMP <4>[ 76.067705] CPU: 6 PID: 1834 Comm: Xorg:sh0 Tainted: G W 6.2.1-2023-03-02+ #1 be1c0ea3c87f9b2d4a6dfee589899950dc18f771 <4>[ 76.067726] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 <4>[ 76.067737] RIP: 0010:__list_del_entry_valid+0x4c/0xa0 <4>[ 76.067749] Code: 39 48 83 c2 22 48 39 d0 74 3e 48 8b 10 48 39 f2 75 44 48 8b 51 08 48 39 f2 75 4c b0 01 c3 48 c7 c7 b1 1f 45 82 e8 c4 c7 a6 ff <0f> 0b 48 c7 c7 62 a9 4d 82 e8 b6 c7 a6 ff 0f 0b 48 c7 c7 fa 60 4f <4>[ 76.067778] RSP: 0018:ffff8881038a7c50 EFLAGS: 00010286 <4>[ 76.067788] RAX: 0000000000000033 RBX: ffff8881038a7c78 RCX: 0000000000000000 <4>[ 76.067799] RDX: ffff889036ba0cf8 RSI: 00000000ffefffff RDI: ffff889036b9d988 <4>[ 76.067809] RBP: 00000000fff00000 R08: 00000000000fffff R09: ffff88907c3fe000 <4>[ 76.067820] R10: 00000000002ffffd R11: 0000000000000004 R12: ffff8881031d18f8 <4>[ 76.067830] R13: 0000000000000000 R14: ffff8881031d1890 R15: ffff88811b4af298 <4>[ 76.067841] FS: 0000000000000000(0000) GS:ffff889036b80000(0000) knlGS:0000000000000000 <4>[ 76.067854] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 76.067862] CR2: 00007f5930738fa0 CR3: 000000010754d001 CR4: 0000000000770ee0 <4>[ 76.067874] PKRU: 55555554 <4>[ 76.067880] Call Trace: <4>[ 76.067885] <TASK> <4>[ 76.067890] drm_fb_release+0x5c/0x170 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 76.067914] ? __slab_free+0x54/0x1d0 <4>[ 76.067922] drm_file_free+0x184/0x260 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 76.067943] drm_release_noglobal+0x68/0x120 [drm 1ef2a6610e3c2e37712af413a4bba8eff7774cb4] <4>[ 76.067966] __fput+0xe9/0x3a0 <4>[ 76.067973] do_exit+0x55c/0xf00 <4>[ 76.067981] do_group_exit+0x73/0x90 <4>[ 76.067987] get_signal+0x6fd/0x7a0 <4>[ 76.067994] arch_do_signal_or_restart+0x15/0x210 <4>[ 76.068002] ? do_futex+0x64/0x110 <4>[ 76.068008] exit_to_user_mode_loop+0x49/0x140 <4>[ 76.068017] exit_to_user_mode_prepare+0x96/0x140 <4>[ 76.068025] syscall_exit_to_user_mode+0x2d/0x120 <4>[ 76.068033] entry_SYSCALL_64_after_hwframe+0x24/0x8e <4>[ 76.068042] RIP: 0033:0x7fb640491197 <4>[ 76.068049] Code: Unable to access opcode bytes at 0x7fb64049116d. <4>[ 76.068058] RSP: 002b:00007fb62fffe840 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca <4>[ 76.068071] RAX: fffffffffffffe00 RBX: 0000000000000000 RCX: 00007fb640491197 <4>[ 76.068081] RDX: 0000000000000000 RSI: 0000000000000189 RDI: 0000555845204e78 <4>[ 76.068091] RBP: 0000555845204e50 R08: 0000000000000000 R09: 00000000ffffffff <4>[ 76.068103] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 <4>[ 76.068115] R13: 0000000000000000 R14: 0000000000000020 R15: 0000555845204e78 <4>[ 76.068128] </TASK> <4>[ 76.068132] Modules linked in: nvme_fabrics ccm r8153_ecm cdc_ether usbnet r8152 uas usb_storage mii xt_CHECKSUM xt_MASQUERADE xt_conntrack ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc snd_ctl_led snd_soc_skl_hda_dsp snd_soc_hdac_hdmi snd_soc_intel_hda_dsp_common snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_hdac_hda snd_sof_intel_hda soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof rtw88_8822ce rtw88_8822c snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match rtw88_pci snd_soc_acpi soundwire_bus rtw88_core snd_soc_core snd_compress mac80211 ac97_bus snd_pcm_dmaengine snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec snd_hda_core uvcvideo snd_hwdep snd_pcm <4>[ 76.068156] x86_pkg_temp_thermal intel_powerclamp videobuf2_vmalloc snd_seq_midi coretemp videobuf2_memops snd_seq_midi_event nls_iso8859_1 videobuf2_v4l2 snd_rawmidi kvm_intel videodev processor_thermal_device_pci_legacy snd_seq processor_thermal_device hid_multitouch processor_thermal_rfim crct10dif_pclmul iTCO_wdt crc32_pclmul processor_thermal_mbox snd_seq_device ghash_clmulni_intel intel_pmc_bxt mei_hdcp ee1004 intel_rapl_msr iTCO_vendor_support snd_timer videobuf2_common processor_thermal_rapl btrfs cfg80211 sha512_ssse3 snd mc intel_lpss_pci mei_me i2c_i801 intel_rapl_common intel_lpss serio_raw mei libarc4 soundcore wmi_bmof i2c_smbus idma64 intel_soc_dts_iosf i2c_hid_acpi i2c_hid int3403_thermal int3400_thermal acpi_thermal_rel acpi_pad int340x_thermal_zone dptf_pch_fivr sch_fq_codel kvmgt mdev kvm parport_pc ppdev lp parport ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 raid10 raid456 libcrc32c async_raid6_recov async_pq raid6_pq async_xor xor <4>[ 76.070725] async_memcpy async_tx raid1 raid0 multipath linear dm_mirror dm_region_hash dm_log joydev hid_generic usbhid hid nvme nvme_core i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper sysimgblt syscopyarea sysfillrect aesni_intel drm crypto_simd cryptd xhci_pci input_leds xhci_pci_renesas vmd video wmi pinctrl_tigerlake mac_hid <4>[ 76.075361] ---[ end trace 0000000000000000 ]--- <4>[ 76.180246] RIP: 0010:__list_del_entry_valid+0x4c/0xa0 <4>[ 76.181041] Code: 39 48 83 c2 22 48 39 d0 74 3e 48 8b 10 48 39 f2 75 44 48 8b 51 08 48 39 f2 75 4c b0 01 c3 48 c7 c7 b1 1f 45 82 e8 c4 c7 a6 ff <0f> 0b 48 c7 c7 62 a9 4d 82 e8 b6 c7 a6 ff 0f 0b 48 c7 c7 fa 60 4f <4>[ 76.181825] RSP: 0018:ffff8881038a7c50 EFLAGS: 00010286 <4>[ 76.182654] RAX: 0000000000000033 RBX: ffff8881038a7c78 RCX: 0000000000000000 <4>[ 76.183439] RDX: ffff889036ba0cf8 RSI: 00000000ffefffff RDI: ffff889036b9d988 <4>[ 76.184229] RBP: 00000000fff00000 R08: 00000000000fffff R09: ffff88907c3fe000 <4>[ 76.185070] R10: 00000000002ffffd R11: 0000000000000004 R12: ffff8881031d18f8 <4>[ 76.185864] R13: 0000000000000000 R14: ffff8881031d1890 R15: ffff88811b4af298 <4>[ 76.186663] FS: 0000000000000000(0000) GS:ffff889036b80000(0000) knlGS:0000000000000000 <4>[ 76.187472] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 <4>[ 76.188326] CR2: 00007f5930738fa0 CR3: 000000010754d001 CR4: 0000000000770ee0 <4>[ 76.189128] PKRU: 55555554 <1>[ 76.189931] Fixing recursive fault but reboot is needed! <3>[ 76.190738] BUG: scheduling while atomic: Xorg:sh0/1834/0x00000000 <4>[ 76.191562] Modules linked in: nvme_fabrics ccm r8153_ecm cdc_ether usbnet r8152 uas usb_storage mii xt_CHECKSUM xt_MASQUERADE xt_conntrack ip6t_REJECT nf_reject_ipv6 ipt_REJECT nf_reject_ipv4 xt_tcpudp nft_compat nft_chain_nat nf_nat nf_conntrack nf_defrag_ipv6 nf_defrag_ipv4 nf_tables nfnetlink bridge stp llc snd_ctl_led snd_soc_skl_hda_dsp snd_soc_hdac_hdmi snd_soc_intel_hda_dsp_common snd_sof_probes snd_hda_codec_hdmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_soc_dmic snd_sof_pci_intel_tgl snd_sof_intel_hda_common snd_soc_hdac_hda snd_sof_intel_hda soundwire_intel soundwire_generic_allocation soundwire_cadence snd_sof_pci snd_sof_xtensa_dsp snd_sof rtw88_8822ce rtw88_8822c snd_sof_utils snd_hda_ext_core snd_soc_acpi_intel_match rtw88_pci snd_soc_acpi soundwire_bus rtw88_core snd_soc_core snd_compress mac80211 ac97_bus snd_pcm_dmaengine snd_hda_intel snd_intel_dspcfg snd_intel_sdw_acpi snd_hda_codec snd_hda_core uvcvideo snd_hwdep snd_pcm <4>[ 76.191587] x86_pkg_temp_thermal intel_powerclamp videobuf2_vmalloc snd_seq_midi coretemp videobuf2_memops snd_seq_midi_event nls_iso8859_1 videobuf2_v4l2 snd_rawmidi kvm_intel videodev processor_thermal_device_pci_legacy snd_seq processor_thermal_device hid_multitouch processor_thermal_rfim crct10dif_pclmul iTCO_wdt crc32_pclmul processor_thermal_mbox snd_seq_device ghash_clmulni_intel intel_pmc_bxt mei_hdcp ee1004 intel_rapl_msr iTCO_vendor_support snd_timer videobuf2_common processor_thermal_rapl btrfs cfg80211 sha512_ssse3 snd mc intel_lpss_pci mei_me i2c_i801 intel_rapl_common intel_lpss serio_raw mei libarc4 soundcore wmi_bmof i2c_smbus idma64 intel_soc_dts_iosf i2c_hid_acpi i2c_hid int3403_thermal int3400_thermal acpi_thermal_rel acpi_pad int340x_thermal_zone dptf_pch_fivr sch_fq_codel kvmgt mdev kvm parport_pc ppdev lp parport ramoops reed_solomon efi_pstore ip_tables x_tables autofs4 raid10 raid456 libcrc32c async_raid6_recov async_pq raid6_pq async_xor xor <4>[ 76.196067] async_memcpy async_tx raid1 raid0 multipath linear dm_mirror dm_region_hash dm_log joydev hid_generic usbhid hid nvme nvme_core i915 drm_buddy i2c_algo_bit ttm drm_display_helper cec rc_core drm_kms_helper sysimgblt syscopyarea sysfillrect aesni_intel drm crypto_simd cryptd xhci_pci input_leds xhci_pci_renesas vmd video wmi pinctrl_tigerlake mac_hid <4>[ 76.202755] CPU: 6 PID: 1834 Comm: Xorg:sh0 Tainted: G D W 6.2.1-2023-03-02+ #1 be1c0ea3c87f9b2d4a6dfee589899950dc18f771 <4>[ 76.203774] Hardware name: HP HP Laptop 14s-dq2xxx/87FD, BIOS F.21 03/21/2022 <4>[ 76.204765] Call Trace: <4>[ 76.205768] <TASK> <4>[ 76.206771] __schedule_bug+0x6f/0xd0 <4>[ 76.207775] __schedule+0x533/0x1410 <4>[ 76.208768] ? console_unlock+0x186/0x1d0 <4>[ 76.209755] ? vprintk_emit+0x1af/0x2f0 <4>[ 76.210738] ? _printk+0x46/0x50 <4>[ 76.211714] do_task_dead+0x39/0x40 <4>[ 76.212686] make_task_dead+0xe4/0xf0 <4>[ 76.213655] rewind_stack_and_make_dead+0x17/0x20 <4>[ 76.214632] RIP: 0033:0x7fb640491197 <4>[ 76.215609] Code: Unable to access opcode bytes at 0x7fb64049116d. <4>[ 76.216586] RSP: 002b:00007fb62fffe840 EFLAGS: 00000246 ORIG_RAX: 00000000000000ca <4>[ 76.217578] RAX: fffffffffffffe00 RBX: 0000000000000000 RCX: 00007fb640491197 <4>[ 76.218581] RDX: 0000000000000000 RSI: 0000000000000189 RDI: 0000555845204e78 <4>[ 76.219578] RBP: 0000555845204e50 R08: 0000000000000000 R09: 00000000ffffffff <4>[ 76.220571] R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 <4>[ 76.221565] R13: 0000000000000000 R14: 0000000000000020 R15: 0000555845204e78 <4>[ 76.222557] </TASK> <7>[ 79.937124] rfkill: input handler enabled -- Ammar Faizi

2 years, 1 month

3
7
0 0

[PATCH v2 00/23] drm/msm+PM+icc: Make job_run() reclaim-safe

by Rob Clark

From: Rob Clark <robdclark(a)chromium.org> Inspired by https://lore.kernel.org/dri-devel/20200604081224.863494-10-daniel.vetter@ff… it seemed like a good idea to get rid of memory allocation in job_run() fence signaling path, and use lockdep annotations to yell at us about anything that could deadlock against shrinker/reclaim. Anything that can trigger reclaim, or block on any other thread that has triggered reclaim, can block the GPU shrinker from releasing memory if it is waiting the job to complete, causing deadlock. The first patch pre-allocates the hw_fence, splitting allocation and initialization, to avoid allocation in the job_run() path. The next eight decouple the obj lock from job_run(), as the obj lock is required to pin/unpin backing pages (ie. holding an obj lock in job_run() could deadlock the shrinker by blocking forward progress towards pinned buffers becoming idle). Followed by two so that we could idr_preload() in order to avoid memory allocations under locks indirectly connected to the shrinker path. Next are three paths to decouple initialization (where allocations are needed) from GPU runpm and devfreq, to avoid allocations in the fence signaling path. Followed by various PM devfreq/qos and interconnect locking fixes to decouple initialization (allocation) from runtime. And finally, the last patch is a modified version of danvet's patch to add lockdep annotations to gpu scheduler, but does so conditionally so that drivers can opt-in. v2: Switch from embedding hw_fence in submit/job object to preallocating the hw_fence. Rework "fenced unpin" locking to drop obj lock from fence signaling path (ie. the part that was still WIP in the first iteration of the patchset). Adds the final patch to enable fence signaling annotations now that job_run() and job_free() are safe. The PM devfreq/QoS and interconnect patches are unchanged. Rob Clark (23): drm/msm: Pre-allocate hw_fence drm/msm: Move submit bo flags update from obj lock drm/msm/gem: Tidy up VMA API drm/msm: Decouple vma tracking from obj lock drm/msm/gem: Simplify vmap vs LRU tracking drm/gem: Export drm_gem_lru_move_tail_locked() drm/msm/gem: Move update_lru() drm/msm/gem: Protect pin_count/madv by LRU lock drm/msm/gem: Avoid obj lock in job_run() drm/msm: Switch idr_lock to spinlock drm/msm: Use idr_preload() drm/msm/gpu: Move fw loading out of hw_init() path drm/msm/gpu: Move BO allocation out of hw_init drm/msm/a6xx: Move ioremap out of hw_init path PM / devfreq: Drop unneed locking to appease lockdep PM / devfreq: Teach lockdep about locking order PM / QoS: Fix constraints alloc vs reclaim locking PM / QoS: Decouple request alloc from dev_pm_qos_mtx PM / QoS: Teach lockdep about dev_pm_qos_mtx locking order soc: qcom: smd-rpm: Use GFP_ATOMIC in write path interconnect: Fix locking for runpm vs reclaim interconnect: Teach lockdep about icc_bw_lock order drm/sched: Add (optional) fence signaling annotation drivers/base/power/qos.c | 83 +++++++++--- drivers/devfreq/devfreq.c | 52 ++++---- drivers/gpu/drm/drm_gem.c | 11 +- drivers/gpu/drm/msm/adreno/a5xx_gpu.c | 48 ++++--- drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 18 ++- drivers/gpu/drm/msm/adreno/a6xx_gpu.c | 46 ++++--- drivers/gpu/drm/msm/adreno/adreno_device.c | 6 + drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 +- drivers/gpu/drm/msm/msm_drv.c | 6 +- drivers/gpu/drm/msm/msm_fence.c | 12 +- drivers/gpu/drm/msm/msm_fence.h | 3 +- drivers/gpu/drm/msm/msm_gem.c | 145 ++++++++++++++------- drivers/gpu/drm/msm/msm_gem.h | 29 +++-- drivers/gpu/drm/msm/msm_gem_submit.c | 27 ++-- drivers/gpu/drm/msm/msm_gem_vma.c | 91 ++++++++++--- drivers/gpu/drm/msm/msm_gpu.h | 8 +- drivers/gpu/drm/msm/msm_ringbuffer.c | 9 +- drivers/gpu/drm/msm/msm_submitqueue.c | 2 +- drivers/gpu/drm/scheduler/sched_main.c | 9 ++ drivers/interconnect/core.c | 18 ++- drivers/soc/qcom/smd-rpm.c | 2 +- include/drm/drm_gem.h | 1 + include/drm/gpu_scheduler.h | 2 + 23 files changed, 416 insertions(+), 221 deletions(-) -- 2.39.2

2 years, 2 months

3
5
0 0

[syzbot] [dri?] general protection fault in drm_crtc_next_vblank_start

by syzbot

Hello, syzbot found the following issue on: HEAD commit: a6d9e3034536 Add linux-next specific files for 20230330 git tree: linux-next console+strace: https://syzkaller.appspot.com/x/log.txt?x=1001d1cdc80000 kernel config: https://syzkaller.appspot.com/x/.config?x=aceb117f7924508e dashboard link: https://syzkaller.appspot.com/bug?extid=54280c5aea19802490b5 compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13435a2ec80000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=139c9c21c80000 Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/ec1f900ea929/disk-a6d9e303.raw… vmlinux: https://storage.googleapis.com/syzbot-assets/fabbf89c0d22/vmlinux-a6d9e303.… kernel image: https://storage.googleapis.com/syzbot-assets/1ed05d6192fa/bzImage-a6d9e303.… The issue was bisected to: commit d39e48ca80c0960b039cb38633957f0040f63e1a Author: Rob Clark <robdclark(a)chromium.org> Date: Fri Sep 3 18:47:54 2021 +0000 drm/atomic-helper: Set fence deadline for vblank bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12d260c9c80000 final oops: https://syzkaller.appspot.com/x/report.txt?x=11d260c9c80000 console output: https://syzkaller.appspot.com/x/log.txt?x=16d260c9c80000 IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+54280c5aea19802490b5(a)syzkaller.appspotmail.com Fixes: d39e48ca80c0 ("drm/atomic-helper: Set fence deadline for vblank") [drm] Initialized udl 0.0.1 20120220 for 1-1:0.0 on minor 2 [drm] Initialized udl on minor 2 udl 1-1:0.0: [drm] *ERROR* Read EDID byte 0 failed err ffffffb9 udl 1-1:0.0: [drm] Cannot find any crtc or sizes general protection fault, probably for non-canonical address 0xdffffc0000000028: 0000 [#1] PREEMPT SMP KASAN KASAN: null-ptr-deref in range [0x0000000000000140-0x0000000000000147] CPU: 0 PID: 9 Comm: kworker/0:1 Not tainted 6.3.0-rc4-next-20230330-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Workqueue: usb_hub_wq hub_event RIP: 0010:drm_crtc_next_vblank_start+0xb3/0x2b0 drivers/gpu/drm/drm_vblank.c:1003 Code: e8 01 00 00 48 69 db 38 02 00 00 48 b8 00 00 00 00 00 fc ff df 49 03 9d 38 03 00 00 4c 8d ab 44 01 00 00 4c 89 ea 48 c1 ea 03 <0f> b6 14 02 4c 89 e8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 67 RSP: 0018:ffffc900000e6bb0 EFLAGS: 00010207 RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000000000028 RSI: ffffffff849f2afb RDI: ffff888079558338 RBP: ffffc900000e6c48 R08: 0000000000000005 R09: 0000000000000000 R10: 0000000000000001 R11: 0000000000000010 R12: ffff8880795590d8 R13: 0000000000000144 R14: ffff8880795590d8 R15: dffffc0000000000 FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f17191c7688 CR3: 00000000281af000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> set_fence_deadline drivers/gpu/drm/drm_atomic_helper.c:1531 [inline] drm_atomic_helper_wait_for_fences+0x1b4/0x780 drivers/gpu/drm/drm_atomic_helper.c:1578 drm_atomic_helper_commit drivers/gpu/drm/drm_atomic_helper.c:2007 [inline] drm_atomic_helper_commit+0x1bd/0x370 drivers/gpu/drm/drm_atomic_helper.c:1979 drm_atomic_commit+0x20a/0x300 drivers/gpu/drm/drm_atomic.c:1503 drm_client_modeset_commit_atomic+0x69b/0x7e0 drivers/gpu/drm/drm_client_modeset.c:1045 drm_client_modeset_commit_locked+0x149/0x580 drivers/gpu/drm/drm_client_modeset.c:1148 drm_client_modeset_commit+0x51/0x80 drivers/gpu/drm/drm_client_modeset.c:1174 drm_fb_helper_single_fb_probe drivers/gpu/drm/drm_fb_helper.c:1983 [inline] __drm_fb_helper_initial_config_and_unlock+0x118a/0x1510 drivers/gpu/drm/drm_fb_helper.c:2169 drm_fb_helper_initial_config drivers/gpu/drm/drm_fb_helper.c:2259 [inline] drm_fb_helper_initial_config+0x42/0x60 drivers/gpu/drm/drm_fb_helper.c:2251 drm_fbdev_generic_client_hotplug+0x1ab/0x270 drivers/gpu/drm/drm_fbdev_generic.c:281 drm_fbdev_generic_setup+0x127/0x3b0 drivers/gpu/drm/drm_fbdev_generic.c:343 udl_usb_probe+0x120/0x190 drivers/gpu/drm/udl/udl_drv.c:120 usb_probe_interface+0x30f/0x960 drivers/usb/core/driver.c:396 call_driver_probe drivers/base/dd.c:579 [inline] really_probe+0x240/0xca0 drivers/base/dd.c:658 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:795 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:825 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:953 bus_for_each_drv+0x149/0x1d0 drivers/base/bus.c:457 __device_attach+0x1e4/0x4b0 drivers/base/dd.c:1025 bus_probe_device+0x17c/0x1c0 drivers/base/bus.c:532 device_add+0x11c4/0x1c50 drivers/base/core.c:3616 usb_set_configuration+0x10ee/0x1af0 drivers/usb/core/message.c:2171 usb_generic_driver_probe+0xcf/0x130 drivers/usb/core/generic.c:238 usb_probe_device+0xd8/0x2c0 drivers/usb/core/driver.c:293 call_driver_probe drivers/base/dd.c:579 [inline] really_probe+0x240/0xca0 drivers/base/dd.c:658 __driver_probe_device+0x1df/0x4d0 drivers/base/dd.c:795 driver_probe_device+0x4c/0x1a0 drivers/base/dd.c:825 __device_attach_driver+0x1d4/0x2e0 drivers/base/dd.c:953 bus_for_each_drv+0x149/0x1d0 drivers/base/bus.c:457 __device_attach+0x1e4/0x4b0 drivers/base/dd.c:1025 bus_probe_device+0x17c/0x1c0 drivers/base/bus.c:532 device_add+0x11c4/0x1c50 drivers/base/core.c:3616 usb_new_device+0xcb2/0x19d0 drivers/usb/core/hub.c:2575 hub_port_connect drivers/usb/core/hub.c:5407 [inline] hub_port_connect_change drivers/usb/core/hub.c:5551 [inline] port_event drivers/usb/core/hub.c:5711 [inline] hub_event+0x2d9e/0x4e40 drivers/usb/core/hub.c:5793 process_one_work+0x99a/0x15e0 kernel/workqueue.c:2405 worker_thread+0x67d/0x10c0 kernel/workqueue.c:2552 kthread+0x33e/0x440 kernel/kthread.c:379 ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:308 </TASK> Modules linked in: ---[ end trace 0000000000000000 ]--- RIP: 0010:drm_crtc_next_vblank_start+0xb3/0x2b0 drivers/gpu/drm/drm_vblank.c:1003 Code: e8 01 00 00 48 69 db 38 02 00 00 48 b8 00 00 00 00 00 fc ff df 49 03 9d 38 03 00 00 4c 8d ab 44 01 00 00 4c 89 ea 48 c1 ea 03 <0f> b6 14 02 4c 89 e8 83 e0 07 83 c0 03 38 d0 7c 08 84 d2 0f 85 67 RSP: 0018:ffffc900000e6bb0 EFLAGS: 00010207 RAX: dffffc0000000000 RBX: 0000000000000000 RCX: 0000000000000000 RDX: 0000000000000028 RSI: ffffffff849f2afb RDI: ffff888079558338 RBP: ffffc900000e6c48 R08: 0000000000000005 R09: 0000000000000000 R10: 0000000000000001 R11: 0000000000000010 R12: ffff8880795590d8 R13: 0000000000000144 R14: ffff8880795590d8 R15: dffffc0000000000 FS: 0000000000000000(0000) GS:ffff8880b9800000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007f17191c7688 CR3: 000000002b398000 CR4: 00000000003506f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 ---------------- Code disassembly (best guess): 0: e8 01 00 00 48 callq 0x48000006 5: 69 db 38 02 00 00 imul $0x238,%ebx,%ebx b: 48 b8 00 00 00 00 00 movabs $0xdffffc0000000000,%rax 12: fc ff df 15: 49 03 9d 38 03 00 00 add 0x338(%r13),%rbx 1c: 4c 8d ab 44 01 00 00 lea 0x144(%rbx),%r13 23: 4c 89 ea mov %r13,%rdx 26: 48 c1 ea 03 shr $0x3,%rdx * 2a: 0f b6 14 02 movzbl (%rdx,%rax,1),%edx <-- trapping instruction 2e: 4c 89 e8 mov %r13,%rax 31: 83 e0 07 and $0x7,%eax 34: 83 c0 03 add $0x3,%eax 37: 38 d0 cmp %dl,%al 39: 7c 08 jl 0x43 3b: 84 d2 test %dl,%dl 3d: 0f .byte 0xf 3e: 85 .byte 0x85 3f: 67 addr32 --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot. For information about bisection process see: https://goo.gl/tpsmEJ#bisection syzbot can test patches for this issue, for details see: https://goo.gl/tpsmEJ#testing-patches

2 years, 2 months

3
2
0 0

[PATCH v2] misc: sram: Add DMA-BUF Heap exporting of SRAM areas

by Andrew Davis

This new export type exposes to userspace the SRAM area as a DMA-BUF Heap, this allows for allocations of DMA-BUFs that can be consumed by various DMA-BUF supporting devices. Signed-off-by: Andrew Davis <afd(a)ti.com> --- Changes from v1: - Use existing DT flags, if both pool(device usable) and export(userspace usable) properties are in the SRAM node then export as a DMA-BUF Heap - Rebase on 6.3-rc5 drivers/misc/Kconfig | 7 + drivers/misc/Makefile | 1 + drivers/misc/sram-dma-heap.c | 245 +++++++++++++++++++++++++++++++++++ drivers/misc/sram.c | 6 + drivers/misc/sram.h | 16 +++ 5 files changed, 275 insertions(+) create mode 100644 drivers/misc/sram-dma-heap.c diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 433aa41977852..8b4c111a6493b 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -448,6 +448,13 @@ config SRAM config SRAM_EXEC bool +config SRAM_DMA_HEAP + bool "Export on-chip SRAM pools using DMA-Heaps" + depends on DMABUF_HEAPS && SRAM + help + This driver allows the export of on-chip SRAM marked as both pool + and exportable to userspace using the DMA-Heaps interface. + config DW_XDATA_PCIE depends on PCI tristate "Synopsys DesignWare xData PCIe driver" diff --git a/drivers/misc/Makefile b/drivers/misc/Makefile index 56de43943cd51..bbdc64aa8af1a 100644 --- a/drivers/misc/Makefile +++ b/drivers/misc/Makefile @@ -47,6 +47,7 @@ obj-$(CONFIG_VMWARE_VMCI) += vmw_vmci/ obj-$(CONFIG_LATTICE_ECP3_CONFIG) += lattice-ecp3-config.o obj-$(CONFIG_SRAM) += sram.o obj-$(CONFIG_SRAM_EXEC) += sram-exec.o +obj-$(CONFIG_SRAM_DMA_HEAP) += sram-dma-heap.o obj-$(CONFIG_GENWQE) += genwqe/ obj-$(CONFIG_ECHO) += echo/ obj-$(CONFIG_CXL_BASE) += cxl/ diff --git a/drivers/misc/sram-dma-heap.c b/drivers/misc/sram-dma-heap.c new file mode 100644 index 0000000000000..c511f4ac1280e --- /dev/null +++ b/drivers/misc/sram-dma-heap.c @@ -0,0 +1,245 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * SRAM DMA-Heap userspace exporter + * + * Copyright (C) 2019-2022 Texas Instruments Incorporated - https://www.ti.com/ + * Andrew Davis <afd(a)ti.com> + */ + +#include <linux/dma-mapping.h> +#include <linux/err.h> +#include <linux/genalloc.h> +#include <linux/io.h> +#include <linux/mm.h> +#include <linux/scatterlist.h> +#include <linux/slab.h> +#include <linux/dma-buf.h> +#include <linux/dma-heap.h> + +#include "sram.h" + +struct sram_dma_heap { + struct dma_heap *heap; + struct gen_pool *pool; +}; + +struct sram_dma_heap_buffer { + struct gen_pool *pool; + struct list_head attachments; + struct mutex attachments_lock; + unsigned long len; + void *vaddr; + phys_addr_t paddr; +}; + +struct dma_heap_attachment { + struct device *dev; + struct sg_table *table; + struct list_head list; +}; + +static int dma_heap_attach(struct dma_buf *dmabuf, + struct dma_buf_attachment *attachment) +{ + struct sram_dma_heap_buffer *buffer = dmabuf->priv; + struct dma_heap_attachment *a; + struct sg_table *table; + + a = kzalloc(sizeof(*a), GFP_KERNEL); + if (!a) + return -ENOMEM; + + table = kmalloc(sizeof(*table), GFP_KERNEL); + if (!table) { + kfree(a); + return -ENOMEM; + } + if (sg_alloc_table(table, 1, GFP_KERNEL)) { + kfree(table); + kfree(a); + return -ENOMEM; + } + sg_set_page(table->sgl, pfn_to_page(PFN_DOWN(buffer->paddr)), buffer->len, 0); + + a->table = table; + a->dev = attachment->dev; + INIT_LIST_HEAD(&a->list); + + attachment->priv = a; + + mutex_lock(&buffer->attachments_lock); + list_add(&a->list, &buffer->attachments); + mutex_unlock(&buffer->attachments_lock); + + return 0; +} + +static void dma_heap_detatch(struct dma_buf *dmabuf, + struct dma_buf_attachment *attachment) +{ + struct sram_dma_heap_buffer *buffer = dmabuf->priv; + struct dma_heap_attachment *a = attachment->priv; + + mutex_lock(&buffer->attachments_lock); + list_del(&a->list); + mutex_unlock(&buffer->attachments_lock); + + sg_free_table(a->table); + kfree(a->table); + kfree(a); +} + +static struct sg_table *dma_heap_map_dma_buf(struct dma_buf_attachment *attachment, + enum dma_data_direction direction) +{ + struct dma_heap_attachment *a = attachment->priv; + struct sg_table *table = a->table; + + /* + * As this heap is backed by uncached SRAM memory we do not need to + * perform any sync operations on the buffer before allowing device + * domain access. For this reason we use SKIP_CPU_SYNC and also do + * not use or provide begin/end_cpu_access() dma-buf functions. + */ + if (!dma_map_sg_attrs(attachment->dev, table->sgl, table->nents, + direction, DMA_ATTR_SKIP_CPU_SYNC)) + return ERR_PTR(-ENOMEM); + + return table; +} + +static void dma_heap_unmap_dma_buf(struct dma_buf_attachment *attachment, + struct sg_table *table, + enum dma_data_direction direction) +{ + dma_unmap_sg_attrs(attachment->dev, table->sgl, table->nents, + direction, DMA_ATTR_SKIP_CPU_SYNC); +} + +static void dma_heap_dma_buf_release(struct dma_buf *dmabuf) +{ + struct sram_dma_heap_buffer *buffer = dmabuf->priv; + + gen_pool_free(buffer->pool, (unsigned long)buffer->vaddr, buffer->len); + kfree(buffer); +} + +static int dma_heap_mmap(struct dma_buf *dmabuf, struct vm_area_struct *vma) +{ + struct sram_dma_heap_buffer *buffer = dmabuf->priv; + int ret; + + /* SRAM mappings are not cached */ + vma->vm_page_prot = pgprot_writecombine(vma->vm_page_prot); + + ret = vm_iomap_memory(vma, buffer->paddr, buffer->len); + if (ret) + pr_err("Could not map buffer to userspace\n"); + + return ret; +} + +static int dma_heap_vmap(struct dma_buf *dmabuf, struct iosys_map *map) +{ + struct sram_dma_heap_buffer *buffer = dmabuf->priv; + + iosys_map_set_vaddr(map, buffer->vaddr); + + return 0; +} + +static const struct dma_buf_ops sram_dma_heap_buf_ops = { + .attach = dma_heap_attach, + .detach = dma_heap_detatch, + .map_dma_buf = dma_heap_map_dma_buf, + .unmap_dma_buf = dma_heap_unmap_dma_buf, + .release = dma_heap_dma_buf_release, + .mmap = dma_heap_mmap, + .vmap = dma_heap_vmap, +}; + +struct dma_buf *sram_dma_heap_allocate(struct dma_heap *heap, + unsigned long len, + unsigned long fd_flags, + unsigned long heap_flags) +{ + struct sram_dma_heap *sram_dma_heap = dma_heap_get_drvdata(heap); + struct sram_dma_heap_buffer *buffer; + + DEFINE_DMA_BUF_EXPORT_INFO(exp_info); + struct dma_buf *dmabuf; + int ret; + + buffer = kzalloc(sizeof(*buffer), GFP_KERNEL); + if (!buffer) + return ERR_PTR(-ENOMEM); + buffer->pool = sram_dma_heap->pool; + INIT_LIST_HEAD(&buffer->attachments); + mutex_init(&buffer->attachments_lock); + buffer->len = len; + + buffer->vaddr = (void *)gen_pool_alloc(buffer->pool, buffer->len); + if (!buffer->vaddr) { + ret = -ENOMEM; + goto free_buffer; + } + + buffer->paddr = gen_pool_virt_to_phys(buffer->pool, (unsigned long)buffer->vaddr); + if (buffer->paddr == -1) { + ret = -ENOMEM; + goto free_pool; + } + + /* create the dmabuf */ + exp_info.exp_name = dma_heap_get_name(heap); + exp_info.ops = &sram_dma_heap_buf_ops; + exp_info.size = buffer->len; + exp_info.flags = fd_flags; + exp_info.priv = buffer; + dmabuf = dma_buf_export(&exp_info); + if (IS_ERR(dmabuf)) { + ret = PTR_ERR(dmabuf); + goto free_pool; + } + + return dmabuf; + +free_pool: + gen_pool_free(buffer->pool, (unsigned long)buffer->vaddr, buffer->len); +free_buffer: + kfree(buffer); + + return ERR_PTR(ret); +} + +static struct dma_heap_ops sram_dma_heap_ops = { + .allocate = sram_dma_heap_allocate, +}; + +int sram_add_dma_heap(struct sram_dev *sram, + struct sram_reserve *block, + phys_addr_t start, + struct sram_partition *part) +{ + struct sram_dma_heap *sram_dma_heap; + struct dma_heap_export_info exp_info; + + dev_info(sram->dev, "Exporting SRAM Heap '%s'\n", block->label); + + sram_dma_heap = kzalloc(sizeof(*sram_dma_heap), GFP_KERNEL); + if (!sram_dma_heap) + return -ENOMEM; + sram_dma_heap->pool = part->pool; + + exp_info.name = kasprintf(GFP_KERNEL, "sram_%s", block->label); + exp_info.ops = &sram_dma_heap_ops; + exp_info.priv = sram_dma_heap; + sram_dma_heap->heap = dma_heap_add(&exp_info); + if (IS_ERR(sram_dma_heap->heap)) { + int ret = PTR_ERR(sram_dma_heap->heap); + kfree(sram_dma_heap); + return ret; + } + + return 0; +} diff --git a/drivers/misc/sram.c b/drivers/misc/sram.c index f0e7f02605eb3..13dcab2062fac 100644 --- a/drivers/misc/sram.c +++ b/drivers/misc/sram.c @@ -120,6 +120,12 @@ static int sram_add_partition(struct sram_dev *sram, struct sram_reserve *block, ret = sram_add_pool(sram, block, start, part); if (ret) return ret; + + if (block->export) { + ret = sram_add_dma_heap(sram, block, start, part); + if (ret) + return ret; + } } if (block->export) { ret = sram_add_export(sram, block, start, part); diff --git a/drivers/misc/sram.h b/drivers/misc/sram.h index d2058d8c8f1d2..7687c32c09226 100644 --- a/drivers/misc/sram.h +++ b/drivers/misc/sram.h @@ -61,4 +61,20 @@ static inline int sram_add_protect_exec(struct sram_partition *part) return -ENODEV; } #endif /* CONFIG_SRAM_EXEC */ + +#ifdef CONFIG_SRAM_DMA_HEAP +int sram_add_dma_heap(struct sram_dev *sram, + struct sram_reserve *block, + phys_addr_t start, + struct sram_partition *part); +#else +static inline int sram_add_dma_heap(struct sram_dev *sram, + struct sram_reserve *block, + phys_addr_t start, + struct sram_partition *part) +{ + return 0; +} +#endif /* CONFIG_SRAM_DMA_HEAP */ + #endif /* __SRAM_H */ -- 2.39.2

2 years, 2 months

2
1
0 0

[PATCH v2 0/3] usb: gadget: functionfs: DMABUF import interface

by Paul Cercueil

Hi, This small patchset adds three new IOCTLs that can be used to attach, detach, or transfer from/to a DMABUF object. Changes since v1: - patch [2/3] is new. I had to reuse a piece of code that was already duplicated in the driver, so I factorized the code. - Make ffs_dma_resv_lock() static - Add MODULE_IMPORT_NS(DMA_BUF); - The attach/detach functions are now performed without locking the eps_lock spinlock. The transfer function starts with the spinlock unlocked, then locks it before allocating and queueing the USB transfer. Cheers, -Paul Paul Cercueil (3): usb: gadget: Support already-mapped DMA SGs usb: gadget: functionfs: Factorize wait-for-endpoint code usb: gadget: functionfs: Add DMABUF import interface drivers/usb/gadget/function/f_fs.c | 467 ++++++++++++++++++++++++++-- drivers/usb/gadget/udc/core.c | 7 +- include/linux/usb/gadget.h | 2 + include/uapi/linux/usb/functionfs.h | 14 +- 4 files changed, 468 insertions(+), 22 deletions(-) -- 2.39.2

2 years, 2 months

2
5
0 0

[PATCH v9 0/2] drm: add kms driver for loongson display controller

by Sui Jingfeng

From: Sui Jingfeng <suijingfeng(a)loongson.cn> Loongson display controller IP has been integrated in both Loongson North Bridge chipset(ls7a1000 and ls7a2000) and Loongson SoCs(ls2k1000 and ls2k2000 etc), it even has been included in Loongson BMC products. This display controller is a PCI device, it has two display pipe. For the DC in LS7A1000 and LS2K1000 each way has a DVO output interface which provide RGB888 signals, vertical & horizontal synchronisations, and the pixel clock. Each CRTC is able to support 1920x1080@60Hz, the maximum resolution is 2048x2048 according to the hardware spec. For the DC in LS7A2000, each display pipe is equipped with a built-in HDMI encoder which is compliant with HDMI 1.4 specification, thus it support 3840x2160@30Hz. The first display pipe is also equipped with a transparent vga encoder which is parallel with the HDMI encoder. The DC in LS7A2000 is more complete, besides above feature, it has two hardware cursors, two hardware vblank counter and two scanout position recorders. v1 -> v2: 1) Use hpd status reg when polling for ls7a2000 2) Fix all warnings emerged when compile with W=1 v2 -> v3: 1) Add COMPILE_TEST in Kconfig and make the driver off by default 2) Alphabetical sorting headers (Thomas) 3) Untangle register access functions as much as possible (Thomas) 4) Switch to TTM based memory manager and prefer cached mapping for Loongson SoC (Thomas) 5) Add chip id detection method, now all models are distinguishable. 6) Revise builtin HDMI phy driver, nearly all main stream mode below 4K@30Hz is tested, this driver supported these mode very well including clone display mode and extend display mode. v3 -> v4: 1) Quickly fix a small mistake. v4 -> v5: 1) Drop potential support for Loongson 2K series SoC temporary, this part should be resend with the DT binding patch in the future. 2) Add per display pipe debugfs support to the builtin HDMI encoder. 3) Rewrite atomic_update() for hardware cursors plane(Thomas) 4) Rewrite encoder and connector initialization part, untangle it according to the chip(Thomas). v5 -> v6: 1) Remove stray code which didn't get used, say lsdc_of_get_reserved_ram 2) Fix all typos I could found, make sentences and code more readable 3) Untangle lsdc_hdmi*_connector_detect() function according to the pipe 4) After a serious consideration, we rename this driver as loongson. Because we also have drivers toward the LoongGPU IP in LS7A2000 and LS2K2000. Besides, there are also drivers about the external encoder, HDMI audio driver and vbios support etc. This patch only provide DC driver part, my teammate Li Yi believe that loongson will be more suitable for loongson graphics than lsdc in the long run. loongson.ko = LSDC + LoongGPU + encoders driver + vbios/DT ... v6 -> v7: 1) Add prime support, self-sharing is works. sharing buffer with etnaviv is also tested, and its works with limitation. 2) Implement buffer objects tracking with list_head. 3) S3(sleep to RAM) is tested on ls3a5000+ls7a2000 evb and it works. 4) Rewrite lsdc_bo_move, since ttm core stop allocating resources during BO creation. Patch V1 ~ V6 of this series no longer works on latest kernel. Thus, we send V7 to revival them. v7 -> v8: 1) Zero a compile warnnings on 32-bit platform, compile with W=1 2) Revise lsdc_bo_gpu_offset() and minor cleanup 3) Pageflip tested on the virtual terminal with following commands modetest -M loongson -s 32:1920x1080 -v modetest -M loongson -s 34:1920x1080 -v -F tiles It works like a charm, when running pageflip test with dual screnn configuration, another two additional bo created by the modetest emerged, VRAM usage up to 40+MB, well we have at least 64MB, still enough. # cat bos bo[0000]: size: 8112kB VRAM bo[0001]: size: 16kB VRAM bo[0002]: size: 16kB VRAM bo[0003]: size: 16208kB VRAM bo[0004]: size: 8112kB VRAM bo[0005]: size: 8112kB VRAM v8 -> v9: 1) Select I2C and I2C_ALGOBIT in Kconfig and should depend on MMU. 2) Using pci_get_domain_bus_and_slot to get the GPU device. 3) Other minor improvements. Sui Jingfeng (2): MAINTAINERS: add maintainers for DRM LOONGSON driver drm: add kms driver for loongson display controller MAINTAINERS | 7 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/loongson/Kconfig | 17 + drivers/gpu/drm/loongson/Makefile | 16 + drivers/gpu/drm/loongson/lsdc_crtc.c | 381 ++++++++++++++++ drivers/gpu/drm/loongson/lsdc_debugfs.c | 261 +++++++++++ drivers/gpu/drm/loongson/lsdc_drv.c | 508 +++++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_drv.h | 324 ++++++++++++++ drivers/gpu/drm/loongson/lsdc_gem.c | 294 +++++++++++++ drivers/gpu/drm/loongson/lsdc_gem.h | 26 ++ drivers/gpu/drm/loongson/lsdc_i2c.c | 171 +++++++ drivers/gpu/drm/loongson/lsdc_irq.c | 86 ++++ drivers/gpu/drm/loongson/lsdc_irq.h | 12 + drivers/gpu/drm/loongson/lsdc_output.c | 563 ++++++++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_output.h | 14 + drivers/gpu/drm/loongson/lsdc_plane.c | 432 ++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_pll.c | 338 ++++++++++++++ drivers/gpu/drm/loongson/lsdc_pll.h | 76 ++++ drivers/gpu/drm/loongson/lsdc_probe.c | 86 ++++ drivers/gpu/drm/loongson/lsdc_probe.h | 11 + drivers/gpu/drm/loongson/lsdc_regs.h | 370 ++++++++++++++++ drivers/gpu/drm/loongson/lsdc_ttm.c | 426 ++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_ttm.h | 71 +++ 24 files changed, 4493 insertions(+) create mode 100644 drivers/gpu/drm/loongson/Kconfig create mode 100644 drivers/gpu/drm/loongson/Makefile create mode 100644 drivers/gpu/drm/loongson/lsdc_crtc.c create mode 100644 drivers/gpu/drm/loongson/lsdc_debugfs.c create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.c create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.h create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.c create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.h create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.c create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.c create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.h create mode 100644 drivers/gpu/drm/loongson/lsdc_output.c create mode 100644 drivers/gpu/drm/loongson/lsdc_output.h create mode 100644 drivers/gpu/drm/loongson/lsdc_plane.c create mode 100644 drivers/gpu/drm/loongson/lsdc_pll.c create mode 100644 drivers/gpu/drm/loongson/lsdc_pll.h create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.c create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.h create mode 100644 drivers/gpu/drm/loongson/lsdc_regs.h create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.c create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.h -- 2.25.1

2 years, 2 months

2
5
0 0

[PATCH 18/19] drm/amd/amdgpu/sdma_v6_0: Demote a bunch of half-completed function headers

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'job' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:248: warning: Function parameter or member 'flags' not described in 'sdma_v6_0_ring_emit_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:945: warning: Function parameter or member 'timeout' not described in 'sdma_v6_0_ring_test_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1124: warning: Function parameter or member 'ring' not described in 'sdma_v6_0_ring_pad_ib' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'vmid' not described in 'sdma_v6_0_ring_emit_vm_flush' drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c:1175: warning: Function parameter or member 'pd_addr' not described in 'sdma_v6_0_ring_emit_vm_flush' Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: Stanley Yang <Stanley.Yang(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c index 40e6b22daa226..efea4ef30a787 100644 --- a/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v6_0.c @@ -233,7 +233,7 @@ static void sdma_v6_0_ring_insert_nop(struct amdgpu_ring *ring, uint32_t count) amdgpu_ring_write(ring, ring->funcs->nop); } -/** +/* * sdma_v6_0_ring_emit_ib - Schedule an IB on the DMA engine * * @ring: amdgpu ring pointer @@ -933,7 +933,7 @@ static int sdma_v6_0_ring_test_ring(struct amdgpu_ring *ring) return r; } -/** +/* * sdma_v6_0_ring_test_ib - test an IB on the DMA engine * * @ring: amdgpu_ring structure holding ring information @@ -1114,7 +1114,7 @@ static void sdma_v6_0_vm_set_pte_pde(struct amdgpu_ib *ib, ib->ptr[ib->length_dw++] = count - 1; /* number of entries */ } -/** +/* * sdma_v6_0_ring_pad_ib - pad the IB * @ib: indirect buffer to fill with padding * @@ -1162,7 +1162,7 @@ static void sdma_v6_0_ring_emit_pipeline_sync(struct amdgpu_ring *ring) SDMA_PKT_POLL_REGMEM_DW5_INTERVAL(4)); /* retry count, poll interval */ } -/** +/* * sdma_v6_0_ring_emit_vm_flush - vm flush using sDMA * * @ring: amdgpu_ring pointer -- 2.40.0.348.gf938b09366-goog

2 years, 2 months

1
0
0 0

[PATCH 16/19] drm/i915/i915_vma: Provide one missing param and demote another non-kerneldoc header

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/i915_vma.c:756: warning: Function parameter or member 'ww' not described in 'i915_vma_insert' drivers/gpu/drm/i915/i915_vma.c:1744: warning: Function parameter or member 'vma' not described in 'i915_vma_destroy_locked' Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: intel-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/i915/i915_vma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c index f51fd9fd4c89c..20a44788999e5 100644 --- a/drivers/gpu/drm/i915/i915_vma.c +++ b/drivers/gpu/drm/i915/i915_vma.c @@ -739,6 +739,7 @@ bool i915_gem_valid_gtt_space(struct i915_vma *vma, unsigned long color) /** * i915_vma_insert - finds a slot for the vma in its address space * @vma: the vma + * @ww: An optional struct i915_gem_ww_ctx * @size: requested size in bytes (can be larger than the VMA) * @alignment: required alignment * @flags: mask of PIN_* flags to use @@ -1714,7 +1715,7 @@ static void release_references(struct i915_vma *vma, struct intel_gt *gt, i915_vma_free(vma); } -/** +/* * i915_vma_destroy_locked - Remove all weak reference to the vma and put * the initial reference. * -- 2.40.0.348.gf938b09366-goog

2 years, 2 months

1
0
0 0

[PATCH 13/19] drm/i915/gem/i915_gem_object: Demote non-kerneldoc header with no param descriptions

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_object.c:887: warning: Function parameter or member 'obj' not described in 'i915_gem_object_has_unknown_state' Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: Matthew Auld <matthew.auld(a)intel.com> Cc: Nirmoy Das <nirmoy.das(a)intel.com> Cc: intel-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_object.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_object.c b/drivers/gpu/drm/i915/gem/i915_gem_object.c index e6d4efde4fc51..4666bb82f312c 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_object.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_object.c @@ -875,7 +875,7 @@ int i915_gem_object_wait_moving_fence(struct drm_i915_gem_object *obj, return ret < 0 ? ret : 0; } -/** +/* * i915_gem_object_has_unknown_state - Return true if the object backing pages are * in an unknown_state. This means that userspace must NEVER be allowed to touch * the pages, with either the GPU or CPU. -- 2.40.0.348.gf938b09366-goog

2 years, 2 months

1
0
0 0

[PATCH 12/19] drm/i915/gem/i915_gem_wait: Provide function name to validate the kerneldoc header

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_wait.c:164: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: Chris Wilson <chris(a)chris-wilson.co.uk> Cc: intel-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index e6e01c2a74a65..4a33ad2d122bd 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_wait.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_wait.c @@ -161,7 +161,7 @@ i915_gem_object_wait_priority(struct drm_i915_gem_object *obj, } /** - * Waits for rendering to the object to be completed + * i915_gem_object_wait - Waits for rendering to the object to be completed * @obj: i915 gem object * @flags: how to wait (under a lock, for all rendering or just for writes etc) * @timeout: how long to wait -- 2.40.0.348.gf938b09366-goog

2 years, 2 months

1
0
0 0

[PATCH 11/19] drm/i915/gem/i915_gem_ttm_move: Provide a couple of missing descriptions for 'num_pages' and 'ctx'

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:272: warning: Function parameter or member 'num_pages' not described in 'i915_ttm_memcpy_arg' drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:569: warning: Function parameter or member 'ctx' not described in 'i915_ttm_move' Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: intel-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c index d030182ca1764..dd188dfcc423e 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c @@ -253,6 +253,7 @@ static struct dma_fence *i915_ttm_accel_move(struct ttm_buffer_object *bo, * @_src_iter: Storage space for the source kmap iterator. * @dst_iter: Pointer to the destination kmap iterator. * @src_iter: Pointer to the source kmap iterator. + * @num_pages: Number of pages * @clear: Whether to clear instead of copy. * @src_rsgt: Refcounted scatter-gather list of source memory. * @dst_rsgt: Refcounted scatter-gather list of destination memory. @@ -557,6 +558,8 @@ __i915_ttm_move(struct ttm_buffer_object *bo, * i915_ttm_move - The TTM move callback used by i915. * @bo: The buffer object. * @evict: Whether this is an eviction. + * @ctx: Pointer to a struct ttm_operation_ctx indicating how the waits should be + * performed if waiting * @dst_mem: The destination ttm resource. * @hop: If we need multihop, what temporary memory type to move to. * -- 2.40.0.348.gf938b09366-goog

2 years, 2 months

1
0
0 0

[PATCH 10/19] drm/i915/gem/i915_gem_ttm: Demote half-filled kerneldoc

by Lee Jones

Hopefully someone knowledgable will follow-up to complete it. Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'offset' not described in '__i915_gem_ttm_object_init' drivers/gpu/drm/i915/gem/i915_gem_ttm.c:1292: warning: Function parameter or member 'page_size' not described in '__i915_gem_ttm_object_init' Cc: Jani Nikula <jani.nikula(a)linux.intel.com> Cc: Joonas Lahtinen <joonas.lahtinen(a)linux.intel.com> Cc: Rodrigo Vivi <rodrigo.vivi(a)intel.com> Cc: Tvrtko Ursulin <tvrtko.ursulin(a)linux.intel.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: Matthew Auld <matthew.auld(a)intel.com> Cc: intel-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index 341b94672abcb..9227f8146a583 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -1274,7 +1274,7 @@ void i915_ttm_bo_destroy(struct ttm_buffer_object *bo) } } -/** +/* * __i915_gem_ttm_object_init - Initialize a ttm-backed i915 gem object * @mem: The initial memory region for the object. * @obj: The gem object. -- 2.40.0.348.gf938b09366-goog

2 years, 2 months

1
0
0 0

[PATCH 1/3] dma-buf/dma-buf.c: add a blank line between the two adjoining functions

by Sui Jingfeng

From: Sui Jingfeng <suijingfeng(a)loongson.cn> Trivial cleanup, no functional change. Signed-off-by: Sui Jingfeng <suijingfeng(a)loongson.cn> --- drivers/dma-buf/dma-buf.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c index aa4ea8530cb3..485b022a31fa 100644 --- a/drivers/dma-buf/dma-buf.c +++ b/drivers/dma-buf/dma-buf.c @@ -777,10 +777,10 @@ static void mangle_sg_table(struct sg_table *sg_table) for_each_sgtable_sg(sg_table, sg, i) sg->page_link ^= ~0xffUL; #endif - } -static struct sg_table * __map_dma_buf(struct dma_buf_attachment *attach, - enum dma_data_direction direction) + +static struct sg_table *__map_dma_buf(struct dma_buf_attachment *attach, + enum dma_data_direction direction) { struct sg_table *sg_table; signed long ret; -- 2.25.1

2 years, 2 months

1
2
0 0

[pull] drm: dma-fence-deadline for v6.4

by Rob Clark

Hi Dave and Daniel, Here is the series for dma-fence deadline hint, without driver specific patches, or UAPI, with the intent that it can be merged into drm-next as well as -driver next trees to enable landing driver specific support through their corresponding -next trees. The following changes since commit eeac8ede17557680855031c6f305ece2378af326: Linux 6.3-rc2 (2023-03-12 16:36:44 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git tags/dma-fence-deadline for you to fetch changes up to d39e48ca80c0960b039cb38633957f0040f63e1a: drm/atomic-helper: Set fence deadline for vblank (2023-03-28 14:52:59 -0700) ---------------------------------------------------------------- This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To continue to be able to use the atomic helpers 2) To support cases where display and gpu are different drivers See https://patchwork.freedesktop.org/series/93035/ This does not yet add any UAPI, although this will be needed in a number of cases: 1) Workloads "ping-ponging" between CPU and GPU, where we don't want the GPU freq governor to interpret time stalled waiting for GPU as "idle" time 2) Cases where the compositor is waiting for fences to be signaled before issuing the atomic ioctl, for example to maintain 60fps cursor updates even when the GPU is not able to maintain that framerate. ---------------------------------------------------------------- Rob Clark (8): dma-buf/dma-fence: Add deadline awareness dma-buf/fence-array: Add fence deadline support dma-buf/fence-chain: Add fence deadline support dma-buf/dma-resv: Add a way to set fence deadline dma-buf/sync_file: Surface sync-file uABI drm/scheduler: Add fence deadline support drm/vblank: Add helper to get next vblank time drm/atomic-helper: Set fence deadline for vblank Documentation/driver-api/dma-buf.rst | 16 +++++++-- drivers/dma-buf/dma-fence-array.c | 11 ++++++ drivers/dma-buf/dma-fence-chain.c | 12 +++++++ drivers/dma-buf/dma-fence.c | 59 +++++++++++++++++++++++++++++++++ drivers/dma-buf/dma-resv.c | 22 ++++++++++++ drivers/gpu/drm/drm_atomic_helper.c | 37 +++++++++++++++++++++ drivers/gpu/drm/drm_vblank.c | 53 ++++++++++++++++++++++++----- drivers/gpu/drm/scheduler/sched_fence.c | 46 +++++++++++++++++++++++++ drivers/gpu/drm/scheduler/sched_main.c | 2 +- include/drm/drm_vblank.h | 1 + include/drm/gpu_scheduler.h | 17 ++++++++++ include/linux/dma-fence.h | 22 ++++++++++++ include/linux/dma-resv.h | 2 ++ include/uapi/linux/sync_file.h | 37 +++++++++------------ 14 files changed, 303 insertions(+), 34 deletions(-)

2 years, 2 months

2
1
0 0

[pull] drm: dma-fence-deadline-core for v6.4

by Rob Clark

Hi Dave and Daniel, Here is the series for dma-fence deadline hint, without driver specific patches, with the intent that it can be merged into drm-next as well as -driver next trees to enable landing driver specific support through their corresponding -next trees. The following changes since commit eeac8ede17557680855031c6f305ece2378af326: Linux 6.3-rc2 (2023-03-12 16:36:44 -0700) are available in the Git repository at: https://gitlab.freedesktop.org/drm/msm.git tags/dma-fence-deadline-core for you to fetch changes up to 0bcc8f52a8d9d1f9cd5af7f88c6599a89e64284a: drm/atomic-helper: Set fence deadline for vblank (2023-03-25 10:55:08 -0700) ---------------------------------------------------------------- Immutable branch with dma-fence deadline hint support between drm-next and driver -next trees. ---------------------------------------------------------------- Rob Clark (11): dma-buf/dma-fence: Add deadline awareness dma-buf/fence-array: Add fence deadline support dma-buf/fence-chain: Add fence deadline support dma-buf/dma-resv: Add a way to set fence deadline dma-buf/sync_file: Surface sync-file uABI dma-buf/sync_file: Add SET_DEADLINE ioctl dma-buf/sw_sync: Add fence deadline support drm/scheduler: Add fence deadline support drm/syncobj: Add deadline support for syncobj waits drm/vblank: Add helper to get next vblank time drm/atomic-helper: Set fence deadline for vblank Documentation/driver-api/dma-buf.rst | 16 ++++++- drivers/dma-buf/dma-fence-array.c | 11 +++++ drivers/dma-buf/dma-fence-chain.c | 12 +++++ drivers/dma-buf/dma-fence.c | 60 ++++++++++++++++++++++++ drivers/dma-buf/dma-resv.c | 22 +++++++++ drivers/dma-buf/sw_sync.c | 81 +++++++++++++++++++++++++++++++++ drivers/dma-buf/sync_debug.h | 2 + drivers/dma-buf/sync_file.c | 19 ++++++++ drivers/gpu/drm/drm_atomic_helper.c | 37 +++++++++++++++ drivers/gpu/drm/drm_syncobj.c | 64 ++++++++++++++++++++------ drivers/gpu/drm/drm_vblank.c | 53 +++++++++++++++++---- drivers/gpu/drm/scheduler/sched_fence.c | 46 +++++++++++++++++++ drivers/gpu/drm/scheduler/sched_main.c | 2 +- include/drm/drm_vblank.h | 1 + include/drm/gpu_scheduler.h | 17 +++++++ include/linux/dma-fence.h | 22 +++++++++ include/linux/dma-resv.h | 2 + include/uapi/drm/drm.h | 17 +++++++ include/uapi/linux/sync_file.h | 59 +++++++++++++++--------- 19 files changed, 496 insertions(+), 47 deletions(-)

2 years, 2 months

3
4
0 0

[PATCH v8 0/2] drm: add kms driver for loongson display controller

by Sui Jingfeng

From: Sui Jingfeng <suijingfeng(a)loongson.cn> Loongson display controller IP has been integrated in both Loongson North Bridge chipset(ls7a1000 and ls7a2000) and Loongson SoCs(ls2k1000 and ls2k2000 etc), it even has been included in Loongson BMC products. This display controller is a PCI device, it has two display pipe. For the DC in LS7A1000 and LS2K1000 each way has a DVO output interface which provide RGB888 signals, vertical & horizontal synchronisations, and the pixel clock. Each CRTC is able to support 1920x1080@60Hz, the maximum resolution is 2048x2048 according to the hardware spec. For the DC in LS7A2000, each display pipe is equipped with a built-in HDMI encoder which is compliant with HDMI 1.4 specification, thus it support 3840x2160@30Hz. The first display pipe is also equipped with a transparent vga encoder which is parallel with the HDMI encoder. The DC in LS7A2000 is more complete, besides above feature, it has two hardware cursors, two hardware vblank counter and two scanout position recorders. v1 -> v2: 1) Use hpd status reg when polling for ls7a2000 2) Fix all warnings emerged when compile with W=1 v2 -> v3: 1) Add COMPILE_TEST in Kconfig and make the driver off by default 2) Alphabetical sorting headers (Thomas) 3) Untangle register access functions as much as possible (Thomas) 4) Switch to TTM based memory manager and prefer cached mapping for Loongson SoC (Thomas) 5) Add chip id detection method, now all models are distinguishable. 6) Revise builtin HDMI phy driver, nearly all main stream mode below 4K@30Hz is tested, this driver supported these mode very well including clone display mode and extend display mode. v3 -> v4: 1) Quickly fix a small mistake. v4 -> v5: 1) Drop potential support for Loongson 2K series SoC temporary, this part should be resend with the DT binding patch in the future. 2) Add per display pipe debugfs support to the builtin HDMI encoder. 3) Rewrite atomic_update() for hardware cursors plane(Thomas) 4) Rewrite encoder and connector initialization part, untangle it according to the chip(Thomas). v5 -> v6: 1) Remove stray code which didn't get used, say lsdc_of_get_reserved_ram 2) Fix all typos I could found, make sentences and code more readable 3) Untange lsdc_hdmi*_connector_detect() function according to the pipe 4) After a serious consideration, we rename this driver as loongson. Because we also have drivers toward the LoongGPU IP in LS7A2000 and LS2K2000. Besides, there are also drivers about the external encoder, HDMI audio driver and vbios support etc. This patch only provide DC driver part, my teammate Li Yi believe that loongson will be more suitable for loongson graphics than lsdc in the long run. loongson.ko = LSDC + LoongGPU + encoders driver + vbios/DT ... v6 -> v7: 1) Add prime support, self-sharing is works. sharing buffer with etnaviv is also tested, and its works with limitation. 2) Implement buffer objects tracking with list_head. 3) S3(sleep to RAM) is tested on ls3a5000+ls7a2000 evb and it works. 4) Rewrite lsdc_bo_move, since ttm core stop allocating resources during BO creation. Patch V1 ~ V6 of this series no longer works on Linux 6.3.0-rc2. Thus, we send V7 to revival them. 5) Remove depends on LOONGARCH || MIPS || COMPILE_TEST to help review and compile on x86 machine. 6) Add a cover letter to help patchwork tracking my patch. V1 ~ V4 can be found at link [1], V5 at link [2], V6 at link [3] [1] https://patchwork.freedesktop.org/series/113566/ [2] https://patchwork.freedesktop.org/series/114386/ [3] https://patchwork.freedesktop.org/patch/524532/ v7 -> v8: 1) Zero a compile warnnings on 32-bit platform, compile with W=1 2) Revise lsdc_bo_gpu_offset() and minor cleanup 3) Pageflip tested on the virtual terminal with following commands modetest -M loongson -s 32:1920x1080 -v modetest -M loongson -s 34:1920x1080 -v -F tiles It works like a charm, when running pageflip test with dual screnn configuration, another two additional bo created by the modetest emerged, VRAM usage up to 40+MB, well we have at least 64MB, still enough. # cat bos bo[0000]: size: 8112kB VRAM bo[0001]: size: 16kB VRAM bo[0002]: size: 16kB VRAM bo[0003]: size: 16208kB VRAM bo[0004]: size: 8112kB VRAM bo[0005]: size: 8112kB VRAM Sui Jingfeng (2): MAINTAINERS: add maintainers for DRM LOONGSON driver drm: add kms driver for loongson display controller MAINTAINERS | 7 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/loongson/Kconfig | 15 + drivers/gpu/drm/loongson/Makefile | 16 + drivers/gpu/drm/loongson/lsdc_crtc.c | 385 ++++++++++++++++ drivers/gpu/drm/loongson/lsdc_debugfs.c | 261 +++++++++++ drivers/gpu/drm/loongson/lsdc_drv.c | 501 +++++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_drv.h | 318 +++++++++++++ drivers/gpu/drm/loongson/lsdc_gem.c | 291 ++++++++++++ drivers/gpu/drm/loongson/lsdc_gem.h | 26 ++ drivers/gpu/drm/loongson/lsdc_i2c.c | 171 +++++++ drivers/gpu/drm/loongson/lsdc_irq.c | 88 ++++ drivers/gpu/drm/loongson/lsdc_irq.h | 11 + drivers/gpu/drm/loongson/lsdc_output.c | 563 ++++++++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_output.h | 14 + drivers/gpu/drm/loongson/lsdc_plane.c | 416 +++++++++++++++++ drivers/gpu/drm/loongson/lsdc_pll.c | 338 ++++++++++++++ drivers/gpu/drm/loongson/lsdc_pll.h | 76 ++++ drivers/gpu/drm/loongson/lsdc_probe.c | 85 ++++ drivers/gpu/drm/loongson/lsdc_probe.h | 11 + drivers/gpu/drm/loongson/lsdc_regs.h | 370 ++++++++++++++++ drivers/gpu/drm/loongson/lsdc_ttm.c | 430 ++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_ttm.h | 68 +++ 24 files changed, 4464 insertions(+) create mode 100644 drivers/gpu/drm/loongson/Kconfig create mode 100644 drivers/gpu/drm/loongson/Makefile create mode 100644 drivers/gpu/drm/loongson/lsdc_crtc.c create mode 100644 drivers/gpu/drm/loongson/lsdc_debugfs.c create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.c create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.h create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.c create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.h create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.c create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.c create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.h create mode 100644 drivers/gpu/drm/loongson/lsdc_output.c create mode 100644 drivers/gpu/drm/loongson/lsdc_output.h create mode 100644 drivers/gpu/drm/loongson/lsdc_plane.c create mode 100644 drivers/gpu/drm/loongson/lsdc_pll.c create mode 100644 drivers/gpu/drm/loongson/lsdc_pll.h create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.c create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.h create mode 100644 drivers/gpu/drm/loongson/lsdc_regs.h create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.c create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.h -- 2.25.1

2 years, 2 months

3
8
0 0

[PATCH v10 00/15] dma-fence: Deadline awareness

by Rob Clark

From: Rob Clark <robdclark(a)chromium.org> This series adds a deadline hint to fences, so realtime deadlines such as vblank can be communicated to the fence signaller for power/ frequency management decisions. This is partially inspired by a trick i915 does, but implemented via dma-fence for a couple of reasons: 1) To continue to be able to use the atomic helpers 2) To support cases where display and gpu are different drivers This iteration adds a dma-fence ioctl to set a deadline (both to support igt-tests, and compositors which delay decisions about which client buffer to display), and a sw_sync ioctl to read back the deadline. IGT tests utilizing these can be found at: https://gitlab.freedesktop.org/robclark/igt-gpu-tools/-/commits/fence-deadl… v1: https://patchwork.freedesktop.org/series/93035/ v2: Move filtering out of later deadlines to fence implementation to avoid increasing the size of dma_fence v3: Add support in fence-array and fence-chain; Add some uabi to support igt tests and userspace compositors. v4: Rebase, address various comments, and add syncobj deadline support, and sync_file EPOLLPRI based on experience with perf/ freq issues with clvk compute workloads on i915 (anv) v5: Clarify that this is a hint as opposed to a more hard deadline guarantee, switch to using u64 ns values in UABI (still absolute CLOCK_MONOTONIC values), drop syncobj related cap and driver feature flag in favor of allowing count_handles==0 for probing kernel support. v6: Re-work vblank helper to calculate time of _start_ of vblank, and work correctly if the last vblank event was more than a frame ago. Add (mostly unrelated) drm/msm patch which also uses the vblank helper. Use dma_fence_chain_contained(). More verbose syncobj UABI comments. Drop DMA_FENCE_FLAG_HAS_DEADLINE_BIT. v7: Fix kbuild complaints about vblank helper. Add more docs. v8: Add patch to surface sync_file UAPI, and more docs updates. v9: Drop (E)POLLPRI support.. I still like it, but not essential and it can always be revived later. Fix doc build warning. v10: Update 11/15 to handle multiple CRTCs Rob Clark (15): dma-buf/dma-fence: Add deadline awareness dma-buf/fence-array: Add fence deadline support dma-buf/fence-chain: Add fence deadline support dma-buf/dma-resv: Add a way to set fence deadline dma-buf/sync_file: Surface sync-file uABI dma-buf/sync_file: Add SET_DEADLINE ioctl dma-buf/sw_sync: Add fence deadline support drm/scheduler: Add fence deadline support drm/syncobj: Add deadline support for syncobj waits drm/vblank: Add helper to get next vblank time drm/atomic-helper: Set fence deadline for vblank drm/msm: Add deadline based boost support drm/msm: Add wait-boost support drm/msm/atomic: Switch to vblank_start helper drm/i915: Add deadline based boost support Rob Clark (15): dma-buf/dma-fence: Add deadline awareness dma-buf/fence-array: Add fence deadline support dma-buf/fence-chain: Add fence deadline support dma-buf/dma-resv: Add a way to set fence deadline dma-buf/sync_file: Surface sync-file uABI dma-buf/sync_file: Add SET_DEADLINE ioctl dma-buf/sw_sync: Add fence deadline support drm/scheduler: Add fence deadline support drm/syncobj: Add deadline support for syncobj waits drm/vblank: Add helper to get next vblank time drm/atomic-helper: Set fence deadline for vblank drm/msm: Add deadline based boost support drm/msm: Add wait-boost support drm/msm/atomic: Switch to vblank_start helper drm/i915: Add deadline based boost support Documentation/driver-api/dma-buf.rst | 16 ++++- drivers/dma-buf/dma-fence-array.c | 11 ++++ drivers/dma-buf/dma-fence-chain.c | 12 ++++ drivers/dma-buf/dma-fence.c | 60 ++++++++++++++++++ drivers/dma-buf/dma-resv.c | 22 +++++++ drivers/dma-buf/sw_sync.c | 81 +++++++++++++++++++++++++ drivers/dma-buf/sync_debug.h | 2 + drivers/dma-buf/sync_file.c | 19 ++++++ drivers/gpu/drm/drm_atomic_helper.c | 37 +++++++++++ drivers/gpu/drm/drm_syncobj.c | 64 +++++++++++++++---- drivers/gpu/drm/drm_vblank.c | 53 +++++++++++++--- drivers/gpu/drm/i915/i915_request.c | 20 ++++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 15 ----- drivers/gpu/drm/msm/msm_atomic.c | 8 ++- drivers/gpu/drm/msm/msm_drv.c | 12 ++-- drivers/gpu/drm/msm/msm_fence.c | 74 ++++++++++++++++++++++ drivers/gpu/drm/msm/msm_fence.h | 20 ++++++ drivers/gpu/drm/msm/msm_gem.c | 5 ++ drivers/gpu/drm/msm/msm_kms.h | 8 --- drivers/gpu/drm/scheduler/sched_fence.c | 46 ++++++++++++++ drivers/gpu/drm/scheduler/sched_main.c | 2 +- include/drm/drm_vblank.h | 1 + include/drm/gpu_scheduler.h | 17 ++++++ include/linux/dma-fence.h | 22 +++++++ include/linux/dma-resv.h | 2 + include/uapi/drm/drm.h | 17 ++++++ include/uapi/drm/msm_drm.h | 14 ++++- include/uapi/linux/sync_file.h | 59 +++++++++++------- 28 files changed, 640 insertions(+), 79 deletions(-) -- 2.39.2

2 years, 2 months

7
31
0 0

[v3, PATCH] drm/mediatek: add dma buffer control for drm plane disable

by Yongqiang Niu

Fixes: 41016fe1028e4 (drm: Rename plane->state variables in atomic update and disable) dma buffer release before overlay disable, that will cause m4u translation fault warning. add dma buffer control flow in mediatek driver: get dma buffer when drm plane disable put dma buffer when overlay really disable Signed-off-by: Yongqiang Niu <yongqiang.niu(a)mediatek.com> --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 25 ++++++++++++++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_plane.c | 17 ++++++++++++++++ drivers/gpu/drm/mediatek/mtk_drm_plane.h | 1 + 3 files changed, 43 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 5071f1263216..9cf1c1778868 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -4,6 +4,7 @@ */ #include <linux/clk.h> +#include <linux/dma-buf.h> #include <linux/dma-mapping.h> #include <linux/mailbox_controller.h> #include <linux/pm_runtime.h> @@ -282,6 +283,23 @@ struct mtk_ddp_comp *mtk_drm_ddp_comp_for_plane(struct drm_crtc *crtc, return NULL; } +static void mtk_drm_dma_buf_put(struct mtk_drm_crtc *mtk_crtc) +{ + unsigned int i; + + for (i = 0; i < mtk_crtc->layer_nr; i++) { + struct drm_plane *plane = &mtk_crtc->planes[i]; + struct mtk_plane_state *plane_state; + + plane_state = to_mtk_plane_state(plane->state); + + if (plane_state && plane_state->pending.dma_buf) { + dma_buf_put(plane_state->pending.dma_buf); + plane_state->pending.dma_buf = NULL; + } + } +} + #if IS_REACHABLE(CONFIG_MTK_CMDQ) static void ddp_cmdq_cb(struct mbox_client *cl, void *mssg) { @@ -322,6 +340,8 @@ static void ddp_cmdq_cb(struct mbox_client *cl, void *mssg) mtk_crtc->pending_async_planes = false; } + mtk_drm_dma_buf_put(mtk_crtc); + mtk_crtc->cmdq_vblank_cnt = 0; wake_up(&mtk_crtc->cb_blocking_queue); } @@ -614,9 +634,14 @@ static void mtk_crtc_ddp_irq(void *data) else if (mtk_crtc->cmdq_vblank_cnt > 0 && --mtk_crtc->cmdq_vblank_cnt == 0) DRM_ERROR("mtk_crtc %d CMDQ execute command timeout!\n", drm_crtc_index(&mtk_crtc->base)); + + if (!mtk_crtc->cmdq_client.chan) + mtk_drm_dma_buf_put(mtk_crtc); #else if (!priv->data->shadow_register) mtk_crtc_ddp_config(crtc, NULL); + + mtk_drm_dma_buf_put(mtk_crtc); #endif mtk_drm_finish_page_flip(mtk_crtc); } diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.c b/drivers/gpu/drm/mediatek/mtk_drm_plane.c index d54fbf34b000..c169ca49129c 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.c @@ -12,6 +12,7 @@ #include <drm/drm_framebuffer.h> #include <drm/drm_gem_atomic_helper.h> #include <linux/align.h> +#include <linux/dma-buf.h> #include "mtk_drm_crtc.h" #include "mtk_drm_ddp_comp.h" @@ -280,6 +281,22 @@ static void mtk_plane_atomic_disable(struct drm_plane *plane, struct drm_plane_state *new_state = drm_atomic_get_new_plane_state(state, plane); struct mtk_plane_state *mtk_plane_state = to_mtk_plane_state(new_state); + struct drm_plane_state *old_state = drm_atomic_get_old_plane_state(state, + plane); + + if (old_state && old_state->fb) { + struct drm_gem_object *gem = old_state->fb->obj[0]; + + if (mtk_plane_state->pending.dma_buf) { + dma_buf_put(mtk_plane_state->pending.dma_buf); + mtk_plane_state->pending.dma_buf = NULL; + } + + if (gem && gem->dma_buf) { + get_dma_buf(gem->dma_buf); + mtk_plane_state->pending.dma_buf = gem->dma_buf; + } + } mtk_plane_state->pending.enable = false; wmb(); /* Make sure the above parameter is set before update */ mtk_plane_state->pending.dirty = true; diff --git a/drivers/gpu/drm/mediatek/mtk_drm_plane.h b/drivers/gpu/drm/mediatek/mtk_drm_plane.h index 8f39011cdbfc..b724e56b7283 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_plane.h +++ b/drivers/gpu/drm/mediatek/mtk_drm_plane.h @@ -33,6 +33,7 @@ struct mtk_plane_pending_state { bool async_dirty; bool async_config; enum drm_color_encoding color_encoding; + struct dma_buf *dma_buf; }; struct mtk_plane_state { -- 2.25.1

2 years, 2 months

4
3
0 0

[syzbot] [dri?] BUG: sleeping function called from invalid context in _vm_unmap_aliases

by syzbot

Hello, syzbot found the following issue on: HEAD commit: f3594f0204b7 Add linux-next specific files for 20230321 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=161552eec80000 kernel config: https://syzkaller.appspot.com/x/.config?x=f22105589e896af1 dashboard link: https://syzkaller.appspot.com/bug?extid=a9a2bb6afe9eb31efc56 compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 Unfortunately, I don't have any reproducer for this issue yet. Downloadable assets: disk image: https://storage.googleapis.com/syzbot-assets/0b755145006a/disk-f3594f02.raw… vmlinux: https://storage.googleapis.com/syzbot-assets/fca26e328a81/vmlinux-f3594f02.… kernel image: https://storage.googleapis.com/syzbot-assets/39744d7d289f/bzImage-f3594f02.… IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+a9a2bb6afe9eb31efc56(a)syzkaller.appspotmail.com BUG: sleeping function called from invalid context at kernel/locking/mutex.c:580 in_atomic(): 0, irqs_disabled(): 0, non_block: 0, pid: 10028, name: syz-executor.4 preempt_count: 0, expected: 0 RCU nest depth: 1, expected: 0 3 locks held by syz-executor.4/10028: #0: ffff88807597afd8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:110 [inline] #0: ffff88807597afd8 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x158/0x3b0 mm/util.c:541 #1: ffff888081123270 (&shmem->pages_lock){+.+.}-{3:3}, at: drm_gem_shmem_get_pages+0x53/0x180 drivers/gpu/drm/drm_gem_shmem_helper.c:216 #2: ffffffff8c796500 (rcu_read_lock){....}-{1:2}, at: _vm_unmap_aliases.part.0+0x138/0x560 mm/vmalloc.c:2182 CPU: 1 PID: 10028 Comm: syz-executor.4 Not tainted 6.3.0-rc3-next-20230321-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0x136/0x150 lib/dump_stack.c:106 __might_resched+0x358/0x580 kernel/sched/core.c:10059 __mutex_lock_common kernel/locking/mutex.c:580 [inline] __mutex_lock+0x9f/0x1350 kernel/locking/mutex.c:747 _vm_unmap_aliases.part.0+0x1ca/0x560 mm/vmalloc.c:2187 _vm_unmap_aliases mm/vmalloc.c:2181 [inline] vm_unmap_aliases+0x49/0x50 mm/vmalloc.c:2230 change_page_attr_set_clr+0x226/0x470 arch/x86/mm/pat/set_memory.c:1837 cpa_set_pages_array arch/x86/mm/pat/set_memory.c:1892 [inline] _set_pages_array+0x1c6/0x220 arch/x86/mm/pat/set_memory.c:2230 drm_gem_shmem_get_pages_locked+0x155/0x240 drivers/gpu/drm/drm_gem_shmem_helper.c:191 drm_gem_shmem_get_pages+0x71/0x180 drivers/gpu/drm/drm_gem_shmem_helper.c:219 drm_gem_shmem_mmap drivers/gpu/drm/drm_gem_shmem_helper.c:636 [inline] drm_gem_shmem_mmap+0x153/0x540 drivers/gpu/drm/drm_gem_shmem_helper.c:620 drm_gem_mmap_obj+0x1b6/0x6c0 drivers/gpu/drm/drm_gem.c:1046 drm_gem_mmap+0x41d/0x780 drivers/gpu/drm/drm_gem.c:1124 call_mmap include/linux/fs.h:1859 [inline] mmap_region+0x694/0x28d0 mm/mmap.c:2652 do_mmap+0x831/0xf60 mm/mmap.c:1438 vm_mmap_pgoff+0x1a2/0x3b0 mm/util.c:543 ksys_mmap_pgoff+0x41f/0x5a0 mm/mmap.c:1484 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f905968c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f905a3fa168 EFLAGS: 00000246 ORIG_RAX: 0000000000000009 RAX: ffffffffffffffda RBX: 00007f90597abf80 RCX: 00007f905968c0f9 RDX: 0000000000000000 RSI: 0000000000003028 RDI: 0000000020ffc000 RBP: 00007f90596e7b39 R08: 0000000000000004 R09: 0000000100000000 R10: 0000000000000012 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcde03503f R14: 00007f905a3fa300 R15: 0000000000022000 </TASK> ============================= [ BUG: Invalid wait context ] 6.3.0-rc3-next-20230321-syzkaller #0 Tainted: G W ----------------------------- syz-executor.4/10028 is trying to lock: ffff888027c7a068 (&vb->lock){+.+.}-{3:3}, at: _vm_unmap_aliases.part.0+0x1ca/0x560 mm/vmalloc.c:2187 other info that might help us debug this: context-{4:4} 3 locks held by syz-executor.4/10028: #0: ffff88807597afd8 (&mm->mmap_lock){++++}-{3:3}, at: mmap_write_lock_killable include/linux/mmap_lock.h:110 [inline] #0: ffff88807597afd8 (&mm->mmap_lock){++++}-{3:3}, at: vm_mmap_pgoff+0x158/0x3b0 mm/util.c:541 #1: ffff888081123270 (&shmem->pages_lock){+.+.}-{3:3}, at: drm_gem_shmem_get_pages+0x53/0x180 drivers/gpu/drm/drm_gem_shmem_helper.c:216 #2: ffffffff8c796500 (rcu_read_lock){....}-{1:2}, at: _vm_unmap_aliases.part.0+0x138/0x560 mm/vmalloc.c:2182 stack backtrace: CPU: 1 PID: 10028 Comm: syz-executor.4 Tainted: G W 6.3.0-rc3-next-20230321-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 03/02/2023 Call Trace: <TASK> __dump_stack lib/dump_stack.c:88 [inline] dump_stack_lvl+0xd9/0x150 lib/dump_stack.c:106 print_lock_invalid_wait_context kernel/locking/lockdep.c:4724 [inline] check_wait_context kernel/locking/lockdep.c:4785 [inline] __lock_acquire+0x159e/0x5df0 kernel/locking/lockdep.c:5024 lock_acquire.part.0+0x11c/0x370 kernel/locking/lockdep.c:5691 __mutex_lock_common kernel/locking/mutex.c:603 [inline] __mutex_lock+0x12f/0x1350 kernel/locking/mutex.c:747 _vm_unmap_aliases.part.0+0x1ca/0x560 mm/vmalloc.c:2187 _vm_unmap_aliases mm/vmalloc.c:2181 [inline] vm_unmap_aliases+0x49/0x50 mm/vmalloc.c:2230 change_page_attr_set_clr+0x226/0x470 arch/x86/mm/pat/set_memory.c:1837 cpa_set_pages_array arch/x86/mm/pat/set_memory.c:1892 [inline] _set_pages_array+0x1c6/0x220 arch/x86/mm/pat/set_memory.c:2230 drm_gem_shmem_get_pages_locked+0x155/0x240 drivers/gpu/drm/drm_gem_shmem_helper.c:191 drm_gem_shmem_get_pages+0x71/0x180 drivers/gpu/drm/drm_gem_shmem_helper.c:219 drm_gem_shmem_mmap drivers/gpu/drm/drm_gem_shmem_helper.c:636 [inline] drm_gem_shmem_mmap+0x153/0x540 drivers/gpu/drm/drm_gem_shmem_helper.c:620 drm_gem_mmap_obj+0x1b6/0x6c0 drivers/gpu/drm/drm_gem.c:1046 drm_gem_mmap+0x41d/0x780 drivers/gpu/drm/drm_gem.c:1124 call_mmap include/linux/fs.h:1859 [inline] mmap_region+0x694/0x28d0 mm/mmap.c:2652 do_mmap+0x831/0xf60 mm/mmap.c:1438 vm_mmap_pgoff+0x1a2/0x3b0 mm/util.c:543 ksys_mmap_pgoff+0x41f/0x5a0 mm/mmap.c:1484 do_syscall_x64 arch/x86/entry/common.c:50 [inline] do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 entry_SYSCALL_64_after_hwframe+0x63/0xcd RIP: 0033:0x7f905968c0f9 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f905a3fa168 EFLAGS: 00000246 ORIG_RAX: 0000000000000009 RAX: ffffffffffffffda RBX: 00007f90597abf80 RCX: 00007f905968c0f9 RDX: 0000000000000000 RSI: 0000000000003028 RDI: 0000000020ffc000 RBP: 00007f90596e7b39 R08: 0000000000000004 R09: 0000000100000000 R10: 0000000000000012 R11: 0000000000000246 R12: 0000000000000000 R13: 00007ffcde03503f R14: 00007f905a3fa300 R15: 0000000000022000 </TASK> --- This report is generated by a bot. It may contain errors. See https://goo.gl/tpsmEJ for more information about syzbot. syzbot engineers can be reached at syzkaller(a)googlegroups.com. syzbot will keep track of this issue. See: https://goo.gl/tpsmEJ#status for how to communicate with syzbot.

2 years, 2 months

2
1
0 0

[PATCH v7 0/2] drm: add kms driver for loongson display controller

by Sui Jingfeng

Loongson display controller IP has been integrated in both Loongson North Bridge chipset(ls7a1000 and ls7a2000) and Loongson SoCs(ls2k1000 and ls2k2000 etc), it even has been included in Loongson BMC products. This display controller is a PCI device, it has two display pipe. For the DC in LS7A1000 and LS2K1000 each way has a DVO output interface which provide RGB888 signals, vertical & horizontal synchronisations, and the pixel clock. Each CRTC is able to support 1920x1080@60Hz, the maximum resolution is 2048x2048 according to the hardware spec. For the DC in LS7A2000, each display pipe is equipped with a built-in HDMI encoder which is compliant with HDMI 1.4 specification, thus it support 3840x2160@30Hz. The first display pipe is also equipped with a transparent vga encoder which is parallel with the HDMI encoder. The DC in LS7A2000 is more complete, besides above feature, it has two hardware cursors, two hardware vblank counter and two scanout position recorders. v1 -> v2: 1) Use hpd status reg when polling for ls7a2000 2) Fix all warnings emerged when compile with W=1 v2 -> v3: 1) Add COMPILE_TEST in Kconfig and make the driver off by default 2) Alphabetical sorting headers (Thomas) 3) Untangle register access functions as much as possible (Thomas) 4) Switch to TTM based memory manager and prefer cached mapping for Loongson SoC (Thomas) 5) Add chip id detection method, now all models are distinguishable. 6) Revise builtin HDMI phy driver, nearly all main stream mode below 4K@30Hz is tested, this driver supported these mode very well including clone display mode and extend display mode. v3 -> v4: 1) Quickly fix a small mistake. v4 -> v5: 1) Drop potential support for Loongson 2K series SoC temporary, this part should be resend with the DT binding patch in the future. 2) Add per display pipe debugfs support to the builtin HDMI encoder. 3) Rewrite atomic_update() for hardware cursors plane(Thomas) 4) Rewrite encoder and connector initialization part, untangle it according to the chip(Thomas). v5 -> v6: 1) Remove stray code which didn't get used, say lsdc_of_get_reserved_ram 2) Fix all typos I could found, make sentences and code more readable 3) Untange lsdc_hdmi*_connector_detect() function according to the pipe 4) After a serious consideration, we rename this driver as loongson. Because we also have drivers toward the LoongGPU IP in LS7A2000 and LS2K2000. Besides, there are also drivers about the external encoder, HDMI audio driver and vbios support etc. This patch only provide DC driver part, my teammate Li Yi believe that loongson will be more suitable for loongson graphics than lsdc in the long run. loongson.ko = LSDC + LoongGPU + encoders driver + vbios/DT ... v6 -> v7: 1) Add prime support, self-sharing is works. sharing buffer with etnaviv is also tested, and its works with limitation. 2) Implement buffer objects tracking with list_head. 3) S3(sleep to RAM) is tested on ls3a5000+ls7a2000 evb and it works. 4) Rewrite lsdc_bo_move, since ttm core stop allocating resources during BO creation. Patch V1 ~ V6 of this series no longer works on Linux 6.3.0-rc2. Thus, we send V7 to revival them. 5) Remove depends on LOONGARCH || MIPS || COMPILE_TEST and other improvements to help review on x86 machine and add a cover letter to help patchwork tracking my patch. V1 ~ V4 can be found at link [1], V5 at link [2], V6 at link [3] [1] https://patchwork.freedesktop.org/series/113566/ [2] https://patchwork.freedesktop.org/series/114386/ [3] https://patchwork.freedesktop.org/patch/524532/ suijingfeng (2): MAINTAINERS: add maintainers for DRM LOONGSON driver drm: add kms driver for loongson display controller MAINTAINERS | 8 + drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/loongson/Kconfig | 15 + drivers/gpu/drm/loongson/Makefile | 16 + drivers/gpu/drm/loongson/lsdc_crtc.c | 384 ++++++++++++++++ drivers/gpu/drm/loongson/lsdc_debugfs.c | 261 +++++++++++ drivers/gpu/drm/loongson/lsdc_drv.c | 502 +++++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_drv.h | 319 ++++++++++++++ drivers/gpu/drm/loongson/lsdc_gem.c | 291 ++++++++++++ drivers/gpu/drm/loongson/lsdc_gem.h | 26 ++ drivers/gpu/drm/loongson/lsdc_i2c.c | 172 ++++++++ drivers/gpu/drm/loongson/lsdc_irq.c | 88 ++++ drivers/gpu/drm/loongson/lsdc_irq.h | 11 + drivers/gpu/drm/loongson/lsdc_output.c | 564 ++++++++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_output.h | 14 + drivers/gpu/drm/loongson/lsdc_plane.c | 409 +++++++++++++++++ drivers/gpu/drm/loongson/lsdc_pll.c | 338 ++++++++++++++ drivers/gpu/drm/loongson/lsdc_pll.h | 76 ++++ drivers/gpu/drm/loongson/lsdc_probe.c | 85 ++++ drivers/gpu/drm/loongson/lsdc_probe.h | 11 + drivers/gpu/drm/loongson/lsdc_regs.h | 370 ++++++++++++++++ drivers/gpu/drm/loongson/lsdc_ttm.c | 422 ++++++++++++++++++ drivers/gpu/drm/loongson/lsdc_ttm.h | 71 +++ 24 files changed, 4456 insertions(+) create mode 100644 drivers/gpu/drm/loongson/Kconfig create mode 100644 drivers/gpu/drm/loongson/Makefile create mode 100644 drivers/gpu/drm/loongson/lsdc_crtc.c create mode 100644 drivers/gpu/drm/loongson/lsdc_debugfs.c create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.c create mode 100644 drivers/gpu/drm/loongson/lsdc_drv.h create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.c create mode 100644 drivers/gpu/drm/loongson/lsdc_gem.h create mode 100644 drivers/gpu/drm/loongson/lsdc_i2c.c create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.c create mode 100644 drivers/gpu/drm/loongson/lsdc_irq.h create mode 100644 drivers/gpu/drm/loongson/lsdc_output.c create mode 100644 drivers/gpu/drm/loongson/lsdc_output.h create mode 100644 drivers/gpu/drm/loongson/lsdc_plane.c create mode 100644 drivers/gpu/drm/loongson/lsdc_pll.c create mode 100644 drivers/gpu/drm/loongson/lsdc_pll.h create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.c create mode 100644 drivers/gpu/drm/loongson/lsdc_probe.h create mode 100644 drivers/gpu/drm/loongson/lsdc_regs.h create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.c create mode 100644 drivers/gpu/drm/loongson/lsdc_ttm.h -- 2.25.1

2 years, 2 months

4
9
0 0

[PATCH 0/2] usb: gadget: functionfs: DMABUF import interface

by Paul Cercueil

Hi, This small patchset adds three new IOCTLs that can be used to attach, detach, or transfer from/to a DMABUF object. This was surprisingly easy to add, as the functionfs code only uses scatterlists for transfers and allows specifying the number of bytes to transfer. The bulk of the code is then for general DMABUF accounting. The patchset isn't tagged RFC but comments are very welcome, there are some things I am not 100% sure about: ffs_dma_resv_lock (with no ww_acquire_ctx), and I'm using pr_debug which feels wrong. Also, I should probably add documentation? The current IOCTLs for functionfs were not documented, as far as I can tell. We use it with DMABUFs created with udmabuf, that we attach to the functionfs interface and to IIO devices (with a DMABUF interface for IIO, on its way to upstream too), to transfer samples from high-speed transceivers to USB in a zero-copy fashion. Cheers, -Paul Paul Cercueil (2): usb: gadget: Support already-mapped DMA SGs usb: gadget: functionfs: Add DMABUF import interface drivers/usb/gadget/function/f_fs.c | 398 ++++++++++++++++++++++++++++ drivers/usb/gadget/udc/core.c | 7 +- include/linux/usb/gadget.h | 2 + include/uapi/linux/usb/functionfs.h | 14 +- 4 files changed, 419 insertions(+), 2 deletions(-) -- 2.39.2

2 years, 2 months

3
10
0 0

[PATCH 18/37] drm/amd/amdgpu/amdgpu_vce: Provide description for amdgpu_vce_validate_bo()'s 'p' param

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c:599: warning: Function parameter or member 'p' not described in 'amdgpu_vce_validate_bo' Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c index 2fb61410b1c02..c4d65ade5c00a 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vce.c @@ -585,6 +585,7 @@ static int amdgpu_vce_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle, /** * amdgpu_vce_validate_bo - make sure not to cross 4GB boundary * + * @p: parser context * @ib: indirect buffer to use * @lo: address of lower dword * @hi: address of higher dword -- 2.40.0.rc1.284.g88254d51c5-goog

2 years, 2 months

2
1
0 0

[PATCH 17/37] drm/amd/amdgpu/amdgpu_mes: Ensure amdgpu_bo_create_kernel()'s return value is checked

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c: In function ‘amdgpu_mes_ctx_alloc_meta_data’: drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c:1099:13: warning: variable ‘r’ set but not used [-Wunused-but-set-variable] Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: Jack Xiao <Jack.Xiao(a)amd.com> Cc: Hawking Zhang <Hawking.Zhang(a)amd.com> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c index 82e27bd4f0383..30cd72ca1eefd 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_mes.c @@ -1104,6 +1104,11 @@ int amdgpu_mes_ctx_alloc_meta_data(struct amdgpu_device *adev, &ctx_data->meta_data_obj, &ctx_data->meta_data_mc_addr, &ctx_data->meta_data_ptr); + if (r) { + dev_warn(adev->dev, "(%d) create CTX bo failed\n", r); + return r; + } + if (!ctx_data->meta_data_obj) return -ENOMEM; -- 2.40.0.rc1.284.g88254d51c5-goog

2 years, 2 months

2
1
0 0

[PATCH 14/37] drm/amd/amdgpu/amdgpu_vm_pt: Supply description for amdgpu_vm_pt_free_dfs()'s unlocked param

by Lee Jones

Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c:683: warning: Function parameter or member 'unlocked' not described in 'amdgpu_vm_pt_free_dfs' Cc: Alex Deucher <alexander.deucher(a)amd.com> Cc: "Christian König" <christian.koenig(a)amd.com> Cc: "Pan, Xinhui" <Xinhui.Pan(a)amd.com> Cc: David Airlie <airlied(a)gmail.com> Cc: Daniel Vetter <daniel(a)ffwll.ch> Cc: Sumit Semwal <sumit.semwal(a)linaro.org> Cc: amd-gfx(a)lists.freedesktop.org Cc: dri-devel(a)lists.freedesktop.org Cc: linux-media(a)vger.kernel.org Cc: linaro-mm-sig(a)lists.linaro.org Signed-off-by: Lee Jones <lee(a)kernel.org> --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c index 01e42bdd8e4e8..df63dc3bca18c 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm_pt.c @@ -673,6 +673,7 @@ void amdgpu_vm_pt_free_work(struct work_struct *work) * @adev: amdgpu device structure * @vm: amdgpu vm structure * @start: optional cursor where to start freeing PDs/PTs + * @unlocked: vm resv unlock status * * Free the page directory or page table level and all sub levels. */ -- 2.40.0.rc1.284.g88254d51c5-goog

2 years, 2 months

2
1
0 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

Linaro-mm-sig