From: Mark Brown broonie@linaro.org
A reference to ARCH_HAS_OPP was added in commit 333d17e56 (arm64: add ARCH_HAS_OPP to allow enabling OPP library) however this symbol has been removed from the kernel in e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) with only a few stray references remaining.
Unfortunately the commit was not present in -next at the time of the update (which was done precisely to enable arm64) so it wasn't noticed.
Signed-off-by: Mark Brown broonie@linaro.org --- arch/arm64/Kconfig | 1 - 1 file changed, 1 deletion(-)
diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 4bcd435b6fd4..129356940a60 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -1,7 +1,6 @@ config ARM64 def_bool y select ARCH_HAS_ATOMIC64_DEC_IF_POSITIVE - select ARCH_HAS_OPP select ARCH_HAS_SG_CHAIN select ARCH_HAS_TICK_BROADCAST if GENERIC_CLOCKEVENTS_BROADCAST select ARCH_USE_CMPXCHG_LOCKREF
On Mon, Jul 21, 2014 at 06:44:20PM +0100, Mark Brown wrote:
From: Mark Brown broonie@linaro.org
A reference to ARCH_HAS_OPP was added in commit 333d17e56 (arm64: add ARCH_HAS_OPP to allow enabling OPP library) however this symbol has been removed from the kernel in e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) with only a few stray references remaining.
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
On Tue, Jul 22, 2014 at 02:56:18PM +0100, Catalin Marinas wrote:
On Mon, Jul 21, 2014 at 06:44:20PM +0100, Mark Brown wrote:
A reference to ARCH_HAS_OPP was added in commit 333d17e56 (arm64: add ARCH_HAS_OPP to allow enabling OPP library) however this symbol has been removed from the kernel in e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) with only a few stray references remaining.
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
Oh, bother. Raphael said he'd applied it but he hasn't done so.
(dropping the mistyped emails)
On Tue, Jul 22, 2014 at 03:02:59PM +0100, Mark Brown wrote:
On Tue, Jul 22, 2014 at 02:56:18PM +0100, Catalin Marinas wrote:
On Mon, Jul 21, 2014 at 06:44:20PM +0100, Mark Brown wrote:
A reference to ARCH_HAS_OPP was added in commit 333d17e56 (arm64: add ARCH_HAS_OPP to allow enabling OPP library) however this symbol has been removed from the kernel in e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) with only a few stray references remaining.
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
Oh, bother. Raphael said he'd applied it but he hasn't done so.
Maybe he'll apply them for 3.17. I don't think we should send a pull request now for this.
On Tue, Jul 22, 2014 at 02:56:18PM +0100, Catalin Marinas wrote:
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
BTW, it's worth pointing out that the patch is still valid - ARCH_HAS_OPP does nothing any more and defining it has no value, it was only left in place to stop warnings from Kconfig as a transition after 049d595a4db3b3a (PM / OPP: Make OPP invisible to users in Kconfig) which is in Linus' tree.
On Tue, Jul 22, 2014 at 03:07:40PM +0100, Mark Brown wrote:
On Tue, Jul 22, 2014 at 02:56:18PM +0100, Catalin Marinas wrote:
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
BTW, it's worth pointing out that the patch is still valid - ARCH_HAS_OPP does nothing any more and defining it has no value, it was only left in place to stop warnings from Kconfig as a transition after 049d595a4db3b3a (PM / OPP: Make OPP invisible to users in Kconfig) which is in Linus' tree.
OK. I'll add it for 3.17 (and drop the commit number above as I don't know where it comes from or whether it will still be valid.
On Tue, Jul 22, 2014 at 05:29:03PM +0100, Catalin Marinas wrote:
On Tue, Jul 22, 2014 at 03:07:40PM +0100, Mark Brown wrote:
On Tue, Jul 22, 2014 at 02:56:18PM +0100, Catalin Marinas wrote:
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
BTW, it's worth pointing out that the patch is still valid - ARCH_HAS_OPP does nothing any more and defining it has no value, it was only left in place to stop warnings from Kconfig as a transition after 049d595a4db3b3a (PM / OPP: Make OPP invisible to users in Kconfig) which is in Linus' tree.
OK. I'll add it for 3.17 (and drop the commit number above as I don't know where it comes from or whether it will still be valid.
Actually, after 049d595a4db3b3a, should arm64 select PM_OPP directly?
Hi Catalin,
On 22/07/14 17:32, Catalin Marinas wrote:
On Tue, Jul 22, 2014 at 05:29:03PM +0100, Catalin Marinas wrote:
On Tue, Jul 22, 2014 at 03:07:40PM +0100, Mark Brown wrote:
On Tue, Jul 22, 2014 at 02:56:18PM +0100, Catalin Marinas wrote:
So, where this e37302045c441 (PM / OPP: Remove ARCH_HAS_OPP) commit? I can't find it in -next, nor mainline.
BTW, it's worth pointing out that the patch is still valid - ARCH_HAS_OPP does nothing any more and defining it has no value, it was only left in place to stop warnings from Kconfig as a transition after 049d595a4db3b3a (PM / OPP: Make OPP invisible to users in Kconfig) which is in Linus' tree.
OK. I'll add it for 3.17 (and drop the commit number above as I don't know where it comes from or whether it will still be valid.
Actually, after 049d595a4db3b3a, should arm64 select PM_OPP directly?
It could be selected by drivers using the OPP library instead. I don't think core arm64 will ever need to use that directly. Mostly it's used by cpufreq/devfreq drivers.
Previously PM_OPP depended on ARCH_HAS_OPP which was unnecessary and is removed in the above mentioned commit IIUC.
Regards, Sudeep
On Tue, Jul 22, 2014 at 05:41:31PM +0100, Sudeep Holla wrote:
On 22/07/14 17:32, Catalin Marinas wrote:
Actually, after 049d595a4db3b3a, should arm64 select PM_OPP directly?
It could be selected by drivers using the OPP library instead. I don't think core arm64 will ever need to use that directly. Mostly it's used by cpufreq/devfreq drivers.
Previously PM_OPP depended on ARCH_HAS_OPP which was unnecessary and is removed in the above mentioned commit IIUC.
Right, it's been converted to a normal utility library - there's no reason for it to be either user visible and there's nothing architecture specific about it either.
linaro-kernel@lists.linaro.org
-
Catalin Marinas -
Mark Brown -
Sudeep Holla