Re: [PATCH 2/3] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task

On Fri, Nov 11, 2016 at 11:16:59PM +0100, Rafael J. Wysocki wrote:

...

•   struct sched_param param = { .sched_priority = 50 };
  

I'd define a symbol for the 50. It's just one extra line of code ...

A minor point for sure, but in general what's the motivation for defining symbols for things which are only used once? It makes it harder to untangle and learn a piece of code IMO, having to jump to the definitions of them to see what they are.

thanks, Steve