11 Dec
2014
11 Dec
'14
8:52 p.m.
On Thursday, December 11, 2014 08:45:22 AM Viresh Kumar wrote:
On 11 December 2014 at 03:31, Rafael J. Wysocki rjw@rjwysocki.net wrote:
I've lost patches [1-2/5] somehow, but never mind. I can get them from Patchwork.
Strange, you were always in --to for them ..
In this one I'm wondering about the printk removal mentioned above. Did checkpatch complain about the printk?
commit ebfdc40969f24fc0cdd1349835d36e8ebae05374 Author: Joe Perches joe@perches.com Date: Wed Aug 6 16:10:27 2014 -0700
checkpatch: attempt to find unnecessary 'out of memory' messages
OK
So I've applied this, but here are the rules for the future regarding checkpatch.pl:
(1) checkpatch.pl is meant for checking changes made by a patch and *not* for checking the existing code.
(2) Always use common sense on top of checkpatch.pl complaints.
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.