Re: [PATCH] dt/flattree: Fix return value of early_init_dt_scan_memory

Hi Jeremy,

On Wed, Apr 20, 2011 at 08:47:26AM +0800, Jeremy Kerr wrote:

Hi Shawn,

...

It fixes the return value of funciont early_init_dt_scan_memory on the success return path.

[In general, the changelog should explain why you're making this change, not just re-iterate what the patch does. Does this fix a problem you were seeing?]

Thanks for the guide.

With regards to this specific patch - I don't think this is correct; if we return 1 here, we'll abort the of_scan_flat_dt loop after successfully parsing one memory node, whereas machines may have multiple nodes. This change will break booting on those machines.

I really did not think of the case that there are multiple memory nodes. Please ignore it, and sorry for the noise.