On 01/27/2015 12:36 AM, Viresh Kumar wrote:
Even if cpufreq is disabled then also the per-cpu variable will return NULL and things will continue working as is. Remove this unnecessary check.
Commit text reword suggestion:
When cpufreq is disabled, the per-cpu variable would have been set to NULL. Remove this unnecessary check.
Signed-off-by: Viresh Kumar viresh.kumar@linaro.org
drivers/cpufreq/cpufreq.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index ca69f42b8e1e..72990ba59fad 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -203,7 +203,7 @@ struct cpufreq_policy *cpufreq_cpu_get(unsigned int cpu) struct cpufreq_policy *policy = NULL; unsigned long flags;
- if (cpufreq_disabled() || (cpu >= nr_cpu_ids))
if (cpu >= nr_cpu_ids) return NULL;
if (!down_read_trylock(&cpufreq_rwsem))
@@ -230,9 +230,6 @@ EXPORT_SYMBOL_GPL(cpufreq_cpu_get);
void cpufreq_cpu_put(struct cpufreq_policy *policy) {
- if (cpufreq_disabled())
return;
- kobject_put(&policy->kobj); up_read(&cpufreq_rwsem); }
Acked-by: Saravana Kannan skannan@codeaurora.org