On Tuesday, September 09, 2014 01:52:10 AM Rafael J. Wysocki wrote:
On Tuesday, September 09, 2014 01:39:32 AM Rafael J. Wysocki wrote:
On Monday, September 08, 2014 04:18:11 PM Stephen Boyd wrote:
On 09/08/14 16:34, Rafael J. Wysocki wrote:
On Thursday, August 28, 2014 11:22:31 AM Viresh Kumar wrote:
The naming convention of this driver was always under the scanner, people complained that it should have a more generic name than cpu0, as it manages all CPUs that are sharing clock lines.
Also, in future it will be modified to support any number of clusters with separate clock/voltage lines.
Lets rename it to 'cpufreq_generic' from 'cpufreq_cpu0'.
I'm not a big fan of changes like this to be honest, because they kind of hide history. For example, if you do a "git blame" on the new file, it will show your commit and nothing before it.
Sounds like a tooling problem. But git blame doesn't have that behavior so there isn't actually any problem?
Ah, OK
It used to some time ago or maybe it depends on how you carry out the rename.
So more bikeshedding. :-)
Isn't "generic" somewhat too broad? Surely it doesn't cover x86. And does it actually cover anything without clocks/regulators?
For now, I'm going to queue up patches [1-8/10] from this series for 3.18.