12 Dec
2014
12 Dec
'14
3:34 a.m.
On 12 December 2014 at 02:22, Rafael J. Wysocki rjw@rjwysocki.net wrote:
OK
So I've applied this, but here are the rules for the future regarding checkpatch.pl:
(1) checkpatch.pl is meant for checking changes made by a patch and *not* for checking the existing code.
(2) Always use common sense on top of checkpatch.pl complaints.
Correct, normally I do ignore the warnings for cases which I don't care about. I did react to this one because there have been patches going around removing print messages on allocation failures. And I didn't wanted to get another one for this and so removed it in my patch only..
-- viresh