Re: [PATCH 07/14] cpufreq: cpu0: OPPs can be populated at runtime

On Tuesday 01 July 2014 12:32 PM, Viresh Kumar wrote:

OPPs can be populated statically, via DT, or added at run time with dev_pm_opp_add().

While this driver handles the first case correctly, it would fail to populate OPPs added at runtime. Because call to of_init_opp_table() would fail as there are no OPPs in DT and probe will return early.

To fix this, remove error checking and call dev_pm_opp_init_cpufreq_table() unconditionally.

Suggested-by: Stephen Boyd sboyd@codeaurora.org Signed-off-by: Viresh Kumar viresh.kumar@linaro.org

---

Assuming you are updating bidnings as suggested by Stephen, patch looks good to me. Acked-by: Santosh Shilimkar santosh.shilimkar@ti.com