Re: [PATCH v5 5/5] hwmon: add ST-Ericsson ABX500 hwmon driver

On Mon, Mar 25, 2013 at 04:48:48PM +0800, Hongbo Zhang wrote:

Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for all ABX500s, and the ab8500.c is specific for AB8500 chip. Under this designed structure, other chip specific files can be added simply using the same common layer abx500.c.

Signed-off-by: Hongbo Zhang hongbo.zhang@linaro.org

[ ... ]

+/* Set functions (RW nodes) */ +static ssize_t set_min(struct device *dev, struct device_attribute *devattr,

•        const char *buf, size_t count)
  

+{

• unsigned long val;
• struct abx500_temp *data = dev_get_drvdata(dev);
• struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr);
• int res = kstrtol(buf, 10, &val);
• if (res < 0)

• return res;
  

• clamp_val(val, 0, DEFAULT_MAX_TEMP);

That needs to be

val = clamp_val(val, 0, DEFAULT_MAX_TEMP);

for each clamp_val().

Guenter