On 17 July 2014 06:19, Rafael J. Wysocki rafael@kernel.org wrote:
Quite frankly, to me this patch just does too much in one go without describing about a half of things it is doing.
I would just add the kobject_move() call to __cpufreq_add_dev() to start with (because that's what you really want if I'm not mistaken) and do the cleanups separately, later.
I understand that as I had similar feelings about it. See what I sent during V1: http://www.spinics.net/lists/stable/msg54338.html
Only when Srivatsa asked me to do the cleanups with it, I went for V2. And still wasn't really sure about getting that as a bug fix. And so had a chat with him again and asked you to push V1, and we will do cleanups later.
So, I don't see V1 in patchworks anymore and I must resend? I will make out a series out of V2, first patch would be a fix for 3.16 & stable, and others would be for 3.17. Hope that works.
-- viresh