Re: [Linaro-acpi] [PATCH 1/5] ACPI: add in a bad_madt_entry() function to eventually replace the macro

On 08/12/2015 04:35 PM, Timur Tabi wrote:

On Thu, Aug 6, 2015 at 3:59 PM, Al Stone al.stone@linaro.org wrote:

...

•   while (ms->num_types != 0) {
  

•           if (ms->major_version == major &&
  

•               ms->minor_version == minor &&
  

•               ms->madt_version == madt->header.revision)
  

•                   break;
  

•           ms++;
  

•   }
  

•   if (!ms) {
  

Shouldn't this be

if (!ms->num_types) {

instead?

Argh. Yes, it should. It will always be false, otherwise. Will fix for next version. Thanks for catching that.