Re: [PATCH 2/3] tracing: Add trace_irqsoff tracepoints

On 16 August 2016 at 17:02, Daniel Wagner daniel.wagner@bmw-carit.de wrote:

Hmm, maybe this is just my bike shedding me speaking here, but I suggest you copy the style with start_critical_timing() and stop_critical_timing() and move the implementation into a small inline function. IMO this is cluttering the reading flow too much. The same is true for the following hunks.

cheers, daniel

Hi Daniel,

I think you are not.:) Doing it the better way always helps atleast by not getting rejected by the kernel community. Thanks a lot for reviewing the code.

Arnd,

Do you think I should add the perf interface too? Masami's mail server was giving me bounced email replies.

- Binoy