On Wednesday 23 April 2014 18:28:35 Peter Griffin wrote:
From: Arnd Bergmann arnd@arndb.de
The sh_mobile_lcdcfb driver calls interfaces provided by the corresponding "meram" helper. This fails if meram is a module but lcdcfb is built-in.
To work around it, this uses special Kconfig magic to only allow lcdcfb to be built if a) both are modules, b) meram is built-in, or c) meram is disabled and the helpers stubbed out
Changing meram from 'y' to 'm' now forces clcd to be a module as well, which seems to be the desired behavior.
Signed-off-by: Arnd Bergmann arnd@arndb.de Signed-off-by: Peter Griffin peter.griffin@linaro.org Cc: Simon Horman horms+renesas@verge.net.au Cc: Magnus Damm magnus.damm@gmail.com Cc: linux-sh@vger.kernel.org Cc: Jean-Christophe Plagniol-Villard plagnioj@jcrosoft.com Cc: Tomi Valkeinen tomi.valkeinen@ti.com Cc: linux-fbdev@vger.kernel.org
This was quick!
I think you got almost everything right with the series, but one important addition would be a cover letter in the sense that 'git format-patch --cover-letter' generates, filling that out with an explanation about the purpose of the patch series, what your involvement is in this, and what you expect to happen with the patches. I'll go through the patches individually and comment on anything that sticks out. I guess once you have addressed those, you can send the patches for real.
Arnd