On 03/26/2013 12:17 PM, Andrew Lunn wrote:
All above code is completly generic and I would rather create some thing like "drivers/cpuidle/generic-idle.c" where it can handle all the registration stuff for all arch's rather than just ARM. There is nothing ARM specific in above code IMHO.
Yes, it seems generic but it won't be.
It very much sounds like you are going in the wrong direction. You should be moving towards generic code, not away from generic code.
Well, I am going to the right direction but with an intermediate step :)
But indeed, I will introduce this init function in the generic code directly and rebase the patchset.
Rafael, is possible to apply the patches 1 - 5 ? Or shall I resend the subset ?
Yes, you at some point will need ARM specific code, but that should be a minor part and can be placed somewhere else, and called by a function pointer, or the generic code can be in a library and called from the ARM specific code, etc.
Andrew
linaro-kernel mailing list linaro-kernel@lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-kernel