On Wed, Sep 11, 2013 at 9:19 AM, Mark Brown broonie@kernel.org wrote:
From: Mark Brown broonie@linaro.org
Cut down on the size of core.c a bit more and ensure that the devres versions of things don't do too much peering inside the internals of the APIs they wrap.
Signed-off-by: Mark Brown broonie@linaro.org
drivers/regulator/Makefile | 2 +- drivers/regulator/core.c | 252 +------------------------------------------ drivers/regulator/devres.c | 252 +++++++++++++++++++++++++++++++++++++++++++ drivers/regulator/internal.h | 38 +++++++ 4 files changed, 292 insertions(+), 252 deletions(-) create mode 100644 drivers/regulator/devres.c create mode 100644 drivers/regulator/internal.h diff --git a/drivers/regulator/internal.h b/drivers/regulator/internal.h new file mode 100644 index 0000000..84bbda1 --- /dev/null +++ b/drivers/regulator/internal.h @@ -0,0 +1,38 @@ +/*
- internal.h -- Voltage/Current Regulator framework internal code
- Copyright 2007, 2008 Wolfson Microelectronics PLC.
- Copyright 2008 SlimLogic Ltd.
- Author: Liam Girdwood lrg@slimlogic.co.uk
- This program is free software; you can redistribute it and/or modify it
- under the terms of the GNU General Public License as published by the
- Free Software Foundation; either version 2 of the License, or (at your
- option) any later version.
- */
+#ifndef __REGULATOR_INTERNAL_H +#define __REGULATOR_INTERNAL_H
+/*
- struct regulator
- One for each consumer device.
- */
+struct regulator {
struct device *dev;struct list_head list;unsigned int always_on:1;unsigned int bypass:1;int uA_load;int min_uV;int max_uV;char *supply_name;struct device_attribute dev_attr;struct regulator_dev *rdev;struct dentry *debugfs;+};
don't you need any forward declaration here nor any include (like for list_head and device_attribute)?
-- Thiago