linaro-kernel

linaro-kernel@lists.linaro.org

10095 discussions

Re: [PATCH v3 3/3] hwmon: add ST-Ericsson ABX500 hwmon driver

by Hongbo Zhang

Guenter, Thanks for you thorough review very much, will adopt all your comments. On 27 February 2013 13:56, Guenter Roeck <linux(a)roeck-us.net> wrote: > On Thu, Feb 21, 2013 at 06:32:41PM +0800, Hongbo Zhang wrote: >> Each of ST-Ericsson X500 chip set series consists of both ABX500 and DBX500 >> chips. This is ABX500 hwmon driver, where the abx500.c is a common layer for >> all ABX500s, and the ab8500.c is specific for AB8500 chip. Under this designed >> structure, other chip specific files can be added simply using the same common >> layer abx500.c. >> >> Signed-off-by: Hongbo Zhang <hongbo.zhang(a)linaro.org> >> --- >> Documentation/hwmon/ab8500 | 22 ++ >> Documentation/hwmon/abx500 | 26 +++ >> drivers/hwmon/Kconfig | 13 ++ >> drivers/hwmon/Makefile | 1 + >> drivers/hwmon/ab8500.c | 178 ++++++++++++++++ >> drivers/hwmon/abx500.c | 501 +++++++++++++++++++++++++++++++++++++++++++++ >> drivers/hwmon/abx500.h | 87 ++++++++ >> 7 files changed, 828 insertions(+) >> create mode 100644 Documentation/hwmon/ab8500 >> create mode 100644 Documentation/hwmon/abx500 >> create mode 100644 drivers/hwmon/ab8500.c >> create mode 100644 drivers/hwmon/abx500.c >> create mode 100644 drivers/hwmon/abx500.h >> >> diff --git a/Documentation/hwmon/ab8500 b/Documentation/hwmon/ab8500 >> new file mode 100644 >> index 0000000..76c534d >> --- /dev/null >> +++ b/Documentation/hwmon/ab8500 >> @@ -0,0 +1,22 @@ >> +Kernel driver ab8500 >> +==================== >> + >> +Supported chips: >> + * ST-Ericsson AB8500 >> + Prefix: 'ab8500' >> + Addresses scanned: - >> + Datasheet: http://www.stericsson.com/developers/documentation.jsp >> + >> +Authors: >> + Martin Persson <martin.persson(a)stericsson.com> >> + Hongbo Zhang <hongbo.zhang(a)linaro.org> >> + >> +Description >> +----------- >> + >> +See also Documentation/hwmon/abx500. This is ST-Ericsson AB8500 hwmon specific >> +initialization. >> + > "This is the ST-Ericsson AB8500 specific driver" or similar might be better. > >> +Currently only the AB8500 internal sensor and one external sensor for battery >> +temperature are monitored. Other GPADC channels can also be monitored if needed >> +in future. >> diff --git a/Documentation/hwmon/abx500 b/Documentation/hwmon/abx500 >> new file mode 100644 >> index 0000000..f60b73c >> --- /dev/null >> +++ b/Documentation/hwmon/abx500 >> @@ -0,0 +1,26 @@ >> +Kernel driver abx500 >> +==================== >> + >> +Supported chips: >> + * ST-Ericsson ABx500 series >> + Prefix: 'abx500' >> + Addresses scanned: - >> + Datasheet: http://www.stericsson.com/developers/documentation.jsp >> + >> +Authors: >> + Martin Persson <martin.persson(a)stericsson.com> >> + Hongbo Zhang <hongbo.zhang(a)linaro.org> >> + >> +Description >> +----------- >> + >> +Every ST-Ericsson Ux500 SOC consists of both ABx500 and DBx500 physically, >> +this is kernel hwmon driver for ABx500. >> + >> +There are some GPADCs inside ABx500 which are designed for connecting to >> +thermal sensors, and there is also a thermal sensor inside ABx500 too, which >> +raises interrupt when critical temperature reached. >> + >> +This abx500 is a common layer which can monitor all of the sensors, every >> +specific abx500 chip has its special configurations in its own file, e.g. some >> +sensors can be configured invisible if they are not available on that chip. > > Given that limits are disabled if set to 0, you really should document that > here. > >> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig >> index 32f238f..0a6fd21 100644 >> --- a/drivers/hwmon/Kconfig >> +++ b/drivers/hwmon/Kconfig >> @@ -39,6 +39,19 @@ config HWMON_DEBUG_CHIP >> >> comment "Native drivers" >> >> +config SENSORS_AB8500 >> + tristate "AB8500 thermal monitoring" >> + depends on AB8500_GPADC >> + default n >> + help >> + If you say yes here you get support for the thermal sensor part >> + of the AB8500 chip. The driver includes thermal management for >> + AB8500 die and two GPADC channels. The GPADC channel are preferably >> + used to access sensors outside the AB8500 chip. >> + >> + This driver can also be built as a module. If so, the module >> + will be called abx500-temp. >> + >> config SENSORS_ABITUGURU >> tristate "Abit uGuru (rev 1 & 2)" >> depends on X86 && DMI >> diff --git a/drivers/hwmon/Makefile b/drivers/hwmon/Makefile >> index 5da2874..06dfe85 100644 >> --- a/drivers/hwmon/Makefile >> +++ b/drivers/hwmon/Makefile >> @@ -19,6 +19,7 @@ obj-$(CONFIG_SENSORS_W83795) += w83795.o >> obj-$(CONFIG_SENSORS_W83781D) += w83781d.o >> obj-$(CONFIG_SENSORS_W83791D) += w83791d.o >> >> +obj-$(CONFIG_SENSORS_AB8500) += abx500.o ab8500.o >> obj-$(CONFIG_SENSORS_ABITUGURU) += abituguru.o >> obj-$(CONFIG_SENSORS_ABITUGURU3)+= abituguru3.o >> obj-$(CONFIG_SENSORS_AD7314) += ad7314.o >> diff --git a/drivers/hwmon/ab8500.c b/drivers/hwmon/ab8500.c >> new file mode 100644 >> index 0000000..33221e7 >> --- /dev/null >> +++ b/drivers/hwmon/ab8500.c >> @@ -0,0 +1,178 @@ >> +/* >> + * Copyright (C) ST-Ericsson SA 2010 > > 2010 - 1013 ? > >> + * Author: Martin Persson <martin.persson(a)stericsson.com> >> + * Hongbo Zhang <hongbo.zhang(a)linaro.org> >> + * License Terms: GNU General Public License v2 >> + * >> + * If/when the AB8500 thermal warning temperature is reached (threshold cannot >> + * be changed by SW), an interrupt is set and the driver notifies user space >> + * via a sysfs event. If a shut down is not triggered by user space within a >> + * certain time frame, pm_power off is called. >> + * >> + * If/when AB8500 thermal shutdown temperature is reached a hardware shutdown >> + * of the AB8500 will occur. >> + */ >> + >> +#include <linux/err.h> >> +#include <linux/hwmon.h> >> +#include <linux/hwmon-sysfs.h> >> +#include <linux/mfd/abx500.h> >> +#include <linux/mfd/abx500/ab8500-bm.h> >> +#include <linux/mfd/abx500/ab8500-gpadc.h> >> +#include <linux/module.h> >> +#include <linux/platform_device.h> >> +#include <linux/slab.h> >> +#include <linux/sysfs.h> >> +#include "abx500.h" >> + >> +#define DEFAULT_POWER_OFF_DELAY 10000 > > I notice you define all delays in ms just to convert them to jiffies, yet the > delays are hardly ever reported to the user anywhere. I think it would make > more sense to just define the delays in HZ, use them directly, and use > msecs_to_jiffies() in the one case where a delay reported to the user. > This would have the added benefit that (HZ * 10) is easier to understand > than an unexplained 10000 when reading the code. > >> +#define NUM_MONITORED_SENSORS 4 >> +#define THERMAL_VCC 1800 >> +#define PULL_UP_RESISTOR 47000 >> + >> +/* >> + * The hardware connection is like this: >> + * VCC----[ R_up ]-----[ NTC ]----GND >> + * where R_up is pull-up resistance, and GPADC measures voltage on NTC. >> + * and res_to_temp table is strictly sorted by falling resistance values. >> + */ >> +static int voltage_to_temp(int vcc, int r_up, int v_ntc, >> + const struct abx500_res_to_temp *tbl, int tbl_sz, int *temp) >> +{ >> + int r_ntc, i = 0; >> + >> + if (vcc < 0 || v_ntc > vcc) > > Should be 'v_ntc >= vcc' to avoid the == case and resulting division by zero. > >> + return -EINVAL; >> + >> + r_ntc = v_ntc * r_up / (vcc - v_ntc); >> + if (r_ntc > tbl[0].resist || r_ntc < tbl[tbl_sz - 1].resist) >> + return -EINVAL; >> + >> + while (!(r_ntc <= tbl[i].resist && r_ntc > tbl[i + 1].resist) >> + && i < tbl_sz - 2) >> + i++; >> + >> + *temp = tbl[i].temp + ((tbl[i + 1].temp - tbl[i].temp) * >> + (r_ntc - tbl[i].resist)) / (tbl[i + 1].resist - tbl[i].resist); >> + >> + return 0; >> +} >> + >> +static int ab8500_read_sensor(struct abx500_temp *data, u8 sensor) >> +{ >> + int temp, voltage, ret; >> + >> + if (sensor == BAT_CTRL) >> + temp = ab8500_btemp_get_batctrl_temp(data->ab8500_btemp); > > That can return a valid number below zero unless I am missing something > (BTEMP_THERMAL_LOW_LIMIT is -10). Which means you can not return the error > and the return value and need to use a pointer for the return value after all. > >> + >> + else if (sensor == BTEMP_BALL) >> + temp = ab8500_btemp_get_temp(data->ab8500_btemp); > > Same here. > >> + >> + else { >> + voltage = ab8500_gpadc_convert(data->ab8500_gpadc, sensor); >> + if (voltage < 0) >> + return -EINVAL; > > return voltage; >> + >> + ret = voltage_to_temp(THERMAL_VCC, PULL_UP_RESISTOR, voltage, >> + temp_tbl_A_thermistor, temp_tbl_A_size, &temp); > > This can also return a negative temperature (the first temperature entry in > temp_tbl_A_thermistor is negative). > >> + if (ret < 0) >> + return -EINVAL; > > return ret; > >> + temp *= 1000; >> + } >> + >> + return temp; >> +} >> + >> +static void ab8500_thermal_power_off(struct work_struct *work) >> +{ >> + struct abx500_temp *data = container_of(work, struct abx500_temp, >> + power_off_work.work); >> + >> + dev_warn(&data->pdev->dev, >> + "Power off due to AB8500 thermal warning.\n"); >> + pm_power_off(); >> +} >> + >> +static ssize_t ab8500_show_name(struct device *dev, >> + struct device_attribute *devattr, >> + char *buf) >> +{ >> + return sprintf(buf, "ab8500\n"); >> +} >> + >> +static ssize_t ab8500_show_label(struct device *dev, >> + struct device_attribute *devattr, >> + char *buf) >> +{ >> + char *name; > > Nitpick: label, really. > >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + int index = attr->index; >> + >> + switch (index) { >> + case 1: >> + name = "ext_adc1"; >> + break; >> + case 2: >> + name = "ext_adc2"; >> + break; >> + case 3: >> + name = "bat_temp"; >> + break; >> + case 4: >> + name = "bat_ctrl"; >> + break; >> + default: >> + return -EINVAL; >> + } >> + return sprintf(buf, "%s\n", name); >> +} >> + >> +static int ab8500_is_visible(struct attribute *attr, int n) >> +{ >> + return attr->mode; >> +} > > Instead of providing an empty function, you should make is_visible optional > and have the calling code return attr->mode directly if it is not defined > (ie NULL). > >> + >> +static int ab8500_temp_irq_handler(int irq, struct abx500_temp *data) >> +{ >> + unsigned long delay_in_jiffies; >> + >> + dev_info(&data->pdev->dev, "AB8500 warning, power off in %lu s\n", >> + data->power_off_delay); >> + > dev_warn, and "AB8500 warning" is redundant. > >> + delay_in_jiffies = msecs_to_jiffies(data->power_off_delay); >> + schedule_delayed_work(&data->power_off_work, delay_in_jiffies); >> + return 0; >> +} >> + >> +int abx500_hwmon_init(struct abx500_temp *data) >> +{ >> + data->ab8500_gpadc = ab8500_gpadc_get("ab8500-gpadc.0"); >> + if (IS_ERR(data->ab8500_gpadc)) >> + return PTR_ERR(data->ab8500_gpadc); >> + >> + data->ab8500_btemp = ab8500_btemp_get(); >> + if (IS_ERR(data->ab8500_btemp)) >> + return PTR_ERR(data->ab8500_btemp); >> + >> + INIT_DELAYED_WORK(&data->power_off_work, ab8500_thermal_power_off); >> + >> + /* >> + * ADC_AUX1 and ADC_AUX2, connected to external NTC >> + * BTEMP_BALL and BAT_CTRL, fixed usage >> + */ >> + data->gpadc_addr[0] = ADC_AUX1; >> + data->gpadc_addr[1] = ADC_AUX2; >> + data->gpadc_addr[2] = BTEMP_BALL; >> + data->gpadc_addr[3] = BAT_CTRL; >> + >> + data->power_off_delay = DEFAULT_POWER_OFF_DELAY; >> + data->monitored_sensors = NUM_MONITORED_SENSORS; >> + >> + data->ops.read_sensor = ab8500_read_sensor; >> + data->ops.irq_handler = ab8500_temp_irq_handler; >> + data->ops.show_name = ab8500_show_name; >> + data->ops.show_label = ab8500_show_label; >> + data->ops.is_visible = ab8500_is_visible; >> + >> + return 0; >> +} >> diff --git a/drivers/hwmon/abx500.c b/drivers/hwmon/abx500.c >> new file mode 100644 >> index 0000000..69ea8cb >> --- /dev/null >> +++ b/drivers/hwmon/abx500.c >> @@ -0,0 +1,501 @@ >> +/* >> + * Copyright (C) ST-Ericsson SA 2010 > > 2010 - 1023 ? > >> + * Author: Martin Persson <martin.persson(a)stericsson.com> >> + * Hongbo Zhang <hongbo.zhang(a)linaro.org> >> + * License Terms: GNU General Public License v2 >> + * >> + * ABX500 does not provide auto ADC, so to monitor the required temperatures, >> + * a periodic work is used. It is more important to not wake up the CPU than >> + * to perform this job, hence the use of a deferred delay. >> + * >> + * A deferred delay for thermal monitor is considered safe because: >> + * If the chip gets too hot during a sleep state it's most likely due to >> + * external factors, such as the surrounding temperature. I.e. no SW decisions >> + * will make any difference. >> + * >> + * If/when the ABX500 thermal warning temperature is reached (threshold cannot >> + * be changed by SW), an interrupt is set and the driver notifies user space >> + * via a sysfs event. >> + * >> + * If/when ABX500 thermal shutdown temperature is reached a hardware shutdown >> + * of the ABX500 will occur. >> + */ >> + >> +#include <linux/err.h> >> +#include <linux/hwmon.h> >> +#include <linux/hwmon-sysfs.h> >> +#include <linux/interrupt.h> >> +#include <linux/jiffies.h> >> +#include <linux/module.h> >> +#include <linux/mutex.h> >> +#include <linux/of.h> >> +#include <linux/platform_device.h> >> +#include <linux/pm.h> >> +#include <linux/slab.h> >> +#include <linux/sysfs.h> >> +#include <linux/workqueue.h> >> +#include "abx500.h" >> + >> +#define DEFAULT_MONITOR_DELAY 1000 >> + >> +static inline void schedule_monitor(struct abx500_temp *data) >> +{ >> + unsigned long delay_in_jiffies; >> + delay_in_jiffies = msecs_to_jiffies(data->gpadc_monitor_delay); >> + data->work_active = true; >> + schedule_delayed_work(&data->work, delay_in_jiffies); >> +} >> + >> +static void threshold_updated(struct abx500_temp *data) >> +{ >> + int i; >> + for (i = 0; i < data->monitored_sensors; i++) >> + if (data->max[i] != 0 || data->min[i] != 0) { >> + schedule_monitor(data); >> + return ; > > Extra ' ' before ; > >> + } >> + >> + dev_dbg(&data->pdev->dev, "No active thresholds.\n"); >> + cancel_delayed_work_sync(&data->work); >> + data->work_active = false; >> +} >> + >> +static void gpadc_monitor(struct work_struct *work) >> +{ >> + int val, i, ret; >> + char alarm_node[30]; >> + bool updated_min_alarm = false; >> + bool updated_max_alarm = false; >> + struct abx500_temp *data = container_of(work, struct abx500_temp, >> + work.work); >> + >> + mutex_lock(&data->lock); >> + for (i = 0; i < data->monitored_sensors; i++) { >> + /* Thresholds are considered inactive if set to 0 */ >> + if (data->max[i] == 0 && data->min[i] == 0) >> + continue; >> + /* >> + * In case we are in the temporary state that one threshold >> + * has been changed, but the other hasn't yet. >> + */ >> + if (data->max[i] < data->min[i]) >> + continue; >> + >> + val = data->ops.read_sensor(data, data->gpadc_addr[i]); >> + if (val < 0) { >> + dev_err(&data->pdev->dev, "GPADC read failed\n"); >> + continue; >> + } >> + >> + if (data->min[i] != 0) { >> + if (val < data->min[i]) { >> + if (data->min_alarm[i] == false) { >> + data->min_alarm[i] = true; >> + updated_min_alarm = true; >> + } >> + } else { >> + if (data->min_alarm[i] == true) { >> + data->min_alarm[i] = false; >> + updated_min_alarm = true; >> + } >> + } >> + > Unnecessary empty line. > >> + } >> + if (data->max[i] != 0) { >> + if (val > data->max[i]) { >> + if (data->max_alarm[i] == false) { >> + data->max_alarm[i] = true; >> + updated_max_alarm = true; >> + } >> + } else if (val < data->max[i] - data->max_hyst[i]) { >> + if (data->max_alarm[i] == true) { >> + data->max_alarm[i] = false; >> + updated_max_alarm = true; >> + } >> + } >> + } >> + >> + if (updated_min_alarm) { >> + ret = sprintf(alarm_node, "temp%d_min_alarm", i); >> + sysfs_notify(&data->pdev->dev.kobj, NULL, alarm_node); >> + } >> + if (updated_max_alarm) { >> + ret = sprintf(alarm_node, "temp%d_max_alarm", i); >> + sysfs_notify(&data->pdev->dev.kobj, NULL, alarm_node); >> + } >> + >> + updated_min_alarm = false; >> + updated_max_alarm = false; >> + } >> + >> + schedule_monitor(data); >> + mutex_unlock(&data->lock); >> +} >> + >> +/* HWMON sysfs interfaces */ >> +static ssize_t show_name(struct device *dev, struct device_attribute *devattr, >> + char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + /* Show chip name */ >> + return data->ops.show_name(dev, devattr, buf); >> +} >> + >> +static ssize_t show_label(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + /* Show each sensor label */ >> + return data->ops.show_label(dev, devattr, buf); >> +} >> + >> +static ssize_t show_input(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + int val; >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + u8 gpadc_addr = data->gpadc_addr[attr->index]; >> + >> + val = data->ops.read_sensor(data, gpadc_addr); >> + if (val < 0) >> + dev_err(&data->pdev->dev, "GPADC read failed\n"); >> + >> + return sprintf(buf, "%d\n", val); >> +} >> + >> +/* Set functions (RW nodes) */ >> +static ssize_t set_min(struct device *dev, struct device_attribute *devattr, >> + const char *buf, size_t count) >> +{ >> + unsigned long val; >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + int res = kstrtoul(buf, 10, &val); >> + if (res < 0) >> + return res; >> + > > You should use kstrtol, and use clamp_val() to limit the range. We don't expect > users to know the valid limits for this chip, and furthermore the limit could be > the result of a calculation. > > Sure you want to accept arbitrary upper limits ? 1,000,000 degrees C ? > OK, learned, thanks. >> + mutex_lock(&data->lock); >> + data->min[attr->index] = val; >> + threshold_updated(data); >> + mutex_unlock(&data->lock); >> + >> + return count; >> +} >> + >> +static ssize_t set_max(struct device *dev, struct device_attribute *devattr, >> + const char *buf, size_t count) >> +{ >> + unsigned long val; >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + int res = kstrtoul(buf, 10, &val); > > Same as above. > >> + if (res < 0) >> + return res; >> + >> + mutex_lock(&data->lock); >> + data->max[attr->index] = val; >> + threshold_updated(data); >> + mutex_unlock(&data->lock); >> + >> + return count; >> +} >> + >> +static ssize_t set_max_hyst(struct device *dev, >> + struct device_attribute *devattr, >> + const char *buf, size_t count) >> +{ >> + unsigned long val; >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + int res = kstrtoul(buf, 10, &val); >> + if (res < 0) >> + return res; >> + >> + mutex_lock(&data->lock); >> + data->max_hyst[attr->index] = val; >> + threshold_updated(data); >> + mutex_unlock(&data->lock); >> + >> + return count; >> +} >> + >> +/* Show functions (RO nodes) */ >> +static ssize_t show_min(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + >> + return sprintf(buf, "%ld\n", data->min[attr->index]); >> +} >> + >> +static ssize_t show_max(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + >> + return sprintf(buf, "%ld\n", data->max[attr->index]); >> +} >> + >> +static ssize_t show_max_hyst(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + >> + return sprintf(buf, "%ld\n", data->max_hyst[attr->index]); >> +} >> + >> +static ssize_t show_min_alarm(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + >> + return sprintf(buf, "%d\n", data->min_alarm[attr->index]); >> +} >> + >> +static ssize_t show_max_alarm(struct device *dev, >> + struct device_attribute *devattr, char *buf) >> +{ >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + struct sensor_device_attribute *attr = to_sensor_dev_attr(devattr); >> + >> + return sprintf(buf, "%d\n", data->max_alarm[attr->index]); >> +} >> + >> +static mode_t abx500_attrs_visible(struct kobject *kobj, >> + struct attribute *a, int n) >> +{ >> + struct device *dev = container_of(kobj, struct device, kobj); >> + struct abx500_temp *data = dev_get_drvdata(dev); >> + >> + return data->ops.is_visible(a, n); >> +} >> + >> +/* Chip name, required by hwmon */ >> +static SENSOR_DEVICE_ATTR(name, S_IRUGO, show_name, NULL, 0); >> + >> +/* GPADC - SENSOR1 */ >> +static SENSOR_DEVICE_ATTR(temp1_label, S_IRUGO, show_label, NULL, 0); >> +static SENSOR_DEVICE_ATTR(temp1_input, S_IRUGO, show_input, NULL, 0); >> +static SENSOR_DEVICE_ATTR(temp1_min, S_IWUSR | S_IRUGO, show_min, set_min, 0); >> +static SENSOR_DEVICE_ATTR(temp1_max, S_IWUSR | S_IRUGO, show_max, set_max, 0); >> +static SENSOR_DEVICE_ATTR(temp1_max_hyst, S_IWUSR | S_IRUGO, >> + show_max_hyst, set_max_hyst, 0); >> +static SENSOR_DEVICE_ATTR(temp1_min_alarm, S_IRUGO, show_min_alarm, NULL, 0); >> +static SENSOR_DEVICE_ATTR(temp1_max_alarm, S_IRUGO, show_max_alarm, NULL, 0); >> + >> +/* GPADC - SENSOR2 */ >> +static SENSOR_DEVICE_ATTR(temp2_label, S_IRUGO, show_label, NULL, 1); >> +static SENSOR_DEVICE_ATTR(temp2_input, S_IRUGO, show_input, NULL, 1); >> +static SENSOR_DEVICE_ATTR(temp2_min, S_IWUSR | S_IRUGO, show_min, set_min, 1); >> +static SENSOR_DEVICE_ATTR(temp2_max, S_IWUSR | S_IRUGO, show_max, set_max, 1); >> +static SENSOR_DEVICE_ATTR(temp2_max_hyst, S_IWUSR | S_IRUGO, >> + show_max_hyst, set_max_hyst, 1); >> +static SENSOR_DEVICE_ATTR(temp2_min_alarm, S_IRUGO, show_min_alarm, NULL, 1); >> +static SENSOR_DEVICE_ATTR(temp2_max_alarm, S_IRUGO, show_max_alarm, NULL, 1); >> + >> +/* GPADC - SENSOR3 */ >> +static SENSOR_DEVICE_ATTR(temp3_label, S_IRUGO, show_label, NULL, 2); >> +static SENSOR_DEVICE_ATTR(temp3_input, S_IRUGO, show_input, NULL, 2); >> +static SENSOR_DEVICE_ATTR(temp3_min, S_IWUSR | S_IRUGO, show_min, set_min, 2); >> +static SENSOR_DEVICE_ATTR(temp3_max, S_IWUSR | S_IRUGO, show_max, set_max, 2); >> +static SENSOR_DEVICE_ATTR(temp3_max_hyst, S_IWUSR | S_IRUGO, >> + show_max_hyst, set_max_hyst, 2); >> +static SENSOR_DEVICE_ATTR(temp3_min_alarm, S_IRUGO, show_min_alarm, NULL, 2); >> +static SENSOR_DEVICE_ATTR(temp3_max_alarm, S_IRUGO, show_max_alarm, NULL, 2); >> + >> +/* GPADC - SENSOR4 */ >> +static SENSOR_DEVICE_ATTR(temp4_label, S_IRUGO, show_label, NULL, 3); >> +static SENSOR_DEVICE_ATTR(temp4_input, S_IRUGO, show_input, NULL, 3); >> +static SENSOR_DEVICE_ATTR(temp4_min, S_IWUSR | S_IRUGO, show_min, set_min, 3); >> +static SENSOR_DEVICE_ATTR(temp4_max, S_IWUSR | S_IRUGO, show_max, set_max, 3); >> +static SENSOR_DEVICE_ATTR(temp4_max_hyst, S_IWUSR | S_IRUGO, >> + show_max_hyst, set_max_hyst, 3); >> +static SENSOR_DEVICE_ATTR(temp4_min_alarm, S_IRUGO, show_min_alarm, NULL, 3); >> +static SENSOR_DEVICE_ATTR(temp4_max_alarm, S_IRUGO, show_max_alarm, NULL, 3); >> + >> +struct attribute *abx500_temp_attributes[] = { >> + &sensor_dev_attr_name.dev_attr.attr, >> + >> + &sensor_dev_attr_temp1_label.dev_attr.attr, >> + &sensor_dev_attr_temp1_input.dev_attr.attr, >> + &sensor_dev_attr_temp1_min.dev_attr.attr, >> + &sensor_dev_attr_temp1_max.dev_attr.attr, >> + &sensor_dev_attr_temp1_max_hyst.dev_attr.attr, >> + &sensor_dev_attr_temp1_min_alarm.dev_attr.attr, >> + &sensor_dev_attr_temp1_max_alarm.dev_attr.attr, >> + >> + &sensor_dev_attr_temp2_label.dev_attr.attr, >> + &sensor_dev_attr_temp2_input.dev_attr.attr, >> + &sensor_dev_attr_temp2_min.dev_attr.attr, >> + &sensor_dev_attr_temp2_max.dev_attr.attr, >> + &sensor_dev_attr_temp2_max_hyst.dev_attr.attr, >> + &sensor_dev_attr_temp2_min_alarm.dev_attr.attr, >> + &sensor_dev_attr_temp2_max_alarm.dev_attr.attr, >> + >> + &sensor_dev_attr_temp3_label.dev_attr.attr, >> + &sensor_dev_attr_temp3_input.dev_attr.attr, >> + &sensor_dev_attr_temp3_min.dev_attr.attr, >> + &sensor_dev_attr_temp3_max.dev_attr.attr, >> + &sensor_dev_attr_temp3_max_hyst.dev_attr.attr, >> + &sensor_dev_attr_temp3_min_alarm.dev_attr.attr, >> + &sensor_dev_attr_temp3_max_alarm.dev_attr.attr, >> + >> + &sensor_dev_attr_temp4_label.dev_attr.attr, >> + &sensor_dev_attr_temp4_input.dev_attr.attr, >> + &sensor_dev_attr_temp4_min.dev_attr.attr, >> + &sensor_dev_attr_temp4_max.dev_attr.attr, >> + &sensor_dev_attr_temp4_max_hyst.dev_attr.attr, >> + &sensor_dev_attr_temp4_min_alarm.dev_attr.attr, >> + &sensor_dev_attr_temp4_max_alarm.dev_attr.attr, >> + NULL >> +}; >> + >> +static const struct attribute_group abx500_temp_group = { >> + .attrs = abx500_temp_attributes, >> + .is_visible = abx500_attrs_visible, >> +}; >> + >> +static irqreturn_t abx500_temp_irq_handler(int irq, void *irq_data) >> +{ >> + struct platform_device *pdev = irq_data; >> + struct abx500_temp *data = platform_get_drvdata(pdev); >> + >> + data->ops.irq_handler(irq, data); >> + return IRQ_HANDLED; >> +} >> + >> +static int setup_irqs(struct platform_device *pdev) >> +{ >> + int ret; >> + int irq = platform_get_irq_byname(pdev, "ABX500_TEMP_WARM"); >> + >> + if (irq < 0) { >> + dev_err(&pdev->dev, "Get irq by name failed\n"); >> + return irq; >> + } >> + >> + ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, >> + abx500_temp_irq_handler, IRQF_NO_SUSPEND, "abx500-temp", pdev); >> + if (ret < 0) >> + dev_err(&pdev->dev, "Request threaded irq failed (%d)\n", ret); >> + >> + return ret; >> +} >> + >> +static int abx500_temp_probe(struct platform_device *pdev) >> +{ >> + struct abx500_temp *data; >> + int err; >> + >> + data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL); >> + if (!data) >> + return -ENOMEM; >> + >> + data->pdev = pdev; >> + mutex_init(&data->lock); >> + >> + /* Chip specific initialization */ >> + err = abx500_hwmon_init(data); >> + if (err < 0 || !data->ops.read_sensor || !data->ops.show_name >> + || !data->ops.show_label || !data->ops.is_visible) { > > Nitpick: Second line should be aligned with '('. > >> + dev_err(&pdev->dev, "ABx500 hwmon init failed"); >> + return -EINVAL; >> + } >> + >> + INIT_DEFERRABLE_WORK(&data->work, gpadc_monitor); >> + data->gpadc_monitor_delay = DEFAULT_MONITOR_DELAY; > > Any benefit of having this as variable in the first place ? Why not just use the > define ? > > Nitpick: Extra space after '='. > >> + platform_set_drvdata(pdev, data); >> + >> + err = sysfs_create_group(&pdev->dev.kobj, &abx500_temp_group); >> + if (err < 0) { >> + dev_err(&pdev->dev, "Create sysfs group failed (%d)\n", err); >> + return err; >> + } >> + >> + data->hwmon_dev = hwmon_device_register(&pdev->dev); >> + if (IS_ERR(data->hwmon_dev)) { >> + err = PTR_ERR(data->hwmon_dev); >> + dev_err(&pdev->dev, "Class registration failed (%d)\n", err); >> + goto exit_sysfs_group; >> + } >> + >> + if (data->ops.irq_handler) { >> + err = setup_irqs(pdev); >> + if (err < 0) { >> + dev_err(&pdev->dev, "irq setup failed (%d)\n", err); >> + goto exit_hwmon_reg; >> + } >> + } >> + return 0; >> + >> +exit_hwmon_reg: >> + hwmon_device_unregister(data->hwmon_dev); >> +exit_sysfs_group: >> + sysfs_remove_group(&pdev->dev.kobj, &abx500_temp_group); >> + return err; >> +} >> + >> +static int abx500_temp_remove(struct platform_device *pdev) >> +{ >> + struct abx500_temp *data = platform_get_drvdata(pdev); >> + >> + mutex_lock(&data->lock); >> + hwmon_device_unregister(data->hwmon_dev); >> + sysfs_remove_group(&pdev->dev.kobj, &abx500_temp_group); >> + cancel_delayed_work_sync(&data->work); > > Should come first. > >> + mutex_unlock(&data->lock); > > This mutex protection is definitely not needed. > >> + >> + return 0; >> +} >> + >> +static int abx500_temp_suspend(struct platform_device *pdev, >> + pm_message_t state) >> +{ >> + struct abx500_temp *data = platform_get_drvdata(pdev); >> + >> + mutex_lock(&data->lock); >> + if (data->work_active) >> + cancel_delayed_work_sync(&data->work); >> + mutex_unlock(&data->lock); > > I don't think this mutex protection is needed. Looking into other drivers, they > commonly cancel work outside mutex protection. > > What happens if poweroff due to overheating is pending ? > >> + >> + return 0; >> +} >> + >> +static int abx500_temp_resume(struct platform_device *pdev) >> +{ >> + struct abx500_temp *data = platform_get_drvdata(pdev); >> + >> + if (data->work_active) >> + schedule_monitor(data); >> + return 0; >> +} >> + >> +#ifdef CONFIG_OF >> +static const struct of_device_id abx500_temp_match[] = { >> + { .compatible = "stericsson,abx500-temp" }, >> + {}, >> +}; >> +#endif >> + >> +static struct platform_driver abx500_temp_driver = { >> + .driver = { >> + .owner = THIS_MODULE, >> + .name = "abx500-temp", >> + .of_match_table = of_match_ptr(abx500_temp_match), >> + }, >> + .suspend = abx500_temp_suspend, >> + .resume = abx500_temp_resume, >> + .probe = abx500_temp_probe, >> + .remove = abx500_temp_remove, >> +}; >> + >> +module_platform_driver(abx500_temp_driver); >> + >> +MODULE_AUTHOR("Martin Persson <martin.persson(a)stericsson.com>"); >> +MODULE_DESCRIPTION("ABX500 temperature driver"); >> +MODULE_LICENSE("GPL"); >> diff --git a/drivers/hwmon/abx500.h b/drivers/hwmon/abx500.h >> new file mode 100644 >> index 0000000..c1dd41d >> --- /dev/null >> +++ b/drivers/hwmon/abx500.h >> @@ -0,0 +1,87 @@ >> +/* >> + * Copyright (C) ST-Ericsson SA 2010 > > 2010 - 2013 ? > >> + * License terms: GNU General Public License v2 >> + * Author: Martin Persson <martin.persson(a)stericsson.com> >> + */ >> + >> +#ifndef _ABX500_H >> +#define _ABX500_H >> + >> +#define NUM_SENSORS 5 >> + >> +struct ab8500_gpadc; >> +struct ab8500_btemp; >> +struct abx500_temp; >> + >> +extern struct abx500_res_to_temp temp_tbl_A_thermistor[]; >> +extern int temp_tbl_A_size; > > Those variables should be defined in the defining code in an exporting > include file, which this driver should include. Also, the name should be less > generic and refer to the introducing module (abx500_temp_tbl_a_thermistor, > maybe). > > Also, CamelCase variable names are discouraged nowadays and create a checkpatch > warning. Please take that into account when selecting a different name. > Talked to the owner of that part, we will move the data to proper place, and rename the variables. >> + >> +/* >> + * struct abx500_temp_ops - abx500 chip specific ops >> + * @read_sensor: reads gpadc output >> + * @irq_handler: irq handler >> + * @show_name: hwmon device name >> + * @show_label: hwmon attribute label >> + * @is_visible: is attribute visible >> + */ >> +struct abx500_temp_ops { >> + int (*read_sensor)(struct abx500_temp *, u8); >> + int (*irq_handler)(int, struct abx500_temp *); >> + ssize_t (*show_name)(struct device *, >> + struct device_attribute *, char *); >> + ssize_t (*show_label) (struct device *, >> + struct device_attribute *, char *); >> + int (*is_visible)(struct attribute *, int); >> +}; >> + >> +/* >> + * struct abx500_temp - representation of temp mon device >> + * @pdev: platform device >> + * @hwmon_dev: hwmon device >> + * @ab8500_gpadc: gpadc interface for ab8500 >> + * @btemp: battery temperature interface for ab8500 >> + * @gpadc_addr: gpadc channel address >> + * @min: sensor temperature min value >> + * @max: sensor temperature max value >> + * @max_hyst: sensor temperature hysteresis value for max limit >> + * @crit: sensor temperature critical value >> + * @min_alarm: sensor temperature min alarm >> + * @max_alarm: sensor temperature max alarm >> + * @crit_alarm: sensor temperature critical value alarm >> + * @work: delayed work scheduled to monitor temperature periodically >> + * @work_active: True if work is active >> + * @power_off_work: delayed work scheduled to power off the system >> + * when critical temperature is reached >> + * @lock: mutex >> + * @gpadc_monitor_delay: delay between temperature readings in ms >> + * @power_off_delay: delay before power off in ms >> + * @monitored_sensors: number of monitored sensors >> + */ >> +struct abx500_temp { >> + struct platform_device *pdev; >> + struct device *hwmon_dev; >> + struct ab8500_gpadc *ab8500_gpadc; >> + struct ab8500_btemp *ab8500_btemp; >> + struct abx500_temp_ops ops; >> + u8 gpadc_addr[NUM_SENSORS]; >> + unsigned long min[NUM_SENSORS]; >> + unsigned long max[NUM_SENSORS]; >> + unsigned long max_hyst[NUM_SENSORS]; >> + unsigned long crit[NUM_SENSORS]; > > Not used anywhere. > >> + bool min_alarm[NUM_SENSORS]; >> + bool max_alarm[NUM_SENSORS]; >> + bool crit_alarm[NUM_SENSORS]; > > Not used anywhere. > >> + struct delayed_work work; >> + bool work_active; >> + struct delayed_work power_off_work; >> + struct mutex lock; >> + /* Delay (ms) between temperature readings */ >> + unsigned long gpadc_monitor_delay; >> + /* Delay (ms) before power off */ >> + unsigned long power_off_delay; >> + int monitored_sensors; > > Many of those variables are only used in the abx500 code. You should have two > structures, one defined inside the abx500 code for variables only used there, > and one exported to other drivers. The exported structure could be embedded in > the private one. > > Similar, you should have a private data structure in the ab8500 driver, for > variables only used there. > Yes, will consider this. (historic reason is that these two files was one file before, and then separated into two) >> +}; >> + >> +int abx500_hwmon_init(struct abx500_temp *data); >> + >> +#endif /* _ABX500_H */ >> -- >> 1.8.0 >> >>

12 years, 6 months

[PATCH v6 0/5] Add DRM FIMD DT support for Exynos4 DT Machines

by Vikas Sajjan

This patch series adds support for DRM FIMD DT for Exynos4 DT Machines, specifically for Exynos4412 SoC. changes since v5: - renamed the fimd binding documentation file name as "samsung.fimd.txt", since it not only talks about exynos display controller but also about previous samsung display controllers. - rephrased an abmigious statement about the interrupt combiner in the fimd binding documentation as pointed out by Sachin Kamat <sachin.kamat.linaro.org> changes since v4: - moved the fimd binding documentation to Documentation/devicetree/bindings/video/ as suggested by Sylwester Nawrocki <sylvester.nawrocki(a)gmail.com> - added more fimd compatiblity strings in fimd documentation as discussed at https://patchwork.kernel.org/patch/2144861/ with Sylwester Nawrocki <sylvester.nawrocki(a)gmail.com> and Tomasz Figa <tomasz.figa(a)gmail.com> - modified compatible string for exynos4 fimd as "exynos4210-fimd" exynos5 fimd as "exynos5250-fimd" to stick to the rule that compatible value should be named after first specific SoC model in which this particular IP version was included as discussed at https://patchwork.kernel.org/patch/2144861/ - documented more about the interrupt combiner and their order as suggested by Sylwester Nawrocki <sylvester.nawrocki(a)gmail.com> changes since v3: - rebased on http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=shortlo… changes since v2: - added alias to 'fimd@11c00000' node (reported by: Rahul Sharma <r.sh.open(a)gmail.com>) - removed 'lcd0_data' node as there was already a similar node lcd_data24 (reported by: Jingoo Han <jg1.han(a)samsung.com> - replaced spaces with tabs in display-timing node changes since v1: - added new patch to add FIMD DT binding Documentation - removed patch enabling SAMSUNG_DEV_BACKLIGHT and SAMSUNG_DEV_PMW for mach-exynos4 DT - added 'status' property to fimd DT node Is based on branch "for-next-next" http://git.kernel.org/?p=linux/kernel/git/kgene/linux-samsung.git;a=shortlo… Sachin Kamat (1): ARM: dts: Add lcd pinctrl node entries for EXYNOS4412 SoC Vikas Sajjan (4): ARM: dts: Add FIMD node to exynos4 ARM: dts: Add FIMD node and display timing node to exynos4412-origen.dts ARM: dts: add FIMD AUXDATA node entry for exynos4 DT ARM: dts: Add FIMD DT binding Documentation .../devicetree/bindings/video/samsung-fimd.txt | 54 ++++++++++++++++++++ arch/arm/boot/dts/exynos4.dtsi | 7 +++ arch/arm/boot/dts/exynos4412-origen.dts | 22 ++++++++ arch/arm/boot/dts/exynos4x12-pinctrl.dtsi | 14 +++++ arch/arm/mach-exynos/mach-exynos4-dt.c | 2 + 5 files changed, 99 insertions(+) create mode 100644 Documentation/devicetree/bindings/video/samsung-fimd.txt -- 1.7.9.5

12 years, 6 months

RE: [PATCH 0/4] time: dynamic irq affinity

by Shakti Swain

My first post in to the mailing list. Deep power idle state is nothing but CPU power domain off. Its not impossible but would require some hw change. If kernel is aware of a CPU being in power off state, can we first do a CPU wakeup before issuing SGI. The wakeup routine has to be implemented by SoC provider as it will be different for each vendor. Regds Shakti Sent from my Nokia Lumia 920 ________________________________ From: Santosh Shilimkar<mailto:santosh.shilimkar@ti.com> Sent: ‎2/‎26/‎2013 10:00 PM To: Daniel Lezcano<mailto:daniel.lezcano@linaro.org> Cc: jacob.jun.pan(a)linux.intel.com<mailto:jacob.jun.pan@linux.intel.com>; Russell King - ARM Linux<mailto:linux@arm.linux.org.uk>; linus.walleij(a)stericsson.com<mailto:linus.walleij@stericsson.com>; linux-pm(a)vger.kernel.org<mailto:linux-pm@vger.kernel.org>; viresh.kumar(a)linaro.org<mailto:viresh.kumar@linaro.org>; patches(a)linaro.org<mailto:patches@linaro.org>; linux-kernel(a)vger.kernel.org<mailto:linux-kernel@vger.kernel.org>; linaro-kernel(a)lists.linaro.org<mailto:linaro-kernel@lists.linaro.org>; linux-arm-kernel(a)lists.infradead.org<mailto:linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 0/4] time: dynamic irq affinity On Wednesday 27 February 2013 03:47 AM, Daniel Lezcano wrote: > When a cpu goes to a deep idle state where its local timer is shutdown, > it notifies the time framework to use the broadcast timer instead. > > Unfortunately, the broadcast device could wake up any CPU, including an > idle one which is not concerned by the wake up at all. > > This implies, in the worst case, an idle CPU will wake up to send an IPI > to another idle cpu. > > This patch solves this by setting the irq affinity to the cpu concerned > by the nearest timer event, by this way, the CPU which is wake up is > guarantee to be the one concerned by the next event and we are safe with > unnecessary wakeup for another idle CPU. > > As the irq affinity is not supported by all the archs, a flag is needed > to specify which clocksource can handle it. > Not completely related to this series but there is another issue where this local timer not wakeup capable hurts. So far we are discussing only the timer related future events which are known and can be programmed with broadcast device. But think of the scenario's where we need to send asynchronous IPIs to CPUs to do some work. e.g generic_exec_single(). If the CPU which is suppose to be available after IPI call is in deep low power state, then the IPI(implemented on ARM) isn't effective. In CPU off idle modes, a GIC SGI will not wake the CPU and hence a special wakeup is needed to bring out those CPUs out of idle. This special wakeup is handled by broad-cast timer in case of CPUIDLE. In short what I mean is, you need to have IPI which can wakeup CPUs from any deep idle power state to address above. Has anybody thought of this one ? Regards, Santosh P.S: Time and again it proves that making the local timer wakeup capable solves the issue. _______________________________________________ linaro-kernel mailing list linaro-kernel(a)lists.linaro.org http://lists.linaro.org/mailman/listinfo/linaro-kernel

12 years, 6 months

Obtaining an vmocre (linaro guest core).

by phi debian

Hi All, I am new on this mailing list, I browsed archive against vmcore but got no hit so the question here. I am running ./Foundation_v8pkg/Foundation_v8 \ --image ./img-foundation.axf \ --block-device ./vexpress64-openembedded_sdk-armv8_20130127-242.img \ --network=nat That gives Linux genericarmv8 3.8.0-1-linaro-vexpress64 #1ubuntu1~ci+130127041142 SMP Sun Jan 27 04:15:58 UTC 2013 aarch64 GNU/Linux root@genericarmv8:/usr# I am doing some linux crashdump analysis tools, and I'd like to prepare the future. At the moment I am not sure how to obtain an aa64 linux crashdump (vmcore), as I got no HW then no distro. I was wondering, is it possible to send a signal to the Foundation_v8 and then got a copy of the guest emulated main memory ? along with a savestate per cpu ? And to make this usable, is there a way to obtain the vmlinux (and possibly modules) a.out non stripped with debuginfos that was used to obtain the img.axf (abd the modules in the .img if any) If this is not doable with file on the server used during the build of ./img-foundation.axf and ./vexpress64-openembedded_sdk-armv8_20130127-242.img then may be I got to expliclty build my own .axf .img and keep the debuginfo from this build. Any advises appreciated. Thank you for the linaro that booted straightaway. Cheers, Phi

12 years, 6 months

Re: 13.01 Versatile Express Android build unstable

by D D

Hi Tixy, Yes, I have tried both the config in the release notes as well as configurations to boot A7. The configurations to boot A7 hang while executing the BOOTSCRIPT. The release note configurations get past that state, boot up the kernel and hang as shown in this thread. As a first step, I am just trying to get the release note configuration working without the hang. Thanks Dinesh On Tue, Feb 26, 2013 at 9:43 AM, Jon Medhurst (Tixy) <tixy(a)linaro.org>wrote: > On Tue, 2013-02-26 at 09:24 -0800, D D wrote: > > Thanks Tixy, I tried 0x0032F003, but still seeing the same hang. > > Looks like 0x0032F003 powers down the non boot cluster (in this case > > A7), while I wanted to try running with the A7s online. That was the > > reason why I was trying to boot with 0x00320003. > > So you have other config changes to get the board booting on A7? I've > never tried to do that. > > Does the config produced by our release notes work for you? (Which will > boot on the A15's.) > > I'm trying to understand if we're debugging a problem with the Linaro > release, or debugging whatever modified setup you have. > > -- > Tixy > > >

12 years, 6 months

arm_big_little: More CPUIdle states?

by Eric Huang

Lorenzo, Looking in the cpuidle code in Linaro's 13.01 kernel, there are only two idle states supported in the cpuidle/arm_big_little.c, one is WFI, the other is C1. So to have more than these 2 idle states supported on a SoC, it looks like I have to create SoC specific CPU idle driver to replace the arm_big_little.c. Is this the intended design? It would be better if there is a way the arm_big_little.c can support SoC specific idle sets, via device tree maybe? Eric Huang

12 years, 6 months

13.01 Versatile Express Android build unstable

by D D

Hi, 13.01 Versatile Express kernel hangs on TC2 during bootup. I am not seeing much help with build 13.02 either. Anyone seeing the same issue, please let me know. Thanks Dinesh Cmd> Powering up system... Daughterboard fitted to site 1. Switching on ATXPSU... ATX3V3: ON VIOset: 1.8V MBtemp: 35 degC Configuring motherboard (rev D, var A)... IOFPGA config: PASSED MUXFPGA config: PASSED OSC CLK config: PASSED Testing SMC devices (FPGA build 16)... SRAM 32MB test: PASSED VRAM 8MB test: PASSED LAN9118 test: PASSED USB & OTG test: PASSED KMI1/KMI2 test: PASSED MMC & SD test: PASSED DVI image test: PASSED AACI AC97 test: PASSED CF card test: PASSED UART port test: PASSED MAC addrs test: PASSED Reading Site 1 Board File \SITE1\HBI0249A\board.txt DB1 JTAG configuration complete. Setting DB1 OSCCLKS... DB1.0 DCC 0 SPI configuration complete. Writing SCC 0x40610007 with 0xFF00FF00 Writing SCC 0x40610046 with 0x01CD1011 Writing SCC 0x406101C0 with 0x00320003 Writing SCC 0x40610048 with 0x022F1010 Writing SCC 0x40610049 with 0x0011710D Writing SCC 0x4061004A with 0x022F1010 Writing SCC 0x4061004B with 0x0011710D Writing SCC 0x4061004C with 0x022F1010 Writing SCC 0x4061004D with 0x0011710D Writing SCC 0x4061004E with 0x022F1010 Writing SCC 0x4061004F with 0x0011710D Writing SCC 0x40610300 with 0x00000005 Writing SCC 0x40610301 with 0x060E0356 Writing SCC 0x40610302 with 0x00000000 Writing SCC 0x40610303 with 0x00000000 Writing SCC 0x40610304 with 0x384061A8 Writing SCC 0x40610305 with 0x38407530 Writing SCC 0x40610306 with 0x384088B8 Writing SCC 0x40610307 with 0x38409C40 Writing SCC 0x40610308 with 0x3840AFC8 Writing SCC 0x40610309 with 0x3840C350 Writing SCC 0x4061030A with 0x3CF0D6D8 Writing SCC 0x4061030B with 0x41A0EA60 Writing SCC 0x4061030C with 0x3840445C Writing SCC 0x4061030D with 0x38404E20 Writing SCC 0x4061030E with 0x384061A8 Writing SCC 0x4061030F with 0x38407530 Writing SCC 0x40610310 with 0x384088B8 Writing SCC 0x40610311 with 0x38409C40 Writing SCC 0x40610312 with 0x3CF0AFC8 Writing SCC 0x40610313 with 0x41A0C350 DB1.0 DCC 0 SCC configuration complete. DB SMB clock enabled. Waiting for SITE1 CB_READY... Testing SMB clock... Configuring MUXFPGA for MB. Setting DVI mode for VGA. Releasing Daughterboard resets. Switching MCC log to UART1. ARM Versatile Express Boot Monitor Version: V5.1.9 Build Date: Dec 3 2012 Daughterboard Site 1: V2P-CA15_A7 Cortex A15 Daughterboard Site 2: Not Used Running boot script from flash - BOOTSCRIPT UEFI firmware (version built at 12:16:16 on Jan 25 2013) add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Info: 2GB Test Chip 2 detected. add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading DxeCore at 0x00BFAB6000 EntryPoint=0x00BFAB6241 add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0HOBLIST address in DXE = 0xBF8C8010 Memory Allocation 0x00000004 0xBFFEB000 - 0xBFFEBFFF Memory Allocation 0x00000004 0xBFFE3000 - 0xBFFEAFFF Memory Allocation 0x00000004 0xBFFE2000 - 0xBFFE2FFF Memory Allocation 0x00000004 0xBFFE1000 - 0xBFFE1FFF Memory Allocation 0x00000004 0xBFFE0000 - 0xBFFE0FFF Memory Allocation 0x00000004 0xBFFDF000 - 0xBFFDFFFF Memory Allocation 0x00000004 0xBFFEC000 - 0xC0003FFF Memory Allocation 0x00000004 0xBFFCF000 - 0xBFFDEFFF Memory Allocation 0x00000004 0xBFD57000 - 0xBFFCEFFF Memory Allocation 0x00000004 0xBFADF000 - 0xBFD56FFF Memory Allocation 0x00000004 0xBFAB6000 - 0xBFADEFFF Memory Allocation 0x00000003 0xBFAB6000 - 0xBFADEFFF FV Hob 0x81000000 - 0x810AFFFF FV Hob 0xBFADF000 - 0xBFD55A3F FV2 Hob 0xBFADF000 - 0xBFD55A3F add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA5C000 EntryPoint=0x000BFA5C26D ArmCpuDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA74000 EntryPoint=0x000BFA7426D RuntimeDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA50000 EntryPoint=0x000BFA5026D SecurityStubDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA43000 EntryPoint=0x000BFA4326D FaultTolerantWriteDxe.eadd-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BAAA2000 EntryPoint=0x000BAAA226D Reset.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BAA95000 EntryPoint=0x000BAA9526D RealTimeClock.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA26000 EntryPoint=0x000BFA2626D HiiDatabase.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA1C000 EntryPoint=0x000BFA1C26D SerialDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BFA10000 EntryPoint=0x000BFA1026D SP805WatchdogDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9FF000 EntryPoint=0x000BF9FF26D AcpiTableDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9EF000 EntryPoint=0x000BF9EF26D DevicePathDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9E1000 EntryPoint=0x000BF9E126D ArmVeNorFlashDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BAA82000 EntryPoint=0x000BAA8226D VariableRuntimeDxe.efi Variable driver failed to add EFI_MEMORY_RUNTIME attribute to Flash. add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9D6000 EntryPoint=0x000BF9D626D MetronomeDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9CA000 EntryPoint=0x000BF9CA26D PL390GicDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9BB000 EntryPoint=0x000BF9BB26D HdLcdGraphicsDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF9AA000 EntryPoint=0x000BF9AA26D MmcDxe.efi add-symbol-file /mnt/ci_build/workspace/uefi/uefi/Build/ArmVExpress-CTA15-A7/DE0Loading driver at 0x000BF99E000 EntryPoint=0x000BF99E26D PL180MciDxe.efi Card is SD2.0 => Supports high capacity High capacity card. The default boot selection will start in 1 seconds PEI 492 ms DXE 9975 ms BDS 12778 ms Total Time = 23246 ms Starting the kernel: [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Linux version 3.8.0-rc4-00183-g134b797 (jenkins-build@ip-10-10-13[ 0.000000] Kernel was built at commit id '' (Lin [ 0.000000] CPU: ARMv7 Processor [412fc0f1] revision 1 (ARMv7), cr=50c5387d [ 0.000000] CPU: PIPT / VIPT nonaliasing data cache, VIPT aliasing instruction cache [ 0.000000] Machine: ARM-Versatile Express, model: V2P-CA15_CA7 [ 0.000000] Truncating memory at 0x80000000 to fit in 32-bit physical address space [ 0.000000] Memory policy: ECC disabled, Data cache writealloc [ 0.000000] Zone ranges: [ 0.000000] Normal [mem 0x80000000-0xaf7fffff] [ 0.000000] HighMem [mem 0xaf800000-0xffffefff] [ 0.000000] Movable zone start for each node [ 0.000000] Early memory node ranges [ 0.000000] node 0: [mem 0x80000000-0xffffefff] [ 0.000000] PERCPU: Embedded 9 pages/cpu @c1bbc000 s14336 r8192 d14336 u36864 [ 0.000000] PID hash table entries: 4096 (order: 2, 16384 bytes)n. Total pag[ 0.000000] Dentry cache hash table entries: 131072 (order: 7, 524288 bytes) [ 0.000000] Inode-cache hash table entries: 65536 (order: 6, 262144 bytes)=/d[ 0.000000] __ex_table already sorted, skipping sort [ 0.000000] Memory: 2032MB = 2032MB total [ 0.000000] Memory: 2051160k/2051160k available, 29608k reserved, 1302528K highmem [ 0.000000] Virtual kernel memory layout: [ 0.000000] vector : 0xffff0000 - 0xffff1000 ( 4 kB) [ 0.000000] fixmap : 0xfff00000 - 0xfffe0000 ( 896 kB) [ 0.000000] vmalloc : 0xf0000000 - 0xff000000 ( 240 MB) [ 0.000000] lowmem : 0xc0000000 - 0xef800000 ( 760 MB) [ 0.000000] pkmap : 0xbfe00000 - 0xc0000000 ( 2 MB) [ 0.000000] modules : 0xbf800000 - 0xbfe00000 ( 6 MB) [ 0.000000] .text : 0xc0008000 - 0xc05b252c (5802 kB) [ 0.000000] .data : 0xc05f2000 - 0xc063ccf0 ( 300 kB) [ 0.000000] .bss : 0xc063ccf0 - 0xc0b950e0 (5473 kB) [ 0.000000] Hierarchical RCU implementation. [ 0.000000] RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=5. [ 0.000000] NR_IRQS:16 nr_irqs:16 16 [ 0.000000] Using SP804 '/smb/motherboard/iofpga@3,00000000/timer@110000' as [ 0.000000] Architected local timer running at 24.00MHz (virt). [ 0.000000] Switching to timer-based delay loop [ 0.000000] sched_clock: 32 bits at 24MHz, resolution 41ns, wraps every 17895[ 0.000000] Console: colour dummy device 80x30 [ 0.000000] console [tty0] enabled [ 0.000000] Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo[ 0.000000] ... MAX_LOCKDEP_SUBCLASSES: 8 [ 0.000000] ... MAX_LOCK_DEPTH: 48 [ 0.000000] ... MAX_LOCKDEP_KEYS: 8191 [ 0.000000] ... CLASSHASH_SIZE: 4096 [ 0.000000] ... MAX_LOCKDEP_ENTRIES: 16384 [ 0.000000] ... MAX_LOCKDEP_CHAINS: 32768 [ 0.000000] ... CHAINHASH_SIZE: 16384 [ 0.000000] memory used by lock dependency info: 3695 kB [ 0.000000] per task-struct memory footprint: 1152 bytes [ 0.003236] Calibrating delay loop (skipped), value calculated using timer fr[ 0.003289] pid_max: default: 32768 minimum: 301 [ 0.003776] Mount-cache hash table entries: 512 [ 0.014055] CPU: Testing write buffer coherency: ok [ 0.014161] ftrace: allocating 19832 entries in 39 pages [ 0.039247] CPU0: update cpu_power 1441 [ 0.039271] CPU0: thread -1, cpu 0, socket 0, mpidr 80000000 [ 0.039325] Setting up static identity map for 0x803d9688 - 0x803d96d4 [ 0.042226] vexpress_spc loaded at f0008000 [ 0.042247] TC2 power management initialized [ 1.040319] CPU1: failed to come online [ 2.041345] CPU2: failed to come online [ 3.042400] CPU3: failed to come online [ 4.043450] CPU4: failed to come online [ 4.043684] Brought up 1 CPUs [ 4.043701] SMP: Total of 1 processors activated (48.00 BogoMIPS). [ 4.054586] sched: registering cpufreq notifiers for scale-invariant loads [ 4.058640] regulator-dummy: no parameters [ 4.060168] NET: Registered protocol family 16 [ 4.060460] DMA: preallocated 256 KiB pool for atomic coherent allocations [ 4.064390] hw perfevents: enabled with CCI PMU driver, 5 counters available [ 4.064538] CCI loaded at f0060000 [ 4.088926] hw-breakpoint: found 5 (+1 reserved) breakpoint and 4 watchpoint [ 4.088955] hw-breakpoint: maximum watchpoint size is 8 bytes. [ 4.088980] Serial: AMBA PL011 UART driver [ 4.089432] 1c090000.uart: ttyAMA0 at MMIO 0x1c090000 (irq = 37) is a PL011 r[ 5.430079] console [ttyAMA0] enabled [ 5.441952] 1c0a0000.uart: ttyAMA1 at MMIO 0x1c0a0000 (irq = 38) is a PL011 r[ 5.465048] 1c0b0000.uart: ttyAMA2 at MMIO 0x1c0b0000 (irq = 39) is a PL011 r[ 5.487744] 1c0c0000.uart: ttyAMA3 at MMIO 0x1c0c0000 (irq = 40) is a PL011 r[ 5.547539] bio: create slab <bio-0> at 0 [ 5.560951] 3V3: 3300 mV [ 5.570555] SCSI subsystem initialized [ 5.583825] usbcore: registered new interface driver usbfs [ 5.600553] usbcore: registered new interface driver hub [ 5.616884] usbcore: registered new device driver usb [ 5.633769] Advanced Linux Sound Architecture Driver Initialized. [ 5.654438] Switching to clocksource arch_sys_counter [ 5.744636] NET: Registered protocol family 2 [ 5.758733] TCP established hash table entries: 8192 (order: 4, 65536 bytes) [ 5.780155] TCP bind hash table entries: 8192 (order: 6, 294912 bytes) [ 5.802052] TCP: Hash tables configured (established 8192 bind 8192) [ 5.821238] TCP: reno registered [ 5.830930] UDP hash table entries: 512 (order: 3, 40960 bytes) [ 5.848993] UDP-Lite hash table entries: 512 (order: 3, 40960 bytes) [ 5.868771] NET: Registered protocol family 1 [ 5.882478] RPC: Registered named UNIX socket transport module. [ 5.900236] RPC: Registered udp transport module. [ 5.914338] RPC: Registered tcp transport module. [ 5.928441] RPC: Registered tcp NFSv4.1 backchannel transport module. [ 5.948251] Trying to unpack rootfs image as initramfs... [ 5.977969] Freeing initrd memory: 216K [ 5.989794] hw perfevents: enabled with ARMv7_Cortex_A15 PMU driver, 7 counte[ 6.014395] hw perfevents: enabled with ARMv7_Cortex_A7 PMU driver, 7 counter[ 6.044892] bounce pool size: 64 pages [ 6.056509] VFS: Disk quotas dquot_6.5.2 [ 6.068394] Dquot-cache hash table entries: 1024 (order 0, 4096 bytes) [ 6.090805] NFS: Registering the id_resolver key type [ 6.106159] Key type id_resolver registered [ 6.118706] Key type id_legacy registered [ 6.130794] jffs2: version 2.2. (NAND) (SUMMARY) ?? 2001-2006 Red Hat, Inc. [ 6.152278] fuse init (API version 7.20) [ 6.165002] Btrfs loaded [ 6.172615] msgmni has been set to 1462 [ 6.186181] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 2[ 6.208399] io scheduler noop registered [ 6.220160] io scheduler deadline registered [ 6.233005] io scheduler cfq registered (default) [ 6.257649] hdlcd 2b000000.hdlcd: HDLCD: found ARM HDLCD version r0p0 [ 6.276976] hdlcd 2b000000.hdlcd: using 1024x768-16@60 mode [ 6.312590] Console: switching to colour frame buffer device 128x48 [ 6.409815] A15 Vcore: 800 <--> 1050 mV at 896 mV [ 6.439818] A7 Vcore: 800 <--> 1050 mV at 900 mV [ 6.469810] VIO: at 1780 mV [ 6.642067] brd: module loaded [ 6.659909] loop: module loaded [ 6.671444] mtdoops: mtd device (mtddev=name/number) must be supplied [ 6.692034] mmci-pl18x 1c050000.mmci: mmc0: PL180 manf 41 rev0 at 0x1c050000 [ 6.754190] smsc911x: Driver version 2008-10-21 [ 6.768250] smsc911x 1a000000.ethernet (unregistered net_device): couldn't ge[ 6.795437] libphy: smsc911x-mdio: probed [ 6.807649] smsc911x 1a000000.ethernet eth0: attached PHY driver [Generic PHY[ 6.842068] smsc911x 1a000000.ethernet eth0: MAC Address: 00:02:f7:00:3b:7a [ 6.864237] nxp-isp1760 1b000000.usb: NXP ISP1760 USB Host Controller [ 6.884936] nxp-isp1760 1b000000.usb: new USB bus registered, assigned bus nu[ 7.109107] nxp-isp1760 1b000000.usb: bus width: 32, oc: digital [ 7.148306] nxp-isp1760 1b000000.usb: irq 48, io mem 0x1b000000 [ 7.167322] nxp-isp1760 1b000000.usb: USB ISP 1761 HW rev. 1 started [ 7.190699] Initializing USB Mass Storage driver... [ 7.206808] usbcore: registered new interface driver usb-storage [ 7.225997] USB Mass Storage support registered. [ 7.243260] mousedev: PS/2 mouse device common for all mice [ 7.263760] rtc-pl031 1c170000.rtc: rtc core: registered pl031 as rtc0 [ 7.289063] device-mapper: ioctl: 4.23.1-ioctl (2012-12-18) initialised: dm-d[ 7.316347] arm_big_little: CPU 0 initialized [ 7.333009] arm_big_little: bL_cpufreq_register: Registered platform driver: [ 7.358424] cpuidle: using governor ladder [ 7.371768] cpuidle: using governor menu [ 7.387848] usbcore: registered new interface driver usbhid [ 7.405548] usbhid: USB HID core driver [ 7.419100] ashmem: initialized [ 7.429948] logger: created 256K log 'log_main' [ 7.444855] logger: created 256K log 'log_events' [ 7.460242] logger: created 256K log 'log_radio' [ 7.475295] nxp-isp1760 1b000000.usb: port 1 high speed [ 7.492132] logger: created 256K log 'log_system' [ 7.515908] mmc0: new SDHC card at address d72a [ 7.538679] mmcblk0: mmc0:d72a SD08G 7.40 GiB [ 7.553791] aaci-pl041 1c040000.aaci: ARM AC'97 Interface PL041 rev0 at 0x1c0[ 7.579549] aaci-pl041 1c040000.aaci: FIFO 512 entries [ 7.598744] oprofile: using timer interrupt. [ 7.612909] TCP: cubic registered [ 7.623837] Initializing XFRM netlink socket [ 7.637832] NET: Registered protocol family 10 [ 7.653470] NET: Registered protocol family 17 [ 7.667749] NET: Registered protocol family 15 [ 7.682113] Key type dns_resolver registered [ 7.695875] VFP support v0.3: implementor 41 architecture 4 part 30 variant f[ 7.719851] Registering SWP/SWPB emulation handler [ 7.735337] nxp-isp1760 1b000000.usb: port 1 high speed [ 7.753161] rtc-pl031 1c170000.rtc: setting system clock to 2013-02-14 03:47:[ 7.780583] CPUidle for CPU0 registered [ 7.793338] ALSA device list: [ 7.803297] #0: ARM AC'97 Interface PL041 rev0 at 0x1c040000, irq 43 [ 7.824873] Freeing init memory: 244K [ 7.841441] mmcblk0: p1 p2 p3 p4 < p5 p6 > [ 7.860577] init (1): /proc/1/oom_adj is deprecated, please use /proc/1/oom_s[ 8.260264] atkbd serio0: keyboard reset failed on 1c060000.kmi [ 8.561474] input: CHICONY HP Basic USB Keyboard as /devices/smb.23/motherbo0[ 8.612606] hid-generic 0003:03F0:0024.0001: input: USB HID v1.10 Keyboard [0 ********************************************* Hangs here ***************************************************************

12 years, 6 months

[RFC] cpufreq: governor: Set MIN_LATENCY_MULTIPLIER to 20

by Viresh Kumar

Currently MIN_LATENCY_MULTIPLIER is set defined as 100 and so on a system with transition latency of 1 ms, the minimum sampling time comes to be around 100 ms. That is quite big if you want to get better performance for your system. Redefine MIN_LATENCY_MULTIPLIER to 20 so that we can support 20ms sampling rate for such platforms. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- Hi Guys, I really don't know how this figure (100) came initially, but we really need to have 20ms support for my platform: ARM TC2. Pushed here: http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/h… drivers/cpufreq/cpufreq_governor.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h index d2ac911..adb8e30 100644 --- a/drivers/cpufreq/cpufreq_governor.h +++ b/drivers/cpufreq/cpufreq_governor.h @@ -34,7 +34,7 @@ */ #define MIN_SAMPLING_RATE_RATIO (2) #define LATENCY_MULTIPLIER (1000) -#define MIN_LATENCY_MULTIPLIER (100) +#define MIN_LATENCY_MULTIPLIER (20) #define TRANSITION_LATENCY_LIMIT (10 * 1000 * 1000) /* Ondemand Sampling types */ -- 1.7.12.rc2.18.g61b472e

12 years, 6 months

[PATCH 1/2] time : pass broadcast device parameter

by Daniel Lezcano

The broadcast timer could be passed as parameter to the function instead of using again tick_broadcast_device.evtdev which was previously used in the caller function. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- kernel/time/tick-broadcast.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c index f113755..baf9b0e7 100644 --- a/kernel/time/tick-broadcast.c +++ b/kernel/time/tick-broadcast.c @@ -370,10 +370,9 @@ struct cpumask *tick_get_broadcast_oneshot_mask(void) return to_cpumask(tick_broadcast_oneshot_mask); } -static int tick_broadcast_set_event(ktime_t expires, int force) +static int tick_broadcast_set_event(struct clock_event_device *bc, + ktime_t expires, int force) { - struct clock_event_device *bc = tick_broadcast_device.evtdev; - if (bc->mode != CLOCK_EVT_MODE_ONESHOT) clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT); @@ -443,7 +442,7 @@ again: * Rearm the broadcast device. If event expired, * repeat the above */ - if (tick_broadcast_set_event(next_event, 0)) + if (tick_broadcast_set_event(dev, next_event, 0)) goto again; } raw_spin_unlock(&tick_broadcast_lock); @@ -486,7 +485,7 @@ void tick_broadcast_oneshot_control(unsigned long reason) cpumask_set_cpu(cpu, tick_get_broadcast_oneshot_mask()); clockevents_set_mode(dev, CLOCK_EVT_MODE_SHUTDOWN); if (dev->next_event.tv64 < bc->next_event.tv64) - tick_broadcast_set_event(dev->next_event, 1); + tick_broadcast_set_event(bc, dev->next_event, 1); } } else { if (cpumask_test_cpu(cpu, tick_get_broadcast_oneshot_mask())) { @@ -555,7 +554,7 @@ void tick_broadcast_setup_oneshot(struct clock_event_device *bc) clockevents_set_mode(bc, CLOCK_EVT_MODE_ONESHOT); tick_broadcast_init_next_event(to_cpumask(tmpmask), tick_next_period); - tick_broadcast_set_event(tick_next_period, 1); + tick_broadcast_set_event(bc, tick_next_period, 1); } else bc->next_event.tv64 = KTIME_MAX; } else { -- 1.7.9.5

12 years, 6 months

[PATCH] clocksource : nomadik-mtu : fix missing irq initialization

by Daniel Lezcano

This patch fix the clock device irq field which is not initialized. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- drivers/clocksource/nomadik-mtu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/clocksource/nomadik-mtu.c b/drivers/clocksource/nomadik-mtu.c index 8914c3c..7cbcaa0 100644 --- a/drivers/clocksource/nomadik-mtu.c +++ b/drivers/clocksource/nomadik-mtu.c @@ -226,5 +226,6 @@ void __init nmdk_timer_init(void __iomem *base, int irq) /* Timer 1 is used for events, register irq and clockevents */ setup_irq(irq, &nmdk_timer_irq); nmdk_clkevt.cpumask = cpumask_of(0); + nmdk_clkevt.irq = irq; clockevents_config_and_register(&nmdk_clkevt, rate, 2, 0xffffffffU); } -- 1.7.9.5

12 years, 6 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel