linaro-kernel

linaro-kernel@lists.linaro.org

10095 discussions

[PATCH] ACPICA / hwreg: Use acpi_gbl_reduced_hardware to prevent accessing PM registers

by Hanjun Guo

On hardware reduced platforms, there is no support for the following: - PM Event and Control registers - SCI interrupt (and handler) - Fixed Events - General Purpose Events (GPEs) - Global Lock - ACPI PM timer - FACS table (Waking vectors and Global Lock) acpi_gbl_reduced_hardware is a global flag and can be used to prevent misbehavior on hardware reduced platforms, and this flag is initialized at the very beginning of the system boot when FADT is parsed, this flag is set to 1 when the FACP Hardware Reduced flag is set, so we can use it to prevent accessing registers which do not exist on reduced hardware platform. but when FACP Hardware Reduced flag is set, ACPI drivers will still access some registers directly which do not exist on reduced hardware platform and cause boot failure: [ 9.024370] Unable to handle kernel paging request at virtual address ffffffbffbe00001 [ 9.024423] pgd = ffffffc00007d000 [ 9.024468] [ffffffbffbe00001] *pgd=000000008007f003, *pmd=0000000000000000 [ 9.024538] Internal error: Oops: 96000006 [#1] SMP [ 9.024577] Modules linked in: [ 9.024627] CPU: 0 Not tainted (3.9.0+ #3) [ 9.024691] PC is at acpi_os_read_port+0x58/0xc8 [ 9.024753] LR is at acpi_hw_read_port+0x4c/0xc4 [ 9.024810] pc : [<ffffffc0002810cc>] lr : [<ffffffc0002a4fc4>] pstate: 600003c5 .... [ 9.031956] Call trace: [ 9.032021] [<ffffffc0002810cc>] acpi_os_read_port+0x58/0xc8 [ 9.032094] [<ffffffc0002a4fc4>] acpi_hw_read_port+0x4c/0xc4 [ 9.032165] [<ffffffc0002a4198>] acpi_hw_read+0x6c/0x100 [ 9.032237] [<ffffffc0002a4250>] acpi_hw_read_multiple+0x24/0x70 [ 9.032312] [<ffffffc0002a457c>] acpi_hw_register_read+0xa8/0x164 [ 9.032386] [<ffffffc0002a52dc>] acpi_write_bit_register+0x9c/0x194 [ 9.032472] [<ffffffc0002bffb4>] acpi_processor_get_power_info+0x6c4/0x748 [ 9.032550] [<ffffffc000565220>] acpi_processor_power_init+0xac/0x138 [ 9.032630] [<ffffffc0003f3c00>] acpi_processor_start+0x48/0x138 [ 9.032704] [<ffffffc000565118>] acpi_processor_add+0x43c/0x498 [ 9.032784] [<ffffffc000283a74>] acpi_device_probe+0x3c/0x198 [ 9.032862] [<ffffffc0002ef0fc>] driver_probe_device+0x90/0x348 [ 9.032940] [<ffffffc0002ef450>] __driver_attach+0x9c/0xa0 [ 9.033015] [<ffffffc0002ed40c>] bus_for_each_dev+0x4c/0x8c [ 9.033090] [<ffffffc0002eeb98>] driver_attach+0x20/0x28 [ 9.033166] [<ffffffc0002ee6e0>] bus_add_driver+0xfc/0x254 [ 9.033244] [<ffffffc0002ef8b0>] driver_register+0x6c/0x184 [ 9.033325] [<ffffffc000284894>] acpi_bus_register_driver+0x34/0x44 [ 9.033400] [<ffffffc000559c60>] acpi_processor_init+0x28/0x40 [ 9.033469] [<ffffffc000081438>] do_one_initcall+0x100/0x138 [ 9.033544] [<ffffffc0005448c8>] kernel_init_freeable+0x128/0x1cc [ 9.033620] [<ffffffc0003f2f90>] kernel_init+0x10/0xcc [ 9.033700] Code: d2bf7c02 f2dff7e2 f2ffffe2 8b020000 (79400000) [ 9.033843] ---[ end trace 64376967e6bc20a9 ]--- [ 9.033995] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b So acpi_gbl_reduced_hardware should be used to check if reduced hardware or not, if it is reduced hardware, just return with some error and do not access the no-existent registers. Signed-off-by: Hanjun Guo <hanjun.guo(a)linaro.org> --- drivers/acpi/acpica/hwregs.c | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/drivers/acpi/acpica/hwregs.c b/drivers/acpi/acpica/hwregs.c index 8d2e866..4c270c3 100644 --- a/drivers/acpi/acpica/hwregs.c +++ b/drivers/acpi/acpica/hwregs.c @@ -265,6 +265,11 @@ acpi_status acpi_hw_clear_acpi_status(void) ACPI_FUNCTION_TRACE(hw_clear_acpi_status); + /* If Hardware Reduced flag is set, there are no GPEs */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + ACPI_DEBUG_PRINT((ACPI_DB_IO, "About to write %04X to %8.8X%8.8X\n", ACPI_BITMASK_ALL_FIXED_STATUS, ACPI_FORMAT_UINT64(acpi_gbl_xpm1a_status.address))); @@ -305,6 +310,10 @@ struct acpi_bit_register_info *acpi_hw_get_bit_register_info(u32 register_id) { ACPI_FUNCTION_ENTRY(); + if (acpi_gbl_reduced_hardware) { + return (NULL); + } + if (register_id > ACPI_BITREG_MAX) { ACPI_ERROR((AE_INFO, "Invalid BitRegister ID: 0x%X", register_id)); @@ -337,6 +346,11 @@ acpi_status acpi_hw_write_pm1_control(u32 pm1a_control, u32 pm1b_control) ACPI_FUNCTION_TRACE(hw_write_pm1_control); + /* If Hardware Reduced flag is set, there are no PM Control registers */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + status = acpi_hw_write(pm1a_control, &acpi_gbl_FADT.xpm1a_control_block); if (ACPI_FAILURE(status)) { @@ -370,6 +384,11 @@ acpi_status acpi_hw_register_read(u32 register_id, u32 *return_value) ACPI_FUNCTION_TRACE(hw_register_read); + /* If Hardware Reduced flag is set, there are no PM Control registers */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + switch (register_id) { case ACPI_REGISTER_PM1_STATUS: /* PM1 A/B: 16-bit access each */ @@ -465,6 +484,11 @@ acpi_status acpi_hw_register_write(u32 register_id, u32 value) ACPI_FUNCTION_TRACE(hw_register_write); + /* If Hardware Reduced flag is set, there are no PM Control registers */ + if (acpi_gbl_reduced_hardware) { + return_ACPI_STATUS(AE_NOT_IMPLEMENTED); + } + switch (register_id) { case ACPI_REGISTER_PM1_STATUS: /* PM1 A/B: 16-bit access each */ /* -- 1.7.9.5

12 years, 1 month

make initrd failed

by Alex Shi

I installed the ubuntu on my pandabard es. and update kernel is fine. But I try to remake the initrd to include new modules. the kernel booting failed with the following complain: [ 2.768005] Power Management for TI OMAP4. [ 2.890472] pinctrl-single 4a31e040.pinmux: mux offset out of range: 0x38 (0x38) [ 2.898651] pinctrl-single 4a31e040.pinmux: could not add functions for pinmux_wl12xx_pins 56x [ 3.616088] RAMDISK: incomplete write (17747 != 32768) [ 3.616088] write error [ 3.624877] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [ 3.633789] CPU1: stopping [ 3.633789] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.12.0-rc2 #8 I even just remake the same initrd without anything change. the new initrd still cross the same problem. So Where I am wrong to remake this initrd? 1, cd initrd; zcat ../initrd.img-3.2.0-1412-omap4 | cpio -i -d -H newc --no-absolute-filenames 2, find . | cpio -o -H newc | gzip &> ../new-initrd 3, copy the new-initrd to pandaboard es system, and reflash it to uInitrd by 'flash-kernel' google said maybe some memory broken. but clearly it is not in case. Any hints are appreciated! -- Thanks Alex

12 years, 1 month

linus/master boot: 24 pass, 1 fail (v3.12-rc1-392-g9d23108)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: linus/master Git describe: v3.12-rc1-392-g9d23108 Commit: 9d23108df3 Merge tag 'staging-3.12-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging Failed boot tests (console logs at the end) =========================================== omap4-panda: FAIL: arm-omap2plus_defconfig Full Report =========== arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.3 sec imx6q-wandboard PASS: 0 min 15.1 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 27.6 sec omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.3 sec omap3-tobi,3530overo PASS: 0 min 42.4 sec omap4-panda FAIL: 2 min 23.9 sec omap4-panda-es PASS: 1 min 12.2 sec omap3-tobi,3730storm PASS: 0 min 41.4 sec omap3-beagle PASS: 0 min 49.8 sec arm-multi_v7_defconfig ---------------------- am335x-boneblack PASS: 0 min 32.0 sec omap3-beagle-xm PASS: 0 min 51.8 sec omap4-panda-es PASS: 1 min 9.6 sec omap4-panda PASS: 1 min 1.8 sec sun4i-a10-cubieboard PASS: 0 min 14.6 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.4 sec omap3-tobi,3530overo PASS: 0 min 40.9 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 40.3 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.5 sec omap3-beagle PASS: 0 min 54.5 sec arm-exynos_defconfig -------------------- exynos5250-arndale PASS: 0 min 33.1 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.3 sec Console logs for failures ========================= arm-omap2plus_defconfig ----------------------- omap4-panda: FAIL: last 24 lines of boot log: --------------------------------------------- [ 20.682098] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00000b00 [ 20.682098] [ 20.684082] CPU0: stopping [ 20.684082] CPU: 0 PID: 910 Comm: udevadm Not tainted 3.12.0-rc1-00392-g9d23108 #1 [ 20.684082] [<c001bc28>] (unwind_backtrace+0x0/0xf0) from [<c0017e50>] (show_stack+0x10/0x14) [ 20.684082] [<c0017e50>] (show_stack+0x10/0x14) from [<c05076d8>] (dump_stack+0x78/0x94) [ 20.720550] [<c05076d8>] (dump_stack+0x78/0x94) from [<c00198f0>] (handle_IPI+0x10c/0x134) [ 20.720550] [<c00198f0>] (handle_IPI+0x10c/0x134) from [<c00085d4>] (gic_handle_irq+0x54/0x5c) [ 20.720550] [<c00085d4>] (gic_handle_irq+0x54/0x5c) from [<c050db64>] (__irq_svc+0x44/0x5c) [ 20.720550] Exception stack(0xedfa5e18 to 0xedfa5e60) [ 20.752624] 5e00: 00000001 0000000b [ 20.752624] 5e20: c0d68ec8 ed96c180 00000000 c08213d0 00000000 00000000 00000000 c0170e7c [ 20.769927] 5e40: 00000000 edfa4000 600f0113 edfa5e60 c009cb80 c009d7d4 800f0113 ffffffff [ 20.769927] [<c050db64>] (__irq_svc+0x44/0x5c) from [<c009d7d4>] (lock_acquire+0xac/0x104) [ 20.778594] [<c009d7d4>] (lock_acquire+0xac/0x104) from [<c050a7a8>] (mutex_lock_nested+0x38/0x380) [ 20.778594] [<c050a7a8>] (mutex_lock_nested+0x38/0x380) from [<c0170e7c>] (sysfs_getattr+0x20/0x4c) [ 20.806488] [<c0170e7c>] (sysfs_getattr+0x20/0x4c) from [<c0114b9c>] (vfs_getattr+0x40/0x60) [ 20.815429] [<c0114b9c>] (vfs_getattr+0x40/0x60) from [<c0114c18>] (vfs_fstatat+0x5c/0x94) [ 20.815429] [<c0114c18>] (vfs_fstatat+0x5c/0x94) from [<c0114e7c>] (SyS_stat64+0x14/0x30) [ 20.815429] [<c0114e7c>] (SyS_stat64+0x14/0x30) from [<c0013e40>] (ret_fast_syscall+0x0/0x48) ~$off # PYBOOT: Exception: userspace: ERROR: Never found root shell # PYBOOT: Time: 143.95 seconds. # PYBOOT: Result: FAIL

12 years, 1 month

[PATCH 1/3] ASoC: max98095: Remove custom hw_write() implementation

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> The registers that are being kept uncached are marked as volatile anyway so the call has no practical impact. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/codecs/max98095.c | 25 ++++--------------------- 1 file changed, 4 insertions(+), 21 deletions(-) diff --git a/sound/soc/codecs/max98095.c b/sound/soc/codecs/max98095.c index 8dbcacd..29c266b 100644 --- a/sound/soc/codecs/max98095.c +++ b/sound/soc/codecs/max98095.c @@ -612,23 +612,6 @@ static int max98095_volatile(struct snd_soc_codec *codec, unsigned int reg) } /* - * Filter coefficients are in a separate register segment - * and they share the address space of the normal registers. - * The coefficient registers do not need or share the cache. - */ -static int max98095_hw_write(struct snd_soc_codec *codec, unsigned int reg, - unsigned int value) -{ - int ret; - - codec->cache_bypass = 1; - ret = snd_soc_write(codec, reg, value); - codec->cache_bypass = 0; - - return ret ? -EIO : 0; -} - -/* * Load equalizer DSP coefficient configurations registers */ static void m98095_eq_band(struct snd_soc_codec *codec, unsigned int dai, @@ -648,8 +631,8 @@ static void m98095_eq_band(struct snd_soc_codec *codec, unsigned int dai, /* Step through the registers and coefs */ for (i = 0; i < M98095_COEFS_PER_BAND; i++) { - max98095_hw_write(codec, eq_reg++, M98095_BYTE1(coefs[i])); - max98095_hw_write(codec, eq_reg++, M98095_BYTE0(coefs[i])); + snd_soc_write(codec, eq_reg++, M98095_BYTE1(coefs[i])); + snd_soc_write(codec, eq_reg++, M98095_BYTE0(coefs[i])); } } @@ -673,8 +656,8 @@ static void m98095_biquad_band(struct snd_soc_codec *codec, unsigned int dai, /* Step through the registers and coefs */ for (i = 0; i < M98095_COEFS_PER_BAND; i++) { - max98095_hw_write(codec, bq_reg++, M98095_BYTE1(coefs[i])); - max98095_hw_write(codec, bq_reg++, M98095_BYTE0(coefs[i])); + snd_soc_write(codec, bq_reg++, M98095_BYTE1(coefs[i])); + snd_soc_write(codec, bq_reg++, M98095_BYTE0(coefs[i])); } } -- 1.8.4.rc3

12 years, 1 month

[RESEND RFC V2] ARM: mm: make UACCESS_WITH_MEMCPY huge page aware

by Steve Capper

Resending, as I ommitted a few important CC's. --- The memory pinning code in uaccess_with_memcpy.c does not check for HugeTLB or THP pmds, and will enter an infinite loop should a __copy_to_user or __clear_user occur against a huge page. This patch adds detection code for huge pages to pin_page_for_write. As this code can be executed in a fast path it refers to the actual pmds rather than the vma. If a HugeTLB or THP is found (they have the same pmd representation on ARM), the page table spinlock is taken to prevent modification whilst the page is pinned. On ARM, huge pages are only represented as pmds, thus no huge pud checks are performed. (For huge puds one would lock the page table in a similar manner as in the pmd case). Two helper functions are introduced; pmd_thp_or_huge will check whether or not a page is huge or transparent huge (which have the same pmd layout on ARM), and pmd_hugewillfault will detect whether or not a page fault will occur on write to the page. Changes since first RFC: * The page mask is widened for hugepages to reduce the number of potential locks/unlocks. (A knobbled /dev/zero with its latency reduction chunks removed shows a 2x data rate boost with hugepages backing: dd if=/dev/zero of=/dev/null bs=10M count=1024 ) Signed-off-by: Steve Capper <steve.capper(a)linaro.org> --- arch/arm/include/asm/pgtable-3level.h | 3 ++ arch/arm/lib/uaccess_with_memcpy.c | 57 ++++++++++++++++++++++++++++++----- 2 files changed, 52 insertions(+), 8 deletions(-) diff --git a/arch/arm/include/asm/pgtable-3level.h b/arch/arm/include/asm/pgtable-3level.h index 5689c18..39c54cf 100644 --- a/arch/arm/include/asm/pgtable-3level.h +++ b/arch/arm/include/asm/pgtable-3level.h @@ -206,6 +206,9 @@ static inline pmd_t *pmd_offset(pud_t *pud, unsigned long addr) #define __HAVE_ARCH_PMD_WRITE #define pmd_write(pmd) (!(pmd_val(pmd) & PMD_SECT_RDONLY)) +#define pmd_hugewillfault(pmd) (!pmd_young(pmd) || !pmd_write(pmd)) +#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd)) + #ifdef CONFIG_TRANSPARENT_HUGEPAGE #define pmd_trans_huge(pmd) (pmd_val(pmd) && !(pmd_val(pmd) & PMD_TABLE_BIT)) #define pmd_trans_splitting(pmd) (pmd_val(pmd) & PMD_SECT_SPLITTING) diff --git a/arch/arm/lib/uaccess_with_memcpy.c b/arch/arm/lib/uaccess_with_memcpy.c index 025f742..78756db 100644 --- a/arch/arm/lib/uaccess_with_memcpy.c +++ b/arch/arm/lib/uaccess_with_memcpy.c @@ -18,11 +18,13 @@ #include <linux/hardirq.h> /* for in_atomic() */ #include <linux/gfp.h> #include <linux/highmem.h> +#include <linux/hugetlb.h> #include <asm/current.h> #include <asm/page.h> static int -pin_page_for_write(const void __user *_addr, pte_t **ptep, spinlock_t **ptlp) +pin_page_for_write(const void __user *_addr, pte_t **ptep, spinlock_t **ptlp, + unsigned long *page_mask) { unsigned long addr = (unsigned long)_addr; pgd_t *pgd; @@ -40,7 +42,36 @@ pin_page_for_write(const void __user *_addr, pte_t **ptep, spinlock_t **ptlp) return 0; pmd = pmd_offset(pud, addr); - if (unlikely(pmd_none(*pmd) || pmd_bad(*pmd))) + if (unlikely(pmd_none(*pmd))) + return 0; + + /* + * A pmd can be bad if it refers to a HugeTLB or THP page. + * + * Both THP and HugeTLB pages have the same pmd layout + * and should not be manipulated by the pte functions. + * + * Lock the page table for the destination and check + * to see that it's still huge and whether or not we will + * need to fault on write, or if we have a splitting THP. + */ + if (unlikely(pmd_thp_or_huge(*pmd))) { + ptl = &current->mm->page_table_lock; + spin_lock(ptl); + if (unlikely(!pmd_thp_or_huge(*pmd) + || pmd_hugewillfault(*pmd) + || pmd_trans_splitting(*pmd))) { + spin_unlock(ptl); + return 0; + } + + *ptep = NULL; + *ptlp = ptl; + *page_mask = HPAGE_MASK; + return 1; + } + + if (unlikely(pmd_bad(*pmd))) return 0; pte = pte_offset_map_lock(current->mm, pmd, addr, &ptl); @@ -52,6 +83,7 @@ pin_page_for_write(const void __user *_addr, pte_t **ptep, spinlock_t **ptlp) *ptep = pte; *ptlp = ptl; + *page_mask = PAGE_MASK; return 1; } @@ -60,6 +92,7 @@ static unsigned long noinline __copy_to_user_memcpy(void __user *to, const void *from, unsigned long n) { int atomic; + unsigned long page_mask; if (unlikely(segment_eq(get_fs(), KERNEL_DS))) { memcpy((void *)to, from, n); @@ -76,7 +109,7 @@ __copy_to_user_memcpy(void __user *to, const void *from, unsigned long n) spinlock_t *ptl; int tocopy; - while (!pin_page_for_write(to, &pte, &ptl)) { + while (!pin_page_for_write(to, &pte, &ptl, &page_mask)) { if (!atomic) up_read(&current->mm->mmap_sem); if (__put_user(0, (char __user *)to)) @@ -85,7 +118,7 @@ __copy_to_user_memcpy(void __user *to, const void *from, unsigned long n) down_read(&current->mm->mmap_sem); } - tocopy = (~(unsigned long)to & ~PAGE_MASK) + 1; + tocopy = (~(unsigned long)to & ~page_mask) + 1; if (tocopy > n) tocopy = n; @@ -94,7 +127,10 @@ __copy_to_user_memcpy(void __user *to, const void *from, unsigned long n) from += tocopy; n -= tocopy; - pte_unmap_unlock(pte, ptl); + if (pte) + pte_unmap_unlock(pte, ptl); + else + spin_unlock(ptl); } if (!atomic) up_read(&current->mm->mmap_sem); @@ -121,6 +157,8 @@ __copy_to_user(void __user *to, const void *from, unsigned long n) static unsigned long noinline __clear_user_memset(void __user *addr, unsigned long n) { + unsigned long page_mask; + if (unlikely(segment_eq(get_fs(), KERNEL_DS))) { memset((void *)addr, 0, n); return 0; @@ -132,14 +170,14 @@ __clear_user_memset(void __user *addr, unsigned long n) spinlock_t *ptl; int tocopy; - while (!pin_page_for_write(addr, &pte, &ptl)) { + while (!pin_page_for_write(addr, &pte, &ptl, &page_mask)) { up_read(&current->mm->mmap_sem); if (__put_user(0, (char __user *)addr)) goto out; down_read(&current->mm->mmap_sem); } - tocopy = (~(unsigned long)addr & ~PAGE_MASK) + 1; + tocopy = (~(unsigned long)addr & ~page_mask) + 1; if (tocopy > n) tocopy = n; @@ -147,7 +185,10 @@ __clear_user_memset(void __user *addr, unsigned long n) addr += tocopy; n -= tocopy; - pte_unmap_unlock(pte, ptl); + if (pte) + pte_unmap_unlock(pte, ptl); + else + spin_unlock(ptl); } up_read(&current->mm->mmap_sem); -- 1.8.1.4

12 years, 1 month

[PATCH v2] migration: Fix debug print type

by Christoffer Dall

The printf args are uint64_t and with -Werr QEMU doesn't compile with migration debugging turned on unless this is fixed. Fix it. Signed-off-by: Christoffer Dall <christoffer.dall(a)linaro.org> --- [Changelog v1 -> v2]: - Use PRIu64 instead of %llu migration.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 1402fa7..e9b83f6 100644 --- a/migration.c +++ b/migration.c @@ -566,7 +566,8 @@ static void *migration_thread(void *opaque) if (!qemu_file_rate_limit(s->file)) { DPRINTF("iterate\n"); pending_size = qemu_savevm_state_pending(s->file, max_size); - DPRINTF("pending size %lu max %lu\n", pending_size, max_size); + DPRINTF("pending size %" PRIu64 " max %" PRIu64 "\n", + pending_size, max_size); if (pending_size && pending_size >= max_size) { qemu_savevm_state_iterate(s->file); } else { -- 1.7.10.4

12 years, 1 month

next/master boot: 23 pass, 2 fail (next-20130924)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: next/master Git describe: next-20130924 Commit: f879f32601 Add linux-next specific files for 20130924 Failed boot tests (console logs at the end) =========================================== omap3-beagle: FAIL: arm-omap2plus_defconfig omap3-beagle: FAIL: arm-multi_v7_defconfig Full Report =========== arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.2 sec imx6q-wandboard PASS: 0 min 15.0 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 27.4 sec omap3-beagle-xm PASS: 0 min 51.8 sec am335x-bone PASS: 0 min 26.3 sec omap3-tobi,3530overo PASS: 0 min 42.3 sec omap4-panda PASS: 1 min 5.1 sec omap4-panda-es PASS: 1 min 14.4 sec omap3-tobi,3730storm PASS: 0 min 41.5 sec omap3-beagle FAIL: 0 min 18.6 sec arm-multi_v7_defconfig ---------------------- am335x-boneblack PASS: 0 min 31.9 sec omap3-beagle-xm PASS: 0 min 52.3 sec omap4-panda-es PASS: 1 min 11.0 sec omap4-panda PASS: 0 min 59.5 sec sun4i-a10-cubieboard PASS: 0 min 11.6 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.5 sec omap3-tobi,3530overo PASS: 0 min 40.8 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 15.9 sec omap3-tobi,3730storm PASS: 0 min 40.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.7 sec omap3-beagle FAIL: 0 min 18.7 sec arm-exynos_defconfig -------------------- exynos5250-arndale PASS: 0 min 35.5 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.4 sec Console logs for failures ========================= arm-omap2plus_defconfig ----------------------- omap3-beagle: FAIL: last 24 lines of boot log: ---------------------------------------------- if test -n ${initenv}; then run initenv; fi OMAP3 beagleboard.org # if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... Warning: asx0 using MAC address from net device 1 Ethernet Device(s) found OMAP3 beagleboard.org # setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no OMAP3 beagleboard.org # dhcp dhcp ERROR: Need valid 'usbnet_devaddr' to be set at ether.c:2369/usb_eth_init() Waiting for Ethernet connection... done. BOOTP broadcast 1 EHCI timed out on TD - token=0x8008d80 BOOTP broadcast 2 ~$off # PYBOOT: Exception: u-boot: ERROR: timed-out getting DHCP address. # PYBOOT: Time: 18.64 seconds. # PYBOOT: Result: FAIL arm-multi_v7_defconfig ---------------------- omap3-beagle: FAIL: last 24 lines of boot log: ---------------------------------------------- if test -n ${initenv}; then run initenv; fi OMAP3 beagleboard.org # if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 2 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... Warning: asx0 using MAC address from net device 1 Ethernet Device(s) found OMAP3 beagleboard.org #setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no OMAP3 beagleboard.org # dhcp dhcp ERROR: Need valid 'usbnet_devaddr' to be set at ether.c:2369/usb_eth_init() Waiting for Ethernet connection... done. BOOTP broadcast 1 BOOTP broadcast 2 BOOTP broadcast 3 ~$off # PYBOOT: Exception: u-boot: ERROR: timed-out getting DHCP address. # PYBOOT: Time: 18.68 seconds. # PYBOOT: Result: FAIL

12 years, 1 month

next/master build: 0 failures 16 warnings (next-20130924)

by Kevin Hilman build bot

Automated build results for all ARM defconfigs. Summarizes all build errors, warnings and section mismatches followed by a per-defconfig summary. Tree/Branch: next/master Git describe: next-20130924 Commit: f879f32601 Add linux-next specific files for 20130924 Build Time: 118 min 3 sec Passed: 130 / 130 (100.00 %) Failed: 0 / 130 ( 0.00 %) Errors: 0 Warnings: 16 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): arm-spitz_defconfig: 1 warnings 0 mismatches arm-mini2440_defconfig: 1 warnings 0 mismatches arm-multi_v7_defconfig+lpae.config: 15 warnings 0 mismatches arm-iop13xx_defconfig: 1 warnings 0 mismatches arm-corgi_defconfig: 1 warnings 0 mismatches arm-iop32x_defconfig: 1 warnings 0 mismatches ------------------------------------------------------------------------------- Warnings Summary: 16 5 crypto/wp512.c:987:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] 1 drivers/tty/serial/imx.c:1542:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] 1 drivers/gpu/host1x/hw/debug_hw.c:175:10: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘dma_addr_t’ [-Wformat] 1 drivers/gpu/host1x/hw/cdma_hw.c:57:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/ipu/ipu_idmac.c:1235:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/ipu/ipu_idmac.c:1235:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-sdma.c:1166:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-sdma.c:1092:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:960:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:960:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:930:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:930:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:603:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 9 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:593:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 9 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:579:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat] 1 drivers/dma/imx-dma.c:579:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm-spitz_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: crypto/wp512.c:987:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] ------------------------------------------------------------------------------- arm-mini2440_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: crypto/wp512.c:987:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] ------------------------------------------------------------------------------- arm-multi_v7_defconfig+lpae.config : PASS, 0 errors, 15 warnings, 0 section mismatches Warnings: drivers/dma/imx-sdma.c:1092:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-sdma.c:1166:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] drivers/dma/ipu/ipu_idmac.c:1235:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat] drivers/dma/ipu/ipu_idmac.c:1235:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:579:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:579:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:593:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 9 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:603:4: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 9 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:930:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:930:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:960:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘dma_addr_t’ [-Wformat] drivers/dma/imx-dma.c:960:2: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 7 has type ‘dma_addr_t’ [-Wformat] drivers/gpu/host1x/hw/cdma_hw.c:57:3: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘dma_addr_t’ [-Wformat] drivers/gpu/host1x/hw/debug_hw.c:175:10: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 3 has type ‘dma_addr_t’ [-Wformat] drivers/tty/serial/imx.c:1542:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] ------------------------------------------------------------------------------- arm-iop13xx_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: crypto/wp512.c:987:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] ------------------------------------------------------------------------------- arm-corgi_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: crypto/wp512.c:987:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] ------------------------------------------------------------------------------- arm-iop32x_defconfig : PASS, 0 errors, 1 warnings, 0 section mismatches Warnings: crypto/wp512.c:987:1: warning: the frame size of 1168 bytes is larger than 1024 bytes [-Wframe-larger-than=] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm-realview-smp_defconfig arm-at91rm9200_defconfig arm-pcm027_defconfig arm-rmk-omap3430-ldp.config arm-bcm2835_defconfig arm-ixp4xx_defconfig arm-dove_defconfig arm-nuc950_defconfig arm-ebsa110_defconfig arm-at91sam9261_9g10_defconfig arm-omap2plus_defconfig arm-bockw_defconfig arm-hackkit_defconfig arm-cns3420vb_defconfig arm-u300_defconfig arm-bcm_defconfig arm-exynos_defconfig arm-imx_v4_v5_defconfig arm-zeus_defconfig arm-rmk-sa11x0-neponset.config arm-davinci_all_defconfig arm-badge4_defconfig arm-exynos_defconfig+lpae.config arm-nuc960_defconfig arm-shark_defconfig arm-allnoconfig arm-em_x270_defconfig arm-armadillo800eva_defconfig arm-trizeps4_defconfig arm-acs5k_defconfig arm-rmk-realview.config arm-at91sam9260_9g20_defconfig arm-lpc32xx_defconfig arm-rmk-omap4430-ldp-allnoconfig.config arm-rmk-versatile.config arm-vexpress_defconfig arm-ape6evm_defconfig arm-netx_defconfig arm-socfpga_defconfig arm-orion5x_defconfig arm-cm_x2xx_defconfig arm-da8xx_omapl_defconfig arm-omap2plus_defconfig+pm.config arm-at91x40_defconfig arm-cerfcube_defconfig arm-versatile_defconfig arm-am200epdkit_defconfig arm-rmk-omap3430-ldp-allnoconfig.config arm-simpad_defconfig arm-pxa910_defconfig arm-acs5k_tiny_defconfig arm-xcep_defconfig arm-s5pv210_defconfig arm-at91_dt_defconfig arm-palmz72_defconfig arm-ezx_defconfig arm-imote2_defconfig arm-netwinder_defconfig arm-iop33x_defconfig arm-rmk-pxa.config arm-koelsch_defconfig arm-assabet_defconfig arm-magician_defconfig arm-mainstone_defconfig arm-s5pc100_defconfig arm-lager_defconfig arm-spear3xx_defconfig arm-shannon_defconfig arm-at91sam9g45_defconfig arm-prima2_defconfig arm-jornada720_defconfig arm-s3c2410_defconfig arm-pxa255-idp_defconfig arm-h3600_defconfig arm-colibri_pxa270_defconfig arm-nhk8815_defconfig arm-nuc910_defconfig arm-viper_defconfig arm-colibri_pxa300_defconfig arm-pleb_defconfig arm-mmp2_defconfig arm-spear6xx_defconfig arm-eseries_pxa_defconfig arm-ks8695_defconfig arm-raumfeld_defconfig arm-integrator_defconfig arm-footbridge_defconfig arm-pxa168_defconfig arm-multi_v7_defconfig arm-s5p64x0_defconfig arm-rpc_defconfig arm-mxs_defconfig arm-pxa3xx_defconfig arm-omap1_defconfig arm-kzm9d_defconfig arm-rmk-vexpress-ct9x4.config arm-ep93xx_defconfig arm-keystone_defconfig arm-at91sam9rl_defconfig arm-lubbock_defconfig arm-s3c6400_defconfig arm-imx_v6_v7_defconfig arm-at91sam9263_defconfig arm-mackerel_defconfig arm-clps711x_defconfig arm-collie_defconfig arm-tegra_defconfig arm-lart_defconfig arm-marzen_defconfig arm-kzm9g_defconfig arm-tct_hammer_defconfig arm-mv78xx0_defconfig arm-realview_defconfig arm-msm_defconfig arm-u8500_defconfig arm-cm_x300_defconfig arm-h5000_defconfig arm-kirkwood_defconfig arm-mvebu_defconfig arm-lpd270_defconfig arm-rmk-omap4430-ldp.config arm-spear13xx_defconfig arm-neponset_defconfig arm-sama5_defconfig

12 years, 1 month

Re: [PATCH 3/3] ASoC: max98088: Convert to direct regmap API usage

by Dylan Reid

On Mon, Sep 23, 2013 at 9:58 AM, Mark Brown <broonie(a)kernel.org> wrote: > From: Mark Brown <broonie(a)linaro.org> > > This saves code and moves us towards removing the redundant register I/O > implementation in ASoC. > > Signed-off-by: Mark Brown <broonie(a)linaro.org> all three successfully tested. > --- > sound/soc/codecs/max98088.c | 580 +++++++++++++++++++------------------------- > 1 file changed, 251 insertions(+), 329 deletions(-) > > diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c > index 8896d5e..31912d5 100644 > --- a/sound/soc/codecs/max98088.c > +++ b/sound/soc/codecs/max98088.c > @@ -15,6 +15,7 @@ > #include <linux/delay.h> > #include <linux/pm.h> > #include <linux/i2c.h> > +#include <linux/regmap.h> > #include <sound/core.h> > #include <sound/pcm.h> > #include <sound/pcm_params.h> > @@ -38,6 +39,7 @@ struct max98088_cdata { > }; > > struct max98088_priv { > + struct regmap *regmap; > enum max98088_type devtype; > struct max98088_pdata *pdata; > unsigned int sysclk; > @@ -54,278 +56,206 @@ struct max98088_priv { > unsigned int extmic_mode; > }; > > -static const u8 max98088_reg[M98088_REG_CNT] = { > - 0x00, /* 00 IRQ status */ > - 0x00, /* 01 MIC status */ > - 0x00, /* 02 jack status */ > - 0x00, /* 03 battery voltage */ > - 0x00, /* 04 */ > - 0x00, /* 05 */ > - 0x00, /* 06 */ > - 0x00, /* 07 */ > - 0x00, /* 08 */ > - 0x00, /* 09 */ > - 0x00, /* 0A */ > - 0x00, /* 0B */ > - 0x00, /* 0C */ > - 0x00, /* 0D */ > - 0x00, /* 0E */ > - 0x00, /* 0F interrupt enable */ > - > - 0x00, /* 10 master clock */ > - 0x00, /* 11 DAI1 clock mode */ > - 0x00, /* 12 DAI1 clock control */ > - 0x00, /* 13 DAI1 clock control */ > - 0x00, /* 14 DAI1 format */ > - 0x00, /* 15 DAI1 clock */ > - 0x00, /* 16 DAI1 config */ > - 0x00, /* 17 DAI1 TDM */ > - 0x00, /* 18 DAI1 filters */ > - 0x00, /* 19 DAI2 clock mode */ > - 0x00, /* 1A DAI2 clock control */ > - 0x00, /* 1B DAI2 clock control */ > - 0x00, /* 1C DAI2 format */ > - 0x00, /* 1D DAI2 clock */ > - 0x00, /* 1E DAI2 config */ > - 0x00, /* 1F DAI2 TDM */ > - > - 0x00, /* 20 DAI2 filters */ > - 0x00, /* 21 data config */ > - 0x00, /* 22 DAC mixer */ > - 0x00, /* 23 left ADC mixer */ > - 0x00, /* 24 right ADC mixer */ > - 0x00, /* 25 left HP mixer */ > - 0x00, /* 26 right HP mixer */ > - 0x00, /* 27 HP control */ > - 0x00, /* 28 left REC mixer */ > - 0x00, /* 29 right REC mixer */ > - 0x00, /* 2A REC control */ > - 0x00, /* 2B left SPK mixer */ > - 0x00, /* 2C right SPK mixer */ > - 0x00, /* 2D SPK control */ > - 0x00, /* 2E sidetone */ > - 0x00, /* 2F DAI1 playback level */ > - > - 0x00, /* 30 DAI1 playback level */ > - 0x00, /* 31 DAI2 playback level */ > - 0x00, /* 32 DAI2 playbakc level */ > - 0x00, /* 33 left ADC level */ > - 0x00, /* 34 right ADC level */ > - 0x00, /* 35 MIC1 level */ > - 0x00, /* 36 MIC2 level */ > - 0x00, /* 37 INA level */ > - 0x00, /* 38 INB level */ > - 0x00, /* 39 left HP volume */ > - 0x00, /* 3A right HP volume */ > - 0x00, /* 3B left REC volume */ > - 0x00, /* 3C right REC volume */ > - 0x00, /* 3D left SPK volume */ > - 0x00, /* 3E right SPK volume */ > - 0x00, /* 3F MIC config */ > - > - 0x00, /* 40 MIC threshold */ > - 0x00, /* 41 excursion limiter filter */ > - 0x00, /* 42 excursion limiter threshold */ > - 0x00, /* 43 ALC */ > - 0x00, /* 44 power limiter threshold */ > - 0x00, /* 45 power limiter config */ > - 0x00, /* 46 distortion limiter config */ > - 0x00, /* 47 audio input */ > - 0x00, /* 48 microphone */ > - 0x00, /* 49 level control */ > - 0x00, /* 4A bypass switches */ > - 0x00, /* 4B jack detect */ > - 0x00, /* 4C input enable */ > - 0x00, /* 4D output enable */ > - 0xF0, /* 4E bias control */ > - 0x00, /* 4F DAC power */ > - > - 0x0F, /* 50 DAC power */ > - 0x00, /* 51 system */ > - 0x00, /* 52 DAI1 EQ1 */ > - 0x00, /* 53 DAI1 EQ1 */ > - 0x00, /* 54 DAI1 EQ1 */ > - 0x00, /* 55 DAI1 EQ1 */ > - 0x00, /* 56 DAI1 EQ1 */ > - 0x00, /* 57 DAI1 EQ1 */ > - 0x00, /* 58 DAI1 EQ1 */ > - 0x00, /* 59 DAI1 EQ1 */ > - 0x00, /* 5A DAI1 EQ1 */ > - 0x00, /* 5B DAI1 EQ1 */ > - 0x00, /* 5C DAI1 EQ2 */ > - 0x00, /* 5D DAI1 EQ2 */ > - 0x00, /* 5E DAI1 EQ2 */ > - 0x00, /* 5F DAI1 EQ2 */ > - > - 0x00, /* 60 DAI1 EQ2 */ > - 0x00, /* 61 DAI1 EQ2 */ > - 0x00, /* 62 DAI1 EQ2 */ > - 0x00, /* 63 DAI1 EQ2 */ > - 0x00, /* 64 DAI1 EQ2 */ > - 0x00, /* 65 DAI1 EQ2 */ > - 0x00, /* 66 DAI1 EQ3 */ > - 0x00, /* 67 DAI1 EQ3 */ > - 0x00, /* 68 DAI1 EQ3 */ > - 0x00, /* 69 DAI1 EQ3 */ > - 0x00, /* 6A DAI1 EQ3 */ > - 0x00, /* 6B DAI1 EQ3 */ > - 0x00, /* 6C DAI1 EQ3 */ > - 0x00, /* 6D DAI1 EQ3 */ > - 0x00, /* 6E DAI1 EQ3 */ > - 0x00, /* 6F DAI1 EQ3 */ > - > - 0x00, /* 70 DAI1 EQ4 */ > - 0x00, /* 71 DAI1 EQ4 */ > - 0x00, /* 72 DAI1 EQ4 */ > - 0x00, /* 73 DAI1 EQ4 */ > - 0x00, /* 74 DAI1 EQ4 */ > - 0x00, /* 75 DAI1 EQ4 */ > - 0x00, /* 76 DAI1 EQ4 */ > - 0x00, /* 77 DAI1 EQ4 */ > - 0x00, /* 78 DAI1 EQ4 */ > - 0x00, /* 79 DAI1 EQ4 */ > - 0x00, /* 7A DAI1 EQ5 */ > - 0x00, /* 7B DAI1 EQ5 */ > - 0x00, /* 7C DAI1 EQ5 */ > - 0x00, /* 7D DAI1 EQ5 */ > - 0x00, /* 7E DAI1 EQ5 */ > - 0x00, /* 7F DAI1 EQ5 */ > - > - 0x00, /* 80 DAI1 EQ5 */ > - 0x00, /* 81 DAI1 EQ5 */ > - 0x00, /* 82 DAI1 EQ5 */ > - 0x00, /* 83 DAI1 EQ5 */ > - 0x00, /* 84 DAI2 EQ1 */ > - 0x00, /* 85 DAI2 EQ1 */ > - 0x00, /* 86 DAI2 EQ1 */ > - 0x00, /* 87 DAI2 EQ1 */ > - 0x00, /* 88 DAI2 EQ1 */ > - 0x00, /* 89 DAI2 EQ1 */ > - 0x00, /* 8A DAI2 EQ1 */ > - 0x00, /* 8B DAI2 EQ1 */ > - 0x00, /* 8C DAI2 EQ1 */ > - 0x00, /* 8D DAI2 EQ1 */ > - 0x00, /* 8E DAI2 EQ2 */ > - 0x00, /* 8F DAI2 EQ2 */ > - > - 0x00, /* 90 DAI2 EQ2 */ > - 0x00, /* 91 DAI2 EQ2 */ > - 0x00, /* 92 DAI2 EQ2 */ > - 0x00, /* 93 DAI2 EQ2 */ > - 0x00, /* 94 DAI2 EQ2 */ > - 0x00, /* 95 DAI2 EQ2 */ > - 0x00, /* 96 DAI2 EQ2 */ > - 0x00, /* 97 DAI2 EQ2 */ > - 0x00, /* 98 DAI2 EQ3 */ > - 0x00, /* 99 DAI2 EQ3 */ > - 0x00, /* 9A DAI2 EQ3 */ > - 0x00, /* 9B DAI2 EQ3 */ > - 0x00, /* 9C DAI2 EQ3 */ > - 0x00, /* 9D DAI2 EQ3 */ > - 0x00, /* 9E DAI2 EQ3 */ > - 0x00, /* 9F DAI2 EQ3 */ > - > - 0x00, /* A0 DAI2 EQ3 */ > - 0x00, /* A1 DAI2 EQ3 */ > - 0x00, /* A2 DAI2 EQ4 */ > - 0x00, /* A3 DAI2 EQ4 */ > - 0x00, /* A4 DAI2 EQ4 */ > - 0x00, /* A5 DAI2 EQ4 */ > - 0x00, /* A6 DAI2 EQ4 */ > - 0x00, /* A7 DAI2 EQ4 */ > - 0x00, /* A8 DAI2 EQ4 */ > - 0x00, /* A9 DAI2 EQ4 */ > - 0x00, /* AA DAI2 EQ4 */ > - 0x00, /* AB DAI2 EQ4 */ > - 0x00, /* AC DAI2 EQ5 */ > - 0x00, /* AD DAI2 EQ5 */ > - 0x00, /* AE DAI2 EQ5 */ > - 0x00, /* AF DAI2 EQ5 */ > - > - 0x00, /* B0 DAI2 EQ5 */ > - 0x00, /* B1 DAI2 EQ5 */ > - 0x00, /* B2 DAI2 EQ5 */ > - 0x00, /* B3 DAI2 EQ5 */ > - 0x00, /* B4 DAI2 EQ5 */ > - 0x00, /* B5 DAI2 EQ5 */ > - 0x00, /* B6 DAI1 biquad */ > - 0x00, /* B7 DAI1 biquad */ > - 0x00, /* B8 DAI1 biquad */ > - 0x00, /* B9 DAI1 biquad */ > - 0x00, /* BA DAI1 biquad */ > - 0x00, /* BB DAI1 biquad */ > - 0x00, /* BC DAI1 biquad */ > - 0x00, /* BD DAI1 biquad */ > - 0x00, /* BE DAI1 biquad */ > - 0x00, /* BF DAI1 biquad */ > - > - 0x00, /* C0 DAI2 biquad */ > - 0x00, /* C1 DAI2 biquad */ > - 0x00, /* C2 DAI2 biquad */ > - 0x00, /* C3 DAI2 biquad */ > - 0x00, /* C4 DAI2 biquad */ > - 0x00, /* C5 DAI2 biquad */ > - 0x00, /* C6 DAI2 biquad */ > - 0x00, /* C7 DAI2 biquad */ > - 0x00, /* C8 DAI2 biquad */ > - 0x00, /* C9 DAI2 biquad */ > - 0x00, /* CA */ > - 0x00, /* CB */ > - 0x00, /* CC */ > - 0x00, /* CD */ > - 0x00, /* CE */ > - 0x00, /* CF */ > - > - 0x00, /* D0 */ > - 0x00, /* D1 */ > - 0x00, /* D2 */ > - 0x00, /* D3 */ > - 0x00, /* D4 */ > - 0x00, /* D5 */ > - 0x00, /* D6 */ > - 0x00, /* D7 */ > - 0x00, /* D8 */ > - 0x00, /* D9 */ > - 0x00, /* DA */ > - 0x70, /* DB */ > - 0x00, /* DC */ > - 0x00, /* DD */ > - 0x00, /* DE */ > - 0x00, /* DF */ > - > - 0x00, /* E0 */ > - 0x00, /* E1 */ > - 0x00, /* E2 */ > - 0x00, /* E3 */ > - 0x00, /* E4 */ > - 0x00, /* E5 */ > - 0x00, /* E6 */ > - 0x00, /* E7 */ > - 0x00, /* E8 */ > - 0x00, /* E9 */ > - 0x00, /* EA */ > - 0x00, /* EB */ > - 0x00, /* EC */ > - 0x00, /* ED */ > - 0x00, /* EE */ > - 0x00, /* EF */ > - > - 0x00, /* F0 */ > - 0x00, /* F1 */ > - 0x00, /* F2 */ > - 0x00, /* F3 */ > - 0x00, /* F4 */ > - 0x00, /* F5 */ > - 0x00, /* F6 */ > - 0x00, /* F7 */ > - 0x00, /* F8 */ > - 0x00, /* F9 */ > - 0x00, /* FA */ > - 0x00, /* FB */ > - 0x00, /* FC */ > - 0x00, /* FD */ > - 0x00, /* FE */ > - 0x00, /* FF */ > +static const struct reg_default max98088_reg[] = { > + { 0xf, 0x00 }, /* 0F interrupt enable */ > + > + { 0x10, 0x00 }, /* 10 master clock */ > + { 0x11, 0x00 }, /* 11 DAI1 clock mode */ > + { 0x12, 0x00 }, /* 12 DAI1 clock control */ > + { 0x13, 0x00 }, /* 13 DAI1 clock control */ > + { 0x14, 0x00 }, /* 14 DAI1 format */ > + { 0x15, 0x00 }, /* 15 DAI1 clock */ > + { 0x16, 0x00 }, /* 16 DAI1 config */ > + { 0x17, 0x00 }, /* 17 DAI1 TDM */ > + { 0x18, 0x00 }, /* 18 DAI1 filters */ > + { 0x19, 0x00 }, /* 19 DAI2 clock mode */ > + { 0x1a, 0x00 }, /* 1A DAI2 clock control */ > + { 0x1b, 0x00 }, /* 1B DAI2 clock control */ > + { 0x1c, 0x00 }, /* 1C DAI2 format */ > + { 0x1d, 0x00 }, /* 1D DAI2 clock */ > + { 0x1e, 0x00 }, /* 1E DAI2 config */ > + { 0x1f, 0x00 }, /* 1F DAI2 TDM */ > + > + { 0x20, 0x00 }, /* 20 DAI2 filters */ > + { 0x21, 0x00 }, /* 21 data config */ > + { 0x22, 0x00 }, /* 22 DAC mixer */ > + { 0x23, 0x00 }, /* 23 left ADC mixer */ > + { 0x24, 0x00 }, /* 24 right ADC mixer */ > + { 0x25, 0x00 }, /* 25 left HP mixer */ > + { 0x26, 0x00 }, /* 26 right HP mixer */ > + { 0x27, 0x00 }, /* 27 HP control */ > + { 0x28, 0x00 }, /* 28 left REC mixer */ > + { 0x29, 0x00 }, /* 29 right REC mixer */ > + { 0x2a, 0x00 }, /* 2A REC control */ > + { 0x2b, 0x00 }, /* 2B left SPK mixer */ > + { 0x2c, 0x00 }, /* 2C right SPK mixer */ > + { 0x2d, 0x00 }, /* 2D SPK control */ > + { 0x2e, 0x00 }, /* 2E sidetone */ > + { 0x2f, 0x00 }, /* 2F DAI1 playback level */ > + > + { 0x30, 0x00 }, /* 30 DAI1 playback level */ > + { 0x31, 0x00 }, /* 31 DAI2 playback level */ > + { 0x32, 0x00 }, /* 32 DAI2 playbakc level */ > + { 0x33, 0x00 }, /* 33 left ADC level */ > + { 0x34, 0x00 }, /* 34 right ADC level */ > + { 0x35, 0x00 }, /* 35 MIC1 level */ > + { 0x36, 0x00 }, /* 36 MIC2 level */ > + { 0x37, 0x00 }, /* 37 INA level */ > + { 0x38, 0x00 }, /* 38 INB level */ > + { 0x39, 0x00 }, /* 39 left HP volume */ > + { 0x3a, 0x00 }, /* 3A right HP volume */ > + { 0x3b, 0x00 }, /* 3B left REC volume */ > + { 0x3c, 0x00 }, /* 3C right REC volume */ > + { 0x3d, 0x00 }, /* 3D left SPK volume */ > + { 0x3e, 0x00 }, /* 3E right SPK volume */ > + { 0x3f, 0x00 }, /* 3F MIC config */ > + > + { 0x40, 0x00 }, /* 40 MIC threshold */ > + { 0x41, 0x00 }, /* 41 excursion limiter filter */ > + { 0x42, 0x00 }, /* 42 excursion limiter threshold */ > + { 0x43, 0x00 }, /* 43 ALC */ > + { 0x44, 0x00 }, /* 44 power limiter threshold */ > + { 0x45, 0x00 }, /* 45 power limiter config */ > + { 0x46, 0x00 }, /* 46 distortion limiter config */ > + { 0x47, 0x00 }, /* 47 audio input */ > + { 0x48, 0x00 }, /* 48 microphone */ > + { 0x49, 0x00 }, /* 49 level control */ > + { 0x4a, 0x00 }, /* 4A bypass switches */ > + { 0x4b, 0x00 }, /* 4B jack detect */ > + { 0x4c, 0x00 }, /* 4C input enable */ > + { 0x4d, 0x00 }, /* 4D output enable */ > + { 0x4e, 0xF0 }, /* 4E bias control */ > + { 0x4f, 0x00 }, /* 4F DAC power */ > + > + { 0x50, 0x0F }, /* 50 DAC power */ > + { 0x51, 0x00 }, /* 51 system */ > + { 0x52, 0x00 }, /* 52 DAI1 EQ1 */ > + { 0x53, 0x00 }, /* 53 DAI1 EQ1 */ > + { 0x54, 0x00 }, /* 54 DAI1 EQ1 */ > + { 0x55, 0x00 }, /* 55 DAI1 EQ1 */ > + { 0x56, 0x00 }, /* 56 DAI1 EQ1 */ > + { 0x57, 0x00 }, /* 57 DAI1 EQ1 */ > + { 0x58, 0x00 }, /* 58 DAI1 EQ1 */ > + { 0x59, 0x00 }, /* 59 DAI1 EQ1 */ > + { 0x5a, 0x00 }, /* 5A DAI1 EQ1 */ > + { 0x5b, 0x00 }, /* 5B DAI1 EQ1 */ > + { 0x5c, 0x00 }, /* 5C DAI1 EQ2 */ > + { 0x5d, 0x00 }, /* 5D DAI1 EQ2 */ > + { 0x5e, 0x00 }, /* 5E DAI1 EQ2 */ > + { 0x5f, 0x00 }, /* 5F DAI1 EQ2 */ > + > + { 0x60, 0x00 }, /* 60 DAI1 EQ2 */ > + { 0x61, 0x00 }, /* 61 DAI1 EQ2 */ > + { 0x62, 0x00 }, /* 62 DAI1 EQ2 */ > + { 0x63, 0x00 }, /* 63 DAI1 EQ2 */ > + { 0x64, 0x00 }, /* 64 DAI1 EQ2 */ > + { 0x65, 0x00 }, /* 65 DAI1 EQ2 */ > + { 0x66, 0x00 }, /* 66 DAI1 EQ3 */ > + { 0x67, 0x00 }, /* 67 DAI1 EQ3 */ > + { 0x68, 0x00 }, /* 68 DAI1 EQ3 */ > + { 0x69, 0x00 }, /* 69 DAI1 EQ3 */ > + { 0x6a, 0x00 }, /* 6A DAI1 EQ3 */ > + { 0x6b, 0x00 }, /* 6B DAI1 EQ3 */ > + { 0x6c, 0x00 }, /* 6C DAI1 EQ3 */ > + { 0x6d, 0x00 }, /* 6D DAI1 EQ3 */ > + { 0x6e, 0x00 }, /* 6E DAI1 EQ3 */ > + { 0x6f, 0x00 }, /* 6F DAI1 EQ3 */ > + > + { 0x70, 0x00 }, /* 70 DAI1 EQ4 */ > + { 0x71, 0x00 }, /* 71 DAI1 EQ4 */ > + { 0x72, 0x00 }, /* 72 DAI1 EQ4 */ > + { 0x73, 0x00 }, /* 73 DAI1 EQ4 */ > + { 0x74, 0x00 }, /* 74 DAI1 EQ4 */ > + { 0x75, 0x00 }, /* 75 DAI1 EQ4 */ > + { 0x76, 0x00 }, /* 76 DAI1 EQ4 */ > + { 0x77, 0x00 }, /* 77 DAI1 EQ4 */ > + { 0x78, 0x00 }, /* 78 DAI1 EQ4 */ > + { 0x79, 0x00 }, /* 79 DAI1 EQ4 */ > + { 0x7a, 0x00 }, /* 7A DAI1 EQ5 */ > + { 0x7b, 0x00 }, /* 7B DAI1 EQ5 */ > + { 0x7c, 0x00 }, /* 7C DAI1 EQ5 */ > + { 0x7d, 0x00 }, /* 7D DAI1 EQ5 */ > + { 0x7e, 0x00 }, /* 7E DAI1 EQ5 */ > + { 0x7f, 0x00 }, /* 7F DAI1 EQ5 */ > + > + { 0x80, 0x00 }, /* 80 DAI1 EQ5 */ > + { 0x81, 0x00 }, /* 81 DAI1 EQ5 */ > + { 0x82, 0x00 }, /* 82 DAI1 EQ5 */ > + { 0x83, 0x00 }, /* 83 DAI1 EQ5 */ > + { 0x84, 0x00 }, /* 84 DAI2 EQ1 */ > + { 0x85, 0x00 }, /* 85 DAI2 EQ1 */ > + { 0x86, 0x00 }, /* 86 DAI2 EQ1 */ > + { 0x87, 0x00 }, /* 87 DAI2 EQ1 */ > + { 0x88, 0x00 }, /* 88 DAI2 EQ1 */ > + { 0x89, 0x00 }, /* 89 DAI2 EQ1 */ > + { 0x8a, 0x00 }, /* 8A DAI2 EQ1 */ > + { 0x8b, 0x00 }, /* 8B DAI2 EQ1 */ > + { 0x8c, 0x00 }, /* 8C DAI2 EQ1 */ > + { 0x8d, 0x00 }, /* 8D DAI2 EQ1 */ > + { 0x8e, 0x00 }, /* 8E DAI2 EQ2 */ > + { 0x8f, 0x00 }, /* 8F DAI2 EQ2 */ > + > + { 0x90, 0x00 }, /* 90 DAI2 EQ2 */ > + { 0x91, 0x00 }, /* 91 DAI2 EQ2 */ > + { 0x92, 0x00 }, /* 92 DAI2 EQ2 */ > + { 0x93, 0x00 }, /* 93 DAI2 EQ2 */ > + { 0x94, 0x00 }, /* 94 DAI2 EQ2 */ > + { 0x95, 0x00 }, /* 95 DAI2 EQ2 */ > + { 0x96, 0x00 }, /* 96 DAI2 EQ2 */ > + { 0x97, 0x00 }, /* 97 DAI2 EQ2 */ > + { 0x98, 0x00 }, /* 98 DAI2 EQ3 */ > + { 0x99, 0x00 }, /* 99 DAI2 EQ3 */ > + { 0x9a, 0x00 }, /* 9A DAI2 EQ3 */ > + { 0x9b, 0x00 }, /* 9B DAI2 EQ3 */ > + { 0x9c, 0x00 }, /* 9C DAI2 EQ3 */ > + { 0x9d, 0x00 }, /* 9D DAI2 EQ3 */ > + { 0x9e, 0x00 }, /* 9E DAI2 EQ3 */ > + { 0x9f, 0x00 }, /* 9F DAI2 EQ3 */ > + > + { 0xa0, 0x00 }, /* A0 DAI2 EQ3 */ > + { 0xa1, 0x00 }, /* A1 DAI2 EQ3 */ > + { 0xa2, 0x00 }, /* A2 DAI2 EQ4 */ > + { 0xa3, 0x00 }, /* A3 DAI2 EQ4 */ > + { 0xa4, 0x00 }, /* A4 DAI2 EQ4 */ > + { 0xa5, 0x00 }, /* A5 DAI2 EQ4 */ > + { 0xa6, 0x00 }, /* A6 DAI2 EQ4 */ > + { 0xa7, 0x00 }, /* A7 DAI2 EQ4 */ > + { 0xa8, 0x00 }, /* A8 DAI2 EQ4 */ > + { 0xa9, 0x00 }, /* A9 DAI2 EQ4 */ > + { 0xaa, 0x00 }, /* AA DAI2 EQ4 */ > + { 0xab, 0x00 }, /* AB DAI2 EQ4 */ > + { 0xac, 0x00 }, /* AC DAI2 EQ5 */ > + { 0xad, 0x00 }, /* AD DAI2 EQ5 */ > + { 0xae, 0x00 }, /* AE DAI2 EQ5 */ > + { 0xaf, 0x00 }, /* AF DAI2 EQ5 */ > + > + { 0xb0, 0x00 }, /* B0 DAI2 EQ5 */ > + { 0xb1, 0x00 }, /* B1 DAI2 EQ5 */ > + { 0xb2, 0x00 }, /* B2 DAI2 EQ5 */ > + { 0xb3, 0x00 }, /* B3 DAI2 EQ5 */ > + { 0xb4, 0x00 }, /* B4 DAI2 EQ5 */ > + { 0xb5, 0x00 }, /* B5 DAI2 EQ5 */ > + { 0xb6, 0x00 }, /* B6 DAI1 biquad */ > + { 0xb7, 0x00 }, /* B7 DAI1 biquad */ > + { 0xb8 ,0x00 }, /* B8 DAI1 biquad */ > + { 0xb9, 0x00 }, /* B9 DAI1 biquad */ > + { 0xba, 0x00 }, /* BA DAI1 biquad */ > + { 0xbb, 0x00 }, /* BB DAI1 biquad */ > + { 0xbc, 0x00 }, /* BC DAI1 biquad */ > + { 0xbd, 0x00 }, /* BD DAI1 biquad */ > + { 0xbe, 0x00 }, /* BE DAI1 biquad */ > + { 0xbf, 0x00 }, /* BF DAI1 biquad */ > + > + { 0xc0, 0x00 }, /* C0 DAI2 biquad */ > + { 0xc1, 0x00 }, /* C1 DAI2 biquad */ > + { 0xc2, 0x00 }, /* C2 DAI2 biquad */ > + { 0xc3, 0x00 }, /* C3 DAI2 biquad */ > + { 0xc4, 0x00 }, /* C4 DAI2 biquad */ > + { 0xc5, 0x00 }, /* C5 DAI2 biquad */ > + { 0xc6, 0x00 }, /* C6 DAI2 biquad */ > + { 0xc7, 0x00 }, /* C7 DAI2 biquad */ > + { 0xc8, 0x00 }, /* C8 DAI2 biquad */ > + { 0xc9, 0x00 }, /* C9 DAI2 biquad */ > }; > > static struct { > @@ -606,11 +536,27 @@ static struct { > { 0xFF, 0x00, 1 }, /* FF */ > }; > > -static int max98088_volatile_register(struct snd_soc_codec *codec, unsigned int reg) > +static bool max98088_readable_register(struct device *dev, unsigned int reg) > +{ > + return max98088_access[reg].readable; > +} > + > +static bool max98088_volatile_register(struct device *dev, unsigned int reg) > { > return max98088_access[reg].vol; > } > > +static const struct regmap_config max98088_regmap = { > + .reg_bits = 8, > + .val_bits = 8, > + > + .readable_reg = max98088_readable_register, > + .volatile_reg = max98088_volatile_register, > + > + .reg_defaults = max98088_reg, > + .num_reg_defaults = ARRAY_SIZE(max98088_reg), > + .cache_type = REGCACHE_RBTREE, > +}; > > /* > * Load equalizer DSP coefficient configurations registers > @@ -1610,58 +1556,34 @@ static int max98088_dai2_digital_mute(struct snd_soc_dai *codec_dai, int mute) > return 0; > } > > -static void max98088_sync_cache(struct snd_soc_codec *codec) > -{ > - u8 *reg_cache = codec->reg_cache; > - int i; > - > - if (!codec->cache_sync) > - return; > - > - codec->cache_only = 0; > - > - /* write back cached values if they're writeable and > - * different from the hardware default. > - */ > - for (i = 1; i < codec->driver->reg_cache_size; i++) { > - if (!max98088_access[i].writable) > - continue; > - > - if (reg_cache[i] == max98088_reg[i]) > - continue; > - > - snd_soc_write(codec, i, reg_cache[i]); > - } > - > - codec->cache_sync = 0; > -} > - > static int max98088_set_bias_level(struct snd_soc_codec *codec, > enum snd_soc_bias_level level) > { > - switch (level) { > - case SND_SOC_BIAS_ON: > - break; > - > - case SND_SOC_BIAS_PREPARE: > - break; > - > - case SND_SOC_BIAS_STANDBY: > - if (codec->dapm.bias_level == SND_SOC_BIAS_OFF) > - max98088_sync_cache(codec); > - > - snd_soc_update_bits(codec, M98088_REG_4C_PWR_EN_IN, > - M98088_MBEN, M98088_MBEN); > - break; > - > - case SND_SOC_BIAS_OFF: > - snd_soc_update_bits(codec, M98088_REG_4C_PWR_EN_IN, > - M98088_MBEN, 0); > - codec->cache_sync = 1; > - break; > - } > - codec->dapm.bias_level = level; > - return 0; > + struct max98088_priv *max98088 = snd_soc_codec_get_drvdata(codec); > + > + switch (level) { > + case SND_SOC_BIAS_ON: > + break; > + > + case SND_SOC_BIAS_PREPARE: > + break; > + > + case SND_SOC_BIAS_STANDBY: > + if (codec->dapm.bias_level == SND_SOC_BIAS_OFF) > + regcache_sync(max98088->regmap); > + > + snd_soc_update_bits(codec, M98088_REG_4C_PWR_EN_IN, > + M98088_MBEN, M98088_MBEN); > + break; > + > + case SND_SOC_BIAS_OFF: > + snd_soc_update_bits(codec, M98088_REG_4C_PWR_EN_IN, > + M98088_MBEN, 0); > + regcache_mark_dirty(max98088->regmap); > + break; > + } > + codec->dapm.bias_level = level; > + return 0; > } > > #define MAX98088_RATES SNDRV_PCM_RATE_8000_96000 > @@ -1988,9 +1910,9 @@ static int max98088_probe(struct snd_soc_codec *codec) > struct max98088_cdata *cdata; > int ret = 0; > > - codec->cache_sync = 1; > + regcache_mark_dirty(max98088->regmap); > > - ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_I2C); > + ret = snd_soc_codec_set_cache_io(codec, 8, 8, SND_SOC_REGMAP); > if (ret != 0) { > dev_err(codec->dev, "Failed to set cache I/O: %d\n", ret); > return ret; > @@ -2070,10 +1992,6 @@ static struct snd_soc_codec_driver soc_codec_dev_max98088 = { > .set_bias_level = max98088_set_bias_level, > .controls = max98088_snd_controls, > .num_controls = ARRAY_SIZE(max98088_snd_controls), > - .reg_cache_size = ARRAY_SIZE(max98088_reg), > - .reg_word_size = sizeof(u8), > - .reg_cache_default = max98088_reg, > - .volatile_register = max98088_volatile_register, > .dapm_widgets = max98088_dapm_widgets, > .num_dapm_widgets = ARRAY_SIZE(max98088_dapm_widgets), > .dapm_routes = max98088_audio_map, > @@ -2081,7 +1999,7 @@ static struct snd_soc_codec_driver soc_codec_dev_max98088 = { > }; > > static int max98088_i2c_probe(struct i2c_client *i2c, > - const struct i2c_device_id *id) > + const struct i2c_device_id *id) > { > struct max98088_priv *max98088; > int ret; > @@ -2091,6 +2009,10 @@ static int max98088_i2c_probe(struct i2c_client *i2c, > if (max98088 == NULL) > return -ENOMEM; > > + max98088->regmap = devm_regmap_init_i2c(i2c, &max98088_regmap); > + if (IS_ERR(max98088->regmap)) > + return PTR_ERR(max98088->regmap); > + > max98088->devtype = id->driver_data; > > i2c_set_clientdata(i2c, max98088); > -- > 1.8.4.rc3 >

12 years, 1 month

linus/master boot: 25 pass, 0 fail (v3.12-rc2)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: linus/master Git describe: v3.12-rc2 Commit: 4a10c2ac2f Linux 3.12-rc2 Full Report =========== arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.3 sec imx6q-wandboard PASS: 0 min 15.0 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 31.3 sec omap3-beagle-xm PASS: 0 min 51.1 sec am335x-bone PASS: 0 min 26.3 sec omap3-tobi,3530overo PASS: 0 min 42.5 sec omap4-panda PASS: 1 min 1.3 sec omap4-panda-es PASS: 1 min 15.5 sec omap3-tobi,3730storm PASS: 0 min 41.6 sec omap3-beagle PASS: 0 min 56.9 sec arm-multi_v7_defconfig ---------------------- am335x-boneblack PASS: 0 min 31.8 sec omap3-beagle-xm PASS: 0 min 51.8 sec omap4-panda-es PASS: 1 min 13.2 sec omap4-panda PASS: 1 min 1.5 sec sun4i-a10-cubieboard PASS: 0 min 11.6 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.4 sec omap3-tobi,3530overo PASS: 0 min 40.8 sec am335x-bone PASS: 0 min 33.4 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 40.1 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.6 sec omap3-beagle PASS: 0 min 55.1 sec arm-exynos_defconfig -------------------- exynos5250-arndale PASS: 0 min 36.6 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.2 sec

12 years, 1 month

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel