linaro-kernel

linaro-kernel@lists.linaro.org

10095 discussions

[PATCH] ASoC: dapm: Use async I/O for DAPM sequences

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> Within a DAPM sequence we normally don't care about when exactly a register write has completed so long as they happen in the order we requested. This means that we can issue most of the writes we do asynchronously which should maximise the ability of the underlying frameworks to keep the hardware busy, providing a small performance improvement on some systems. We currently ensure that all writes are completed both when changing to a different device and when calling into the regulator and clock frameworks. This should ensure that the previous ordering is maintained. We also ensure that writes are completed prior to calling into widget event functions since some event functions implement delays. This should be improved in future so that widgets can disable this sync in order to add extra writes. Signed-off-by: Mark Brown <broonie(a)linaro.org> xvdfvsd --- sound/soc/soc-dapm.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 25b9554..905e4c5 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -409,6 +409,12 @@ static inline void soc_widget_unlock(struct snd_soc_dapm_widget *w) mutex_unlock(&w->platform->mutex); } +static void soc_dapm_async_complete(struct snd_soc_dapm_context *dapm) +{ + if (dapm->codec && dapm->codec->using_regmap) + regmap_async_complete(dapm->codec->control_data); +} + static int soc_widget_update_bits_locked(struct snd_soc_dapm_widget *w, unsigned short reg, unsigned int mask, unsigned int value) { @@ -417,8 +423,9 @@ static int soc_widget_update_bits_locked(struct snd_soc_dapm_widget *w, int ret; if (w->codec && w->codec->using_regmap) { - ret = regmap_update_bits_check(w->codec->control_data, - reg, mask, value, &change); + ret = regmap_update_bits_check_async(w->codec->control_data, + reg, mask, value, + &change); if (ret != 0) return ret; } else { @@ -1201,6 +1208,8 @@ int dapm_regulator_event(struct snd_soc_dapm_widget *w, { int ret; + soc_dapm_async_complete(w->dapm); + if (SND_SOC_DAPM_EVENT_ON(event)) { if (w->on_val & SND_SOC_DAPM_REGULATOR_BYPASS) { ret = regulator_allow_bypass(w->regulator, false); @@ -1234,6 +1243,8 @@ int dapm_clock_event(struct snd_soc_dapm_widget *w, if (!w->clk) return -EIO; + soc_dapm_async_complete(w->dapm); + #ifdef CONFIG_HAVE_CLK if (SND_SOC_DAPM_EVENT_ON(event)) { return clk_prepare_enable(w->clk); @@ -1426,6 +1437,7 @@ static void dapm_seq_check_event(struct snd_soc_card *card, if (w->event && (w->event_flags & event)) { pop_dbg(w->dapm->dev, card->pop_time, "pop test : %s %s\n", w->name, ev_name); + soc_dapm_async_complete(w->dapm); trace_snd_soc_dapm_widget_event_start(w, event); ret = w->event(w, NULL, event); trace_snd_soc_dapm_widget_event_done(w, event); @@ -1498,6 +1510,7 @@ static void dapm_seq_run(struct snd_soc_card *card, struct list_head *list, int event, bool power_up) { struct snd_soc_dapm_widget *w, *n; + struct snd_soc_dapm_context *d; LIST_HEAD(pending); int cur_sort = -1; int cur_subseq = -1; @@ -1528,6 +1541,9 @@ static void dapm_seq_run(struct snd_soc_card *card, cur_subseq); } + if (cur_dapm && w->dapm != cur_dapm) + soc_dapm_async_complete(cur_dapm); + INIT_LIST_HEAD(&pending); cur_sort = -1; cur_subseq = INT_MIN; @@ -1586,6 +1602,10 @@ static void dapm_seq_run(struct snd_soc_card *card, cur_dapm->seq_notifier(cur_dapm, i, cur_subseq); } + + list_for_each_entry(d, &card->dapm_list, list) { + soc_dapm_async_complete(d); + } } static void dapm_widget_update(struct snd_soc_card *card) -- 1.8.4.rc3

11 years, 9 months

[PATCH] ASoC: dapm: Run clock and regulator events separately to other supplies

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> In order to avoid trying to use an external clock or supply for an on-chip supply prior to it being enabled move the clock and regulator supply events to a separate step in DAPM sequencing from normal supply events. This should have minimal practical impact since these widgets are sorted using SND_SOC_NOPM which is a negative value and hence sorted separately to any real register writes, though it may be relevant if supplies have event callbacks only. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- sound/soc/soc-dapm.c | 50 +++++++++++++++++++++++++------------------------- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c index 905e4c5..eb26d5a 100644 --- a/sound/soc/soc-dapm.c +++ b/sound/soc/soc-dapm.c @@ -59,31 +59,31 @@ snd_soc_dapm_new_control(struct snd_soc_dapm_context *dapm, /* dapm power sequences - make this per codec in the future */ static int dapm_up_seq[] = { [snd_soc_dapm_pre] = 0, - [snd_soc_dapm_supply] = 1, [snd_soc_dapm_regulator_supply] = 1, [snd_soc_dapm_clock_supply] = 1, - [snd_soc_dapm_micbias] = 2, + [snd_soc_dapm_supply] = 2, + [snd_soc_dapm_micbias] = 3, [snd_soc_dapm_dai_link] = 2, - [snd_soc_dapm_dai_in] = 3, - [snd_soc_dapm_dai_out] = 3, - [snd_soc_dapm_aif_in] = 3, - [snd_soc_dapm_aif_out] = 3, - [snd_soc_dapm_mic] = 4, - [snd_soc_dapm_mux] = 5, - [snd_soc_dapm_virt_mux] = 5, - [snd_soc_dapm_value_mux] = 5, - [snd_soc_dapm_dac] = 6, - [snd_soc_dapm_switch] = 7, - [snd_soc_dapm_mixer] = 7, - [snd_soc_dapm_mixer_named_ctl] = 7, - [snd_soc_dapm_pga] = 8, - [snd_soc_dapm_adc] = 9, - [snd_soc_dapm_out_drv] = 10, - [snd_soc_dapm_hp] = 10, - [snd_soc_dapm_spk] = 10, - [snd_soc_dapm_line] = 10, - [snd_soc_dapm_kcontrol] = 11, - [snd_soc_dapm_post] = 12, + [snd_soc_dapm_dai_in] = 4, + [snd_soc_dapm_dai_out] = 4, + [snd_soc_dapm_aif_in] = 4, + [snd_soc_dapm_aif_out] = 4, + [snd_soc_dapm_mic] = 5, + [snd_soc_dapm_mux] = 6, + [snd_soc_dapm_virt_mux] = 6, + [snd_soc_dapm_value_mux] = 6, + [snd_soc_dapm_dac] = 7, + [snd_soc_dapm_switch] = 8, + [snd_soc_dapm_mixer] = 8, + [snd_soc_dapm_mixer_named_ctl] = 8, + [snd_soc_dapm_pga] = 9, + [snd_soc_dapm_adc] = 10, + [snd_soc_dapm_out_drv] = 11, + [snd_soc_dapm_hp] = 11, + [snd_soc_dapm_spk] = 11, + [snd_soc_dapm_line] = 11, + [snd_soc_dapm_kcontrol] = 12, + [snd_soc_dapm_post] = 13, }; static int dapm_down_seq[] = { @@ -109,10 +109,10 @@ static int dapm_down_seq[] = { [snd_soc_dapm_dai_in] = 10, [snd_soc_dapm_dai_out] = 10, [snd_soc_dapm_dai_link] = 11, - [snd_soc_dapm_clock_supply] = 12, - [snd_soc_dapm_regulator_supply] = 12, [snd_soc_dapm_supply] = 12, - [snd_soc_dapm_post] = 13, + [snd_soc_dapm_clock_supply] = 13, + [snd_soc_dapm_regulator_supply] = 13, + [snd_soc_dapm_post] = 14, }; static void pop_wait(u32 pop_time) -- 1.8.4.rc3

11 years, 9 months

[PATCH 1/2] regmap: Simplify the initiation of async I/O

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> Rather than passing a flag around through the entire call stack store it in the regmap struct and read it when required. This minimises the visibility of the feature through the API, minimising the code updates needed to use it more widely. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- drivers/base/regmap/internal.h | 3 ++- drivers/base/regmap/regcache.c | 3 +-- drivers/base/regmap/regmap.c | 19 +++++++++++-------- 3 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/base/regmap/internal.h b/drivers/base/regmap/internal.h index 63c22bc..33414b1 100644 --- a/drivers/base/regmap/internal.h +++ b/drivers/base/regmap/internal.h @@ -63,6 +63,7 @@ struct regmap { void *bus_context; const char *name; + bool async; spinlock_t async_lock; wait_queue_head_t async_waitq; struct list_head async_list; @@ -221,7 +222,7 @@ bool regcache_set_val(struct regmap *map, void *base, unsigned int idx, int regcache_lookup_reg(struct regmap *map, unsigned int reg); int _regmap_raw_write(struct regmap *map, unsigned int reg, - const void *val, size_t val_len, bool async); + const void *val, size_t val_len); void regmap_async_complete_cb(struct regmap_async *async, int ret); diff --git a/drivers/base/regmap/regcache.c b/drivers/base/regmap/regcache.c index d6c2d69..a36112a 100644 --- a/drivers/base/regmap/regcache.c +++ b/drivers/base/regmap/regcache.c @@ -631,8 +631,7 @@ static int regcache_sync_block_raw_flush(struct regmap *map, const void **data, map->cache_bypass = 1; - ret = _regmap_raw_write(map, base, *data, count * val_bytes, - false); + ret = _regmap_raw_write(map, base, *data, count * val_bytes); map->cache_bypass = 0; diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 4866ae5..6f15519 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1043,7 +1043,7 @@ static int _regmap_select_page(struct regmap *map, unsigned int *reg, } int _regmap_raw_write(struct regmap *map, unsigned int reg, - const void *val, size_t val_len, bool async) + const void *val, size_t val_len) { struct regmap_range_node *range; unsigned long flags; @@ -1095,7 +1095,7 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg, dev_dbg(map->dev, "Writing window %d/%zu\n", win_residue, val_len / map->format.val_bytes); ret = _regmap_raw_write(map, reg, val, win_residue * - map->format.val_bytes, async); + map->format.val_bytes); if (ret != 0) return ret; @@ -1128,7 +1128,7 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg, val = work_val; } - if (async && map->bus->async_write) { + if (map->async && map->bus->async_write) { struct regmap_async *async; trace_regmap_async_write_start(map->dev, reg, val_len); @@ -1275,7 +1275,7 @@ static int _regmap_bus_raw_write(void *context, unsigned int reg, map->work_buf + map->format.reg_bytes + map->format.pad_bytes, - map->format.val_bytes, false); + map->format.val_bytes); } static inline void *_regmap_map_get_context(struct regmap *map) @@ -1367,7 +1367,7 @@ int regmap_raw_write(struct regmap *map, unsigned int reg, map->lock(map->lock_arg); - ret = _regmap_raw_write(map, reg, val, val_len, false); + ret = _regmap_raw_write(map, reg, val, val_len); map->unlock(map->lock_arg); @@ -1516,8 +1516,7 @@ int regmap_bulk_write(struct regmap *map, unsigned int reg, const void *val, return ret; } } else { - ret = _regmap_raw_write(map, reg, wval, val_bytes * val_count, - false); + ret = _regmap_raw_write(map, reg, wval, val_bytes * val_count); } if (val_bytes != 1) @@ -1563,7 +1562,11 @@ int regmap_raw_write_async(struct regmap *map, unsigned int reg, map->lock(map->lock_arg); - ret = _regmap_raw_write(map, reg, val, val_len, true); + map->async = true; + + ret = _regmap_raw_write(map, reg, val, val_len); + + map->async = false; map->unlock(map->lock_arg); -- 1.8.4.rc3

11 years, 9 months

next-thierry boot: 33 pass, 0 fail (v3.12-rc4-4340-g56a7390)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: next-thierry Git describe: v3.12-rc4-4340-g56a7390 Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 34.6 sec omap3-beagle-xm PASS: 0 min 51.1 sec am335x-bone PASS: 0 min 26.1 sec omap3-tobi,3530overo PASS: 0 min 21.2 sec omap4-panda PASS: 1 min 6.0 sec omap4-panda-es PASS: 1 min 6.3 sec omap3-tobi,3730storm PASS: 0 min 20.4 sec omap3-beagle PASS: 0 min 50.3 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.2 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.2 sec imx6q-wandboard PASS: 0 min 14.8 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.0 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.7 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 25.1 sec tegra30-beaver PASS: 0 min 14.2 sec am335x-boneblack PASS: 0 min 39.4 sec omap3-beagle-xm PASS: 0 min 51.7 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 1.4 sec omap4-panda-es PASS: 1 min 4.0 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.6 sec sun4i-a10-cubieboard PASS: 0 min 13.7 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.6 sec omap3-tobi,3530overo PASS: 0 min 19.7 sec am335x-bone PASS: 0 min 33.2 sec imx6q-wandboard PASS: 0 min 16.8 sec omap3-tobi,3730storm PASS: 0 min 19.4 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.9 sec omap3-beagle PASS: 0 min 48.2 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 31.4 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec

11 years, 9 months

queue boot: 25 pass, 2 fail (v3.11.4-49-g4f309b3)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: queue Git describe: v3.11.4-49-g4f309b3 Failed boot tests (console logs at the end) =========================================== armada-370-mirabox: FAIL: multi_v7_defconfig armada-xp-openblocks-ax3-4: FAIL: multi_v7_defconfig Full Report =========== omap2plus_defconfig ------------------- omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.5 sec omap3-tobi,3530overo PASS: 0 min 42.7 sec omap4-panda PASS: 1 min 7.7 sec omap4-panda-es PASS: 1 min 7.6 sec omap3-tobi,3730storm PASS: 0 min 42.4 sec omap3-beagle PASS: 1 min 1.2 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 15.4 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 15.8 sec imx6dl-wandboard,wand-solo PASS: 0 min 15.6 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.8 sec armada-370-mirabox PASS: 0 min 18.2 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.1 sec multi_v7_defconfig ------------------ tegra30-beaver PASS: 0 min 14.3 sec omap3-beagle-xm PASS: 0 min 51.9 sec armada-370-mirabox FAIL: 0 min 19.6 sec omap4-panda PASS: 1 min 0.1 sec armada-xp-openblocks-ax3-4 FAIL: 0 min 22.4 sec sun4i-a10-cubieboard PASS: 0 min 13.8 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.2 sec omap3-tobi,3530overo PASS: 0 min 41.1 sec am335x-bone PASS: 0 min 33.6 sec omap4-panda-es PASS: 1 min 5.3 sec omap3-tobi,3730storm PASS: 0 min 43.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.3 sec omap3-beagle PASS: 0 min 49.9 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.4 sec Console logs for failures ========================= multi_v7_defconfig ------------------ armada-370-mirabox: FAIL: last 24 lines of boot log: ---------------------------------------------------- [ 139.326195] usbhid: USB HID core driver [ 139.330220] TCP: cubic registered [ 139.333912] NET: Registered protocol family 10 [ 139.338821] sit: IPv6 over IPv4 tunneling driver [ 139.343881] Key type dns_resolver registered [ 139.348214] VFP support v0.3: implementor 56 architecture 2 part 20 variant 9 rev 6 [ 139.355936] Registering SWP/SWPB emulation handler [ 139.361297] ../../drivers/rtc/hctosys.c: unable to open rtc device (rtc0) [ 139.368636] VFS: Cannot open root device "(null)" or unknown-block(0,0): error -6 [ 139.376134] Please append a correct "root=" boot option; here are the available partitions: [ 139.384522] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) [ 139.392803] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.11.4-00049-g4f309b3 #1 [ 139.400067] [<c00157bc>] (unwind_backtrace+0x0/0xf4) from [<c001168c>] (show_stack+0x10/0x14) [ 139.408613] [<c001168c>] (show_stack+0x10/0x14) from [<c04b12d0>] (dump_stack+0x84/0x94) [ 139.416729] [<c04b12d0>] (dump_stack+0x84/0x94) from [<c04ae7f4>] (panic+0xa0/0x1f0) [ 139.424491] [<c04ae7f4>] (panic+0xa0/0x1f0) from [<c06470ec>] (mount_block_root+0x1a0/0x230) [ 139.432947] [<c06470ec>] (mount_block_root+0x1a0/0x230) from [<c0647284>] (mount_root+0x108/0x110) [ 139.441923] [<c0647284>] (mount_root+0x108/0x110) from [<c06473e4>] (prepare_namespace+0x158/0x1a0) [ 139.450997] [<c06473e4>] (prepare_namespace+0x158/0x1a0) from [<c0646da8>] (kernel_init_freeable+0x1c8/0x1d8) [ 139.460932] [<c0646da8>] (kernel_init_freeable+0x1c8/0x1d8) from [<c04ac350>] (kernel_init+0x8/0x158) [ 139.470172] [<c04ac350>] (kernel_init+0x8/0x158) from [<c000e2b8>] (ret_from_fork+0x14/0x3c) # PYBOOT: Exception: kernel: ERROR: failed to boot: Kernel panic # PYBOOT: Time: 19.55 seconds. # PYBOOT: Result: FAIL armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ [ 159.417980] [<c001168c>] (show_stack+0x10/0x14) from [<c04b12d0>] (dump_stack+0x84/0x94) [ 159.426100] [<c04b12d0>] (dump_stack+0x84/0x94) from [<c04ae7f4>] (panic+0xa0/0x1f0) [ 159.433867] [<c04ae7f4>] (panic+0xa0/0x1f0) from [<c06470ec>] (mount_block_root+0x1a0/0x230) [ 159.442329] [<c06470ec>] (mount_block_root+0x1a0/0x230) from [<c0647284>] (mount_root+0x108/0x110) [ 159.451314] [<c0647284>] (mount_root+0x108/0x110) from [<c06473e4>] (prepare_namespace+0x158/0x1a0) [ 159.460390] [<c06473e4>] (prepare_namespace+0x158/0x1a0) from [<c0646da8>] (kernel_init_freeable+0x1c8/0x1d8) [ 159.470333] [<c0646da8>] (kernel_init_freeable+0x1c8/0x1d8) from [<c04ac350>] (kernel_init+0x8/0x158) [ 159.479580] [<c04ac350>] (kernel_init+0x8/0x158) from [<c000e2b8>] (ret_from_fork+0x14/0x3c) [ 159.488041] CPU1: stopping [ 159.490758] CPU: 1 PID: 0 Comm: swapper/1 Not tainted 3.11.4-00049-g4f309b3 #1 [ 159.498008] [<c00157bc>] (unwind_backtrace+0x0/0xf4) from [<c001168c>] (show_stack+0x10/0x14) [ 159.506557] [<c001168c>] (show_stack+0x10/0x14) from [<c04b12d0>] (dump_stack+0x84/0x94) [ 159.514671] [<c04b12d0>] (dump_stack+0x84/0x94) from [<c0013b74>] (handle_IPI+0x10c/0x134) [ 159.522960] [<c0013b74>] (handle_IPI+0x10c/0x134) from [<c00086a4>] (armada_370_xp_handle_irq+0x90/0xa8) [ 159.532467] [<c00086a4>] (armada_370_xp_handle_irq+0x90/0xa8) from [<c0012180>] (__irq_svc+0x40/0x50) [ 159.541709] Exception stack(0xee873fa0 to 0xee873fe8) [ 159.546775] 3fa0: c22dc920 00000000 000000e6 000000e6 c074e175 c06c44c0 c04bb204 ee872000 [ 159.554975] 3fc0: c074e175 ee872000 ee872000 c06c4448 00000000 ee873fe8 c000f430 c00797d0 [ 159.563172] 3fe0: 60000113 ffffffff [ 159.566677] [<c0012180>] (__irq_svc+0x40/0x50) from [<c00797d0>] (cpu_startup_entry+0x100/0x144) [ 159.575487] [<c00797d0>] (cpu_startup_entry+0x100/0x144) from [<000088a4>] (0x88a4) # PYBOOT: Exception: kernel: ERROR: failed to boot: Kernel panic # PYBOOT: Time: 22.36 seconds. # PYBOOT: Result: FAIL

11 years, 9 months

linus/master boot: 33 pass, 0 fail (v3.12-rc4-29-g0e7a3ed)

by Kevin Hilman build bot

Automated DT boot report for various ARM defconfigs. Boot test simply checks if kernel can boot to initramfs with busybox and run some basic commands (e.g. 'cat /proc/cpuinfo'). Tree/Branch: linus/master Git describe: v3.12-rc4-29-g0e7a3ed Commit: 0e7a3ed04f Merge branch 'perf-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip Full Report =========== arm-tegra_defconfig ------------------- tegra30-beaver PASS: 0 min 17.1 sec arm-omap2plus_defconfig ----------------------- am335x-boneblack PASS: 0 min 29.9 sec omap3-beagle-xm PASS: 0 min 51.9 sec am335x-bone PASS: 0 min 26.1 sec omap3-tobi,3530overo PASS: 0 min 21.5 sec omap4-panda PASS: 1 min 5.8 sec omap4-panda-es PASS: 1 min 12.3 sec omap3-tobi,3730storm PASS: 0 min 23.2 sec omap3-beagle PASS: 0 min 54.6 sec arm-imx_v6_v7_defconfig ----------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.2 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.1 sec imx6q-wandboard PASS: 0 min 14.8 sec arm-multi_v7_defconfig ---------------------- ste-snowball PASS: 0 min 28.1 sec tegra30-beaver PASS: 0 min 16.7 sec am335x-boneblack PASS: 0 min 34.5 sec omap3-beagle-xm PASS: 0 min 52.0 sec armada-370-mirabox PASS: 0 min 20.2 sec omap4-panda PASS: 0 min 59.1 sec omap4-panda-es PASS: 1 min 4.5 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.6 sec sun4i-a10-cubieboard PASS: 0 min 11.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.4 sec omap3-tobi,3530overo PASS: 0 min 19.7 sec am335x-bone PASS: 0 min 33.2 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 22.5 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.6 sec omap3-beagle PASS: 0 min 50.9 sec arm-u8500_defconfig ------------------- ste-snowball PASS: 0 min 36.5 sec arm-exynos_defconfig -------------------- exynos5250-arndale PASS: 0 min 30.0 sec arm-mvebu_defconfig ------------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.0 sec armada-370-mirabox PASS: 0 min 19.8 sec arm-sama5_defconfig ------------------- sama5d35ek PASS: 0 min 18.3 sec

11 years, 9 months

Re: [PATCH 1/2] ARM: mcpm: fix big endian issue in mcpm startup code

by Dave Martin

On Mon, Oct 07, 2013 at 09:37:19PM -0700, Victor Kamensky wrote: > In big endian mode mcpm_entry_point is first function > that called on secondaries CPU. First it should switch > CPU into big endian code. > > Signed-off-by: Victor Kamensky <victor.kamensky(a)linaro.org> Providing Nico's also OK with it, I don't see a problem with this. Minor cosmetic nit: please line up the ) after be with the others. Not the end of the world, though. Reviewed-by: Dave Martin <Dave.Martin(a)arm.com> Cheers ---Dave > --- > arch/arm/common/mcpm_head.S | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/common/mcpm_head.S b/arch/arm/common/mcpm_head.S > index 39c96df..4f88f5e 100644 > --- a/arch/arm/common/mcpm_head.S > +++ b/arch/arm/common/mcpm_head.S > @@ -15,6 +15,7 @@ > > #include <linux/linkage.h> > #include <asm/mcpm.h> > +#include <asm/assembler.h> > > #include "vlock.h" > > @@ -47,6 +48,7 @@ > > ENTRY(mcpm_entry_point) > > + ARM_BE8(setend be) > THUMB( adr r12, BSYM(1f) ) > THUMB( bx r12 ) > THUMB( .thumb ) > -- > 1.8.1.4 > > > _______________________________________________ > linaro-kernel mailing list > linaro-kernel(a)lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-kernel

11 years, 9 months

[PATCH] regmap: Don't generate gather writes for single register raw writes

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> Since it is quite common for single register raw or async writes to be generated by rbtree cache syncs or firmware downloads and essentially all hardware will be faster with only a single transfer optimise this case by copying single values into the internal scratch buffer before sending. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- drivers/base/regmap/regmap.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c index 5754513..4866ae5 100644 --- a/drivers/base/regmap/regmap.c +++ b/drivers/base/regmap/regmap.c @@ -1118,6 +1118,16 @@ int _regmap_raw_write(struct regmap *map, unsigned int reg, u8[0] |= map->write_flag_mask; + /* + * Essentially all I/O mechanisms will be faster with a single + * buffer to write. Since register syncs often generate raw + * writes of single registers optimise that case. + */ + if (val != work_val && val_len == map->format.val_bytes) { + memcpy(work_val, val, map->format.val_bytes); + val = work_val; + } + if (async && map->bus->async_write) { struct regmap_async *async; -- 1.8.4.rc3

11 years, 9 months

[PATCH] ARM: OMAP4/highbank: Flush L2 cache before disabling

by Taras Kondratiuk

Kexec disables outer cache before jumping to reboot code, but it doesn't flush it explicitly. Flush is done implicitly inside of l2x0_disable(). But some SoC's override default .disable handler and don't flush cache. This may lead to a corrupted memory during Kexec reboot on these platforms. This patch adds cache flush inside of OMAP4 and Highbank outer_cache.disable() handlers to make it consistent with default l2x0_disable(). Also it removes redundant outer_flush_all() call just before outer_disable(). Acked-by: Rob Herring <rob.herring(a)calxeda.com> Acked-by: Santosh Shilimkar <santosh.shilimkar(a)ti.com> Signed-off-by: Taras Kondratiuk <taras.kondratiuk(a)linaro.org> --- Based on v3.12-rc3 RFC v2: https://patchwork.kernel.org/patch/2990231/ Make the fix specific to platforms that don't use l2x0_disable(). RFC v1: https://patchwork.kernel.org/patch/2974431/ --- Cc: Will Deacon <will.deacon(a)arm.com> Cc: Russell King <linux(a)arm.linux.org.uk> Cc: Rob Herring <rob.herring(a)calxeda.com> Cc: Santosh Shilimkar <santosh.shilimkar(a)ti.com> Cc: linaro-kernel(a)lists.linaro.org Cc: linux-arm-kernel(a)lists.infradead.org Cc: linux-omap(a)vger.kernel.org --- arch/arm/mach-highbank/highbank.c | 1 + arch/arm/mach-highbank/pm.c | 1 - arch/arm/mach-omap2/omap4-common.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-highbank/highbank.c b/arch/arm/mach-highbank/highbank.c index 8e63ccd..22e6f34 100644 --- a/arch/arm/mach-highbank/highbank.c +++ b/arch/arm/mach-highbank/highbank.c @@ -63,6 +63,7 @@ void highbank_set_cpu_jump(int cpu, void *jump_addr) static void highbank_l2x0_disable(void) { + outer_flush_all(); /* Disable PL310 L2 Cache controller */ highbank_smc1(0x102, 0x0); } diff --git a/arch/arm/mach-highbank/pm.c b/arch/arm/mach-highbank/pm.c index 04eddb4..9a5b8a7 100644 --- a/arch/arm/mach-highbank/pm.c +++ b/arch/arm/mach-highbank/pm.c @@ -28,7 +28,6 @@ static int highbank_suspend_finish(unsigned long val) { - outer_flush_all(); outer_disable(); highbank_set_pwr_suspend(); diff --git a/arch/arm/mach-omap2/omap4-common.c b/arch/arm/mach-omap2/omap4-common.c index 2840d1e..f6ccab61 100644 --- a/arch/arm/mach-omap2/omap4-common.c +++ b/arch/arm/mach-omap2/omap4-common.c @@ -163,6 +163,7 @@ void __iomem *omap4_get_l2cache_base(void) static void omap4_l2x0_disable(void) { + outer_flush_all(); /* Disable PL310 L2 Cache controller */ omap_smc1(0x102, 0x0); } -- 1.7.9.5

11 years, 9 months

[PATCH v3 0/4] perf: parse the dwarf backtrace info from .debug_frame section

by Jean Pihet

On ARM the debug info is not present in the .eh_frame sections but in .debug_frame instead, in dwarf format. This patch set uses libunwind to load and parse the dwarf debug info from the .debug_frame section if no .eh_frame_hdr section is found; also it sets the hooks in the perf_regs and libunwind code for ARMv7. Dependencies: . if present, libunwind >= 1.1 is needed to prevent a segfault when parsing the dwarf info, . libunwind needs to be configured with --enable-debug-frame. Note: --enable-debug-frame is automatically selected on ARM. The generated perf binary has been tested on ARMv7 (OMAP4, Marvell Armada XP) and x86_64, using the following commands: perf record -g [dwarf] -- <binary> perf report --sort symbol --call-graph --stdio Jean Pihet (2): perf tools: Check libunwind for availability of dwarf parsing feature perf: parse the .debug_frame section in case .eh_frame is not present Will Deacon (2): ARM: perf: add support for perf registers API ARM: perf: wire up perf_regs and unwind support for ARM arch/arm/Kconfig | 2 + arch/arm/include/uapi/asm/Kbuild | 1 + arch/arm/include/uapi/asm/perf_regs.h | 23 ++++++++++ arch/arm/kernel/Makefile | 1 + arch/arm/kernel/perf_regs.c | 30 +++++++++++++ tools/perf/arch/arm/Makefile | 3 ++ tools/perf/arch/arm/include/perf_regs.h | 54 ++++++++++++++++++++++++ tools/perf/arch/arm/util/unwind.c | 48 +++++++++++++++++++++ tools/perf/config/Makefile | 13 ++++-- tools/perf/config/feature-tests.mak | 21 ++++++++- tools/perf/util/unwind.c | 75 ++++++++++++++++++++++++++------- 11 files changed, 251 insertions(+), 20 deletions(-) create mode 100644 arch/arm/include/uapi/asm/perf_regs.h create mode 100644 arch/arm/kernel/perf_regs.c create mode 100644 tools/perf/arch/arm/include/perf_regs.h create mode 100644 tools/perf/arch/arm/util/unwind.c -- 1.7.11.7

11 years, 9 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel