linaro-kernel

linaro-kernel@lists.linaro.org

10095 discussions

mainline boot: 48 pass, 0 fail (v3.14-rc8-9-gfce7fc7)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc8-9-gfce7fc7 Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm 0 min 15.3 sec: PASS (with 1 Warnings) legacy,da850evm 0 min 14.3 sec: PASS (with 1 Warnings) omap2plus_defconfig ------------------- legacy,3730xm 0 min 53.6 sec: PASS am335x-boneblack 0 min 24.5 sec: PASS omap3-beagle-xm 1 min 1.7 sec: PASS legacy,3530beagle 0 min 36.2 sec: PASS (with 1 Warnings) omap4-panda 1 min 4.4 sec: PASS omap3-overo-tobi 0 min 26.2 sec: PASS (with 1 Warnings) am335x-bone 0 min 27.6 sec: PASS omap3-overo-storm-tobi 0 min 22.4 sec: PASS omap5-uevm 1 min 7.3 sec: PASS (with 1 Warnings) omap4-panda-es 1 min 1.9 sec: PASS legacy,3730storm 0 min 24.5 sec: PASS legacy,3530overo 0 min 21.4 sec: PASS (with 1 Warnings) multi_lpae_defconfig -------------------- omap5-uevm 1 min 46.4 sec: PASS (with 1 Warnings) sun7i-a20-cubieboard2 0 min 14.4 sec: PASS tegra_defconfig --------------- tegra30-beaver 0 min 17.2 sec: PASS imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual 0 min 18.8 sec: PASS imx6dl-wandboard,wand-solo 0 min 18.3 sec: PASS imx6q-wandboard 0 min 17.2 sec: PASS msm_defconfig ------------- qcom-apq8074-dragonboard 0 min 16.3 sec: PASS bcm_defconfig ------------- bcm28155-ap 0 min 23.1 sec: PASS sunxi_defconfig --------------- sun7i-a20-cubieboard2 0 min 12.9 sec: PASS sun4i-a10-cubieboard 0 min 12.8 sec: PASS exynos_defconfig ---------------- exynos5250-arndale 0 min 29.5 sec: PASS multi_v7_defconfig ------------------ ste-snowball 1 min 17.0 sec: PASS tegra30-beaver 0 min 17.0 sec: PASS am335x-boneblack 0 min 23.6 sec: PASS omap3-beagle-xm 0 min 51.3 sec: PASS sun7i-a20-cubieboard2 0 min 14.2 sec: PASS armada-370-mirabox 0 min 22.1 sec: PASS omap4-panda 1 min 5.6 sec: PASS armada-xp-openblocks-ax3-4 0 min 24.8 sec: PASS sun4i-a10-cubieboard 0 min 14.3 sec: PASS bcm28155-ap 0 min 27.3 sec: PASS omap3-overo-tobi 0 min 21.9 sec: PASS (with 1 Warnings) imx6dl-wandboard,wand-solo 0 min 17.7 sec: PASS am335x-bone 0 min 26.2 sec: PASS omap3-overo-storm-tobi 0 min 22.2 sec: PASS omap5-uevm 1 min 51.1 sec: PASS (with 1 Warnings) imx6q-wandboard 0 min 17.8 sec: PASS omap4-panda-es 1 min 19.1 sec: PASS imx6dl-wandboard,wand-dual 0 min 18.1 sec: PASS u8500_defconfig --------------- ste-snowball 0 min 33.3 sec: PASS sama5_defconfig --------------- sama5d35ek 0 min 17.4 sec: PASS davinci_all_defconfig --------------------- legacy,dm365evm 0 min 17.4 sec: PASS mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 0 min 23.7 sec: PASS armada-370-mirabox 0 min 20.3 sec: PASS

11 years, 3 months

mainline boot: 48 pass, 0 fail (v3.14-rc8-7-g632b06a)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc8-7-g632b06a Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm 0 min 15.4 sec: PASS (with 1 Warnings) legacy,da850evm 0 min 14.4 sec: PASS (with 1 Warnings) omap2plus_defconfig ------------------- legacy,3730xm 0 min 50.8 sec: PASS am335x-boneblack 0 min 25.5 sec: PASS omap3-beagle-xm 1 min 6.9 sec: PASS legacy,3530beagle 0 min 35.5 sec: PASS (with 1 Warnings) omap4-panda 1 min 6.9 sec: PASS omap3-overo-tobi 0 min 22.9 sec: PASS (with 1 Warnings) am335x-bone 0 min 27.6 sec: PASS omap3-overo-storm-tobi 0 min 25.3 sec: PASS omap5-uevm 1 min 6.8 sec: PASS (with 1 Warnings) omap4-panda-es 1 min 6.6 sec: PASS legacy,3730storm 0 min 24.0 sec: PASS legacy,3530overo 0 min 21.2 sec: PASS (with 1 Warnings) multi_lpae_defconfig -------------------- omap5-uevm 1 min 45.3 sec: PASS (with 1 Warnings) sun7i-a20-cubieboard2 0 min 14.5 sec: PASS tegra_defconfig --------------- tegra30-beaver 0 min 17.1 sec: PASS imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual 0 min 18.9 sec: PASS imx6dl-wandboard,wand-solo 0 min 18.9 sec: PASS imx6q-wandboard 0 min 17.4 sec: PASS msm_defconfig ------------- qcom-apq8074-dragonboard 0 min 15.0 sec: PASS bcm_defconfig ------------- bcm28155-ap 0 min 23.0 sec: PASS sunxi_defconfig --------------- sun7i-a20-cubieboard2 0 min 12.9 sec: PASS sun4i-a10-cubieboard 0 min 17.3 sec: PASS exynos_defconfig ---------------- exynos5250-arndale 0 min 29.7 sec: PASS multi_v7_defconfig ------------------ ste-snowball 1 min 17.3 sec: PASS tegra30-beaver 0 min 20.1 sec: PASS am335x-boneblack 0 min 23.3 sec: PASS omap3-beagle-xm 0 min 50.0 sec: PASS sun7i-a20-cubieboard2 0 min 14.4 sec: PASS armada-370-mirabox 0 min 22.0 sec: PASS omap4-panda 0 min 57.7 sec: PASS armada-xp-openblocks-ax3-4 0 min 24.9 sec: PASS sun4i-a10-cubieboard 0 min 14.3 sec: PASS bcm28155-ap 0 min 26.4 sec: PASS omap3-overo-tobi 0 min 21.6 sec: PASS (with 1 Warnings) imx6dl-wandboard,wand-solo 0 min 18.1 sec: PASS am335x-bone 0 min 26.1 sec: PASS omap3-overo-storm-tobi 0 min 25.0 sec: PASS omap5-uevm 1 min 43.5 sec: PASS (with 1 Warnings) imx6q-wandboard 0 min 17.6 sec: PASS omap4-panda-es 0 min 56.1 sec: PASS imx6dl-wandboard,wand-dual 0 min 18.2 sec: PASS u8500_defconfig --------------- ste-snowball 0 min 33.3 sec: PASS sama5_defconfig --------------- sama5d35ek 0 min 17.5 sec: PASS davinci_all_defconfig --------------------- legacy,dm365evm 0 min 16.8 sec: PASS mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 0 min 22.2 sec: PASS armada-370-mirabox 0 min 20.4 sec: PASS

11 years, 3 months

Re: [PATCH 09/19] arm: dts: add omap4 CPU thermal data

by Alex Shi

On 03/25/2014 08:30 PM, Mark Brown wrote: > On Tue, Mar 25, 2014 at 06:49:22PM +0800, Alex Shi wrote: >> From: Eduardo Valentin <eduardo.valentin(a)ti.com> > > Dropping a bunch of irrelevant people/lists. > >> This patch changes a dtsi file to contain the thermal data >> for MPU domain on OMAP4 and later SoCs. This data will >> enable the passive cooling with CPUfreq cooling device >> at 100C and the system will do a thermal shutdown at 125C. >> >> This thermal data can be reused across TI SoC devices. > > We probably shouldn't in general have DTS patches backported to LSK > unless we're using them for testing - they aren't needed by people using > the feature and may interfere with downstream users working on these > boards who have their own modifications. Of course this is OMAP4 which > is used on Panda so it might make sense since that's already part of our > test coverage... > Yes, the testing show it is ok now. But you are right. it's better not have this change when think of downstream users. I will remove all dts patches. -- Thanks Alex

11 years, 3 months

[PATCH] spi: Do not require a completion

by Mark Brown

From: Mark Brown <broonie(a)linaro.org> There is no real reason why we require transfers to have a completion and the only user of the completion now checks to see if one has been provided before using it so stop enforcing this. This makes it more convenient for drivers to chain multiple asynchronous transfers together. Signed-off-by: Mark Brown <broonie(a)linaro.org> --- drivers/spi/spi.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 26b331d27c35..121c43b5a8e8 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1812,8 +1812,6 @@ static int __spi_validate(struct spi_device *spi, struct spi_message *message) if (list_empty(&message->transfers)) return -EINVAL; - if (!message->complete) - return -EINVAL; /* Half-duplex links include original MicroWire, and ones with * only one data pin like SPI_3WIRE (switches direction) or where -- 1.9.1

11 years, 3 months

[PATCH 0/3] Fixes for kprobes test issues

by Jon Medhurst

This small series fixes issues found with the kprobes tests during testing of Dave Long's latest ARM uprobe patches [1]. Whilst these fixes are based on top of that series all the bugs are already present in the kernel tree. [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-March/238862.html Contents: Jon Medhurst (3): ARM: kprobes: Prevent known test failures stopping other tests running ARM: kprobes: Disallow instructions with PC and register specified shift ARM: kprobes: Fix test code compilation errors for ARMv4 targets arch/arm/kernel/kprobes-test-arm.c | 33 +++++++++++++++++++++------------ arch/arm/kernel/kprobes-test.c | 10 ++++++++++ arch/arm/kernel/probes-arm.c | 6 +++---

11 years, 3 months

mainline boot: 45 pass, 3 fail (v3.14-rc8)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc8 Failed boot tests (console logs at the end) =========================================== imx6dl-wandboard,wand-dual: FAIL: imx_v6_v7_defconfig tegra30-beaver: FAIL: multi_v7_defconfig imx6dl-wandboard,wand-dual: FAIL: multi_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.4 sec legacy,da850evm PASS: 0 min 14.4 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 53.3 sec am335x-boneblack PASS: 0 min 25.9 sec omap3-beagle-xm PASS: 1 min 0.7 sec legacy,3530beagle PASS: 0 min 34.4 sec omap4-panda PASS: 1 min 6.2 sec omap3-overo-tobi PASS: 0 min 23.4 sec am335x-bone PASS: 0 min 27.5 sec omap3-overo-storm-tobi PASS: 0 min 22.5 sec omap5-uevm PASS: 1 min 2.1 sec omap4-panda-es PASS: 1 min 10.0 sec legacy,3730storm PASS: 0 min 23.7 sec legacy,3530overo PASS: 0 min 21.6 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 43.9 sec sun7i-a20-cubieboard2 PASS: 0 min 14.4 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 20.6 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual FAIL: 0 min 31.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.7 sec imx6q-wandboard PASS: 0 min 17.1 sec msm_defconfig ------------- qcom-apq8074-dragonboard PASS: 1 min 9.5 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.8 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.9 sec sun4i-a10-cubieboard PASS: 0 min 12.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 50.5 sec multi_v7_defconfig ------------------ ste-snowball PASS: 1 min 18.1 sec tegra30-beaver FAIL: 0 min 31.4 sec am335x-boneblack PASS: 0 min 23.7 sec omap3-beagle-xm PASS: 0 min 48.5 sec sun7i-a20-cubieboard2 PASS: 0 min 14.4 sec armada-370-mirabox PASS: 0 min 22.1 sec omap4-panda PASS: 0 min 54.2 sec armada-xp-openblocks-ax3-4 PASS: 0 min 24.8 sec sun4i-a10-cubieboard PASS: 0 min 17.2 sec bcm28155-ap PASS: 1 min 4.2 sec omap3-overo-tobi PASS: 0 min 22.0 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.8 sec am335x-bone PASS: 0 min 26.2 sec omap3-overo-storm-tobi PASS: 0 min 21.2 sec omap5-uevm PASS: 1 min 49.6 sec imx6q-wandboard PASS: 0 min 17.4 sec omap4-panda-es PASS: 0 min 59.3 sec imx6dl-wandboard,wand-dual FAIL: 0 min 31.4 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 31.4 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.1 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.9 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.2 sec armada-370-mirabox PASS: 0 min 20.1 sec Console logs for failures ========================= imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual: FAIL: last 80 lines of boot log: ------------------------------------------------------------ Connected to wand-dual console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-dual console)> hardreset (user:khilman) Reboot wand-dual Reboot: wand-dual ; phidget 2 1 : ['off'] Reboot: wand-dual ; phidget 2 1 : off, sleep, on ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL multi_v7_defconfig ------------------ tegra30-beaver: FAIL: last 80 lines of boot log: ------------------------------------------------ Connected to beaver console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(beaver console)> hardreset (user:khilman) Reboot beaver Reboot: beaver ; ip9258 1 2 : off, sleep, on U-Boot SPL 2013.07-rc3-00036-gd84eb85 (Aug 07 2013 - 18:31:58) U-Boot 2013.07-rc3-00036-gd84eb85 (Aug 07 2013 - 18:31:58) TEGRA30 Board: NVIDIA Beaver I2C: ready DRAM: 2 GiB MMC: Tegra SD/MMC: 0, Tegra SD/MMC: 1 In: serial Out: se 0 Tegra30 (Beaver) # ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL imx6dl-wandboard,wand-dual: FAIL: last 80 lines of boot log: ------------------------------------------------------------ Connected to wand-dual console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-dual console)> hardreset (user:khilman) Reboot wand-dual Reboot: wand-dual ; phidget 2 1 : off, sleep, on ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL

11 years, 3 months

[PATCH] tick: fix spelling mistake in tick_handle_periodic()

by Viresh Kumar

One of the comments in tick_handle_periodic() had 'when' instead of 'which' (My guess :)). Fix it. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- kernel/time/tick-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 20b2fe3..791a3a2 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -118,7 +118,7 @@ void tick_handle_periodic(struct clock_event_device *dev) * to be sure we're using a real hardware clocksource. * Otherwise we could get trapped in an infinite * loop, as the tick_periodic() increments jiffies, - * when then will increment time, posibly causing + * which then will increment time, posibly causing * the loop to trigger again and again. */ if (timekeeping_valid_for_hres()) -- 1.7.12.rc2.18.g61b472e

11 years, 3 months

[PATCH V2] tick: fix spelling mistake in tick_handle_periodic()

by Viresh Kumar

One of the comments in tick_handle_periodic() had 'when' instead of 'which' (My guess :)). Fix it. Also fix spelling mistake in 'Possible'. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- V1->V2: Fix spelling mistake of possible as well. kernel/time/tick-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 20b2fe3..0fec634 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -118,7 +118,7 @@ void tick_handle_periodic(struct clock_event_device *dev) * to be sure we're using a real hardware clocksource. * Otherwise we could get trapped in an infinite * loop, as the tick_periodic() increments jiffies, - * when then will increment time, posibly causing + * which then will increment time, possibly causing * the loop to trigger again and again. */ if (timekeeping_valid_for_hres()) -- 1.7.12.rc2.18.g61b472e

11 years, 3 months

next boot: 35 pass, 9 fail (next-20140325)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: next Git describe: next-20140325 Failed boot tests (console logs at the end) =========================================== sun7i-a20-cubieboard2: FAIL: multi_lpae_defconfig imx6dl-wandboard,wand-dual: FAIL: imx_v6_v7_defconfig imx6dl-wandboard,wand-solo: FAIL: imx_v6_v7_defconfig imx6q-wandboard: FAIL: imx_v6_v7_defconfig ste-snowball: FAIL: multi_v7_defconfig sun7i-a20-cubieboard2: FAIL: multi_v7_defconfig imx6dl-wandboard,wand-solo: FAIL: multi_v7_defconfig imx6q-wandboard: FAIL: multi_v7_defconfig imx6dl-wandboard,wand-dual: FAIL: multi_v7_defconfig Full Report =========== omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 53.5 sec am335x-boneblack PASS: 0 min 25.8 sec omap3-beagle-xm PASS: 1 min 0.9 sec legacy,3530beagle PASS: 0 min 36.1 sec omap4-panda PASS: 1 min 8.5 sec omap3-overo-tobi PASS: 0 min 23.7 sec am335x-bone PASS: 0 min 27.6 sec omap3-overo-storm-tobi PASS: 0 min 25.1 sec omap5-uevm PASS: 1 min 3.0 sec omap4-panda-es PASS: 1 min 3.3 sec legacy,3730storm PASS: 0 min 23.5 sec legacy,3530overo PASS: 0 min 21.7 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 40.8 sec sun7i-a20-cubieboard2 FAIL: 0 min 19.8 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.3 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual FAIL: 0 min 31.4 sec imx6dl-wandboard,wand-solo FAIL: 0 min 22.6 sec imx6q-wandboard FAIL: 0 min 21.2 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 23.0 sec sun4i-a10-cubieboard PASS: 0 min 17.4 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.8 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 52.7 sec multi_v7_defconfig ------------------ qcom-apq8074-dragonboard PASS: 1 min 9.6 sec ste-snowball FAIL: 0 min 33.5 sec tegra30-beaver PASS: 0 min 19.9 sec am335x-boneblack PASS: 0 min 23.9 sec omap3-beagle-xm PASS: 0 min 55.7 sec sun7i-a20-cubieboard2 FAIL: 0 min 19.8 sec armada-370-mirabox PASS: 0 min 22.2 sec omap4-panda PASS: 0 min 51.0 sec armada-xp-openblocks-ax3-4 PASS: 0 min 25.2 sec sun4i-a10-cubieboard PASS: 0 min 14.6 sec bcm28155-ap PASS: 1 min 15.0 sec omap3-overo-tobi PASS: 0 min 22.0 sec imx6dl-wandboard,wand-solo FAIL: 0 min 22.4 sec am335x-bone PASS: 0 min 31.6 sec omap3-overo-storm-tobi PASS: 0 min 24.0 sec omap5-uevm PASS: 1 min 43.8 sec imx6q-wandboard FAIL: 0 min 31.5 sec omap4-panda-es PASS: 0 min 54.8 sec imx6dl-wandboard,wand-dual FAIL: 0 min 31.4 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 30.5 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 17.5 sec Console logs for failures ========================= multi_lpae_defconfig -------------------- sun7i-a20-cubieboard2: FAIL: last 80 lines of boot log: ------------------------------------------------------- setenv ethaddr 22:71:81:DA:53:EA sun7i# setenv bootargs console=ttyS0,115200 debug earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 setenv bootargs console=ttyS0,115200 debug earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 sun7i# setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' sun7i# setenv initrd_high 0xffffffff setenv initrd_high 0xffffffff sun7i# if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi sun7i# if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi sun7i# setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no sun7i# dhcp dhcp ENET Speed is 100 Mbps - FULL duplex connection BOOTP broadcast 1 DHCP client bound to address 192.168.1.153 sun7i# setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 sun7i# if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi sun7i# tftp 0x40008000 192.168.1.2:tmp/cubie2-3SPYNb/zImage tftp 0x40008000 192.168.1.2:tmp/cubie2-3SPYNb/zImage Using emac device TFTP from server 192.168.1.2; our IP address is 192.168.1.153 Filename 'tmp/cubie2-3SPYNb/zImage'. Load address: 0x40008000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ###################################################### 2.7 MiB/s done Bytes transferred = 4595424 (461ee0 hex) sun7i# tftp 0x42000000 192.168.1.2:buildroot.cpio.gz.uboot tftp 0x42000000 192.168.1.2:buildroot.cpio.gz.uboot Using emac device TFTP from server 192.168.1.2; our IP address is 192.168.1.153 Filename 'buildroot.cpio.gz.uboot'. Load address: 0x42000000 Loading: *############################################ 2.7 MiB/s done Bytes transferred = 642602 (9ce2a hex) sun7i# tftp 0x41000000 192.168.1.2:tmp/cubie2-3SPYNb/sun7i-a20-cubieboard2.dtb tftp 0x41000000 192.168.1.2:tmp/cubie2-3SPYNb/sun7i-a20-cubieboard2.dtb Using emac device TFTP from server 192.168.1.2; our IP address is 192.168.1.153 Filename 'tmp/cubie2-3SPYNb/sun7i-a20-cubieboard2.dtb'. Load address: 0x41000000 Loading: *## 2.5 MiB/s done Bytes transferred = 18209 (4721 hex) sun7i# printenv bootargs printenv bootargs bootargs=console=ttyS0,115200 debug earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 ip=192.168.1.153:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none sun7i# bootz 0x40008000 0x42000000 0x41000000 bootz 0x40008000 0x42000000 0x41000000 Kernel image @ 0x40008000 [ 0x000000 - 0x461ee0 ] ## Loading init Ramdisk from Legacy Image at 42000000 ... Image Name: Created: 2014-02-07 19:37:29 UTC Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 642538 Bytes = 627.5 KiB Load Address: 00000000 Entry Point: 00000000 Verifying Checksum ... OK ## Flattened Device Tree blob at 41000000 Booting using the fdt blob at 0x41000000 Loading Device Tree to 40ff8000, end 40fff720 ... OK Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 19.81 seconds. # PYBOOT: Result: FAIL imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual: FAIL: last 80 lines of boot log: ------------------------------------------------------------ Connected to wand-dual console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-dual console)> hardreset (user:khilman) Reboot wand-dual Reboot: wand-dual ; phidget 2 1 : off, sleep, on ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.39 seconds. # PYBOOT: Result: FAIL imx6dl-wandboard,wand-solo: FAIL: last 80 lines of boot log: ------------------------------------------------------------ version U-Boot 2013.04-00012-g0b44183-dirty (May 15 2013 - 16:16:11) arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2010.09-50) 4.5.1 GNU ld (Sourcery G++ Lite 2010.09-50) 2.20.51.20100809 => setenv bootargs console=ttymxc0,115200 rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 setenv bootargs console=ttymxc0,115200 rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 => setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' => if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi => if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi => setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no => dhcp dhcp FEC Waiting for PHY auto negotiation to complete.. done BOOTP broadcast 1 DHCP client bound to address 192.168.1.164 =>setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 =>if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi => tftp 0x10800000 192.168.1.2:tmp/wand-solo-bAcavE/zImage tftp 0x10800000 192.168.1.2:tmp/wand-solo-bAcavE/zImage Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'tmp/wand-solo-bAcavE/zImage'. Load address: 0x10800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ############################### 1.5 MiB/s done Bytes transferred = 5223440 (4fb410 hex) => tftp 0x11100000 192.168.1.2:buildroot.cpio.gz.uboot tftp 0x11100000 192.168.1.2:buildroot.cpio.gz.uboot Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'buildroot.cpio.gz.uboot'. Load address: 0x11100000 Loading: *############################################ 1.5 MiB/s done Bytes transferred = 642602 (9ce2a hex) => tftp 0x11000000 192.168.1.2:tmp/wand-solo-bAcavE/imx6dl-wandboard.dtb tftp 0x11000000 192.168.1.2:tmp/wand-solo-bAcavE/imx6dl-wandboard.dtb Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'tmp/wand-solo-bAcavE/imx6dl-wandboard.dtb'. Load address: 0x11000000 Loading: *## 1.4 MiB/s done Bytes transferred = 26637 (680d hex) => printenv bootargs printenv bootargs bootargs=console=ttymxc0,115200 rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 ip=192.168.1.164:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none => bootz 0x10800000 0x11100000 0x11000000 bootz 0x10800000 0x11100000 0x11000000 ## Loading init Ramdisk from Legacy Image at 11100000 ... Image Name: Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 642538 Bytes = 627.5 KiB Load Address: 00000000 Entry Point: 00000000 ## Flattened Device Tree blob at 11000000 Booting using the fdt blob at 0x11000000 Using Device Tree in place at 11000000, end 1100980c Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 22.60 seconds. # PYBOOT: Result: FAIL imx6q-wandboard: FAIL: last 80 lines of boot log: ------------------------------------------------- U-Boot 2013.07-00001-gc362749 (Sep 06 2013 - 07:50:29) arm-linux-gnueabi-gcc (Ubuntu/Linaro 4.7.2-1ubuntu1) 4.7.2 GNU ld (GNU Binutils for Ubuntu) 2.22.90.20120919 => setenv bootargs console=ttymxc0,115200 setenv bootargs console=ttymxc0,115200 => setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' => if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi => if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi => setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no => dhcp dhcp FEC Waiting for PHY auto negotiation to complete.. done BOOTP broadcast 1 DHCP client bound to address 192.168.1.163 => setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 => if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi => tftp 0x10800000 192.168.1.2:tmp/wand-quad-ot6Kuw/zImage tftp 0x10800000 192.168.1.2:tmp/wand-quad-ot6Kuw/zImage Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.163 Filename 'tmp/wand-quad-ot6Kuw/zImage'. Load address: 0x10800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ################################################################# ############################### 2.7 MiB/s done Bytes transferred = 5223440 (4fb410 hex) => tftp 0x11100000 192.168.1.2:buildroot.cpio.gz.uboot tftp 0x11100000 192.168.1.2:buildroot.cpio.gz.uboot Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.163 Filename 'buildroot.cpio.gz.uboot'. Load address: 0x11100000 Loading: *############################################ 2.7 MiB/s done Bytes transferred = 642602 (9ce2a hex) => tftp 0x11000000 192.168.1.2:tmp/wand-quad-ot6Kuw/imx6q-wandboard.dtb tftp 0x11000000 192.168.1.2:tmp/wand-quad-ot6Kuw/imx6q-wandboard.dtb Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.163 Filename 'tmp/wand-quad-ot6Kuw/imx6q-wandboard.dtb'. Load address: 0x11000000 Loading: *### 2.6 MiB/s done Bytes transferred = 29426 (72f2 hex) => printenv bootargs printenv bootargs bootargs=console=ttymxc0,115200 ip=192.168.1.163:192.168.1.2::255.255.255.0::::192.168.1.254:none => bootz 0x10800000 0x11100000 0x11000000 bootz 0x10800000 0x11100000 0x11000000 Kernel image @ 0x10800000 [ 0x000000 - 0x4fb410 ] ## Loading init Ramdisk from Legacy Image at 11100000 ... Image Name: Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 642538 Bytes = 627.5 KiB Load Address: 00000000 Entry Point: 00000000 Verifying Checksum ... OK ## Flattened Device Tree blob at 11000000 Booting using the fdt blob at 0x11000000 Using Device Tree in place at 11000000, end 1100a2f1 Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 21.16 seconds. # PYBOOT: Result: FAIL multi_v7_defconfig ------------------ ste-snowball: FAIL: last 80 lines of boot log: ---------------------------------------------- CPU: ST-Ericsson db8500 v2 (Dual ARM Cortex A9) 998.400 Mhz I2C: ready DRAM: 1 GB MMC: MCDE: startup failed sec_bridge: ISSWAPI_FLUSH_BOOT_CODE: 2 EMMC: 0, MMC: 1 In: serial Out: serial Err: serial Net: smc911x-0 Hit any key to stop autoboot: 1 0 U8500 $ U8500 $ version version U-Boot 2009.11 (sept. 19 2011 - 17:03:11) U8500 $ setenv ethaddr 6e:e6:84:36:8e:9e setenv ethaddr 6e:e6:84:36:8e:9e Can't overwrite "ethaddr" U8500 $ setenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 setenv bootargs console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 U8500 $ setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' U8500 $ if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi U8500 $ if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi U8500 $ setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no U8500 $ dhcp dhcp smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e BOOTP broadcast 1 BOOTP broadcast 2 DHCP client bound to address 192.168.1.159 U8500 $ setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 U8500 $ if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi U8500 $ tftp 0x00800000 192.168.1.2:tmp/snowball-Ow5Avd/tmp70n7TB-uImage tftp 0x00800000 192.168.1.2:tmp/snowball-Ow5Avd/tmp70n7TB-uImage smc911x: detected LAN9221 controller smc911x: phy initialized smc911x: MAC 6e:e6:84:36:8e:9e Using smc911x-0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.159 Filename 'tmp/snowball-Ow5Avd/tmp70n7TB-uImage'. Load address: 0x800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# ####################################################### done Bytes transferred = 4611385 (465d39 hex) U8500 $ printenv bootargs printenv bootargs bootargs=console=ttyAMA2,115200n8 debug earlyprintk rw root=/dev/mmcblk0p3 rootwait rootfstype=ext4 ip=192.168.1.159:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none U8500 $ bootm 0x00800000 bootm 0x00800000 ## Booting kernel from Legacy Image at 00800000 ... Image Name: Linux Image Type: ARM Linux Kernel Image (uncompressed) Data Size: 4611321 Bytes = 4.4 MB Load Address: 00008000 Entry Point: 00008000 Loading Kernel Image ... OK OK Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 33.52 seconds. # PYBOOT: Result: FAIL sun7i-a20-cubieboard2: FAIL: last 80 lines of boot log: ------------------------------------------------------- setenv ethaddr 22:71:81:DA:53:EA sun7i# setenv bootargs console=ttyS0,115200 debug earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 setenv bootargs console=ttyS0,115200 debug earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 sun7i# setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' sun7i# setenv initrd_high 0xffffffff setenv initrd_high 0xffffffff sun7i# if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi sun7i# if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi sun7i# setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no sun7i# dhcp dhcp ENET Speed is 100 Mbps - FULL duplex connection BOOTP broadcast 1 DHCP client bound to address 192.168.1.153 sun7i# setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 sun7i# if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi sun7i# tftp 0x40008000 192.168.1.2:tmp/cubie2-rc1ORR/zImage tftp 0x40008000 192.168.1.2:tmp/cubie2-rc1ORR/zImage Using emac device TFTP from server 192.168.1.2; our IP address is 192.168.1.153 Filename 'tmp/cubie2-rc1ORR/zImage'. Load address: 0x40008000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# #################################################### 2.7 MiB/s done Bytes transferred = 4570072 (45bbd8 hex) sun7i# tftp 0x42000000 192.168.1.2:buildroot.cpio.gz.uboot tftp 0x42000000 192.168.1.2:buildroot.cpio.gz.uboot Using emac device TFTP from server 192.168.1.2; our IP address is 192.168.1.153 Filename 'buildroot.cpio.gz.uboot'. Load address: 0x42000000 Loading: *############################################ 2.8 MiB/s done Bytes transferred = 642602 (9ce2a hex) sun7i# tftp 0x41000000 192.168.1.2:tmp/cubie2-rc1ORR/sun7i-a20-cubieboard2.dtb tftp 0x41000000 192.168.1.2:tmp/cubie2-rc1ORR/sun7i-a20-cubieboard2.dtb Using emac device TFTP from server 192.168.1.2; our IP address is 192.168.1.153 Filename 'tmp/cubie2-rc1ORR/sun7i-a20-cubieboard2.dtb'. Load address: 0x41000000 Loading: *## 2.5 MiB/s done Bytes transferred = 18209 (4721 hex) sun7i# printenv bootargs printenv bootargs bootargs=console=ttyS0,115200 debug earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 ip=192.168.1.153:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none sun7i# bootz 0x40008000 0x42000000 0x41000000 bootz 0x40008000 0x42000000 0x41000000 Kernel image @ 0x40008000 [ 0x000000 - 0x45bbd8 ] ## Loading init Ramdisk from Legacy Image at 42000000 ... Image Name: Created: 2014-02-07 19:37:29 UTC Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 642538 Bytes = 627.5 KiB Load Address: 00000000 Entry Point: 00000000 Verifying Checksum ... OK ## Flattened Device Tree blob at 41000000 Booting using the fdt blob at 0x41000000 Loading Device Tree to 40ff8000, end 40fff720 ... OK Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 19.84 seconds. # PYBOOT: Result: FAIL imx6dl-wandboard,wand-solo: FAIL: last 80 lines of boot log: ------------------------------------------------------------ => version version U-Boot 2013.04-00012-g0b44183-dirty (May 15 2013 - 16:16:11) arm-none-linux-gnueabi-gcc (Sourcery G++ Lite 2010.09-50) 4.5.1 GNU ld (Sourcery G++ Lite 2010.09-50) 2.20.51.20100809 => setenv bootargs console=ttymxc0,115200 rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 setenv bootargs console=ttymxc0,115200 rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 => setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' => if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi => if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi => setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no => dhcp dhcp FEC Waiting for PHY auto negotiation to complete.. done BOOTP broadcast 1 DHCP client bound to address 192.168.1.164 => setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 => if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi => tftp 0x10800000 192.168.1.2:tmp/wand-solo-OWL_0Q/zImage tftp 0x10800000 192.168.1.2:tmp/wand-solo-OWL_0Q/zImage Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'tmp/wand-solo-OWL_0Q/zImage'. Load address: 0x10800000 Loading: *################################################################# ################################################################# ################################################################# ################################################################# #################################################### 1.5 MiB/s done Bytes transferred = 4570072 (45bbd8 hex) => tftp 0x11100000 192.168.1.2:buildroot.cpio.gz.uboot tftp 0x11100000 192.168.1.2:buildroot.cpio.gz.uboot Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'buildroot.cpio.gz.uboot'. Load address: 0x11100000 Loading: *############################################ 1.5 MiB/s done Bytes transferred = 642602 (9ce2a hex) =>tftp 0x11000000 192.168.1.2:tmp/wand-solo-OWL_0Q/imx6dl-wandboard.dtb tftp 0x11000000 192.168.1.2:tmp/wand-solo-OWL_0Q/imx6dl-wandboard.dtb Using FEC device TFTP from server 192.168.1.2; our IP address is 192.168.1.164 Filename 'tmp/wand-solo-OWL_0Q/imx6dl-wandboard.dtb'. Load address: 0x11000000 Loading: *## 1.4 MiB/s done Bytes transferred = 26637 (680d hex) => printenv bootargs printenv bootargs bootargs=console=ttymxc0,115200 rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 ip=192.168.1.164:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none => bootz 0x10800000 0x11100000 0x11000000 bootz 0x10800000 0x11100000 0x11000000 ## Loading init Ramdisk from Legacy Image at 11100000 ... Image Name: Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 642538 Bytes = 627.5 KiB Load Address: 00000000 Entry Point: 00000000 ## Flattened Device Tree blob at 11000000 Booting using the fdt blob at 0x11000000 Using Device Tree in place at 11000000, end 1100980c Starting kernel ... Tz7r~y8þ¢ŒX²s4fMs/<_X~X€Q%ÓÑµR0töô@dxBVàkL6cvh/_.gzB²ÐÖg?wV¿Ìë{¯ß/@7`kVÖ¿ÈëÈh/_oBPák\Vâöèoßoc@Pik'V?pVØëöÔ+ß n|4q:5<±²3rDbf^ôþö²øø²d?zð0ÒôýŸŽÔ©(j>XVÀg¿ÖðÖßPx^wt]vdbyVvÐ2²hz3ëþüŒ<ñöÔM>Ó@PVgV¿ùoZW}~'\{P\?PWAfzWgVë{Vc3vz`àVÄg÷vg[wtT7]V¿ÙÐÖóûæú×gVëû7ðñw}5^Vg?@ZÃÄ÷}W}X'Ý»Ü¿Öùw~V3GOHwsøÖwfa`Q@gkt\W}~§ÜÔ¿Ð×InzWG#wrppw4^QÔg_}W}~Ö·ØûÖ¿Ð?PWAfzWgTë{7Vc}w<r.<9}14~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 22.44 seconds. # PYBOOT: Result: FAIL imx6q-wandboard: FAIL: last 80 lines of boot log: ------------------------------------------------- Connected to wand-quad console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-quad console)> hardreset (user:khilman) Reboot wand-quad Reboot: wand-quad ; phidget 2 3 : off, sleep, on U-Boot 2013.07-00001-gc362749 (Sep 06 2013 - 07:50:29) CPU: Freescale i.MX6Q rev1.2 at 792 MHz Reset cause: POR Board: Wandboard DRAM: 2 GiB MMC: FSL_SDHC: 0, FSL_SDHC: 1 *** Warning - bad CRC, using default environment In: serial 0 => ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.48 seconds. # PYBOOT: Result: FAIL imx6dl-wandboard,wand-dual: FAIL: last 80 lines of boot log: ------------------------------------------------------------ Connected to wand-dual console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-dual console)> hardreset (user:khilman) Reboot wand-dual Reboot: wand-dual ; phidget 2 1 : off, sleep, on ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.39 seconds. # PYBOOT: Result: FAIL

11 years, 3 months

[PATCH] tick: Remove code duplication in tick_handle_periodic()

by Viresh Kumar

tick_handle_periodic() is calling ktime_add() at two places, first before the infinite loop and then at the end of infinite loop. We can rearrange code a bit to fix code duplication here. It looks quite simple and shouldn't break anything, I guess :) Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- kernel/time/tick-common.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/kernel/time/tick-common.c b/kernel/time/tick-common.c index 20b2fe3..d610ae3 100644 --- a/kernel/time/tick-common.c +++ b/kernel/time/tick-common.c @@ -98,18 +98,19 @@ static void tick_periodic(int cpu) void tick_handle_periodic(struct clock_event_device *dev) { int cpu = smp_processor_id(); - ktime_t next; + ktime_t next = dev->next_event; tick_periodic(cpu); if (dev->mode != CLOCK_EVT_MODE_ONESHOT) return; - /* - * Setup the next period for devices, which do not have - * periodic mode: - */ - next = ktime_add(dev->next_event, tick_period); for (;;) { + /* + * Setup the next period for devices, which do not have + * periodic mode: + */ + next = ktime_add(next, tick_period); + if (!clockevents_program_event(dev, next, false)) return; /* @@ -123,7 +124,6 @@ void tick_handle_periodic(struct clock_event_device *dev) */ if (timekeeping_valid_for_hres()) tick_periodic(cpu); - next = ktime_add(next, tick_period); } } -- 1.7.12.rc2.18.g61b472e

11 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel