linaro-kernel

linaro-kernel@lists.linaro.org

10095 discussions

[PATCH V3 00/10] PM / OPP: Fixes and cleanups

by Viresh Kumar

Hi, Happy new year guys !! This series fixes a memory leak (first patch) and does some cleanups to the OPP core. It is based of pm/linux-next branch. This series is tested for few days by various build and boot bots: - Kernel CI (Linaro) - Fengguang Wu's bot (Intel) V2->V3: - Only the 7th patch is updated based on Stephen's comment. - All the patches now have a Reviewed-by tag. V1->V2: - 6 out of 10 patches have received Acks from Stephen/MyungJoo. - dev_pm_opp_get_suspend_opp_freq() return freq in Hz now - s/opp_table/table in _opp_allocate() - Improved comment over _opp_add() defining its return types - opp_rcu_lockdep_assert() added at few places - Dropped a useless comment -- viresh Viresh Kumar (10): PM / OPP: Fix memory leak while adding duplicate OPPs PM / OPP: Remove useless TODO PM / OPP: Rename _allocate_opp() to _opp_allocate() PM / OPP: Error out on failing to add static OPPs for v1 bindings PM / OPP: Add light weight _opp_free() routine PM / OPP: Rename and split _dev_pm_opp_remove_table() PM / OPP: Don't allocate OPP table from _opp_allocate() PM / OPP: Rename dev_pm_opp_get_suspend_opp() and return OPP rate PM / OPP: Don't expose srcu_head to register notifiers PM / OPP: Split out part of _add_opp_table() and _remove_opp_table() drivers/base/power/opp/core.c | 293 ++++++++++++++++++++++++++---------------- drivers/base/power/opp/of.c | 89 +++++++------ drivers/base/power/opp/opp.h | 11 +- drivers/cpufreq/cpufreq-dt.c | 7 +- drivers/devfreq/devfreq.c | 26 +--- include/linux/pm_opp.h | 20 ++- 6 files changed, 253 insertions(+), 193 deletions(-) -- 2.7.1.410.g6faf27b

8 years, 8 months

v4.10-rc2 build: 0 failures 0 warnings (v4.10-rc2)

by Build bot for Mark Brown

Tree/Branch: v4.10-rc2 Git describe: v4.10-rc2 Commit: 0c744ea4f7 Linux 4.10-rc2 Build Time: 98 min 44 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

master build: 0 failures 0 warnings (v4.10-rc1-32-g4759d38)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-32-g4759d38 Commit: 4759d386d5 Merge branch 'libnvdimm-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm Build Time: 98 min 59 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

master build: 0 failures 0 warnings (v4.10-rc1-25-g238d1d0)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-25-g238d1d0 Commit: 238d1d0f79 Merge tag 'docs-4.10-rc1-fix' of git://git.lwn.net/linux Build Time: 103 min 22 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

master build: 0 failures 0 warnings (v4.10-rc1-19-g98473f9)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-19-g98473f9 Commit: 98473f9f3f mm/filemap: fix parameters to test_bit() Build Time: 98 min 54 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

master build: 8 failures 2 warnings (v4.10-rc1-18-gb91e130)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-18-gb91e130 Commit: b91e1302ad mm: optimize PageWaiters bit use for unlock_page() Build Time: 88 min 10 sec Passed: 2 / 10 ( 20.00 %) Failed: 8 / 10 ( 80.00 %) Errors: 1 Warnings: 2 Section Mismatches: 0 Failed defconfigs: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig arm-allmodconfig arm-allnoconfig arm-multi_v4t_defconfig arm64-defconfig Errors: arm64-allnoconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm64-allmodconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm-multi_v5_defconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm-multi_v7_defconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm-allmodconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm-allnoconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm-multi_v4t_defconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' arm64-defconfig ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): 1 warnings 0 mismatches : arm64-allnoconfig 1 warnings 0 mismatches : arm64-allmodconfig 1 warnings 0 mismatches : arm-multi_v5_defconfig 1 warnings 0 mismatches : arm-multi_v7_defconfig 1 warnings 0 mismatches : arm-allmodconfig 1 warnings 0 mismatches : arm-allnoconfig 1 warnings 0 mismatches : arm-multi_v4t_defconfig 1 warnings 0 mismatches : arm64-defconfig ------------------------------------------------------------------------------- Errors summary: 1 8 ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings Summary: 2 7 ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] 1 ....../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- arm64-allnoconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm64-allmodconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ....../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm-multi_v5_defconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm-multi_v7_defconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm-allmodconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm-allnoconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm-multi_v4t_defconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- arm64-defconfig : FAIL, 1 errors, 1 warnings, 0 section mismatches Errors: ../mm/filemap.c:933:9: error: too few arguments to function 'test_bit' Warnings: ../mm/filemap.c:934:1: warning: control reaches end of non-void function [-Wreturn-type] ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: x86_64-allnoconfig x86_64-defconfig

8 years, 8 months

[PATCH] cpufreq: schedutil: add up/down frequency transition rate limits

by Viresh Kumar

From: Steve Muckle <smuckle.linux(a)gmail.com> The rate-limit tunable in the schedutil governor applies to transitions to both lower and higher frequencies. On several platforms it is not the ideal tunable though, as it is difficult to get best power/performance figures using the same limit in both directions. It is common on mobile platforms with demanding user interfaces to want to increase frequency rapidly for example but decrease slowly. One of the example can be a case where we have short busy periods followed by similar or longer idle periods. If we keep the rate-limit high enough, we will not go to higher frequencies soon enough. On the other hand, if we keep it too low, we will have too many frequency transitions, as we will always reduce the frequency after the busy period. It would be very useful if we can set low rate-limit while increasing the frequency (so that we can respond to the short busy periods quickly) and high rate-limit while decreasing frequency (so that we don't reduce the frequency immediately after the short busy period and that may avoid frequency transitions before the next busy period). Implement separate up/down transition rate limits. Note that the governor avoids frequency recalculations for a period equal to minimum of up and down rate-limit. A global mutex is also defined to protect updates to min_rate_limit_us via two separate sysfs files. Note that this wouldn't change behavior of the schedutil governor for the platforms which wish to keep same values for both up and down rate limits. This is tested with the rt-app [1] on ARM Exynos, dual A15 processor platform. Testcase: Run a SCHED_OTHER thread on CPU0 which will emulate work-load for X ms of busy period out of the total period of Y ms, i.e. Y - X ms of idle period. The values of X/Y taken were: 20/40, 20/50, 20/70, i.e idle periods of 20, 30 and 50 ms respectively. These were tested against values of up/down rate limits as: 10/10 ms and 10/40 ms. For every test we noticed a performance increase of 5-10% with the schedutil governor, which was very much expected. [Viresh]: Simplified user interface and introduced min_rate_limit_us + mutex, rewrote commit log and included test results. [1] https://github.com/scheduler-tools/rt-app/ Signed-off-by: Steve Muckle <smuckle.linux(a)gmail.com> Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- kernel/sched/cpufreq_schedutil.c | 106 +++++++++++++++++++++++++++++++++------ 1 file changed, 90 insertions(+), 16 deletions(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c index 42a220e78f00..7fae0dbfe4bd 100644 --- a/kernel/sched/cpufreq_schedutil.c +++ b/kernel/sched/cpufreq_schedutil.c @@ -22,7 +22,8 @@ struct sugov_tunables { struct gov_attr_set attr_set; - unsigned int rate_limit_us; + unsigned int up_rate_limit_us; + unsigned int down_rate_limit_us; }; struct sugov_policy { @@ -33,7 +34,9 @@ struct sugov_policy { raw_spinlock_t update_lock; /* For shared policies */ u64 last_freq_update_time; - s64 freq_update_delay_ns; + s64 min_rate_limit_ns; + s64 up_rate_delay_ns; + s64 down_rate_delay_ns; unsigned int next_freq; /* The next fields are only needed if fast switch cannot be used. */ @@ -84,7 +87,27 @@ static bool sugov_should_update_freq(struct sugov_policy *sg_policy, u64 time) } delta_ns = time - sg_policy->last_freq_update_time; - return delta_ns >= sg_policy->freq_update_delay_ns; + + /* No need to recalculate next freq for min_rate_limit_us at least */ + return delta_ns >= sg_policy->min_rate_limit_ns; +} + +static bool sugov_up_down_rate_limit(struct sugov_policy *sg_policy, u64 time, + unsigned int next_freq) +{ + s64 delta_ns; + + delta_ns = time - sg_policy->last_freq_update_time; + + if (next_freq > sg_policy->next_freq && + delta_ns < sg_policy->up_rate_delay_ns) + return true; + + if (next_freq < sg_policy->next_freq && + delta_ns < sg_policy->down_rate_delay_ns) + return true; + + return false; } static void sugov_update_commit(struct sugov_policy *sg_policy, u64 time, @@ -92,6 +115,9 @@ static void sugov_update_commit(struct sugov_policy *sg_policy, u64 time, { struct cpufreq_policy *policy = sg_policy->policy; + if (sugov_up_down_rate_limit(sg_policy, time, next_freq)) + return; + sg_policy->last_freq_update_time = time; if (policy->fast_switch_enabled) { @@ -340,15 +366,32 @@ static inline struct sugov_tunables *to_sugov_tunables(struct gov_attr_set *attr return container_of(attr_set, struct sugov_tunables, attr_set); } -static ssize_t rate_limit_us_show(struct gov_attr_set *attr_set, char *buf) +static DEFINE_MUTEX(min_rate_lock); + +static void update_min_rate_limit_us(struct sugov_policy *sg_policy) +{ + mutex_lock(&min_rate_lock); + sg_policy->min_rate_limit_ns = min(sg_policy->up_rate_delay_ns, + sg_policy->down_rate_delay_ns); + mutex_unlock(&min_rate_lock); +} + +static ssize_t up_rate_limit_us_show(struct gov_attr_set *attr_set, char *buf) +{ + struct sugov_tunables *tunables = to_sugov_tunables(attr_set); + + return sprintf(buf, "%u\n", tunables->up_rate_limit_us); +} + +static ssize_t down_rate_limit_us_show(struct gov_attr_set *attr_set, char *buf) { struct sugov_tunables *tunables = to_sugov_tunables(attr_set); - return sprintf(buf, "%u\n", tunables->rate_limit_us); + return sprintf(buf, "%u\n", tunables->down_rate_limit_us); } -static ssize_t rate_limit_us_store(struct gov_attr_set *attr_set, const char *buf, - size_t count) +static ssize_t up_rate_limit_us_store(struct gov_attr_set *attr_set, + const char *buf, size_t count) { struct sugov_tunables *tunables = to_sugov_tunables(attr_set); struct sugov_policy *sg_policy; @@ -357,18 +400,42 @@ static ssize_t rate_limit_us_store(struct gov_attr_set *attr_set, const char *bu if (kstrtouint(buf, 10, &rate_limit_us)) return -EINVAL; - tunables->rate_limit_us = rate_limit_us; + tunables->up_rate_limit_us = rate_limit_us; - list_for_each_entry(sg_policy, &attr_set->policy_list, tunables_hook) - sg_policy->freq_update_delay_ns = rate_limit_us * NSEC_PER_USEC; + list_for_each_entry(sg_policy, &attr_set->policy_list, tunables_hook) { + sg_policy->up_rate_delay_ns = rate_limit_us * NSEC_PER_USEC; + update_min_rate_limit_us(sg_policy); + } return count; } -static struct governor_attr rate_limit_us = __ATTR_RW(rate_limit_us); +static ssize_t down_rate_limit_us_store(struct gov_attr_set *attr_set, + const char *buf, size_t count) +{ + struct sugov_tunables *tunables = to_sugov_tunables(attr_set); + struct sugov_policy *sg_policy; + unsigned int rate_limit_us; + + if (kstrtouint(buf, 10, &rate_limit_us)) + return -EINVAL; + + tunables->down_rate_limit_us = rate_limit_us; + + list_for_each_entry(sg_policy, &attr_set->policy_list, tunables_hook) { + sg_policy->down_rate_delay_ns = rate_limit_us * NSEC_PER_USEC; + update_min_rate_limit_us(sg_policy); + } + + return count; +} + +static struct governor_attr up_rate_limit_us = __ATTR_RW(up_rate_limit_us); +static struct governor_attr down_rate_limit_us = __ATTR_RW(down_rate_limit_us); static struct attribute *sugov_attributes[] = { - &rate_limit_us.attr, + &up_rate_limit_us.attr, + &down_rate_limit_us.attr, NULL }; @@ -512,10 +579,13 @@ static int sugov_init(struct cpufreq_policy *policy) goto stop_kthread; } - tunables->rate_limit_us = LATENCY_MULTIPLIER; + tunables->up_rate_limit_us = LATENCY_MULTIPLIER; + tunables->down_rate_limit_us = LATENCY_MULTIPLIER; lat = policy->cpuinfo.transition_latency / NSEC_PER_USEC; - if (lat) - tunables->rate_limit_us *= lat; + if (lat) { + tunables->up_rate_limit_us *= lat; + tunables->down_rate_limit_us *= lat; + } policy->governor_data = sg_policy; sg_policy->tunables = tunables; @@ -574,7 +644,11 @@ static int sugov_start(struct cpufreq_policy *policy) struct sugov_policy *sg_policy = policy->governor_data; unsigned int cpu; - sg_policy->freq_update_delay_ns = sg_policy->tunables->rate_limit_us * NSEC_PER_USEC; + sg_policy->up_rate_delay_ns = + sg_policy->tunables->up_rate_limit_us * NSEC_PER_USEC; + sg_policy->down_rate_delay_ns = + sg_policy->tunables->down_rate_limit_us * NSEC_PER_USEC; + update_min_rate_limit_us(sg_policy); sg_policy->last_freq_update_time = 0; sg_policy->next_freq = UINT_MAX; sg_policy->work_in_progress = false; -- 2.7.1.410.g6faf27b

8 years, 8 months

master build: 0 failures 0 warnings (v4.10-rc1-17-g2d706e7)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-17-g2d706e7 Commit: 2d706e790f Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6 Build Time: 102 min 4 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

master build: 0 failures 0 warnings (v4.10-rc1-15-g8f18e4d)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-15-g8f18e4d Commit: 8f18e4d03e Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net Build Time: 103 min 1 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

master build: 0 failures 0 warnings (v4.10-rc1-3-g0dad3a3)

by Build bot for Mark Brown

Tree/Branch: master Git describe: v4.10-rc1-3-g0dad3a3 Commit: 0dad3a3014 x86/mce/AMD: Make the init code more robust Build Time: 98 min 55 sec Passed: 10 / 10 (100.00 %) Failed: 0 / 10 ( 0.00 %) Errors: 0 Warnings: 0 Section Mismatches: 0 ------------------------------------------------------------------------------- defconfigs with issues (other than build errors): ------------------------------------------------------------------------------- =============================================================================== Detailed per-defconfig build reports below: ------------------------------------------------------------------------------- Passed with no errors, warnings or mismatches: arm64-allnoconfig arm64-allmodconfig arm-multi_v5_defconfig arm-multi_v7_defconfig x86_64-defconfig arm-allmodconfig arm-allnoconfig x86_64-allnoconfig arm-multi_v4t_defconfig arm64-defconfig close failed in file object destructor: sys.excepthook is missing lost sys.stderr

8 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel