Rob,
On Wed, Feb 29, 2012 at 4:11 AM, Robert Lee rob.lee@linaro.org wrote:
This patch series moves various functionality duplicated in platform cpuidle drivers to the core cpuidle driver. Also, the platform irq disabling was removed as it appears that all calls into cpuidle_call_idle will have already called local_irq_disable().
NOTE to Maintainers: Platform code changes are not required due to patch 1/9 but please review and push these platform changes as possible to allow this consolidation to occur.
Based on 3.3-rc5 plus recent exynos cpuidle patch (affect exynos cpuidle only): http://www.spinics.net/lists/linux-samsung-soc/msg09467.html
v5 submission can be found here: http://www.spinics.net/lists/arm-kernel/msg161596.html Changes since v5:
- Fixed mindless bug in CONFIG_ARCH_HAS_RELAX code in drivers/cpuidle/cpuidle.c
- Removed inline from wrapper function (thanks Mike Turquette and Rob Herring)
- Add zeroing out of last_residency if error value is returned (thanks Mike)
- Made drivers/cpuidle/cpuidle.c more intelligently handle en_core_tk_irqen
flag allowing removal of the if (en_core_tk_irqen) in cpuidle_idle_call (thanks Daniel Lezcano)
- Moved CPUIDLE_ARM_WFI_STATE macro to arch/arm/include/asm/cpuidle.h (thanks
Jean Pihet)
- Cleaned up some comments and a stray change (thanks Jean)
Except the comments I sent to the list, this version looks good: Acked-by: Jean Pihet j-pihet@ti.com
Tested OK using cpuidle in RETention and OFF modes on Beagleboard (OMAP3530 ES2.1): Tested-by: Jean Pihet j-pihet@ti.com
Thanks & regards, Jean