linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

by Neil Wong

hi, all: Now i had been uploaded libjpeg-turbo code to git.linaro.org, you can download code by git clone https://git.linaro.org/people/neil.wong/libjpeg-turbo.git, it include patch based on libjpeg-turbo SVN:1410, version 1.4 or 1.3.90, and i also uploaded the total package under code directory. This package based on Ragesh' patch, and i fix some bug and rewrite some code based on newest jpeg-turbo code, and this package can pass tjunittest test, and i also added rgba8888 bitmap file support, and new package use CLZ, it will reduce memory usage 64k bytes, and have above 2x speed than old jpeg library with neon support, and now this is a roughly release, you can replace your jpeg library with it and have a try. thanks. Neil

10 years, 5 months

[ACTIVITY] Week47

by Vishal Bhoj

== Progress == * Android Release (60%) * DNS issue on TC2 and (20%) * ARA (20%) == Plans == * ARA stuff Regards, Vishal

10 years, 5 months

[ACTIVITY] Week47

by Wookey

== Progress == * Added i386 cross-toolchain builds for jessie * Moved cross-toolchains to emdebian.org site * Merged plethora of cross-toolchain wiki pages (more to do!) * Lots of cross-toolchian build-design debate * Scheduled multiarch version unskew builds * Rebuilds for all docbook-bug affected arm64 packages * Upgraded desktop to jessie = Plans == get standalone builds working == Issues == Cross-toolchain build-method disagreements Wookey -- Principal hats: Linaro, Wookware, ARM http://wookware.org/

10 years, 5 months

[PATCH] idlestat: Replace asserts with proper error handlings

by pi-cheng.chen

Replace asserts with displaying error messages and/or terminating program in a controlled manner. Also refine some error handling paths. Signed-off-by: Pi-Cheng Chen <pi-cheng.chen(a)linaro.org> --- energy_model.c | 3 --- idlestat.c | 62 +++++++++++++++++++++++++++++++++++++++++++--------------- topology.c | 12 ++++++------ 3 files changed, 52 insertions(+), 25 deletions(-) diff --git a/energy_model.c b/energy_model.c index 87ea3a8..b564ec6 100644 --- a/energy_model.c +++ b/energy_model.c @@ -3,7 +3,6 @@ #include <string.h> #include <stdbool.h> #include <errno.h> -#include <assert.h> #include "energy_model.h" #include "idlestat.h" @@ -92,8 +91,6 @@ int parse_energy_model(struct program_options *options) char *path = options->energy_model_filename; int ret; - assert(path != NULL); - f = fopen(path, "r"); if (!f) { if (errno == ENOENT) { diff --git a/idlestat.c b/idlestat.c index eff04e5..5bd2a14 100644 --- a/idlestat.c +++ b/idlestat.c @@ -40,7 +40,6 @@ #include <sys/types.h> #include <sys/resource.h> #include <sys/wait.h> -#include <assert.h> #include "idlestat.h" #include "utils.h" @@ -647,7 +646,8 @@ static int alloc_pstate(struct cpufreq_pstates *pstates, unsigned int freq) tmp = realloc(pstate, sizeof(*pstate) * (nrfreq + 1)); if (!tmp) { - perror("realloc pstate"); + fprintf(stderr, "%s: Failed ot realloc memory for pstate. " + "Exiting.\n", __func__); return -1; } pstate = tmp; @@ -864,7 +864,8 @@ static void cpu_change_pstate(struct cpuidle_datas *datas, int cpu, next = freq_to_pstate_index(ps, freq); if (next < 0) next = alloc_pstate(ps, freq); - assert(next >= 0); + if (next < 0) + exit(1); switch (cur) { case 1: @@ -1090,15 +1091,24 @@ static int get_wakeup_irq(struct cpuidle_datas *datas, char *buffer, int count) char irqname[NAMELEN+1]; if (strstr(buffer, "irq_handler_entry")) { - assert(sscanf(buffer, TRACE_IRQ_FORMAT, &cpu, &irqid, - irqname) == 3); + if (sscanf(buffer, TRACE_IRQ_FORMAT, &cpu, &irqid, + irqname) != 3) { + fprintf(stderr, "warning: Unrecognized" + "irq_handler_entry record. Skip it.\n"); + return -1; + } store_irq(cpu, irqid, irqname, datas); return 0; } if (strstr(buffer, "ipi_entry")) { - assert(sscanf(buffer, TRACE_IPIIRQ_FORMAT, &cpu, irqname) == 2); + if (sscanf(buffer, TRACE_IPIIRQ_FORMAT, &cpu, irqname) != 2) { + fprintf(stderr, "warning: Unrecognized ipi_entry" + "record. Skip it.\n"); + return -1; + } + irqname[strlen(irqname) - 1] = '\0'; store_irq(cpu, -1, irqname, datas); return 0; @@ -1128,20 +1138,23 @@ struct cpuidle_datas *idlestat_load(struct program_options *options) if (strstr(buffer, "idlestat")) { options->format = IDLESTAT_HEADER; fgets(buffer, BUFSIZE, f); - assert(sscanf(buffer, "cpus=%u", &nrcpus) == 1); + if (sscanf(buffer, "cpus=%u", &nrcpus) != 1) + nrcpus = 0; fgets(buffer, BUFSIZE, f); } else if (strstr(buffer, "# tracer")) { options->format = TRACE_CMD_HEADER; while(!feof(f)) { if (buffer[0] != '#') break; - if (strstr(buffer, "#P:")) - assert(sscanf(buffer, "#%*[^#]#P:%u", &nrcpus) == 1); + if (strstr(buffer, "#P:") && + sscanf(buffer, "#%*[^#]#P:%u", &nrcpus) != 1) + nrcpus = 0; fgets(buffer, BUFSIZE, f); } } else { fprintf(stderr, "%s: unrecognized import format in '%s'\n", __func__, options->filename); + fclose(f); return NULL; } @@ -1185,8 +1198,13 @@ struct cpuidle_datas *idlestat_load(struct program_options *options) do { if (strstr(buffer, "cpu_idle")) { - assert(sscanf(buffer, TRACE_FORMAT, &time, &state, - &cpu) == 3); + if (sscanf(buffer, TRACE_FORMAT, &time, &state, &cpu) + != 3) { + fprintf(stderr, "warning: Unrecognized cpuidle" + "record. The result of analysis might " + "be wrong.\n"); + continue; + } if (start) { begin = time; @@ -1198,8 +1216,13 @@ struct cpuidle_datas *idlestat_load(struct program_options *options) count++; continue; } else if (strstr(buffer, "cpu_frequency")) { - assert(sscanf(buffer, TRACE_FORMAT, &time, &freq, - &cpu) == 3); + if (sscanf(buffer, TRACE_FORMAT, &time, &freq, &cpu) + != 3) { + fprintf(stderr, "warning: Unrecognized cpufreq" + "record. The result of analysis might " + "be wrong.\n"); + continue; + } cpu_change_pstate(datas, cpu, freq, time); count++; continue; @@ -1524,8 +1547,11 @@ static int idlestat_store(const char *path, double start_ts, double end_ts, if (ret < 0) return -1; - if (initp) - assert(ret == initp->nrcpus); + if (initp && ret != initp->nrcpus) { + fprintf(stderr, "%s: The number of CPUs is inconsistency\n", + __func__); + return -1; + } f = fopen(path, "w+"); @@ -1716,7 +1742,11 @@ int main(int argc, char *argv[], char *const envp[]) if ((options.mode == TRACE) || args < argc) { /* Read cpu topology info from sysfs */ - read_sysfs_cpu_topo(); + if (read_sysfs_cpu_topo()) { + fprintf(stderr, "Failed to read CPU topology info from" + " sysfs.\n"); + return 1; + } /* Stop tracing (just in case) */ if (idlestat_trace_enable(false)) { diff --git a/topology.c b/topology.c index 92521e1..eddd479 100644 --- a/topology.c +++ b/topology.c @@ -34,7 +34,6 @@ #include <dirent.h> #include <ctype.h> #include <sys/stat.h> -#include <assert.h> #include "list.h" #include "utils.h" @@ -313,8 +312,11 @@ static int topo_folder_scan(char *path, folder_filter_t filter) closedir(dir_topology); read_topology_cb(newpath, &cpu_info); - assert(sscanf(direntp->d_name, "cpu%d", - &cpu_info.cpu_id) == 1); + if (sscanf(direntp->d_name, "cpu%d", + &cpu_info.cpu_id) != 1) { + ret = -1; + goto out_free_newpath; + } add_topo_info(&g_cpu_topo_list, &cpu_info); } @@ -341,9 +343,7 @@ int init_cpu_topo_info(void) int read_sysfs_cpu_topo(void) { - topo_folder_scan("/sys/devices/system/cpu", cpu_filter_cb); - - return 0; + return topo_folder_scan("/sys/devices/system/cpu", cpu_filter_cb); } int read_cpu_topo_info(FILE *f, char *buf) -- 1.9.1

10 years, 5 months

[ACTIVITY] Week 47

by Riku Voipio

== Progress == * New script to run KVM tests with trusty/utopic guests (DEVPLAT-264 20%) * Moving CI towards utopic and other CI fixes (30%) * Stand-alone Perf recipe for OE (CARD-1653 50%) == Plans == * Switch kvm/xen guest images, DEVPLAT-264 * Find out the needed next steps for ARMv8 slaves (CARD-1729)

10 years, 5 months

[ACTIVITY] Week46

by Vishal Bhoj

== Progress == * SELinux configs merged into linux-linaro. (5%) * L updates and fixes to CI loop (95%) == Plans == * Android releases. Regards, Vishal

10 years, 5 months

[ACTIVITY] Week46

by Wookey

== Progress == * Updated xbuilder to 1.1. Uploaded to Debian (NEW) * Ran cross-build tests on Jessie with new toolchains: https://people.linaro.org/~wookey/buildd/testing/sbuild/latest/status.html * Set up new emdebian server after crack. * Cross-toolchain design work with team - udated wiki * Fixed up cross-gcc 4.9.2-2 dependency strictness * Uploaded cross-binutils 0.16 and cross-gcc 4.9.2-2 * 4 months of expenses done = Plans == Get new toolchains available from emdebian.org get standalone builds working == Issues == Cross-toolchain build-method disagreements Wookey -- Principal hats: Linaro, Debian, Wookware, ARM http://wookware.org/

10 years, 5 months

[ACTIVITY] Week 46

by Bernhard Rosenkränzer

== Progress == * Got AOSP master to build with clang again after the L release merge broke it badly * Upstreamed 89 related patches * Added workarounds for extended cbuild.validation.linaro.org downtime to toolchain build scripts == Plans == * Toolchain and NDK releases * Fix up AOSP master clang build * Upstream remaining patches * Check (and probably fix) AOSP master clang builds for Aarch64 == Issues == * none

10 years, 5 months

[ACTIVITY] Week 46

by Koen Kooi

== Progress == * OpenEmbedded (100%) * OpenJDK build failures (CARD-787 <https://cards.linaro.org/browse/CARD-787>) * Prebuilt toolchain testing (CARD-1728) == Plans == * Release * OpenEmbedded * eglibc -> glibc move (CARD-787 <https://cards.linaro.org/browse/CARD-787> ) * update gcc (CARD-787 <https://cards.linaro.org/browse/CARD-787>) * update binutils (CARD-787 <https://cards.linaro.org/browse/CARD-787>) * Prebuilt toolchain testing (CARD-1728) -- Koen Kooi Builds and Baselines | Release Manager Linaro.org | Open source software for ARM SoCs

10 years, 5 months

[PATCH 1/3] rt-app: Add a script to tune parameters in json file.

by pi-cheng.chen

This scripts strips all comments in the input JSON file, modifies the parameters according to commnad line arguments, and write the content to a new JSON file. Signed-off-by: Pi-Cheng Chen <pi-cheng.chen(a)linaro.org> --- doc/tune_json.py | 138 +++++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 138 insertions(+) create mode 100755 doc/tune_json.py diff --git a/doc/tune_json.py b/doc/tune_json.py new file mode 100755 index 0000000..36746ff --- /dev/null +++ b/doc/tune_json.py @@ -0,0 +1,138 @@ +#!/usr/bin/env python + +import collections +import argparse +import shutil +import os +import sys +import json +import re + + +def find_dict_by_key(doc, key): + if key in doc and type(doc[key]) is collections.OrderedDict: + return doc[key] + + for k in doc: + if type(doc[k]) is collections.OrderedDict: + return find_dict_by_key(doc[k], key) + + +def dict_find_and_replace_value(dic, key, val): + for k in dic: + if type(dic[k]) is collections.OrderedDict: + dict_find_and_replace_value(dic[k], key, val) + if k == key: + dic[k] = val + + +def dict_of_loading(dic): + if not 'run' in dic: + return False, None + + for k in dic: + if 'timer' in k and 'period' in dic[k]: + return True, k + else: + return False, None + + +def calculate_and_update_loading(dic, loading): + of_loading, timer_id = dict_of_loading(dic) + + if of_loading: + period = dic[timer_id]['period'] + run = period * loading / 100 + dic['run'] = run + + for k in dic: + if type(dic[k]) is collections.OrderedDict: + calculate_and_update_loading(dic[k], loading) + + +# strip comments in json file and load the file as a dict +def load_json_file(filename): + try: + f = open(filename, 'r') + except: + print 'ERROR: Unable to open %s' %filename + sys.exit(2) + + comment_re = re.compile( + '(^)?[^\S\n]*/(?:\*(.*?)\*/[^\S\n]*|/[^\n]*)($)?', + re.DOTALL | re.MULTILINE) + + content = ''.join(f.readlines()) + + match = comment_re.search(content) + while match: + content = content[:match.start()] + content[match.end():] + match = comment_re.search(content) + + return json.JSONDecoder(object_pairs_hook=collections.OrderedDict).decode(content) + + +def dump_json_file(doc, filename): + try: + fo = open(filename, 'w+') + except: + print 'ERROR: Unable to open %s' %filename + sys.exit(2) + + json.dump(doc, fo, indent=4, sort_keys=False) + fo.close() + + +if __name__ == '__main__': + tmp = 'tmp.json' + + parser = argparse.ArgumentParser() + + parser.add_argument('-f', '--file', dest='infile', default='', help='input json filename') + parser.add_argument('-o', '--out', dest='outfile', default='workload.json', help='output json filename'); + parser.add_argument('--instance', default=0, type=int, help='number of thread instance') + parser.add_argument('--period', default=0, type=int, help='period of each thread/phase (ms)') + parser.add_argument('--run', default=0, type=int, help='run time of each thread/phase (ms)') + parser.add_argument('--sleep', default=0, type=int, help='sleep time of each thread/phase (ms)') + parser.add_argument('--loop', default=0,type=int, help='loop count of each thread/phase (-1 as infinite loop)') + parser.add_argument('--loading', default=0, type=int, help='loading of each thread (%%)') + parser.add_argument('--key', type=str, help='the key id of thread/phase in which the parameters will be changed') + + args = parser.parse_args() + + if not os.path.isfile(args.infile): + print 'ERROR: input file %s does not exist\n' %args.infile + parser.print_help() + sys.exit(2) + + shutil.copyfile(args.infile, tmp) + + doc = target = load_json_file(tmp) + + if args.key: + target = find_dict_by_key(doc, args.key) + if not target: + print 'ERROR: key id %s is not found' %args.key + sys.exit(2) + + if args.instance > 0: + dict_find_and_replace_value(target, 'instance', args.instance) + + if args.period > 0: + dict_find_and_replace_value(target, 'period', args.period * 1000) + + if args.run > 0: + dict_find_and_replace_value(target, 'run', args.run * 1000) + + if args.sleep > 0: + dict_find_and_replace_value(target, 'sleep', args.sleep * 1000) + + if args.loop > 0 or args.loop == -1: + dict_find_and_replace_value(target, 'loop', args.loop) + + if args.loading > 0: + calculate_and_update_loading(target, args.loading); + + dump_json_file(doc, tmp) + + os.rename(tmp, args.outfile) -- 1.9.1

10 years, 5 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev