linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

libjpeg-turbo-1.1.1 + linaro Performance

by Tom Gall

Hi All, I've taken some time to freshen up the libjpeg-turbo hosted at lp:libjpeg-turbo to be refreshed with the upstream 1.1.1 plus Mandeeps previous work. I thought as part of this effort I'd do some performance comparisons between this new cut of code and the much older non arm optimized libjpeg62. For this test, I selected 3 ppms and 3 jpegs of the same image. The images are all color and are of the sizes : 1920x1024, 406x357 and 7227x3847. I placed the images inside of a ramdisk as well as would run the cjpeg and djpeg applications with time. Both cjpeg and djpeg and statically linked. I believe the libjpeg62 and libjpeg-turbo code using the current 4.5.2 version of gcc using the 0706 panda hwpack and LEB. Note, while these numbers are interesting to a point, time is I believe the wrong tool to make this measurement. Instead the call to the jpeg code should have time stamps before and after the operation to get a better idea of the time used. Numbers: cjpeg (ppm to jpeg conversion default parms) image size libjpeg62 libjpeg-turbo improvement (positive numbers are better) 1920x1024 real 0m0.522s real 0m0.452s +0.070s user 0m0.438s user 0m0.352s +0.086s sys 0m0.055s sys 0m0.070s -0.015s 406x357 real 0m0.086s real 0m0.085s +0.001s user 0m0.047s user 0m0.047s 0s sys 0m0.008s sys 0m0.008s 0s 7227x3847 real 0m3.812s real 0m4.075s - 0.263s user 0m3.461s user 0m3.711s - 0.250s sys 0m0.305s sys 0m0.328s - 0.023s djpeg (jpeg to ppm conversion default parms) image size libjpeg62 libjpeg-turbo improvement 1920x1024 real 0m0.414s real 0m0.294s +0.120s user 0m0.273s user 0m0.156s +0.117s sys 0m0.109s sys 0m0.109s 0s 406x357 real 0m0.079s real 0m0.072s +0.007s user 0m0.023s user 0m0.016s +0.007s sys 0m0.023s sys 0m0.023s 0s 7227x3847 real 0m7.517s real 0m10.099s -2.582s user 0m2.047s user 0m1.242s +0.805s sys 0m0.813s sys 0m0.859s -0.046s Further work: There are some additional patches from Michael Edwards, those were not part of this measurement tho I will be picking his patches up. Better timestamp code instead of using time. -- Regards, Tom "We want great men who, when fortune frowns will not be discouraged." - Colonel Henry Knox Linaro.org │ Open source software for ARM SoCs w) tom.gall att linaro.org w) tom_gall att vnet.ibm.com h) tom_gall att mac.com

13 years, 10 months

[uboot PATCH] Add uboot "fdt_high" enviroment variable

by David A. Long

From: David A. Long <dave.long(a)linaro.org> Add a new "fdt_high" enviroment variable. This can be used to control (or prevent) the relocation of the flattened device tree on boot. It can be used to prevent relocation of the fdt into highmem. The variable behaves similarly to the existing "initrd_high" variable. Signed-off-by: David A. Long <dave.long(a)linaro.org> --- common/image.c | 45 +++++++++++++++++++++++++++++++++++---------- 1 files changed, 35 insertions(+), 10 deletions(-) diff --git a/common/image.c b/common/image.c index e542a57..d565f33 100644 --- a/common/image.c +++ b/common/image.c @@ -1234,8 +1234,10 @@ int boot_relocate_fdt (struct lmb *lmb, char **of_flat_tree, ulong *of_size) { void *fdt_blob = *of_flat_tree; void *of_start = 0; + char *fdt_high; ulong of_len = 0; int err; + int disable_relocation=0; /* nothing to do */ if (*of_size == 0) @@ -1249,7 +1251,24 @@ int boot_relocate_fdt (struct lmb *lmb, char **of_flat_tree, ulong *of_size) /* position on a 4K boundary before the alloc_current */ /* Pad the FDT by a specified amount */ of_len = *of_size + CONFIG_SYS_FDT_PAD; - of_start = (void *)(unsigned long)lmb_alloc_base(lmb, of_len, 0x1000, + + /* If fdt_high is set use it to select the relocation address */ + fdt_high = getenv("fdt_high"); + if(fdt_high) { + void *desired_addr = (void *) simple_strtoul(fdt_high, NULL, 16); + + if(((ulong) desired_addr) == ~0UL || desired_addr == NULL) { + /* Zero or all ones means use fdt in place */ + desired_addr = fdt_blob; + disable_relocation = 1; + } + of_start = (void *)(unsigned long)lmb_alloc_base(lmb, of_len, 0x1000, ((ulong) desired_addr) + of_len); + if(of_start != desired_addr) { + puts("Failed using fdt_high value for Device Tree"); + goto error; + } + } else + of_start = (void *)(unsigned long)lmb_alloc_base(lmb, of_len, 0x1000, getenv_bootm_mapsize() + getenv_bootm_low()); if (of_start == 0) { @@ -1257,18 +1276,24 @@ int boot_relocate_fdt (struct lmb *lmb, char **of_flat_tree, ulong *of_size) goto error; } - debug ("## device tree at %p ... %p (len=%ld [0x%lX])\n", - fdt_blob, fdt_blob + *of_size - 1, of_len, of_len); + if(disable_relocation) { + /* We assume there is space after the existing fdt to use for padding */ + fdt_set_totalsize(of_start, of_len); + printf(" Using Device Tree in place at %p, end %p\n", of_start, of_start+of_len-1); + } else { + debug ("## device tree at %p ... %p (len=%ld [0x%lX])\n", + fdt_blob, fdt_blob + *of_size - 1, of_len, of_len); - printf (" Loading Device Tree to %p, end %p ... ", - of_start, of_start + of_len - 1); + printf (" Loading Device Tree to %p, end %p ... ", + of_start, of_start + of_len - 1); - err = fdt_open_into (fdt_blob, of_start, of_len); - if (err != 0) { - fdt_error ("fdt move failed"); - goto error; + err = fdt_open_into (fdt_blob, of_start, of_len); + if (err != 0) { + fdt_error ("fdt move failed"); + goto error; + } + puts ("OK\n"); } - puts ("OK\n"); *of_flat_tree = of_start; *of_size = of_len;

13 years, 10 months

[ACTIVITY] Multimedia WG status report - wk27.2011 (20110704-20110708)

by Ilias Biris

Last meeting minutes: https://wiki.linaro.org/WorkingGroups/Middleware/Multimedia/Notes/2011-07-05 Current status report:https://wiki.linaro.org/WorkingGroups/Middleware/Multimedia/WeeklyRe… Highlights: Issues/Changes: Mandeep Kumar is not contributing to Linaro work. A suitable replacement is sought after with the member company. As a plan-B Ilias has asked another member of the team to look after JPEG-turbo for 1107 release, providing the release and any necessary highlights to release management. This plan should be confirmed with Kurt once he is back from vac. Info has already been shared with the team member picking up jpeg-turbo As a result of this change sending the public plan review presentation to the TSC was postponed till Kurt has a new version of the plan. Public plan review: this is still planned to take place on 13 or 14 of July. Final date will be determined next week. The blueprints for the work now look to be mostly in shape. Still to cover - Userspace UMM - robclark needs to clarify whether any userspace API related to buffer sharing needs a separate blueprint or it can be as a set of work items in the existing memory management blueprints. - Jpeg optimization related to codec optimization - due to the change mentioned above this will need to be revised to identify how to meet the 1107 and beyond targets - As a result of the change the team will doublecheck other blueprints for any timeline adjustments needed -- Ilias Biris ilias.biris(a)linaro.org Project Manager, Linaro M: +358504839608, IRC: ibiris Skype: ilias_biris Linaro.org│ Open source software for ARM SoCs

13 years, 10 months

[NOTES] Kernel WG Weekly Status report 2011-07-08

by Mounir Bsaibes

Enclosed please find the link to the Weekly Status report for the kernel working group for the week ending 2011-07-08. == Weekly Status Report == https://wiki.linaro.org/WorkingGroups/Kernel/Status/2011-07-07 == Summary == * Updated linaro+android tree to linaro 11.06 final kernel * Worked on testing Android Alarm Timers integration with Posix Alarm Timers. * Rebased mmc non-blocking patchset v8 on to of mmc-next for 3.1. * Merged only one patch to linaro-2.6.39 fixing a bug in the MMC test module. * Started an experimental merge of Catalin Marinas' LPAE (ARM Large Physical Address Extension) patches with linux-linaro-2.6.39. Have a booting kernel on the ARM VExpress-CA15x4 model making use of physical memory beyond 4GB. Regards, Mounir -- Mounir Bsaibes Project Manager Follow Linaro.org: facebook.com/pages/Linaro/155974581091106 http://twitter.com/#!/linaroorg http://www.linaro.org/linaro-blog <http://www.linaro.org/linaro-blog>

13 years, 10 months

[Notes] Power Management WG Weekly Status report week 2011-07-08

by Mounir Bsaibes

Enclosed please find the link to the Meeting Minutes & Weekly Status report for the Power Management working group for the week ending 2011-07-08. == Meeting Minutes == https://wiki.linaro.org/WorkingGroups/PowerManagement/Meetings/2011-07-06 == Weekly Status Report == https://wiki.linaro.org/WorkingGroups/PowerManagement/Status/2011-07-07 == Summary == * Planning for 11.07 cycle, next milestone * Thermal Manager * Completed Runtime PM Adaptation of thermal sensor driver * Posted thermal sensor hwmod patches * Sched_mc * Follow cpu topology patch upstream * Test some config on sched_mc and powersaving on CA-9 * Prepare sched_mc discussion for August Linaro Connect * Update the non reg test for sched_mc * Powerdebug * Submitted tests for PM QA cpufreq * Modified script to conform to LAVA Regards, Mounir -- Mounir Bsaibes Project Manager Follow Linaro.org: facebook.com/pages/Linaro/155974581091106 http://twitter.com/#!/linaroorg http://www.linaro.org/linaro-blog <http://www.linaro.org/linaro-blog>

13 years, 10 months

[NOTES] Toolchain WG Weekly Status report 2011-07-08

by Mounir Bsaibes

Enclosed please find the links to the meetings minutes and Weekly Status report for the Toolchain working group for the week ending 2011-07-08. == Meetings minutes == https://wiki.linaro.org/WorkingGroups/Toolchain/Meetings/2011-07-04<https://wiki.linaro.org/WorkingGroups/ToolChain/Meetings/2011-07-04> https://wiki.linaro.org/WorkingGroups/Toolchain/Meetings/2011-07-07<https://wiki.linaro.org/WorkingGroups/ToolChain/Meetings/2011-07-07> == Weekly Status Report == https://wiki.linaro.org/WorkingGroups/ToolChain/Status/2011-07-07 == Summary == * Continuing to run bechmarks to identify areas that can be improved * Revital is looking into SPEC quantum which has a very hot loop * The testsuite failures when running GDB as a cross debugger have been logged and started on * Looking into using libunwind remotely against Android as an example crash debugger * Various GCC patches including: * Widening multiply in the core * Widening multiply in the vectoriser * Half precision float support * Support for NEON shifts by immediate value * A good number of bug fixes Regards, Mounir -- Mounir Bsaibes Project Manager Follow Linaro.org: facebook.com/pages/Linaro/155974581091106 http://twitter.com/#!/linaroorg http://www.linaro.org/linaro-blog <http://www.linaro.org/linaro-blog>

13 years, 10 months

[ACTIVITY] Status report for Graphics WG - wk27.2011 (20110704-20110708)

by Ilias Biris

Status report is in https://wiki.linaro.org/WorkingGroups/Middleware/Graphics/WeeklyReport Last weekly meeting minutes can be found from https://wiki.linaro.org/WorkingGroups/Middleware/Graphics/Notes/2011-07-06 Highlights 11.06 release done, great thanks to all! Graphics deliverables were part of the release (glcompbench, glamrk2, unity, nux). Planning for 11.07 is now in place. Milestone pages created, blueprints associated, work now moving forward to meet the targets. See the planned release content from Graphics in https://wiki.linaro.org/Cycles/1107/Release/MilestonePagesStatus Preparation for Connect is ongoing. GLEW patches have been submitted upstream, discussing now the revisions to be made. Android targets: 0xbench - trying to see if the benchmarking work which Alexandros has been busy with can be folded into 0xbench. glmark2 seems to be a good candidate. ARMHF benchmarking for graphics was also discussed, if nothing else such work would provide also HF builds of the benchmarking packages we have in Graphics. Discussion ongoing, perhaps this is something to leave for discusion during Linaro Connect - it depends on the time available with the release happening in less than 2 weeks Memory management has seen a different kind of communication on the lists this week. Linaro folks are working to drive the solutions safely ahead, addressing stakeholder concerns on the way. Best, -- Ilias Biris ilias.biris(a)linaro.org Project Manager, Linaro M: +358504839608, IRC: ibiris Skype: ilias_biris Linaro.org│ Open source software for ARM SoCs

13 years, 10 months

Re: Updated armel cross toolchains for lucid/maverick/natty releases

by Marcin Juszkiewicz

On 08.07.2011 00:11, Michael Hope wrote: > On Thu, Jul 7, 2011 at 1:36 AM, Marcin Juszkiewicz >> There is no gcc-4.6 for Lucid currently as it requires newer versions of >> few libraries (mpfr, mpc) and one of rule of this PPA is "do not update >> packages which may affect other packages". > > Hi Marcin. The versions included with Lucid are OK for 4.6. Lucid > includes libmpc 0.8.1 (GCC's configure.ac marks it as 'buggy but > acceptable) and libmpfr 2.4.2. There is a difference in package names > - it's libmpfr1ldbl in Lucid and libmpfr4 in Natty. Thanks Michael. I do not remember why I though that. Anyway gcc-4.6 got built for Lucid too. Enjoy.

13 years, 10 months

[ACTIVITY] Status report for Office of CTO - wk27.2011 (20110704-20110708)

by Ilias Biris

Status report: https://wiki.linaro.org/OfficeofCTO/WeeklyReport Weekly meeting minutes: https://wiki.linaro.org/OfficeofCTO/2011-07-05 Highlights: ARMHF: Konstantinos has been doing benchmarking (check out https://wiki.linaro.org/OfficeofCTO/HardFloat/Benchmarks for more details of the results so far). A first release of Konstantinos' own images will be made for the 1107 as a non-official use-at-own-risk set of images. Blueprint to follow the images release is https://blueprints.launchpad.net/linaro/+spec/engr-octo-armhf-images. ArmHF Cross bootstrap: just about getting in place. Working on a libtool bug, as well as a second issue which is a lot of perl modules which do not cross build Boot architecture meetings have started. Boot architecture seems to be on a good start, goal this week is to have an agenda for the face to face Linaro Connect meeting. Device tree: seems to be moving along well. Patches should if all goes as expected get merged in the 3.1 kernel window. Work is being done also on device model and how it relates to power management. Work for 1107 planned - related to Boot Architecture, final updates to the device tree documentation, ARMHF work, SMP (64 bit sync primitives in gcc). For the highlights only ARMHF images availability is provided now, depending how the rest of the work goes we may have additional highlights for documentation made available Finally, the Office of CTO wiki is being updated, so keep watching that space for better wiki pages that convey all the great work done by that team -- Ilias Biris ilias.biris(a)linaro.org Project Manager, Linaro M: +358504839608, IRC: ibiris Skype: ilias_biris Linaro.org│ Open source software for ARM SoCs

13 years, 10 months

[PATCH] ARM:SAMSUNG: DMA Cleanup as per sparse

by Sangwook Lee

Function declaration differs between file: dma.c and file:dma.h and SPARSE (Documentation/sparse.txt) gives error messages All dma channels are members of 'enum dma_ch' and not 'unsigned int' Please have a look at channel definitions in: arch/arm/mach-s3c64xx/include/mach/dma.h arch/arm/plat-samsung/include/plat/s3c-dma-pl330.h arch/arm/mach-s3c2410/include/mach/dma.h So all arguments should be of type 'enum dma_ch' Signed-off-by: Sangwook Lee <sangwook.lee(a)linaro.org> --- arch/arm/mach-s3c64xx/dma.c | 14 +++++++------- arch/arm/plat-s3c24xx/dma.c | 12 ++++++------ arch/arm/plat-samsung/dma.c | 6 +++--- arch/arm/plat-samsung/include/plat/dma.h | 21 +++++++++++---------- 4 files changed, 27 insertions(+), 26 deletions(-) diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c index b197171..204bfaf 100644 --- a/arch/arm/mach-s3c64xx/dma.c +++ b/arch/arm/mach-s3c64xx/dma.c @@ -113,7 +113,7 @@ found: return chan; } -int s3c2410_dma_config(unsigned int channel, int xferunit) +int s3c2410_dma_config(enum dma_ch channel, int xferunit) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -297,7 +297,7 @@ static int s3c64xx_dma_flush(struct s3c2410_dma_chan *chan) return 0; } -int s3c2410_dma_ctrl(unsigned int channel, enum s3c2410_chan_op op) +int s3c2410_dma_ctrl(enum dma_ch channel, enum s3c2410_chan_op op) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -331,7 +331,7 @@ EXPORT_SYMBOL(s3c2410_dma_ctrl); * */ -int s3c2410_dma_enqueue(unsigned int channel, void *id, +int s3c2410_dma_enqueue(enum dma_ch channel, void *id, dma_addr_t data, int size) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -415,7 +415,7 @@ err_buff: EXPORT_SYMBOL(s3c2410_dma_enqueue); -int s3c2410_dma_devconfig(unsigned int channel, +int s3c2410_dma_devconfig(enum dma_ch channel, enum s3c2410_dmasrc source, unsigned long devaddr) { @@ -463,7 +463,7 @@ int s3c2410_dma_devconfig(unsigned int channel, EXPORT_SYMBOL(s3c2410_dma_devconfig); -int s3c2410_dma_getposition(unsigned int channel, +int s3c2410_dma_getposition(enum dma_ch channel, dma_addr_t *src, dma_addr_t *dst) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -487,7 +487,7 @@ EXPORT_SYMBOL(s3c2410_dma_getposition); * get control of an dma channel */ -int s3c2410_dma_request(unsigned int channel, +int s3c2410_dma_request(enum dma_ch channel, struct s3c2410_dma_client *client, void *dev) { @@ -533,7 +533,7 @@ EXPORT_SYMBOL(s3c2410_dma_request); * allowed to go through. */ -int s3c2410_dma_free(unsigned int channel, struct s3c2410_dma_client *client) +int s3c2410_dma_free(enum dma_ch channel, struct s3c2410_dma_client *client) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); unsigned long flags; diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c index 2abf966..623fba5 100644 --- a/arch/arm/plat-s3c24xx/dma.c +++ b/arch/arm/plat-s3c24xx/dma.c @@ -712,7 +712,7 @@ static struct s3c2410_dma_chan *s3c2410_dma_map_channel(int channel); * get control of an dma channel */ -int s3c2410_dma_request(unsigned int channel, +int s3c2410_dma_request(enum dma_ch channel, struct s3c2410_dma_client *client, void *dev) { @@ -783,7 +783,7 @@ EXPORT_SYMBOL(s3c2410_dma_request); * allowed to go through. */ -int s3c2410_dma_free(unsigned int channel, struct s3c2410_dma_client *client) +int s3c2410_dma_free(enum dma_ch channel, struct s3c2410_dma_client *client) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); unsigned long flags; @@ -974,7 +974,7 @@ static int s3c2410_dma_started(struct s3c2410_dma_chan *chan) } int -s3c2410_dma_ctrl(unsigned int channel, enum s3c2410_chan_op op) +s3c2410_dma_ctrl(enum dma_ch channel, enum s3c2410_chan_op op) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -1021,7 +1021,7 @@ EXPORT_SYMBOL(s3c2410_dma_ctrl); * xfersize: size of unit in bytes (1,2,4) */ -int s3c2410_dma_config(unsigned int channel, +int s3c2410_dma_config(enum dma_ch channel, int xferunit) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -1104,7 +1104,7 @@ EXPORT_SYMBOL(s3c2410_dma_config); * devaddr: physical address of the source */ -int s3c2410_dma_devconfig(unsigned int channel, +int s3c2410_dma_devconfig(enum dma_ch channel, enum s3c2410_dmasrc source, unsigned long devaddr) { @@ -1177,7 +1177,7 @@ EXPORT_SYMBOL(s3c2410_dma_devconfig); * returns the current transfer points for the dma source and destination */ -int s3c2410_dma_getposition(unsigned int channel, dma_addr_t *src, dma_addr_t *dst) +int s3c2410_dma_getposition(enum dma_ch channel, dma_addr_t *src, dma_addr_t *dst) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); diff --git a/arch/arm/plat-samsung/dma.c b/arch/arm/plat-samsung/dma.c index cb459dd..6143aa1 100644 --- a/arch/arm/plat-samsung/dma.c +++ b/arch/arm/plat-samsung/dma.c @@ -41,7 +41,7 @@ struct s3c2410_dma_chan *s3c_dma_lookup_channel(unsigned int channel) * irq? */ -int s3c2410_dma_set_opfn(unsigned int channel, s3c2410_dma_opfn_t rtn) +int s3c2410_dma_set_opfn(enum dma_ch channel, s3c2410_dma_opfn_t rtn) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -56,7 +56,7 @@ int s3c2410_dma_set_opfn(unsigned int channel, s3c2410_dma_opfn_t rtn) } EXPORT_SYMBOL(s3c2410_dma_set_opfn); -int s3c2410_dma_set_buffdone_fn(unsigned int channel, s3c2410_dma_cbfn_t rtn) +int s3c2410_dma_set_buffdone_fn(enum dma_ch channel, s3c2410_dma_cbfn_t rtn) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); @@ -71,7 +71,7 @@ int s3c2410_dma_set_buffdone_fn(unsigned int channel, s3c2410_dma_cbfn_t rtn) } EXPORT_SYMBOL(s3c2410_dma_set_buffdone_fn); -int s3c2410_dma_setflags(unsigned int channel, unsigned int flags) +int s3c2410_dma_setflags(enum dma_ch channel, unsigned int flags) { struct s3c2410_dma_chan *chan = s3c_dma_lookup_channel(channel); diff --git a/arch/arm/plat-samsung/include/plat/dma.h b/arch/arm/plat-samsung/include/plat/dma.h index 2e8f8c6..8c273b7 100644 --- a/arch/arm/plat-samsung/include/plat/dma.h +++ b/arch/arm/plat-samsung/include/plat/dma.h @@ -42,6 +42,7 @@ struct s3c2410_dma_client { }; struct s3c2410_dma_chan; +enum dma_ch; /* s3c2410_dma_cbfn_t * @@ -62,7 +63,7 @@ typedef int (*s3c2410_dma_opfn_t)(struct s3c2410_dma_chan *, * request a dma channel exclusivley */ -extern int s3c2410_dma_request(unsigned int channel, +extern int s3c2410_dma_request(enum dma_ch channel, struct s3c2410_dma_client *, void *dev); @@ -71,14 +72,14 @@ extern int s3c2410_dma_request(unsigned int channel, * change the state of the dma channel */ -extern int s3c2410_dma_ctrl(unsigned int channel, enum s3c2410_chan_op op); +extern int s3c2410_dma_ctrl(enum dma_ch channel, enum s3c2410_chan_op op); /* s3c2410_dma_setflags * * set the channel's flags to a given state */ -extern int s3c2410_dma_setflags(unsigned int channel, +extern int s3c2410_dma_setflags(enum dma_ch channel, unsigned int flags); /* s3c2410_dma_free @@ -86,7 +87,7 @@ extern int s3c2410_dma_setflags(unsigned int channel, * free the dma channel (will also abort any outstanding operations) */ -extern int s3c2410_dma_free(unsigned int channel, struct s3c2410_dma_client *); +extern int s3c2410_dma_free(enum dma_ch channel, struct s3c2410_dma_client *); /* s3c2410_dma_enqueue * @@ -95,7 +96,7 @@ extern int s3c2410_dma_free(unsigned int channel, struct s3c2410_dma_client *); * drained before the buffer is given to the DMA system. */ -extern int s3c2410_dma_enqueue(unsigned int channel, void *id, +extern int s3c2410_dma_enqueue(enum dma_ch channel, void *id, dma_addr_t data, int size); /* s3c2410_dma_config @@ -103,14 +104,14 @@ extern int s3c2410_dma_enqueue(unsigned int channel, void *id, * configure the dma channel */ -extern int s3c2410_dma_config(unsigned int channel, int xferunit); +extern int s3c2410_dma_config(enum dma_ch channel, int xferunit); /* s3c2410_dma_devconfig * * configure the device we're talking to */ -extern int s3c2410_dma_devconfig(unsigned int channel, +extern int s3c2410_dma_devconfig(enum dma_ch channel, enum s3c2410_dmasrc source, unsigned long devaddr); /* s3c2410_dma_getposition @@ -118,10 +119,10 @@ extern int s3c2410_dma_devconfig(unsigned int channel, * get the position that the dma transfer is currently at */ -extern int s3c2410_dma_getposition(unsigned int channel, +extern int s3c2410_dma_getposition(enum dma_ch channel, dma_addr_t *src, dma_addr_t *dest); -extern int s3c2410_dma_set_opfn(unsigned int, s3c2410_dma_opfn_t rtn); -extern int s3c2410_dma_set_buffdone_fn(unsigned int, s3c2410_dma_cbfn_t rtn); +extern int s3c2410_dma_set_opfn(enum dma_ch, s3c2410_dma_opfn_t rtn); +extern int s3c2410_dma_set_buffdone_fn(enum dma_ch, s3c2410_dma_cbfn_t rtn); -- 1.7.4.1

13 years, 10 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev