linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

by Etienne Le Sueur

Hi Linaro-dev list, I'm trying to set up my Pandaboard as a small server using a 3G USB dongle. I'm trying to set up a PPP connection to my provider, but pppd is complaining: "Couldn't set tty to PPP discipline: Invalid argument" My google-foo tells me that this could be the result of some disabled kernel configs, speficially PPP_ASYNC and PPP_SYNC_TTY - http://lists.debian.org/debian-user/2002/09/msg01810.html linaro@linarotv-xbmc:/etc/ppp$ grep "PPP" /boot/config-3.1.1-8-linaro-lt-omap CONFIG_PPP=m # CONFIG_PPPOE is not set # CONFIG_PPP_ASYNC is not set # CONFIG_PPP_BSDCOMP is not set # CONFIG_PPP_DEFLATE is not set # CONFIG_PPP_FILTER is not set # CONFIG_PPP_MPPE is not set # CONFIG_PPP_MULTILINK is not set # CONFIG_PPP_SYNC_TTY is not set linaro@linarotv-xbmc:/etc/ppp$ uname -a Linux linarotv-xbmc 3.1.1-8-linaro-lt-omap #8~lt~ci~20120118001257+025756-Ubuntu SMP PREEMPT Thu Jan 19 09: armv7l armv7l armv7l GNU/Linux Would it be possible to enable these config options in the nightly build so I can try with a new kernel tomorrow? Otherwise I can spend the time to build my own kernel and report back if that's the route you'd rather take. Cheers, Etienne Le Sueur

13 years, 3 months

[PATCH] sched: generalize CONFIG_IRQ_TIME_ACCOUNTING for X86 and ARM

by Dmitry Antipov

Generalize CONFIG_IRQ_TIME_ACCOUNTING between X86 and ARM, move "noirqtime=" option to common debugging code. Signed-off-by: Dmitry Antipov <dmitry.antipov(a)linaro.org> --- arch/arm/kernel/sched_clock.c | 3 +++ arch/x86/Kconfig | 11 ----------- arch/x86/kernel/tsc.c | 4 ---- include/linux/sched.h | 2 ++ lib/Kconfig.debug | 12 ++++++++++++ lib/Makefile | 2 ++ lib/irqtime.c | 12 ++++++++++++ 7 files changed, 31 insertions(+), 15 deletions(-) create mode 100644 lib/irqtime.c diff --git a/arch/arm/kernel/sched_clock.c b/arch/arm/kernel/sched_clock.c index 5416c7c..56d2a9d 100644 --- a/arch/arm/kernel/sched_clock.c +++ b/arch/arm/kernel/sched_clock.c @@ -162,5 +162,8 @@ void __init sched_clock_postinit(void) if (read_sched_clock == jiffy_sched_clock_read) setup_sched_clock(jiffy_sched_clock_read, 32, HZ); + if (!no_sched_irq_time) + enable_sched_clock_irqtime(); + sched_clock_poll(sched_clock_timer.data); } diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 5bed94e..4759676 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -805,17 +805,6 @@ config SCHED_MC making when dealing with multi-core CPU chips at a cost of slightly increased overhead in some places. If unsure say N here. -config IRQ_TIME_ACCOUNTING - bool "Fine granularity task level IRQ time accounting" - default n - ---help--- - Select this option to enable fine granularity task irq time - accounting. This is done by reading a timestamp on each - transitions between softirq and hardirq state, so there can be a - small performance impact. - - If in doubt, say N here. - source "kernel/Kconfig.preempt" config X86_UP_APIC diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c index a62c201..a3a5465 100644 --- a/arch/x86/kernel/tsc.c +++ b/arch/x86/kernel/tsc.c @@ -103,14 +103,10 @@ int __init notsc_setup(char *str) __setup("notsc", notsc_setup); -static int no_sched_irq_time; - static int __init tsc_setup(char *str) { if (!strcmp(str, "reliable")) tsc_clocksource_reliable = 1; - if (!strncmp(str, "noirqtime", 9)) - no_sched_irq_time = 1; return 1; } diff --git a/include/linux/sched.h b/include/linux/sched.h index 7d379a6..b3575b5 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1966,9 +1966,11 @@ extern void sched_clock_idle_wakeup_event(u64 delta_ns); * The reason for this explicit opt-in is not to have perf penalty with * slow sched_clocks. */ +extern int no_sched_irq_time; extern void enable_sched_clock_irqtime(void); extern void disable_sched_clock_irqtime(void); #else +#define no_sched_irq_time 1 static inline void enable_sched_clock_irqtime(void) {} static inline void disable_sched_clock_irqtime(void) {} #endif diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 8745ac7..a55287e 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -299,6 +299,18 @@ config SCHEDSTATS application, you can say N to avoid the very slight overhead this adds. +config IRQ_TIME_ACCOUNTING + bool "Fine granularity task level IRQ time accounting" + depends on DEBUG_KERNEL && (X86 || (ARM && HAVE_SCHED_CLOCK)) + default n + ---help--- + Select this option to enable fine granularity task irq time + accounting. This is done by reading a timestamp on each + transitions between softirq and hardirq state, so there can be a + small performance impact. + + If in doubt, say N here. + config TIMER_STATS bool "Collect kernel timers statistics" depends on DEBUG_KERNEL && PROC_FS diff --git a/lib/Makefile b/lib/Makefile index 18515f0..44d67d4 100644 --- a/lib/Makefile +++ b/lib/Makefile @@ -49,6 +49,8 @@ obj-$(CONFIG_DEBUG_PREEMPT) += smp_processor_id.o obj-$(CONFIG_DEBUG_LIST) += list_debug.o obj-$(CONFIG_DEBUG_OBJECTS) += debugobjects.o +obj-$(CONFIG_IRQ_TIME_ACCOUNTING) += irqtime.o + ifneq ($(CONFIG_HAVE_DEC_LOCK),y) lib-y += dec_and_lock.o endif diff --git a/lib/irqtime.c b/lib/irqtime.c new file mode 100644 index 0000000..10d440d --- /dev/null +++ b/lib/irqtime.c @@ -0,0 +1,12 @@ +#include <linux/kernel.h> +#include <linux/sched.h> + +int no_sched_irq_time; + +static int __init irqtime_setup(char *str) +{ + no_sched_irq_time = 1; + return 1; +} + +__setup("noirqtime", irqtime_setup); -- 1.7.7.6

13 years, 3 months

[REMINDER] Linaro 12.02 release dates and deliveries

by David Zinman

Greetings, Hope everyone is enjoying connect so far. This is a reminder for the coming release dates: * Linaro 12.02 Toolchain WG release February 9, 2012. * Linaro 12.02 Platform/WGs/LTs is February 16, 2012. * Linaro 12.02 Release Candidate is February 20, 2012. * Linaro 12.02 Release images is February 23, 2012. * Linaro 12.02 release is UTC 16:00, February 23, 2012. The release calendar for this cycle can be found here: https://wiki.linaro.org/Cycles/1202/Release/Calendar -- David Zinman Linaro Release Manager | Project Manager Linaro.org | Open source software for ARM SoCs

13 years, 3 months

[RFC PATCH 0/2] thermal: Add generic cpu cooling devices according to thermal framework

by Amit Daniel Kachhap

PATCH 1) [thermal: Add a new trip type to use cooling device instance number] This patch adds a new trip type THERMAL_TRIP_STATE_ACTIVE which passes cooling device instance number and may be helpful for cpufreq cooling devices to take the correct cooling action. PATCH 2) [thermal: Add generic cpu cooling implementation] This patch adds generic cpu cooling low level implementation through frequency clipping and cpu hotplug. In future, other cpu related cooling devices may be added here. An ACPI version of this already exists(drivers/acpi/processor_thermal.c). But this will be useful for platforms like ARM using the generic thermal interface along with the generic cpu cooling devices. The cooling device registration API's return cooling device pointers which can be easily binded with the thermal zone trip points. Amit Daniel Kachhap (2): thermal: Add a new trip type to use cooling device instance number thermal: Add generic cpu cooling implementation Documentation/thermal/cpu-cooling-api.txt | 52 +++++ Documentation/thermal/sysfs-api.txt | 4 +- drivers/thermal/Kconfig | 11 + drivers/thermal/Makefile | 1 + drivers/thermal/cpu_cooling.c | 302 +++++++++++++++++++++++++++++ drivers/thermal/thermal_sys.c | 27 +++- include/linux/cpu_cooling.h | 45 +++++ include/linux/thermal.h | 1 + 8 files changed, 440 insertions(+), 3 deletions(-) create mode 100644 Documentation/thermal/cpu-cooling-api.txt create mode 100644 drivers/thermal/cpu_cooling.c create mode 100644 include/linux/cpu_cooling.h

13 years, 3 months

[linux-pm][RFC PATCH] thermal: Add support to report cooling statistics achieved by cooling devices

by Amit Daniel Kachhap

Add a sysfs node code to report effective cooling of all cooling devices attached to each trip points of a thermal zone. The cooling data reported will be absolute if the higher temperature trip points are arranged first otherwise the cooling stats is the cumulative effect of the earlier invoked cooling handlers. The basic assumption is that cooling devices will bring down the temperature in a symmetric manner and those statistics can be stored back and used for further tuning of the system. Signed-off-by: Amit Daniel Kachhap <amit.kachhap(a)linaro.org> --- Documentation/thermal/sysfs-api.txt | 10 ++++ drivers/thermal/thermal_sys.c | 96 +++++++++++++++++++++++++++++++++++ include/linux/thermal.h | 8 +++ 3 files changed, 114 insertions(+), 0 deletions(-) diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt index b61e46f..1db9a9d 100644 --- a/Documentation/thermal/sysfs-api.txt +++ b/Documentation/thermal/sysfs-api.txt @@ -209,6 +209,13 @@ passive Valid values: 0 (disabled) or greater than 1000 RW, Optional +trip_stats + This attribute presents the effective cooling generated from all the + cooling devices attached to a trip point. The output is a pair of value + for each trip point. Each pair represents + (trip index, cooling temperature difference in millidegree Celsius) + RO, Optional + ***************************** * Cooling device attributes * ***************************** @@ -261,6 +268,9 @@ method, the sys I/F structure will be built like this: |---cdev0_trip_point: 1 /* cdev0 can be used for passive */ |---cdev1: --->/sys/class/thermal/cooling_device3 |---cdev1_trip_point: 2 /* cdev1 can be used for active[0]*/ + |---trip_stats 0 0 + 1 8000 /*trip 1 causes 8 degree Celsius drop*/ + 2 3000 /*trip 2 causes 3 degree Celsius drop*/ |cooling_device0: |---type: Processor diff --git a/drivers/thermal/thermal_sys.c b/drivers/thermal/thermal_sys.c index dd9a574..47e7b6e 100644 --- a/drivers/thermal/thermal_sys.c +++ b/drivers/thermal/thermal_sys.c @@ -92,6 +92,64 @@ static void release_idr(struct idr *idr, struct mutex *lock, int id) if (lock) mutex_unlock(lock); } +static void update_cooling_stats(struct thermal_zone_device *tz, long cur_temp) +{ + int count, max_index, cur_interval; + long trip_temp, max_temp = 0, cool_temp; + static int last_trip_level = -1; + + if (cur_temp >= tz->last_temperature) + return; + + /* find the trip according to last temperature */ + for (count = 0; count < tz->trips; count++) { + tz->ops->get_trip_temp(tz, count, &trip_temp); + if (tz->last_temperature >= trip_temp) { + if (max_temp < trip_temp) { + max_temp = trip_temp; + max_index = count; + } + } + } + + if (!max_temp) { + last_trip_level = -1; + return; + } + + cur_interval = tz->stat[max_index].interval_ptr; + cool_temp = tz->last_temperature - cur_temp; + + if (last_trip_level != max_index) { + if (++cur_interval == INTERVAL_HISTORY) + cur_interval = 0; + tz->stat[max_index].cool_temp[cur_interval] = cool_temp; + tz->stat[max_index].interval_ptr = cur_interval; + last_trip_level = max_index; + } else { + tz->stat[max_index].cool_temp[cur_interval] += cool_temp; + } +} + +static int calculate_cooling_temp_avg(struct thermal_zone_device *tz, int trip, + int *avg_cool) +{ + int result = 0, count = 0, used_data = 0; + + if (trip > THERMAL_MAX_TRIPS) + return -EINVAL; + + *avg_cool = 0; + for (count = 0; count < INTERVAL_HISTORY; count++) { + if (tz->stat[trip].cool_temp[count] > 0) { + *avg_cool += tz->stat[trip].cool_temp[count]; + used_data++; + } + } + if (used_data > 1) + *avg_cool = (*avg_cool)/used_data; + return result; +} /* sys I/F for thermal zone */ @@ -493,6 +551,26 @@ temp_crit_show(struct device *dev, struct device_attribute *attr, return sprintf(buf, "%ld\n", temperature); } +static ssize_t +thermal_cooling_trip_stats_show(struct device *dev, + struct device_attribute *attr, + char *buf) +{ + struct thermal_zone_device *tz = to_thermal_zone(dev); + int avg_cool = 0, result, trip_index; + ssize_t len = 0; + + for (trip_index = 0; trip_index < tz->trips; trip_index++) { + result = calculate_cooling_temp_avg(tz, + trip_index, &avg_cool); + if (!result) + len += sprintf(buf + len, "%d %d\n", + trip_index, avg_cool); + } + return len; +} +static DEVICE_ATTR(trip_stats, 0444, + thermal_cooling_trip_stats_show, NULL); static struct thermal_hwmon_device * thermal_hwmon_lookup_by_type(const struct thermal_zone_device *tz) @@ -1049,6 +1127,8 @@ void thermal_zone_device_update(struct thermal_zone_device *tz) goto leave; } + update_cooling_stats(tz, temp); + for (count = 0; count < tz->trips; count++) { tz->ops->get_trip_type(tz, count, &trip_type); tz->ops->get_trip_temp(tz, count, &trip_temp); @@ -1181,6 +1261,13 @@ struct thermal_zone_device *thermal_zone_device_register(char *type, return ERR_PTR(result); } + /*Allocate variables for cooling stats*/ + tz->stat = devm_kzalloc(&tz->device, + sizeof(struct thermal_cooling_stats) * trips, + GFP_KERNEL); + if (!tz->stat) + goto unregister; + /* sys I/F */ if (type) { result = device_create_file(&tz->device, &dev_attr_type); @@ -1207,6 +1294,12 @@ struct thermal_zone_device *thermal_zone_device_register(char *type, passive = 1; } + if (trips > 0) { + result = device_create_file(&tz->device, &dev_attr_trip_stats); + if (result) + goto unregister; + } + if (!passive) result = device_create_file(&tz->device, &dev_attr_passive); @@ -1282,6 +1375,9 @@ void thermal_zone_device_unregister(struct thermal_zone_device *tz) for (count = 0; count < tz->trips; count++) TRIP_POINT_ATTR_REMOVE(&tz->device, count); + if (tz->trips > 0) + device_remove_file(&tz->device, &dev_attr_trip_stats); + thermal_remove_hwmon_sysfs(tz); release_idr(&thermal_tz_idr, &thermal_idr_lock, tz->id); idr_destroy(&tz->idr); diff --git a/include/linux/thermal.h b/include/linux/thermal.h index 47b4a27..47504c7 100644 --- a/include/linux/thermal.h +++ b/include/linux/thermal.h @@ -72,6 +72,13 @@ struct thermal_cooling_device_ops { #define THERMAL_TRIPS_NONE -1 #define THERMAL_MAX_TRIPS 12 #define THERMAL_NAME_LENGTH 20 +#define INTERVAL_HISTORY 12 + +struct thermal_cooling_stats { + int cool_temp[INTERVAL_HISTORY]; + int interval_ptr; +}; + struct thermal_cooling_device { int id; char type[THERMAL_NAME_LENGTH]; @@ -102,6 +109,7 @@ struct thermal_zone_device { struct list_head cooling_devices; struct idr idr; struct mutex lock; /* protect cooling devices list */ + struct thermal_cooling_stats *stat; struct list_head node; struct delayed_work poll_queue; }; -- 1.7.1

13 years, 3 months

Re: [PATCH 6/6] mmc: omap_hsmmc: Don't expect MMC1 to always have vmmc supply

by S, Venkatraman

On Sat, Feb 4, 2012 at 8:21 PM, Rajendra Nayak <rnayak(a)ti.com> wrote: > MMC1 is not the only instance that can be used/wired for SD. > So remove this assumption from the driver. > > Signed-off-by: Rajendra Nayak <rnayak(a)ti.com> > --- > drivers/mmc/host/omap_hsmmc.c | 14 -------------- > 1 files changed, 0 insertions(+), 14 deletions(-) > > diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c > index 17e264b..97d3065 100644 > --- a/drivers/mmc/host/omap_hsmmc.c > +++ b/drivers/mmc/host/omap_hsmmc.c > @@ -300,7 +300,6 @@ static int omap_hsmmc_set_power(struct device *dev, int slot, int power_on, > static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > { > struct regulator *reg; > - int ret = 0; > int ocr_value = 0; > > mmc_slot(host).set_power = omap_hsmmc_set_power; > @@ -308,15 +307,6 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > reg = regulator_get(host->dev, "vmmc"); > if (IS_ERR(reg)) { > dev_dbg(host->dev, "vmmc regulator missing\n"); > - /* > - * HACK: until fixed.c regulator is usable, > - * we don't require a main regulator > - * for MMC2 or MMC3 > - */ > - if (host->id == OMAP_MMC1_DEVID) { > - ret = PTR_ERR(reg); > - goto err; > - } > } else { > host->vcc = reg; > ocr_value = mmc_regulator_get_ocrmask(reg); > @@ -358,10 +348,6 @@ static int omap_hsmmc_reg_get(struct omap_hsmmc_host *host) > } > > return 0; > - > -err: > - mmc_slot(host).set_power = NULL; > - return ret; > } > > static void omap_hsmmc_reg_put(struct omap_hsmmc_host *host) > -- Almost all usage of the id field is gone, except for a trivial debug print. Would be prudent to get rid of it entirely from struct omap_hsmmc_host.

13 years, 3 months

[PATCH] ux500 : decouple/recouple gic from the PRCMU

by Daniel Lezcano

This patch allows to decouple and recouple the gic from the PRCMU. This is needed to put the A9 core in retention mode with the cpuidle driver. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> --- drivers/mfd/db8500-prcmu.c | 42 ++++++++++++++++++++++++++++++++++++++ include/linux/mfd/db8500-prcmu.h | 2 + include/linux/mfd/dbx500-prcmu.h | 16 ++++++++++++++ 3 files changed, 60 insertions(+), 0 deletions(-) diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c index af8e0ef..c708431 100644 --- a/drivers/mfd/db8500-prcmu.c +++ b/drivers/mfd/db8500-prcmu.c @@ -528,6 +528,10 @@ static const char *hwacc_ret_regulator_name[NUM_HW_ACC] = { #define PRCMU_PLLDSI_LOCKP_LOCKED 0x3 +#define PRCMU_A9_MASK_REQ 0x00000328 +#define PRCMU_A9_MASK_REQ_MASK 0x00000001 +#define PRCMU_A9_MASK_ACK 0x0000032C + static struct { u8 project_number; u8 api_version; @@ -787,6 +791,44 @@ int db8500_prcmu_set_power_state(u8 state, bool keep_ulp_clk, bool keep_ap_pll) return 0; } +/* + * prcmu_gic_mask - apply the mask to the mask request + * register. This mask has the bits [1-31] reserved and + * the request applies to the bit 0 of this register. + */ +static inline void prcmu_gic_mask(u32 mask) +{ + u32 val = readl(_PRCMU_BASE + PRCMU_A9_MASK_REQ); + writel((val & ~PRCMU_A9_MASK_REQ_MASK) | mask, + _PRCMU_BASE + PRCMU_A9_MASK_REQ); +} + +/* + * db8500_prcmu_gic_disable - This function decouple the gic + * from the prcmu. + */ +void db8500_prcmu_gic_disable(void) +{ + prcmu_gic_mask(PRCMU_A9_MASK_REQ_MASK); + + /* Wait for gic mask register update */ + while (!(readl(_PRCMU_BASE + PRCMU_A9_MASK_REQ) & + PRCMU_A9_MASK_REQ_MASK)) + cpu_relax(); + + /* Wait a few cycles for the gic mask completion */ + udelay(1); +} + +/* + * db8500_prcmu_gic_enable - This function recouple the gic + * with the prcmu. + */ +void db8500_prcmu_gic_enable(void) +{ + prcmu_gic_mask(0); +} + /* This function should only be called while mb0_transfer.lock is held. */ static void config_wakeups(void) { diff --git a/include/linux/mfd/db8500-prcmu.h b/include/linux/mfd/db8500-prcmu.h index 60d27f7..4a1032c 100644 --- a/include/linux/mfd/db8500-prcmu.h +++ b/include/linux/mfd/db8500-prcmu.h @@ -536,6 +536,8 @@ int prcmu_load_a9wdog(u8 id, u32 val); void db8500_prcmu_system_reset(u16 reset_code); int db8500_prcmu_set_power_state(u8 state, bool keep_ulp_clk, bool keep_ap_pll); +void db8500_prcmu_gic_disable(void); +void db8500_prcmu_gic_enable(void); void db8500_prcmu_enable_wakeups(u32 wakeups); int db8500_prcmu_set_epod(u16 epod_id, u8 epod_state); int db8500_prcmu_request_clock(u8 clock, bool enable); diff --git a/include/linux/mfd/dbx500-prcmu.h b/include/linux/mfd/dbx500-prcmu.h index bac942f..a5fee69 100644 --- a/include/linux/mfd/dbx500-prcmu.h +++ b/include/linux/mfd/dbx500-prcmu.h @@ -237,6 +237,22 @@ static inline int prcmu_set_power_state(u8 state, bool keep_ulp_clk, keep_ap_pll); } +static inline void prcmu_gic_disable(void) +{ + if (machine_is_u5500()) + return; + else + return db8500_prcmu_gic_disable(); +} + +static inline void prcmu_gic_enable(void) +{ + if (machine_is_u5500()) + return; + else + return db8500_prcmu_gic_enable(); +} + static inline int prcmu_set_epod(u16 epod_id, u8 epod_state) { if (machine_is_u5500()) -- 1.7.5.4

13 years, 3 months

Re: FW: [PATCH 02/07] HWMON: DA9052/53 hwmon driver v1

by Ashish Jangam

On Tue, 2012-02-07 at 17:52 +0530, Ashish Jangam wrote: > Can you consider adding yourself or David as maintainer ? Not a must, > but no one else would really be able to support the driver. Thank for this, you can add my name. > > +Supported chips: > > + * Dialog Semiconductors DA9052-BC and DA9053-AA/Bx PMICs > > + Prefix: 'da9052' > > + Datasheet: Kindly visit www.dialog-semiconductor.com and request for the > > + official datasheet. > > + > Maybe, but that doesn't seem to be straightforward. The web site has no > search field, and I am not sure who to contact in the contact list. And > since there does not seem to be support in the US, I am not sure if one > is expected to contact someone in Europe or Taiwan or some other place. > > Maybe you can let me know how exactly to get the datasheets - I like to > keep those around for chips we are supporting. You need to request for DA9052/53 datasheet from www.dialog-semiconductor.com/DA9053.php > > > +static ssize_t da9052_read_tjunc(struct device *dev, > > + struct device_attribute *devattr, char *buf) > > +{ > > + struct da9052_hwmon *hwmon = dev_get_drvdata(dev); > > + int tjunc, toffset, result; > > + > > + tjunc = da9052_reg_read(hwmon->da9052, DA9052_TJUNC_RES_REG); > > + if (tjunc < 0) > > + return tjunc; > > + > > + toffset = da9052_reg_read(hwmon->da9052, DA9052_T_OFFSET_REG); > > + if (toffset < 0) > > + return toffset; > > + > > + if ((tjunc - toffset) == 0) > > + result = 0; > > + else > > + /* Degrees celsius = 1.708 * (TJUNC_RES - T_OFFSET) - 108.8 */ > > + result = 1708 * (tjunc - toffset) - 108800; > > + > > Hmm. > tjunc = 1, toffset = 2: > return 1708 * (-1) - 108800 = -108800 - 1708 = -110508 > tjunc = 2, toffset = 2: > return 0 > tjunc = 3, toffset = 2: > return 1780 * 1 - 108800 = -108800 + 1708 = -107092 > > I am not saying this is wrong, not having access to the data sheet, but > it is a bit odd. Why is the 0-difference case handled differently, and > why does it return 0 and not, say, -108800 ? > > If tjunc - toffset < 0 is invalid (no idea if it is, of course), it > might make sense to detect that condition. toffset is the trim value used for improving the calculated temperature accuracy so considering this tjunc - toffset <=0 seems to be not applicable cases. I will correct this along with your other comments and will re-submit the patch.

13 years, 3 months

[PATCH] sched: move CONFIG_IRQ_TIME_ACCOUNTING to common code

by Dmitry Antipov

Since CONFIG_IRQ_TIME_ACCOUNTING is architecture-agnostic, move it from x86 area to common code. Signed-off-by: Dmitry Antipov <dmitry.antipov(a)linaro.org> --- arch/x86/Kconfig | 11 ----------- lib/Kconfig.debug | 11 +++++++++++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 5bed94e..4759676 100644 --- a/arch/x86/Kconfig +++ b/arch/x86/Kconfig @@ -805,17 +805,6 @@ config SCHED_MC making when dealing with multi-core CPU chips at a cost of slightly increased overhead in some places. If unsure say N here. -config IRQ_TIME_ACCOUNTING - bool "Fine granularity task level IRQ time accounting" - default n - ---help--- - Select this option to enable fine granularity task irq time - accounting. This is done by reading a timestamp on each - transitions between softirq and hardirq state, so there can be a - small performance impact. - - If in doubt, say N here. - source "kernel/Kconfig.preempt" config X86_UP_APIC diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 8745ac7..d6d7afc 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -299,6 +299,17 @@ config SCHEDSTATS application, you can say N to avoid the very slight overhead this adds. +config IRQ_TIME_ACCOUNTING + bool "Fine granularity task level IRQ time accounting" + default n + ---help--- + Select this option to enable fine granularity task irq time + accounting. This is done by reading a timestamp on each + transitions between softirq and hardirq state, so there can be a + small performance impact. + + If in doubt, say N here. + config TIMER_STATS bool "Collect kernel timers statistics" depends on DEBUG_KERNEL && PROC_FS -- 1.7.7.6

13 years, 3 months

Continued Snowball Audio Session

by Tom Gall

If you were at the Snowball Audio session today (or wanted to be but were not able to make it) by popular demand a "part 2" session has been scheduled for Tuesday February 7th at 11:00 am in the Blue room. See you there! -- Regards, Tom "Where's the kaboom!? There was supposed to be an earth-shattering kaboom!" Marvin Martian Multimedia Tech Lead | Linaro.org │ Open source software for ARM SoCs w) tom.gall att linaro.org w) tom_gall att vnet.ibm.com h) tom_gall att mac.com

13 years, 3 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev