linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

[PATCH 0/2] Add ST-Ericsson AB8500 HWMON driver

by Hongbo Zhang

These patches are against the v3.8-rc4. Guenter Roeck, Jean Delvare, Please help to have a look at this. Samuel Ortiz, Please review 1/2 and leave your Acked-by: if no problem, I think these patches should be merged into HWMON tree. Thanks for all. Hongbo Zhang (2): ARM: ux500: rename ab8500 to abx500 for hwmon driver hwmon: add ST-Ericsson ABX500 hwmon driver drivers/hwmon/Kconfig | 13 + drivers/hwmon/Makefile | 1 + drivers/hwmon/ab8500.c | 160 +++++++++++ drivers/hwmon/abx500.c | 681 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/hwmon/abx500.h | 88 ++++++ drivers/mfd/ab8500-core.c | 6 +- 6 files changed, 946 insertions(+), 3 deletions(-) create mode 100644 drivers/hwmon/ab8500.c create mode 100644 drivers/hwmon/abx500.c create mode 100644 drivers/hwmon/abx500.h -- 1.8.0

13 years

[PATCH] cpufreq: governors: Reset tunables only for cpufreq_unregister_governor()

by Viresh Kumar

Currently, whenever governor->governor() is called for CPUFRREQ_GOV_START event we reset few tunables of governor. Which isn't correct, as this routine is called for every cpu hot-[un]plugging event. We should actually be resetting these only when the governor module is removed and re-installed. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/cpufreq.c | 4 ++++ drivers/cpufreq/cpufreq_governor.c | 24 ++++++++++++++++-------- include/linux/cpufreq.h | 1 + 3 files changed, 21 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 8d521422..9656420 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -1561,6 +1561,9 @@ static int __cpufreq_governor(struct cpufreq_policy *policy, policy->cpu, event); ret = policy->governor->governor(policy, event); + if (!policy->governor->initialized && (event == CPUFREQ_GOV_START)) + policy->governor->initialized = 1; + /* we keep one module reference alive for each CPU governed by this CPU */ if ((event != CPUFREQ_GOV_START) || ret) @@ -1584,6 +1587,7 @@ int cpufreq_register_governor(struct cpufreq_governor *governor) mutex_lock(&cpufreq_governor_mutex); + governor->initialized = 0; err = -EBUSY; if (__find_governor(governor->name) == NULL) { err = 0; diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 7aaa9b1..79795c4 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -254,11 +254,6 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, return rc; } - /* policy latency is in nS. Convert it to uS first */ - latency = policy->cpuinfo.transition_latency / 1000; - if (latency == 0) - latency = 1; - /* * conservative does not implement micro like ondemand * governor, thus we are bound to jiffes/HZ @@ -270,20 +265,33 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, cpufreq_register_notifier(cs_ops->notifier_block, CPUFREQ_TRANSITION_NOTIFIER); - dbs_data->min_sampling_rate = MIN_SAMPLING_RATE_RATIO * - jiffies_to_usecs(10); + if (!policy->governor->initialized) + dbs_data->min_sampling_rate = + MIN_SAMPLING_RATE_RATIO * + jiffies_to_usecs(10); } else { od_dbs_info->rate_mult = 1; od_dbs_info->sample_type = OD_NORMAL_SAMPLE; od_ops->powersave_bias_init_cpu(cpu); - od_tuners->io_is_busy = od_ops->io_busy(); + + if (!policy->governor->initialized) + od_tuners->io_is_busy = od_ops->io_busy(); } + if (policy->governor->initialized) + goto unlock; + + /* policy latency is in nS. Convert it to uS first */ + latency = policy->cpuinfo.transition_latency / 1000; + if (latency == 0) + latency = 1; + /* Bring kernel and HW constraints together */ dbs_data->min_sampling_rate = max(dbs_data->min_sampling_rate, MIN_LATENCY_MULTIPLIER * latency); *sampling_rate = max(dbs_data->min_sampling_rate, latency * LATENCY_MULTIPLIER); +unlock: mutex_unlock(&dbs_data->mutex); /* Initiate timer time stamp */ diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index feb360c..6bf3f2d 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -183,6 +183,7 @@ static inline unsigned long cpufreq_scale(unsigned long old, u_int div, u_int mu struct cpufreq_governor { char name[CPUFREQ_NAME_LEN]; + int initialized; int (*governor) (struct cpufreq_policy *policy, unsigned int event); ssize_t (*show_setspeed) (struct cpufreq_policy *policy, -- 1.7.12.rc2.18.g61b472e

13 years

[PATCH] cpufreq: governors: clean timer init and exit code

by Fabio Baltieri

Drop unused arguments from dbs_timer_init and clean dbs_timer_exit and cpufreq_governor_dbs to remove non necessary special cases. Reported-by: Viresh Kumar <viresh.kumar(a)linaro.org> Signed-off-by: Fabio Baltieri <fabio.baltieri(a)linaro.org> --- Hello Rafael, that's the cleanup on top of "cpufreq: handle SW coordinated CPUs". Thanks, Fabio drivers/cpufreq/cpufreq_governor.c | 43 ++++++++++++-------------------------- 1 file changed, 13 insertions(+), 30 deletions(-) diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index ee8b7ca..46f96a4 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -169,19 +169,19 @@ bool dbs_sw_coordinated_cpus(struct cpu_dbs_common_info *cdbs) } EXPORT_SYMBOL_GPL(dbs_sw_coordinated_cpus); -static inline void dbs_timer_init(struct dbs_data *dbs_data, - struct cpu_dbs_common_info *cdbs, - unsigned int sampling_rate, - int cpu) +static inline void dbs_timer_init(struct dbs_data *dbs_data, int cpu, + unsigned int sampling_rate) { int delay = delay_for_sampling_rate(sampling_rate); - struct cpu_dbs_common_info *cdbs_local = dbs_data->get_cpu_cdbs(cpu); + struct cpu_dbs_common_info *cdbs = dbs_data->get_cpu_cdbs(cpu); - schedule_delayed_work_on(cpu, &cdbs_local->work, delay); + schedule_delayed_work_on(cpu, &cdbs->work, delay); } -static inline void dbs_timer_exit(struct cpu_dbs_common_info *cdbs) +static inline void dbs_timer_exit(struct dbs_data *dbs_data, int cpu) { + struct cpu_dbs_common_info *cdbs = dbs_data->get_cpu_cdbs(cpu); + cancel_delayed_work_sync(&cdbs->work); } @@ -289,36 +289,19 @@ second_time: } mutex_unlock(&dbs_data->mutex); - if (dbs_sw_coordinated_cpus(cpu_cdbs)) { - /* Initiate timer time stamp */ - cpu_cdbs->time_stamp = ktime_get(); + /* Initiate timer time stamp */ + cpu_cdbs->time_stamp = ktime_get(); - for_each_cpu(j, policy->cpus) { - struct cpu_dbs_common_info *j_cdbs; - - j_cdbs = dbs_data->get_cpu_cdbs(j); - dbs_timer_init(dbs_data, j_cdbs, - *sampling_rate, j); - } - } else { - dbs_timer_init(dbs_data, cpu_cdbs, *sampling_rate, cpu); - } + for_each_cpu(j, policy->cpus) + dbs_timer_init(dbs_data, j, *sampling_rate); break; case CPUFREQ_GOV_STOP: if (dbs_data->governor == GOV_CONSERVATIVE) cs_dbs_info->enable = 0; - if (dbs_sw_coordinated_cpus(cpu_cdbs)) { - for_each_cpu(j, policy->cpus) { - struct cpu_dbs_common_info *j_cdbs; - - j_cdbs = dbs_data->get_cpu_cdbs(j); - dbs_timer_exit(j_cdbs); - } - } else { - dbs_timer_exit(cpu_cdbs); - } + for_each_cpu(j, policy->cpus) + dbs_timer_exit(dbs_data, j); mutex_lock(&dbs_data->mutex); mutex_destroy(&cpu_cdbs->timer_mutex); -- 1.7.12.1

13 years

big.LITTLE MP Scheduler test summary-Week-5

by Naresh Kamboju

Hi, Calendar Week 5, 2013: Here is test result summary for big.LITTLE MP Scheduler test on TC2 platform with Android image sched_tests.git No of Test Cases Tests Run Tests Pass Tests Fail Absolute pass rate (%) Failure Analysis/Comments Regression 20 20 20 0 100 - mpbasicsuite 14 14 14 0 100 - mpcoresuite 8 8 5 3 62 - mpextendedsuite 16 14 9 5 64 - mploadbalance 2 2 2 0 100 - Android Build: https://android-build.linaro.org/builds/~linaro-android-restricted/vexpress… Linux kernel: Linux localhost 3.8.0-rc4-00185-gc4d5a97 #1 SMP Thu Jan 31 09:15:31 UTC 2013 Results spread sheet: https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0Ai9ggMs8bsGJdER3a… Best regards Naresh Kamboju

13 years

[PATCH] cpufreq: governors: fix misuse of cdbs.cpu

by Fabio Baltieri

Fix governors code to set all cpu's cdbs->cpu to the the actual cpu id and use cur_policy->cpu istead of cdbs->cpu to track current governor's leader cpu. Reported-by: Viresh Kumar <viresh.kumar(a)linaro.org> Signed-off-by: Fabio Baltieri <fabio.baltieri(a)linaro.org> --- drivers/cpufreq/cpufreq_conservative.c | 5 +++-- drivers/cpufreq/cpufreq_governor.c | 2 +- drivers/cpufreq/cpufreq_ondemand.c | 5 +++-- 3 files changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c index 653fb06..c18a304 100644 --- a/drivers/cpufreq/cpufreq_conservative.c +++ b/drivers/cpufreq/cpufreq_conservative.c @@ -114,7 +114,7 @@ static void cs_check_cpu(int cpu, unsigned int load) static void cs_timer_update(struct cs_cpu_dbs_info_s *dbs_info, bool sample, struct delayed_work *dw) { - unsigned int cpu = dbs_info->cdbs.cpu; + unsigned int cpu = dbs_info->cdbs.cur_policy->cpu; int delay = delay_for_sampling_rate(cs_tuners.sampling_rate); if (sample) @@ -132,7 +132,8 @@ static void cs_timer_coordinated(struct cs_cpu_dbs_info_s *dbs_info_local, bool sample = true; /* use leader CPU's dbs_info */ - dbs_info = &per_cpu(cs_cpu_dbs_info, dbs_info_local->cdbs.cpu); + dbs_info = &per_cpu(cs_cpu_dbs_info, + dbs_info_local->cdbs.cur_policy->cpu); mutex_lock(&dbs_info->cdbs.timer_mutex); time_now = ktime_get(); diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 67e235a..46f1c78 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -208,11 +208,11 @@ int cpufreq_governor_dbs(struct dbs_data *dbs_data, mutex_lock(&dbs_data->mutex); dbs_data->enable++; - cpu_cdbs->cpu = cpu; for_each_cpu(j, policy->cpus) { struct cpu_dbs_common_info *j_cdbs; j_cdbs = dbs_data->get_cpu_cdbs(j); + j_cdbs->cpu = j; j_cdbs->cur_policy = policy; j_cdbs->prev_cpu_idle = get_cpu_idle_time(j, &j_cdbs->prev_cpu_wall); diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c index 5ae84ff..75efd5e 100644 --- a/drivers/cpufreq/cpufreq_ondemand.c +++ b/drivers/cpufreq/cpufreq_ondemand.c @@ -219,7 +219,7 @@ static void od_check_cpu(int cpu, unsigned int load_freq) static void od_timer_update(struct od_cpu_dbs_info_s *dbs_info, bool sample, struct delayed_work *dw) { - unsigned int cpu = dbs_info->cdbs.cpu; + unsigned int cpu = dbs_info->cdbs.cur_policy->cpu; int delay, sample_type = dbs_info->sample_type; /* Common NORMAL_SAMPLE setup */ @@ -255,7 +255,8 @@ static void od_timer_coordinated(struct od_cpu_dbs_info_s *dbs_info_local, bool sample = true; /* use leader CPU's dbs_info */ - dbs_info = &per_cpu(od_cpu_dbs_info, dbs_info_local->cdbs.cpu); + dbs_info = &per_cpu(od_cpu_dbs_info, + dbs_info_local->cdbs.cur_policy->cpu); mutex_lock(&dbs_info->cdbs.timer_mutex); time_now = ktime_get(); -- 1.7.12.1

13 years

[PATCH] cpufreq: governors: implement generic policy_is_shared

by Fabio Baltieri

Implement a generic helper function policy_is_shared() to replace the current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be used by code other than cpufreq governors. Suggested-by: Viresh Kumar <viresh.kumar(a)linaro.org> Signed-off-by: Fabio Baltieri <fabio.baltieri(a)linaro.org> --- drivers/cpufreq/cpufreq_conservative.c | 2 +- drivers/cpufreq/cpufreq_governor.c | 8 -------- drivers/cpufreq/cpufreq_governor.h | 1 - drivers/cpufreq/cpufreq_ondemand.c | 2 +- include/linux/cpufreq.h | 5 +++++ 5 files changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/cpufreq/cpufreq_conservative.c b/drivers/cpufreq/cpufreq_conservative.c index 5d8e894..653fb06 100644 --- a/drivers/cpufreq/cpufreq_conservative.c +++ b/drivers/cpufreq/cpufreq_conservative.c @@ -154,7 +154,7 @@ static void cs_dbs_timer(struct work_struct *work) struct cs_cpu_dbs_info_s *dbs_info = container_of(work, struct cs_cpu_dbs_info_s, cdbs.work.work); - if (dbs_sw_coordinated_cpus(&dbs_info->cdbs)) { + if (policy_is_shared(dbs_info->cdbs.cur_policy)) { cs_timer_coordinated(dbs_info, dw); } else { mutex_lock(&dbs_info->cdbs.timer_mutex); diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c index 46f96a4..67e235a 100644 --- a/drivers/cpufreq/cpufreq_governor.c +++ b/drivers/cpufreq/cpufreq_governor.c @@ -161,14 +161,6 @@ void dbs_check_cpu(struct dbs_data *dbs_data, int cpu) } EXPORT_SYMBOL_GPL(dbs_check_cpu); -bool dbs_sw_coordinated_cpus(struct cpu_dbs_common_info *cdbs) -{ - struct cpufreq_policy *policy = cdbs->cur_policy; - - return cpumask_weight(policy->cpus) > 1; -} -EXPORT_SYMBOL_GPL(dbs_sw_coordinated_cpus); - static inline void dbs_timer_init(struct dbs_data *dbs_data, int cpu, unsigned int sampling_rate) { diff --git a/drivers/cpufreq/cpufreq_governor.h b/drivers/cpufreq/cpufreq_governor.h index aaf073d..b72e628 100644 --- a/drivers/cpufreq/cpufreq_governor.h +++ b/drivers/cpufreq/cpufreq_governor.h @@ -172,7 +172,6 @@ static inline int delay_for_sampling_rate(unsigned int sampling_rate) u64 get_cpu_idle_time(unsigned int cpu, u64 *wall); void dbs_check_cpu(struct dbs_data *dbs_data, int cpu); -bool dbs_sw_coordinated_cpus(struct cpu_dbs_common_info *cdbs); int cpufreq_governor_dbs(struct dbs_data *dbs_data, struct cpufreq_policy *policy, unsigned int event); #endif /* _CPUFREQ_GOVERNER_H */ diff --git a/drivers/cpufreq/cpufreq_ondemand.c b/drivers/cpufreq/cpufreq_ondemand.c index 1017b90..5ae84ff 100644 --- a/drivers/cpufreq/cpufreq_ondemand.c +++ b/drivers/cpufreq/cpufreq_ondemand.c @@ -277,7 +277,7 @@ static void od_dbs_timer(struct work_struct *work) struct od_cpu_dbs_info_s *dbs_info = container_of(work, struct od_cpu_dbs_info_s, cdbs.work.work); - if (dbs_sw_coordinated_cpus(&dbs_info->cdbs)) { + if (policy_is_shared(dbs_info->cdbs.cur_policy)) { od_timer_coordinated(dbs_info, dw); } else { mutex_lock(&dbs_info->cdbs.timer_mutex); diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index 5fdc6c6..f106406 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -125,6 +125,11 @@ struct cpufreq_policy { #define CPUFREQ_SHARED_TYPE_ALL (2) /* All dependent CPUs should set freq */ #define CPUFREQ_SHARED_TYPE_ANY (3) /* Freq can be set from any dependent CPU*/ +static inline bool policy_is_shared(struct cpufreq_policy *policy) +{ + return cpumask_weight(policy->cpus) > 1; +} + /******************** cpufreq transition notifiers *******************/ #define CPUFREQ_PRECHANGE (0) -- 1.7.12.1

13 years

LInaro 13.01 test result summary for Linux Linaro ubuntu Quantal images.

by Botao Sun

Linaro 13.01 Release (Calendar Week 5, 2013): Here is test result summary for Linux Linaro ubuntu Quantal image on following boards: 1) ARM Versatile Express A9; 2) Samsung Origen; 3) Samsung Arndale; 4) TI Panda 4430; 5) TI Panda 4460; 6) ST Ericsson Snowball. Synopsis: Samsung Arndale board bringing up, booted successfully; ARM DS-5 data streaming doesn't work on TI Panda boards; Ethernet starts to work on Samsung Origen by manually modify configuration file. 1. ARM Versatile Express A9 + Linux Linaro Quantal (Column I): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdFNmV… It keeps exactly same status as last test result: only "Halt" & "Device Tree" test failed, all other features work well, and kernel has been upgraded to 3.8.0-1. 2. Samsung Origen + Linux Linaro Quantal (Column J): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEowN… "Halt" test failed, but it worked well last week. Ethernet starts to work by modify "/etc/network/interfaces" manually then reboot. Device Tree backs to work and Segmentation Fault error has been fixed in PowerTop. WiFi is still unavailable. 3. Samsung Arndale + Linux Linaro Quantal (Column C): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AgB-fT5LL31CdGZJS… New board, Samsung Arndale has been brought up and booted successfully, although not reliable enough. 4. TI Panda 4430 + Linux Linaro Quantal (Column I): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEwwZ… ARM DS5 data streaming failed due to gator version mismatch, Device Tree is unavailable. "cpuhotplug_07" in Power Management test failed again but it worked well last week. 5. TI Panda 4460 + Linux Linaro Quantal (Column I): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEwwZ… ARM DS5 data streaming failed due to gator version mismatch, Device Tree is unavailable, all other test passed. 6. ST Ericsson Snowball + Linux Linaro Quantal (Column I): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdFJ4X… It keeps exactly same status as last week, board can boot into serial console successfully, but many features are unavailable, like HDMI, reboot, halt and Ethernet. For the previous week test summary (Calendar week 4), please refer to attachment. Thank you. Best Regards Botao Sun

13 years

[PATCH v7 0/5] cpufreq: handle SW coordinated CPUs

by Fabio Baltieri

Hello Rafael, this is the v7 for the cpufreq SW coordinated CPU bug fix, developed after the discussion with Viresh about some issues that appeared after the merge of both mine and his patches. Changes from v6: * Dropped the cpu hotplug patch, as it was solving part of problem addressed by Viresh patch: dbcb634 cpufreq: Notify governors when cpus are hot-[un]plugged but was behaving erratically when both patches were applied together. * In the initial patch, cleaned up cpufreq_governor_dbs and dbs_timer_{init,exit} to remove non necessary variables and special case initialization, as the additional data provided on that code was not necessary since v6. The code is a bit cleaner now. Would you consider replacing my patches currently on your pm-cpufreq-next branch with this series? There should not be any conflicts with existing patches. Let me know if you prefer incremental patches instead. Thanks, Fabio Fabio Baltieri (3): cpufreq: ondemand: call dbs_check_cpu only when necessary cpufreq: conservative: call dbs_check_cpu only when necessary cpufreq: ondemand: use all CPUs in update_sampling_rate Rickard Andersson (1): cpufreq: handle SW coordinated CPUs drivers/cpufreq/cpufreq_conservative.c | 46 ++++++++++++++++++++++--- drivers/cpufreq/cpufreq_governor.c | 34 ++++++++++++++----- drivers/cpufreq/cpufreq_governor.h | 2 ++ drivers/cpufreq/cpufreq_ondemand.c | 62 +++++++++++++++++++++++++++------- 4 files changed, 119 insertions(+), 25 deletions(-) -- 1.7.12.1

13 years

[PATCH] cpufreq: Update Documentation for cpus and related_cpus

by Viresh Kumar

Documentation related to cpus and related_cpus is confusing and not very clear. Over that CPUFreq core has seen much changes recently. Lets update documentation and comments for cpus and related_cpus. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- Documentation/cpu-freq/cpu-drivers.txt | 6 ++++++ Documentation/cpu-freq/user-guide.txt | 8 ++++---- include/linux/cpufreq.h | 6 ++++-- 3 files changed, 14 insertions(+), 6 deletions(-) diff --git a/Documentation/cpu-freq/cpu-drivers.txt b/Documentation/cpu-freq/cpu-drivers.txt index c436096..72f70b1 100644 --- a/Documentation/cpu-freq/cpu-drivers.txt +++ b/Documentation/cpu-freq/cpu-drivers.txt @@ -111,6 +111,12 @@ policy->governor must contain the "default policy" for For setting some of these values, the frequency table helpers might be helpful. See the section 2 for more information on them. +SMP systems normally have same clock source for a group of cpus. For these the +.init() would be called only once for the first online cpu. Here the .init() +routine must initialize policy->cpus with mask of all possible cpus (Online + +Offline) that share the clock. Then the core would copy this mask onto +policy->related_cpus and will reset policy->cpus to carry only online cpus. + 1.3 verify ------------ diff --git a/Documentation/cpu-freq/user-guide.txt b/Documentation/cpu-freq/user-guide.txt index 04f6b32..ff2f283 100644 --- a/Documentation/cpu-freq/user-guide.txt +++ b/Documentation/cpu-freq/user-guide.txt @@ -190,11 +190,11 @@ scaling_max_freq show the current "policy limits" (in first set scaling_max_freq, then scaling_min_freq. -affected_cpus : List of CPUs that require software coordination - of frequency. +affected_cpus : List of Online CPUs that require software + coordination of frequency. -related_cpus : List of CPUs that need some sort of frequency - coordination, whether software or hardware. +related_cpus : List of Online + Offline CPUs that need software + coordination of frequency. scaling_driver : Hardware driver for cpufreq. diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h index b60f6ba..04d2e84 100644 --- a/include/linux/cpufreq.h +++ b/include/linux/cpufreq.h @@ -86,8 +86,10 @@ struct cpufreq_real_policy { }; struct cpufreq_policy { - cpumask_var_t cpus; /* CPUs requiring sw coordination */ - cpumask_var_t related_cpus; /* CPUs with any coordination */ + /* CPUs sharing clock, require sw coordination */ + cpumask_var_t cpus; /* Online CPUs only */ + cpumask_var_t related_cpus; /* Online + Offline CPUs */ + unsigned int shared_type; /* ANY or ALL affected CPUs should set cpufreq */ unsigned int cpu; /* cpu nr of registered CPU */ -- 1.7.12.rc2.18.g61b472e

13 years

Re: [PATCH 2/5] cpufreq: star/stop cpufreq timers on cpu hotplug

by Viresh Kumar

Hi Fabio, Sorry for waking up very late :) The reason why i am starting this thread again is due to problem reported by Joseph, with latest linux-next/master branch (which contains few big patches from me :) ): Reboot is giving following to him: * Will now halt [ 193.756068] Disabling non-boot CPUs... [ 193.760088] BUG: scheduling while atomic: halt/780/0x00000002 [ 193.765845] Modules linked in: brcmfmac brcmutil [ 193.770613] [<c0014990>] (unwind_backtrace+0x0/0xf8) from [<c0049510>] (__schedule_bug+0x44/0x5c) [ 193.779548] [<c0049510>] (__schedule_bug+0x44/0x5c) from [<c04fa320>] (__schedule+0x688/0x6ec) [ 193.788206] [<c04fa320>] (__schedule+0x688/0x6ec) from [<c04fa75c>] (schedule_preempt_disabled+0x24/0x34) [ 193.797811] [<c04fa75c>] (schedule_preempt_disabled+0x24/0x34) from [<c04f916c>] (__mutex_lock_slowpath+0x170/0x34c) [ 193.808367] [<c04f916c>] (__mutex_lock_slowpath+0x170/0x34c) from [<c04f9354>] (mutex_lock+0xc/0x24) [ 193.817554] [<c04f9354>] (mutex_lock+0xc/0x24) from [<c04f1cdc>] (unregister_cpu_notifier+0xc/0x24) [ 193.826640] [<c04f1cdc>] (unregister_cpu_notifier+0xc/0x24) from [<c033a8a4>] (cpufreq_governor_dbs+0x118/0x614) [ 193.836866] [<c033a8a4>] (cpufreq_governor_dbs+0x118/0x614) from [<c033747c>] (__cpufreq_governor+0x58/0xc0) [ 193.846737] [<c033747c>] (__cpufreq_governor+0x58/0xc0) from [<c0339104>] (__cpufreq_remove_dev.clone.7+0x58/0x320) [ 193.857207] [<c0339104>] (__cpufreq_remove_dev.clone.7+0x58/0x320) from [<c04f7958>] (cpufreq_cpu_callback+0x8c/0x9c) [ 193.867850] [<c04f7958>] (cpufreq_cpu_callback+0x8c/0x9c) from [<c0044f4c>] (notifier_call_chain+0x44/0x84) [ 193.877623] [<c0044f4c>] (notifier_call_chain+0x44/0x84) from [<c0026e24>] (__cpu_notify+0x2c/0x48) [ 193.886704] [<c0026e24>] (__cpu_notify+0x2c/0x48) from [<c04f1b08>] (_cpu_down+0xb0/0x23c) [ 193.895004] [<c04f1b08>] (_cpu_down+0xb0/0x23c) from [<c00270ec>] (disable_nonboot_cpus+0x68/0x104) [ 193.904089] [<c00270ec>] (disable_nonboot_cpus+0x68/0x104) from [<c0034fbc>] (kernel_power_off+0x24/0x48) [ 193.913688] [<c0034fbc>] (kernel_power_off+0x24/0x48) from [<c0035810>] (sys_reboot+0x104/0x1e0) [ 193.922517] [<c0035810>] (sys_reboot+0x104/0x1e0) from [<c000e520>] (ret_fast_syscall+0x0/0x30) And the crash log show this patch of yours somewhere :) First question: Is this patch still required? Because following patch from me is sending a STOP/START to governors on cpu hot-[un]plug ? commit dbcb63407c095af73f3464767e00902cdee55e8b Author: Viresh Kumar <viresh.kumar(a)linaro.org> Date: Sat Jan 12 05:14:39 2013 +0000 cpufreq: Notify governors when cpus are hot-[un]plugged For me, the answer is NO. Over that, i tried these patches on ARM bigLITTLE TC2 (3 A7's and 2 A15's) and my system wasn't booting at all for ondemand governor. Reverting your patch does fix the issue: [ 2.613573] arm_big_little: bL_cpufreq_init: Initialized, cpu: 0, cluster 0 [ 2.635436] arm_big_little: bL_cpufreq_init: Initialized, cpu: 2, cluster 1 [ 23.650184] INFO: rcu_sched self-detected stall on CPU { 0} (t=2100 jiffies g=4294967088 c=4294967087 q=10) [ 23.679664] Backtrace for cpu 0 (current): [ 23.680239] INFO: rcu_sched detected stalls on CPUs/tasks: { 0} (detected by 2, t=2103 jiffies, g=4294967088, c=4294967087, q=10) [ 23.726839] [<c0014020>] (unwind_backtrace+0x0/0xf8) from [<c0012f60>] (smp_send_all_cpu_backtrace+0x60/0xcc) [ 23.756545] [<c0012f60>] (smp_send_all_cpu_backtrace+0x60/0xcc) from [<c008232c>] (rcu_pending+0x2c8/0x63c) [ 23.785731] [<c008232c>] (rcu_pending+0x2c8/0x63c) from [<c0083854>] (rcu_check_callbacks+0x7c/0x148) [ 23.813358] [<c0083854>] (rcu_check_callbacks+0x7c/0x148) from [<c002d1e0>] (update_process_times+0x38/0x68) [ 23.842808] [<c002d1e0>] (update_process_times+0x38/0x68) from [<c0066b00>] (tick_sched_handle+0x48/0x54) [ 23.871472] [<c0066b00>] (tick_sched_handle+0x48/0x54) from [<c0066d6c>] (tick_sched_timer+0x44/0x74) [ 23.899098] [<c0066d6c>] (tick_sched_timer+0x44/0x74) from [<c00416d8>] (__run_hrtimer+0x84/0x1b4) [ 23.925940] [<c00416d8>] (__run_hrtimer+0x84/0x1b4) from [<c004224c>] (hrtimer_interrupt+0x108/0x2d4) [ 23.953563] [<c004224c>] (hrtimer_interrupt+0x108/0x2d4) from [<c0013990>] (arch_timer_handler_virt+0x30/0x38) [ 23.983530] [<c0013990>] (arch_timer_handler_virt+0x30/0x38) from [<c007e41c>] (handle_percpu_devid_irq+0x74/0x110) [ 24.014799] [<c007e41c>] (handle_percpu_devid_irq+0x74/0x110) from [<c007ac8c>] (generic_handle_irq+0x20/0x30) [ 24.044765] [<c007ac8c>] (generic_handle_irq+0x20/0x30) from [<c000e9f4>] (handle_IRQ+0x38/0x94) [ 24.071085] [<c000e9f4>] (handle_IRQ+0x38/0x94) from [<c0008570>] (gic_handle_irq+0x28/0x5c) [ 24.096362] [<c0008570>] (gic_handle_irq+0x28/0x5c) from [<c000dd80>] (__irq_svc+0x40/0x50) [ 24.121374] Exception stack(0xef047ec0 to 0xef047f08) [ 24.136492] 7ec0: 00000000 c0591780 00000000 c0591798 c0591780 c05d5d60 00000000 c0593280 [ 24.160986] 7ee0: c0552c98 c02b1df4 ef046000 00000000 c059179c ef047f08 c03b5f84 c0043698 [ 24.185477] 7f00: a0000113 ffffffff [ 24.195910] [<c000dd80>] (__irq_svc+0x40/0x50) from [<c0043698>] (raw_notifier_chain_register+0x24/0x54) [ 24.224314] [<c0043698>] (raw_notifier_chain_register+0x24/0x54) from [<c03b5f84>] (register_cpu_notifier+0x18/0x2c) [ 24.255843] [<c03b5f84>] (register_cpu_notifier+0x18/0x2c) from [<c02ab1b0>] (cpufreq_register_driver+0x134/0x190) [ 24.286852] [<c02ab1b0>] (cpufreq_register_driver+0x134/0x190) from [<c02b1930>] (bL_cpufreq_register+0x68/0xd4) [ 24.317337] [<c02b1930>] (bL_cpufreq_register+0x68/0xd4) from [<c0008740>] (do_one_initcall+0x110/0x178) [ 24.345738] [<c0008740>] (do_one_initcall+0x110/0x178) from [<c03b5994>] (kernel_init+0x194/0x330) [ 24.372577] [<c03b5994>] (kernel_init+0x194/0x330) from [<c000e1d8>] (ret_from_fork+0x14/0x3c) [ 24.398371] On Thu, Dec 27, 2012 at 8:25 PM, Fabio Baltieri <fabio.baltieri(a)linaro.org> wrote: > Add a CPU notifier to start and stop individual core timers on CPU > hotplug events when running on CPUs with SW coordinated frequency. > > Signed-off-by: Fabio Baltieri <fabio.baltieri(a)linaro.org> > --- > drivers/cpufreq/cpufreq_governor.c | 51 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 51 insertions(+) > > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c > index b0e4506..e881250 100644 > --- a/drivers/cpufreq/cpufreq_governor.c > +++ b/drivers/cpufreq/cpufreq_governor.c > @@ -25,9 +25,12 @@ > #include <linux/tick.h> > #include <linux/types.h> > #include <linux/workqueue.h> > +#include <linux/cpu.h> > > #include "cpufreq_governor.h" > > +static DEFINE_PER_CPU(struct dbs_data *, cpu_cur_dbs); > + > static inline u64 get_cpu_idle_time_jiffy(unsigned int cpu, u64 *wall) > { > u64 idle_time; > @@ -185,6 +188,46 @@ static inline void dbs_timer_exit(struct cpu_dbs_common_info *cdbs) > cancel_delayed_work_sync(&cdbs->work); > } > > +static int __cpuinit cpu_callback(struct notifier_block *nfb, > + unsigned long action, void *hcpu) > +{ > + unsigned int cpu = (unsigned long)hcpu; > + struct device *cpu_dev = get_cpu_device(cpu); > + struct dbs_data *dbs_data = per_cpu(cpu_cur_dbs, cpu); > + struct cpu_dbs_common_info *cpu_cdbs = dbs_data->get_cpu_cdbs(cpu); > + unsigned int sampling_rate; > + > + if (dbs_data->governor == GOV_CONSERVATIVE) { > + struct cs_dbs_tuners *cs_tuners = dbs_data->tuners; > + sampling_rate = cs_tuners->sampling_rate; > + } else { > + struct od_dbs_tuners *od_tuners = dbs_data->tuners; > + sampling_rate = od_tuners->sampling_rate; > + } > + > + if (cpu_dev) { > + switch (action) { > + case CPU_ONLINE: > + case CPU_ONLINE_FROZEN: > + case CPU_DOWN_FAILED: > + case CPU_DOWN_FAILED_FROZEN: > + dbs_timer_init(dbs_data, cpu_cdbs, > + sampling_rate, cpu); > + break; > + case CPU_DOWN_PREPARE: > + case CPU_DOWN_PREPARE_FROZEN: > + dbs_timer_exit(cpu_cdbs); > + break; > + } > + } > + > + return NOTIFY_OK; > +} > + > +static struct notifier_block __refdata ondemand_cpu_notifier = { Over that, why is it called ondemand here ? > + .notifier_call = cpu_callback, > +}; > + > int cpufreq_governor_dbs(struct dbs_data *dbs_data, > struct cpufreq_policy *policy, unsigned int event) > { > @@ -296,7 +339,11 @@ second_time: > j_cdbs = dbs_data->get_cpu_cdbs(j); > dbs_timer_init(dbs_data, j_cdbs, > *sampling_rate, j); > + > + per_cpu(cpu_cur_dbs, j) = dbs_data; > } > + > + register_hotcpu_notifier(&ondemand_cpu_notifier); > } else { > dbs_timer_init(dbs_data, cpu_cdbs, *sampling_rate, cpu); > } > @@ -307,11 +354,15 @@ second_time: > cs_dbs_info->enable = 0; > > if (dbs_sw_coordinated_cpus(cpu_cdbs)) { > + unregister_hotcpu_notifier(&ondemand_cpu_notifier); > + > for_each_cpu(j, policy->cpus) { > struct cpu_dbs_common_info *j_cdbs; > > j_cdbs = dbs_data->get_cpu_cdbs(j); > dbs_timer_exit(j_cdbs); > + > + per_cpu(cpu_cur_dbs, j) = NULL; > } > } else { > dbs_timer_exit(cpu_cdbs); -- viresh

13 years

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev