linaro-dev

linaro-dev@lists.linaro.org

4332 discussions

[PATCH] pmqa: cpuidle: add test to check cpuidle statistics

by Sanjay Singh Rawat

From: Daniel Lezcano <daniel.lezcano(a)linaro.org> Add functionality to record the current runtime cpuidle statistics and show the same. Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.com> --- README | 6 + Test.mk | 6 + cpuidle/cpuidle_04.sh | 41 ++++ cpuidle/cpuidle_04.txt | 1 + cpuidle/cpuidle_stats.c | 472 +++++++++++++++++++++++++++++++++++++++++++++++ 5 files changed, 526 insertions(+) create mode 100755 cpuidle/cpuidle_04.sh create mode 100644 cpuidle/cpuidle_04.txt create mode 100644 cpuidle/cpuidle_stats.c diff --git a/README b/README index a22a3c8..41c5f41 100644 --- a/README +++ b/README @@ -10,3 +10,9 @@ If you want to run a subset of the tests, do: make -C sched_mc check make -C cpufreq check + +For running cpuidle-stats test, which is 4th subtest in cpuidle; run: + + make -C cpuidle check TEST=4 + +Note: Any other value for TEST will not run any other subtest diff --git a/Test.mk b/Test.mk index 671bbf5..19d7346 100644 --- a/Test.mk +++ b/Test.mk @@ -36,7 +36,13 @@ SANITY_STATUS:= $(shell if test $(SNT) && test -f $(SNT); then \ echo 1; fi; else echo 1; fi) ifeq "$(SANITY_STATUS)" "1" + +ifeq "$(TEST)" "4" +TST=cpuidle_04.sh +run_tests: uncheck $(EXEC) $(LOG) +else run_tests: uncheck $(EXEC) $(LOG) +endif %.log: %.sh @echo "###" diff --git a/cpuidle/cpuidle_04.sh b/cpuidle/cpuidle_04.sh new file mode 100755 index 0000000..42d6de5 --- /dev/null +++ b/cpuidle/cpuidle_04.sh @@ -0,0 +1,41 @@ +#!/bin/bash +# +# PM-QA validation test suite for the power management on Linux +# +# Copyright (C) 2011, Linaro Limited. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. +# +# Contributors: +# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) +# - initial API and implementation +# + +source ../include/functions.sh + +CPUIDLE_STATS=./cpuidle_stats + +if [ $(id -u) != 0 ]; then + log_skip "run as non-root" + exit 0 +fi + +check_cpuidle_stats() { + trace-cmd record -e cpu_idle + trace-cmd report trace.dat > trace-cpuidle.dat + check "Running cpuidle_stats on collected data" "./$CPUIDLE_STATS" trace-cpuidle.dat +} + +check_cpuidle_stats diff --git a/cpuidle/cpuidle_04.txt b/cpuidle/cpuidle_04.txt new file mode 100644 index 0000000..8cf6bb1 --- /dev/null +++ b/cpuidle/cpuidle_04.txt @@ -0,0 +1 @@ +Run cpuidle_stats program to check runtime cpuidle statistics. diff --git a/cpuidle/cpuidle_stats.c b/cpuidle/cpuidle_stats.c new file mode 100644 index 0000000..971fcc9 --- /dev/null +++ b/cpuidle/cpuidle_stats.c @@ -0,0 +1,472 @@ +#include <getopt.h> +#include <stdio.h> +#include <stdlib.h> +#include <stdbool.h> +#include <unistd.h> +#include <string.h> +#include <values.h> +#include <sys/time.h> +#include <sys/resource.h> + +#define BUFSIZE 256 +#define MAXCSTATE 8 +#define MAX(A,B) (A > B ? A : B) +#define MIN(A,B) (A < B ? A : B) +#define AVG(A,B,I) ((A) + ((B - A) / (I))) + +static char buffer[BUFSIZE]; + +struct cpuidle_data { + double begin; + double end; + double duration; +}; + +struct cpuidle_cstate { + struct cpuidle_data *data; + int nrdata; + double avg_time; + double max_time; + double min_time; + double duration; +}; + +struct cpuidle_cstates { + struct cpuidle_cstate cstate[MAXCSTATE]; + int last_cstate; + int cstate_max; +}; + +struct cpuidle_datas { + struct cpuidle_cstates *cstates; + int nrcpus; +}; + +static inline int error(const char *str) +{ + perror(str); + return -1; +} + +static inline void *ptrerror(const char *str) +{ + perror(str); + return NULL; +} + +static int dump_data(struct cpuidle_datas *datas, int state, int count) +{ + int i = 0, j, k, nrcpus = datas->nrcpus; + struct cpuidle_cstates *cstates; + struct cpuidle_cstate *cstate; + + do { + cstates = &datas->cstates[i]; + + for (j = 0; j < cstates->cstate_max + 1; j++) { + + if (state != -1 && state != j) + continue; + + cstate = &cstates->cstate[j]; + + for (k = 0; k < MIN(count, cstate->nrdata); k++) { + printf("%lf %d\n", cstate->data[k].begin, j); + printf("%lf 0\n", cstate->data[k].end); + } + + /* add a break */ + printf("\n"); + } + + i++; + + } while (i < nrcpus && nrcpus != -1); + + return 0; +} + +static int display_data(struct cpuidle_datas *datas, int state) +{ + int i = 0, j, nrcpus = datas->nrcpus; + struct cpuidle_cstates *cstates; + struct cpuidle_cstate *cstate; + + do { + cstates = &datas->cstates[i]; + + for (j = 0; j < cstates->cstate_max + 1; j++) { + + if (state != -1 && state != j) + continue; + + cstate = &cstates->cstate[j]; + + if (nrcpus == -1) + printf("\ncluster"); + else + printf("\ncpu%d", i); + + printf("/state%d, %d hits, total %.2lfus, "\ + "avg %.2lfus, min %.2lfus, max %.2lfus", + j, cstate->nrdata, cstate->duration, + cstate->avg_time, cstate->min_time, + cstate->max_time); + } + + i++; + + } while (i < nrcpus && nrcpus != -1); + printf("\n"); + return 0; +} + +static struct cpuidle_data *intersection(struct cpuidle_data *data1, + struct cpuidle_data *data2) +{ + double begin, end; + struct cpuidle_data *data; + + begin = MAX(data1->begin, data2->begin); + end = MIN(data1->end, data2->end); + + if (begin >= end) + return NULL; + + data = malloc(sizeof(*data)); + if (!data) + return NULL; + + data->begin = begin; + data->end = end; + data->duration = end - begin; + data->duration *= 1000000; + + return data; +} + +static struct cpuidle_cstate *inter(struct cpuidle_cstate *c1, + struct cpuidle_cstate *c2) +{ + int i, j; + struct cpuidle_data *interval; + struct cpuidle_cstate *result; + struct cpuidle_data *data = NULL; + size_t index; + + if (!c1) + return c2; + if (!c2) + return c1; + + result = calloc(sizeof(*result), 1); + if (!result) + return NULL; + + for (i = 0, index = 0; i < c1->nrdata; i++) { + + for (j = index; j < c2->nrdata; j++) { + + /* intervals are ordered, no need to go further */ + if (c1->data[i].end < c2->data[j].begin) + break; + + /* primary loop begins where we ended */ + if (c1->data[i].begin > c2->data[j].end) + index = j; + + interval = intersection(&c1->data[i], &c2->data[j]); + if (!interval) + continue; + + result->min_time = MIN(!result->nrdata ? 999999.0 : + result->min_time, + interval->duration); + + result->max_time = MAX(result->max_time, + interval->duration); + + result->avg_time = AVG(result->avg_time, + interval->duration, + result->nrdata + 1); + + result->duration += interval->duration; + + result->nrdata++; + + data = realloc(data, sizeof(*data) * + (result->nrdata + 1)); + if (!data) + return NULL; + + result->data = data; + result->data[result->nrdata - 1] = *interval; + + free(interval); + } + } + + return result; +} + +static int store_data(double time, int state, int cpu, + struct cpuidle_datas *datas, int count) +{ + struct cpuidle_cstates *cstates = &datas->cstates[cpu]; + struct cpuidle_cstate *cstate; + struct cpuidle_data *data; + int nrdata, last_cstate = cstates->last_cstate; + + /* ignore when we got a "closing" state first */ + if (state == -1 && !cstates->cstate_max) + return 0; + + cstate = &cstates->cstate[state == -1 ? last_cstate : state ]; + data = cstate->data; + nrdata = cstate->nrdata; + + if (state == -1) { + + data = &data[nrdata]; + + data->end = time; + data->duration = data->end - data->begin; + + /* That happens when precision digit in the file exceed + * 7 (eg. xxx.1000000). Ignoring the result because I don't + * find a way to fix with the sscanf used in the caller + */ + if (data->duration < 0) + return 0; + + /* convert to us */ + data->duration *= 1000000; + cstate->min_time = MIN(!nrdata ? 999999.0 : cstate->min_time, + data->duration); + cstate->max_time = MAX(cstate->max_time, data->duration); + cstate->avg_time = AVG(cstate->avg_time, data->duration, + cstate->nrdata + 1); + cstate->duration += data->duration; + cstate->nrdata++; + + return 0; + } + + data = realloc(data, sizeof(*data) * (nrdata + 1)); + if (!data) + return error("realloc data");; + + data[nrdata].begin = time; + + cstates->cstate[state].data = data; + cstates->cstate_max = MAX(cstates->cstate_max, state); + cstates->last_cstate = state; + + return 0; +} + +static struct cpuidle_datas *load_data(const char *path) +{ + FILE *f; + unsigned int state = 0, cpu = 0, nrcpus= 0; + double time, begin, end; + size_t count; + + struct cpuidle_datas *datas; + + f = fopen(path, "r"); + if (!f) + return ptrerror("fopen"); + + for (count = 0; count < 2; count++) { + fgets(buffer, BUFSIZE, f); + sscanf(buffer, "cpus=%u", &nrcpus); + } + + if (!nrcpus) + return ptrerror("read error for 'cpus=' in trace file"); + + datas = malloc(sizeof(*datas)); + if (!datas) + return ptrerror("malloc datas"); + + datas->cstates = calloc(sizeof(*datas->cstates), nrcpus); + if (!datas->cstates) + return ptrerror("calloc cstate"); + + datas->nrcpus = nrcpus; + + for (; fgets(buffer, BUFSIZE, f); count++) { + + sscanf(buffer, "%*[^]]] %lf:%*[^=]=%u%*[^=]=%d", + &time, &state, &cpu); + + if (count == 2) + begin = time; + end = time; + + store_data(time, state, cpu, datas, count); + } + + fclose(f); + + fprintf(stderr, "Log is %lf secs long with %d events\n", + end - begin, count); + + return datas; +} + +struct cpuidle_datas *cluster_data(struct cpuidle_datas *datas) +{ + struct cpuidle_cstate *c1, *cstates; + struct cpuidle_datas *result; + int i, j; + int cstate_max = -1; + + result = malloc(sizeof(*result)); + if (!result) + return NULL; + + result->nrcpus = -1; /* the cluster */ + + result->cstates = calloc(sizeof(*result->cstates), 1); + if (!result->cstates) + return NULL; + + /* hack but negligeable overhead */ + for (i = 0; i < datas->nrcpus; i++) + cstate_max = MAX(cstate_max, datas->cstates[i].cstate_max); + result->cstates[0].cstate_max = cstate_max; + + for (i = 0; i < cstate_max + 1; i++) { + + for (j = 0, cstates = NULL; j < datas->nrcpus; j++) { + + c1 = &datas->cstates[j].cstate[i]; + + cstates = inter(cstates, c1); + if (!cstates) + continue; + } + + result->cstates[0].cstate[i] = *cstates; + } + + return result; +} + +static int help(const char *cmd) +{ + fprintf(stderr, "%s [-d/--dump] [-c/--cstate=x] <file>\n", cmd); + exit(0); +} + +static struct option long_options[] = { + { "dump", 0, 0, 'd' }, + { "iterations", 0, 0, 'i' }, + { "cstate", 0, 0, 'c' }, + { "debug", 0, 0, 'g' }, + { "verbose", 0, 0, 'v' }, + { "help", 0, 0, 'h' }, + { 0, 0, 0, 0 } +}; + +struct idledebug_options { + bool debug; + bool dump; + int cstate; + int iterations; +}; + +int getoptions(int argc, char *argv[], struct idledebug_options *options) +{ + int c; + + memset(options, 0, sizeof(*options)); + options->cstate = -1; + + while (1) { + + int optindex = 0; + + c = getopt_long(argc, argv, "gdvhi:c:", + long_options, &optindex); + if (c == -1) + break; + + switch (c) { + case 'g': + options->debug = true; + break; + case 'd': + options->dump = true; + break; + case 'i': + options->iterations = atoi(optarg); + break; + case 'c': + options->cstate = atoi(optarg); + break; + case 'h': + help(argv[0]); + break; + case '?': + fprintf(stderr, "%s: Unknown option %c'.\n", + argv[0], optopt); + default: + return -1; + } + } + + if (options->cstate >= MAXCSTATE) { + fprintf(stderr, "C-state must be less than %d\n", + MAXCSTATE); + return -1; + } + + if (options->iterations < 0) { + fprintf(stderr, "dump values must be a positive value\n"); + } + + if (optind == argc) { + fprintf(stderr, "expected filename\n"); + return -1; + } + + return 0; +} + +int main(int argc, char *argv[]) +{ + struct cpuidle_datas *datas; + struct cpuidle_datas *cluster; + struct idledebug_options options; + struct rusage rusage; + + + if (getoptions(argc, argv, &options)) + return 1; + + datas = load_data(argv[optind]); + if (!datas) + return 1; + + cluster = cluster_data(datas); + if (!cluster) + return 1; + + if (options.dump > 0) { + dump_data(datas, options.cstate, options.iterations); + dump_data(cluster, options.cstate, options.iterations); + } else { + display_data(datas, options.cstate); + display_data(cluster, options.cstate); + } + + if (options.debug) { + getrusage(RUSAGE_SELF, &rusage); + printf("max rss : %ld kB\n", rusage.ru_maxrss); + } + + return 0; +} -- 1.7.9.5

12 years, 8 months

big.LITTLE MP Scheduler test summary-Week-8

by Naresh Kamboju

Hi, Calendar Week 8, 2013: Here is test result summary for big.LITTLE MP Scheduler test on TC2 platform with Android image sched_tests.git No of Test Cases Tests Run Tests Pass Tests Fail Absolute pass rate (%) Failure Analysis/Comments Regression 20 19 19 0 100 - mpbasicsuite 10 9 9 1 90 - mpcoresuite 4 4 4 0 75 - mpextendedsuite 6 6 4 2 66.7 - mploadbalance 2 2 2 0 100 - Android Build: https://android-build.linaro.org/builds/~linaro-android-restricted/vexpress… Linux kernel: Linux version 3.8.0-00922-ge33868e (jenkins-build@ip-10-10-27-33) (gcc version 4.7.3 20130205 (prerelease) (Linaro GCC 4.7-2013.02-1~dev) ) #1 SMP Wed Feb 20 04:49:44 UTC 2013 Results spread sheet: https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0Ai9ggMs8bsGJdER3a… Best regards Naresh Kamboju

12 years, 8 months

big.LITTLE MP status Feb 22, 2013

by David Zinman

https://wiki.linaro.org/projects/big.LITTLE.MP Work Items for functional completion: https://wiki.linaro.org/projects/big.LITTLE.MP/WorkItems Roadmap Cards: Improving HMP Linux scheduling - http://cards.linaro.org/browse/CARD-190 Blueprints and bugs are all now in a single Launchpad project for big.LITTLE: https://launchpad.net/linaro-big-little-system Version 15 of big LITTLE MP has been pulled into the baseline. Updates: ------- - Rebased over 3.8-rc7 - Stats: Total distinct patches: 36 - Dropped Patches: Two patches from cpufreq-fixes-v2 (3): causing some failures. Details: http://lists.linaro.org/pipermail/linaro-dev/2013-February/015370.html Items under review: ================= Bugs fix submissions: 1 - Fix the nr_busy_cpus to prevent spurious Idle Load Balance 2 - Fix the load tracking with RT tasks 3 - Fix the active migration when 1 task is running on the pulled CPU Patches: 1 - Packing small tasks 2 - Force migration of a standalone long running task for LITTLE to big 3 - Use per task load tracking to evaluate the CPU load instead of the nice priority 4 - Don't move small tasks during periodic load balance, packing small tasks will do it for us so the scheduler should focus on long running tasks 5 - Tune sched_domain for HMP QA === big.LITTLE MP LAVA Dashboard http://validation.linaro.org/lava-server/dashboard/image-reports/linaro-and… Testing: http://lists.linaro.org/pipermail/linaro-dev/2013-February/015372.html Bugs: https://bugs.launchpad.net/linaro-big-little-system/+bug/1083573 https://bugs.launchpad.net/linaro-big-little-system/+bug/1087149: - Complicated and being investigated. -- David Zinman, Project Manager Linaro.org | Open source software for ARM SoCs

12 years, 8 months

[PATCH V2 0/4] CPUFreq: Implement per policy instances of governors

by Viresh Kumar

This is targetted for 3.10-rc1 or linux-next just after the merge window. All patches are pushed here for others to apply: http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/h… Currently, there can't be multiple instances of single governor_type. If we have a multi-package system, where we have multiple instances of struct policy (per package), we can't have multiple instances of same governor. i.e. We can't have multiple instances of ondemand governor for multiple packages. Governors directory in sysfs is created at /sys/devices/system/cpu/cpufreq/ governor-name/. Which again reflects that there can be only one instance of a governor_type in the system. This is a bottleneck for multicluster system, where we want different packages to use same governor type, but with different tunables. This patchset is inclined towards fixing this issue. Now we will create governors directory in cpu/cpu*/cpufreq/<gov> for platforms which have multiple struct policy alive at any moment. For others the interface is kept same: cpu/cpufreq/<gov>. V1->V2: - Few patches from V1 are already picked up by Rafael for 3.9-rc1 - Last two patches are new - Added dbs_data->exit() routines to free up memory used for struct tuners. @Rafael: I don't really want to have following patch: "cpufreq: Add Kconfig option to enable/disable have_multiple_policies" and added it because of comment from Borislov against which nobody else replied :) I still want to have your opinion on the same. Viresh Kumar (4): cpufreq: Add per policy governor-init/exit infrastructure cpufreq: governor: Implement per policy instances of governors cpufreq: Add Kconfig option to enable/disable have_multiple_policies cpufreq: Get rid of "struct global_attr" drivers/cpufreq/Kconfig | 3 + drivers/cpufreq/acpi-cpufreq.c | 9 +- drivers/cpufreq/cpufreq.c | 27 +++-- drivers/cpufreq/cpufreq_conservative.c | 148 +++++++++++++--------- drivers/cpufreq/cpufreq_governor.c | 159 ++++++++++++++---------- drivers/cpufreq/cpufreq_governor.h | 43 +++++-- drivers/cpufreq/cpufreq_ondemand.c | 216 +++++++++++++++++++-------------- drivers/cpufreq/intel_pstate.c | 30 ++--- include/linux/cpufreq.h | 44 ++++--- 9 files changed, 402 insertions(+), 277 deletions(-) -- 1.7.12.rc2.18.g61b472e

12 years, 8 months

suggestion: move kernel patches off linaro-dev

by Peter Maydell

Hi; does anybody else think it would be a good idea to move all the kernel patch email traffic off linaro-dev and onto a more kernel-specific mailing list (eg, linaro-kernel, maybe) ? A quick eyeball of a few pages of my gmail folder for linaro-dev shows that something like 75% of it is kernel devs patchbombing the list. You don't see huge floods of patches here for gcc or QEMU or any of the many other projects Linaro contributes to, so why all the kernel patches? I think that moving these off to their own list would allow those who have a genuine interest in kernel internals to read and review these patches, and reduce the noise level on this (Linaro's most generic list) for everybody else. NB: I'm not suggesting "no kernel discussion here"; I just would like actual patchmail to go elsewhere... thanks -- PMM

12 years, 8 months

[resend] Timer broadcast question

by Daniel Lezcano

Hi, I am working on identifying the different wakeup sources from the interrupts and I have a question regarding the timer broadcast. The broadcast timer is setup to the next event and that will wake up any idle cpu belonging to the "broadcast cpumask", right ? The cpu which has been woken up will look for each cpu the next-event and send an IPI to wake it up. Although, it is possible the sender of this IPI may not be concerned by the timer expiration and has been woken up just for sending the IPI, right ? If this is correct, is it possible to setup the timer irq affinity to a cpu which will be concerned by the timer expiration ? so we prevent an unnecessary wake up for a cpu. For example, let's say we have a 2 cpus system. cpu0, cpu1 are idle The next event is for cpu1 but cpu0 is wake up by the broadcast timer, after checking it has nothing to do except send a IPI_TIMER to cpu1 and then goes to idle again. Wouldn't be worth to set the broadcast timer affinity to cpu1, so cpu0 is not wake up ? Did I missed something or does it sound correct ? Thanks -- Daniel -- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog

12 years, 8 months

Test Result Summary of Calendar Week 8, 2013 for Linux Linaro ubuntu Quantal.

by Botao Sun

Calendar Week 8, 2013: Here is test result summary for Linux Linaro ubuntu Quantal image on following boards: 1) ARM Versatile Express A9; 2) Samsung Arndale; 3) TI Panda 4430; 4) TI Panda 4460; 5) ST Ericsson Snowball. Synopsis: Kernel version on TI Panda platform has been upgraded to "3.8.0-1-linaro-omap", but many issues occurred on TI Panda 4430 and even boot failed on TI Panda 4460. Boot loader on STE Snowball has been upgraded to "U-Boot 2013.01.-rc1 ". 1. ARM Versatile Express A9 + Linux Linaro Quantal (Column L): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdFNmV… It keeps exactly same status from calendar week 50 last year: only "Halt" & "Device Tree" test failed, all other features work well. 2. Samsung Arndale + Linux Linaro Quantal (Column F): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AgB-fT5LL31CdGZJS… Ethernet backs to work and DS-5 works well too. A kernel panic is occurred during the Power Management test, HDMI display is still unavailable. All other features work well. 3. TI Panda 4430 + Linux Linaro Quantal (Column L): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEwwZ… Kernel has been upgraded from 3.4 to 3.8 but this causes many issues. HDMI, DVI-D, Ethernet, WiFi and USB Host failed. Also, there is a kernel panic occurred during the power management test. ARM DS-5 test is blocked since network is unavailable. 4. TI Panda 4460 + Linux Linaro Quantal (Column L): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEwwZ… Kernel has been upgraded from 3.4 to 3.8 but this causes boot failed on TI Panda 4460 board. All rest test is blocked. 5. ST Ericsson Snowball + Linux Linaro Quantal (Column L): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdFJ4X… Boot loader has been upgraded to the latest version "U-Boot 2013.01.-rc1" and this upgrade fixed Ethernet and Device Tree. Now we have SD MMC, HDMI display, Reboot and Power Management test failed. For the previous week test summary (Calendar Week 7), please refer to attachment. Thank you. Best Regards Botao Sun

12 years, 8 months

No section mismatch warnings for Thumb2 kernels

by Jon Medhurst (Tixy)

After some time investigating why I wasn't seeing some kernel section mismatch errors that someone else was seeing, I found the cause was that in Linaro we build Thumb2 kernels in the main, and modpost.c doesn't have support for any of the Thumb relocation types in addend_arm_rel(). I thought I would spread this knowledge, because lack of section mismatch warnings means we might miss some nasty bugs when developing code. If this is old news, then sorry for the noise. -- Tixy

12 years, 8 months

[pmqa,1/1] cpuidle: add function to log cpuidle stats

by Sanjay Singh Rawat

Add functionality to record the overall and current runtime cpuidle statistics. Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.com> --- cpuidle/Readme.txt | 9 + cpuidle/cpuidle_03.sh | 9 + cpuidle/cpuidle_stats.c | 443 +++++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 461 insertions(+) create mode 100644 cpuidle/Readme.txt create mode 100644 cpuidle/cpuidle_stats.c diff --git a/cpuidle/Readme.txt b/cpuidle/Readme.txt new file mode 100644 index 0000000..9eacae0 --- /dev/null +++ b/cpuidle/Readme.txt @@ -0,0 +1,9 @@ +# cpuidle_stats execution: + - can compile and run separately. + - can run as part of cpuidle test : "sudo make -C cpuidle check" + +# info: +- Need sudo permission to run. +- saves trace in cpuidle/cpuidle_trace.log. +- Gives complete and current sampling time(in/out and timespent) cpuidle +state information. diff --git a/cpuidle/cpuidle_03.sh b/cpuidle/cpuidle_03.sh index 22bca10..0295555 100755 --- a/cpuidle/cpuidle_03.sh +++ b/cpuidle/cpuidle_03.sh @@ -56,5 +56,14 @@ fi trap "restore_cpus; sigtrap" SIGHUP SIGINT SIGTERM +check_cpuidle_trace() { + echo "### cpuidle state transition check:" + echo "## Collect the overall and current runtime cpuidle stats" + check "cpuidle stats execution" "./cpuidle_stats" + return 0 +} + for_each_cpu check_cpuidle_kill restore_cpus + +check_cpuidle_trace diff --git a/cpuidle/cpuidle_stats.c b/cpuidle/cpuidle_stats.c new file mode 100644 index 0000000..8cc5436 --- /dev/null +++ b/cpuidle/cpuidle_stats.c @@ -0,0 +1,443 @@ +#include <stdio.h> +#include <unistd.h> +#include <string.h> +#include <stdlib.h> +#include <sys/types.h> +#include <fcntl.h> +#include <getopt.h> +#include <sched.h> +#include <linux/unistd.h> +#include <signal.h> +#include <time.h> + +#define path "./cpuidle_trace.log" + +unsigned int num_of_cpus; +int signal_handled = 0; +struct timeval start_time, stop_time; +FILE *log_file; +struct cpu_idle_stats { + int num_states, exit,active_state; + struct state_stats{ + char name[25],desc[25],latency[25]; + char power[25],time[25], usage[25]; + int in; + double time_spent, entry_time; + } **state; + double exit_time; +} **cpuidle_stats; + +double traceline_time_stamp(char *line) +{ + char *ptr; + char time_stamp[14]; + + ptr = strchr(line,'.'); + if( ptr == NULL) { + printf("Funtion-%s : error, line format not recognized\n",__func__); + return -1; //todo - proper return value + } + strncpy(time_stamp,(ptr-6),13); //6 digits before and after decimal + time_stamp[14]=0; //set EOS + + return atof(time_stamp); +} + +void print_stat() +{ + int cpu,state; + + fprintf(log_file,"=================== Current cpuidle statistics ================\n"); + + for(cpu=0 ; cpu<4 ; cpu++) { + fprintf(log_file,"cpu-%d : [State] [In-Count] [Time Spent]\n",cpu); + for(state=0 ; state<5 ; state++) { + fprintf(log_file,"\t[states-%d] in-count = %d time-spent = %lf\n", + state, cpuidle_stats[cpu]->state[state]->in, + cpuidle_stats[cpu]->state[state]->time_spent); + } + fprintf(log_file,"\t\t[Out-Count] = %d\n\n",cpuidle_stats[cpu]->exit); + } +} + +/* function: scan the trace file + */ +int scan_trace_file(void) +{ + char line[1024],str[50]; + FILE *fp; + + printf("Scanning trace file ...\n"); + fp = fopen (path, "r"); + if (fp == NULL) { + printf("function-%s: error fopen\n",__func__); + return -1; + } + + while( fgets(line, sizeof(line), fp) != NULL ) { + if(strstr(line,"cpu_idle")) { + int cpu_num; + for(cpu_num=0 ; cpu_num<4 ; cpu_num++) { + int ret; + + sprintf(str,"cpu_id=%d",cpu_num); + if(strstr(line,str) == NULL) + continue; + + for(ret=0 ; ret<cpuidle_stats[cpu_num]->num_states ; ret++) { + sprintf(str,"state=%d",ret); + if(strstr(line,"state=4294967295")) { //todo: do it better + cpuidle_stats[cpu_num]->exit_time = + traceline_time_stamp(line); + if(cpuidle_stats[cpu_num]->state[cpuidle_stats[cpu_num]->active_state]->entry_time) + cpuidle_stats[cpu_num]->state[cpuidle_stats[cpu_num]->active_state]->time_spent += + cpuidle_stats[cpu_num]->exit_time - + cpuidle_stats[cpu_num]->state[cpuidle_stats[cpu_num]->active_state]->entry_time; + + cpuidle_stats[cpu_num]->exit++; + break; + } + if(strstr(line,str) == NULL) + continue; + + cpuidle_stats[cpu_num]->active_state = ret; + cpuidle_stats[cpu_num]->state[ret]->entry_time = + traceline_time_stamp(line); + cpuidle_stats[cpu_num]->state[ret]->in++; + } + + } + } + } + print_stat(); + printf("Logs saved in cpuidle_stats.log\n\n"); +} + +/* function: allocate and setup few structure for you + */ +void print_cpus_states_info(struct cpu_idle_stats **cpuidle_stats) +{ + int cpus, states; + char line_buf[1024],*ptr; + + for(cpus=0 ; cpus<num_of_cpus ; cpus++) + { + memset(line_buf,'\0',sizeof(line_buf)); + ptr=line_buf; + fprintf(log_file,"=========================================================\n"); + fprintf(log_file,"\nCPU%d - Overall cpuidle state info: [STATE-0 ---> STATE-%d]\n" + ,cpus,(cpuidle_stats[cpus]->num_states-1)); + for(states=0 ; states< cpuidle_stats[cpus]->num_states ; states++) + { + int str_len= strlen(cpuidle_stats[cpus]->state[states]->desc); + memcpy(ptr,cpuidle_stats[cpus]->state[states]->desc,str_len); + ptr += (str_len - 1); + *ptr++ = '/'; + *ptr++ = '\t'; + } + fprintf(log_file," desc[0->4] - %s\n",line_buf); + + memset(line_buf,'\0',sizeof(line_buf)); + ptr=line_buf; + for(states=0 ; states< cpuidle_stats[cpus]->num_states ; states++) + { + int str_len= strlen(cpuidle_stats[cpus]->state[states]->latency); + memcpy(ptr,cpuidle_stats[cpus]->state[states]->latency,str_len); + ptr += (str_len - 1); + *ptr++ = '\t'; + } + fprintf(log_file," latency[0->4] - %s\n",line_buf); + + memset(line_buf,'\0',sizeof(line_buf)); + ptr=line_buf; + for(states=0 ; states< cpuidle_stats[cpus]->num_states ; states++) + { + int str_len= strlen(cpuidle_stats[cpus]->state[states]->name); + memcpy(ptr,cpuidle_stats[cpus]->state[states]->name,str_len); + ptr += (str_len - 1); + *ptr++ = '\t'; + } + fprintf(log_file," name[0->4] - %s\n",line_buf); + + memset(line_buf,'\0',sizeof(line_buf)); + ptr=line_buf; + for(states=0 ; states< cpuidle_stats[cpus]->num_states ; states++) + { + int str_len= strlen(cpuidle_stats[cpus]->state[states]->power); + memcpy(ptr,cpuidle_stats[cpus]->state[states]->power,str_len); + ptr += (str_len - 1); + *ptr++ = '\t'; + } + fprintf(log_file," power[0->4] - %s\n",line_buf); + + memset(line_buf,'\0',sizeof(line_buf)); + ptr=line_buf; + for(states=0 ; states< cpuidle_stats[cpus]->num_states ; states++) + { + int str_len= strlen(cpuidle_stats[cpus]->state[states]->time); + memcpy(ptr,cpuidle_stats[cpus]->state[states]->time,str_len); + ptr += (str_len - 1); + *ptr++ = '\t'; + } + fprintf(log_file," time[0->4] - %s\n",line_buf); + + memset(line_buf,'\0',sizeof(line_buf)); + ptr=line_buf; + for(states=0 ; states< cpuidle_stats[cpus]->num_states ; states++) + { + int str_len= strlen(cpuidle_stats[cpus]->state[states]->usage); + memcpy(ptr,cpuidle_stats[cpus]->state[states]->usage,str_len); + ptr += (str_len - 1); + *ptr++ = '\t'; + } + fprintf(log_file," usage[0->4] - %s\n",line_buf); + } + fprintf(log_file,"=========================================================\n"); +} + +/* function: read sys attribute in char buffer + */ +int read_attribute(char *state_path, char *buf) +{ + int fd, ret; + + fd = open(state_path, O_RDONLY, 0666); + if(fd < 0) { + ret = fd; + goto fail; + } + ret = read(fd, buf, 255); + if(ret < 0) { + close(fd); + goto fail; + } + close(fd); + return 0; +fail: + printf("function-%s: error/fail\n",__func__); + return ret; +} + +/* Function: Read the cpu-state attributes from sysfs + */ +int read_state_stats(struct state_stats *state, char *state_path) +{ + char state_attr_path[256]; + int ret; + + snprintf(state_attr_path, sizeof(state_attr_path),"%s/%s", + state_path,"desc"); + ret = read_attribute(state_attr_path,state->desc); + if(ret < 0) + goto fail; + + snprintf(state_attr_path, sizeof(state_attr_path),"%s/%s", + state_path,"latency"); + ret = read_attribute(state_attr_path,state->latency); + if(ret < 0) + goto fail; + + snprintf(state_attr_path, sizeof(state_attr_path),"%s/%s", + state_path,"name"); + ret = read_attribute(state_attr_path,state->name); + if(ret < 0) + goto fail; + + snprintf(state_attr_path, sizeof(state_attr_path),"%s/%s", + state_path,"power"); + ret = read_attribute(state_attr_path,state->power); + if(ret < 0) + goto fail; + + snprintf(state_attr_path, sizeof(state_attr_path),"%s/%s", + state_path,"time"); + ret = read_attribute(state_attr_path,state->time); + if(ret < 0) + goto fail; + + snprintf(state_attr_path, sizeof(state_attr_path),"%s/%s", + state_path,"usage"); + ret = read_attribute(state_attr_path,state->usage); + if(ret < 0) + goto fail; + + return 0; +fail: + printf("Function-%s: error\n",__func__); + return ret; +} + +/* function: print complete stats present in sysfs from epoch time + */ +int get_states_info(struct cpu_idle_stats **cpuidle_stats, int num_of_cpus) +{ + char cpu_path[256],state_path[256]; + int cpu,state,ret; + FILE *file; + + for(cpu=0 ; cpu<num_of_cpus ; cpu++) { + snprintf(cpu_path, sizeof(state_path), + "/sys/devices/system/cpu/cpu%d/cpuidle",cpu); + for(state=0 ; state<256 ; state++){ + snprintf(state_path, sizeof(state_path),"%s/state%d", + cpu_path,state); + file = fopen(state_path,"r"); + if(file != NULL) { + fclose(file); + } + else { + fprintf(log_file,"cpu-%d total states = %d\n",cpu,state); + cpuidle_stats[cpu]->num_states = state; + break; + } + } + + cpuidle_stats[cpu]->state = + malloc(cpuidle_stats[cpu]->num_states * sizeof(int *)); + for(state=0 ; state<cpuidle_stats[cpu]->num_states ; state++) { + cpuidle_stats[cpu]->state[state] = + malloc(sizeof(struct state_stats)); + memset(cpuidle_stats[cpu]->state[state],'\0', + sizeof(struct state_stats)); + snprintf(state_path, sizeof(state_path),"%s/state%d", + cpu_path,state); + ret = read_state_stats(cpuidle_stats[cpu]->state[state], + state_path); + } + } + print_cpus_states_info(cpuidle_stats); +} + +/* function: checks cpu and state information and allocate structure accordingly + */ +int setup_cpuidle_info() +{ + int ret,retb; + + num_of_cpus = sysconf(_SC_NPROCESSORS_CONF); + fprintf(log_file,"number of cpus = %d\n",num_of_cpus); + + cpuidle_stats = malloc(num_of_cpus * sizeof(int *)); + for( ret=0 ; ret<num_of_cpus ; ret++) { + int i; + + cpuidle_stats[ret] = (struct cpu_idle_stats*) + malloc(sizeof(struct cpu_idle_stats)); + if(!cpuidle_stats[ret]) { + printf("functioin:%s memory allocation failure\n",__func__); + } + memset(cpuidle_stats[ret],0,sizeof(struct cpu_idle_stats)); + } + ret = get_states_info(cpuidle_stats, num_of_cpus); + if(ret < 0) { + printf("function:%s: error\n",__func__); + } + + return ret; +} + +/* function: Handler to stop tracing + */ +void handle_tracing_stop(int signum) +{ + char buf[256]; + int ret; + double duration; + + snprintf(buf,sizeof(buf), + "echo 0 > /sys/kernel/debug/tracing/events/power/cpu_idle/enable"); + ret = system(buf); + if(ret != 0) + goto fail; + + snprintf(buf,sizeof(buf), + "cat /sys/kernel/debug/tracing/trace > ./cpuidle_trace.log"); + ret = system(buf); + if(ret != 0) + goto fail; + + printf("\nCapturing cpu_idle trace : end, saved in file:" + "cpuidle_trace.log\n"); + signal_handled = 1; + return; +fail: + printf("san-%s: fail/error\n",__func__); +} + +/* function: Generate cpuidle trace and save in file + */ +int capture_trace() +{ + char buf[256]; + char p[]="adkfh"; + int ret; + + printf("\n\nCapturing cpu_idle trace : start\n"); + signal(SIGINT, handle_tracing_stop); + + /* prepare */ + snprintf(buf,sizeof(buf), + "echo 0 > /sys/kernel/debug/tracing/events/power/cpu_idle/enable"); + ret = system(buf); + if(ret != 0) + goto fail; + snprintf(buf,sizeof(buf),"echo > /sys/kernel/debug/tracing/trace"); + ret = system(buf); + if(ret != 0) + goto fail; + /* enable tracing */ + snprintf(buf,sizeof(buf), + "echo nop > /sys/kernel/debug/tracing/current_tracer"); + ret = system(buf); + if(ret != 0) + goto fail; + snprintf(buf,sizeof(buf), + "echo 1 > /sys/kernel/debug/tracing/tracing_enabled"); + ret = system(buf); + if(ret != 0) + goto fail; + snprintf(buf,sizeof(buf),"echo 1 > /sys/kernel/debug/tracing/tracing_on"); + ret = system(buf); + if(ret != 0) + goto fail; + + gettimeofday(&start_time,NULL); + snprintf(buf,sizeof(buf), + "echo 1 > /sys/kernel/debug/tracing/events/power/cpu_idle/enable"); + ret = system(buf); + if(ret != 0) + goto fail; + + printf("\nPress Ctrl + c to Exit\n"); + while(!signal_handled) + sleep(1); + + return 0; +fail: + printf("%s: fail/error\n",__func__); + return ret; +} + +int main() +{ + int ret; + + log_file = fopen("cpuidle_stats.log","w"); + if(log_file == NULL) { + printf("error: can't create log file\n"); + return -1; + } + + ret = setup_cpuidle_info(); + if(ret < 0) { + printf("function: %s: error\n",__func__); + } + + ret = capture_trace(); + if(ret != 0) + return ret; + + scan_trace_file(); + + return 0; +} -- 1.7.9.5

12 years, 8 months

Failure to generate beagle_sd.img using linaro-media-create

by Amar Shankar

Hi All, I am trying to create beagle_sd.img for beagle board using linaro-media-create, by referring the procedure in http://sourceforge.net/apps/mediawiki/tianocore/index.php?title=BeagleBoard… But I am getting the below error. Could someone please help resolve the issue. kiran@kiran-desktop:~/beagle_image$ sudo linaro-media-create --image_file beagle_sd.img --dev beagle --binary linaro-m-headless-tar-20101101-0.tar.gz --hwpack hwpack_linaro-omap3_20101109-1_armel_supported.tar.gz /usr/lib/pymodules/python2.6/argparse.py:1576: DeprecationWarning: The "version" argument to ArgumentParser is deprecated. Please use "add_argument(..., action='version', version="N", ...)" instead """instead""", DeprecationWarning) Searching correct rootfs path ------------------------------------------------------------ Installing (linaro-hwpack-install) hwpack_linaro-omap3_20101109-1_armel_supported.tar.gz in target rootfs. Unpacking hardware pack ...Done Updating apt package lists ... Ign file: ./ Release.gpg Ign filetmp/tmp.PybN7nuXq3/unpacked/pkgs/ ./ Translation-en Ign file: ./ Release Ign file: ./ Packages Get:1 http://ppa.launchpad.net maverick Release.gpg [316B] Ign http://ppa.launchpad.net/linaro-maintainers/overlay/ubuntu/ maverick/main Translation-en Ign http://ports.ubuntu.com maverick Release.gpg Ign http://ports.ubuntu.com/ maverick/main Translation-en Ign http://ports.ubuntu.com/ maverick/universe Translation-en Ign http://ports.ubuntu.com maverick-security Release.gpg Ign http://ports.ubuntu.com/ maverick-security/main Translation-en Ign http://ports.ubuntu.com/ maverick-security/universe Translation-en Ign http://ports.ubuntu.com maverick-updates Release.gpg Ign http://ports.ubuntu.com/ maverick-updates/main Translation-en Ign http://ports.ubuntu.com/ maverick-updates/universe Translation-en Ign http://ports.ubuntu.com maverick-proposed Release.gpg Ign http://ports.ubuntu.com/ maverick-proposed/main Translation-en Get:2 http://ppa.launchpad.net maverick Release [9762B] Ign http://ports.ubuntu.com/ maverick-proposed/universe Translation-en Ign http://ports.ubuntu.com maverick Release Ign http://ports.ubuntu.com maverick-security Release Get:3 http://ppa.launchpad.net maverick/main armel Packages [11.7kB] Ign http://ports.ubuntu.com maverick-updates Release Ign http://ports.ubuntu.com maverick-proposed Release Ign http://ports.ubuntu.com maverick/main armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick/universe armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick-security/main armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick-security/universe armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick-updates/main armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick-updates/universe armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick-proposed/main armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick-proposed/universe armel Packages/DiffIndex Ign http://ports.ubuntu.com maverick/main armel Packages Ign http://ports.ubuntu.com maverick/universe armel Packages Ign http://ports.ubuntu.com maverick-security/main armel Packages Ign http://ports.ubuntu.com maverick-security/universe armel Packages Ign http://ports.ubuntu.com maverick-updates/main armel Packages Ign http://ports.ubuntu.com maverick-updates/universe armel Packages Ign http://ports.ubuntu.com maverick-proposed/main armel Packages Ign http://ports.ubuntu.com maverick-proposed/universe armel Packages Err http://ports.ubuntu.com maverick/main armel Packages 404 Not Found Err http://ports.ubuntu.com maverick/universe armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-security/main armel Packages Err http://ports.ubuntu.com maverick/main armel Packages 404 Not Found Err http://ports.ubuntu.com maverick/universe armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-security/main armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-security/universe armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-updates/main armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-updates/universe armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-proposed/main armel Packages 404 Not Found Err http://ports.ubuntu.com maverick-proposed/universe armel Packages 404 Not Found Fetched 21.8kB in 2s (9070B/s) W: Failed to fetch http://ports.ubuntu.com/dists/maverick/main/binary-armel/Packages.gz 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick/universe/binary-armel/Packages.gz 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick-security/main/binary-armel/Packages.… 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick-security/universe/binary-armel/Packa… 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick-updates/main/binary-armel/Packages.gz 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick-updates/universe/binary-armel/Packag… 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick-proposed/main/binary-armel/Packages.… 404 Not Found W: Failed to fetch http://ports.ubuntu.com/dists/maverick-proposed/universe/binary-armel/Packa… 404 Not Found E: Some index files failed to download, they have been ignored, or old ones used instead. Cleaning up .../bin/mv: cannot stat `/sbin/start-stop-daemon.REAL': No such file or directory proc umounted Traceback (most recent call last): File "/usr/bin/linaro-media-create", line 202, in <module> verified_files, extract_kpkgs, *hwpacks) File "/usr/lib/pymodules/python2.6/linaro_image_tools/media_create/chroot_utils.py", line 89, in install_hwpacks hwpack_force_yes or hwpack_verified) File "/usr/lib/pymodules/python2.6/linaro_image_tools/media_create/chroot_utils.py", line 129, in install_hwpack cmd_runner.run(args, as_root=True, chroot=chroot_dir).wait() File "/usr/lib/pymodules/python2.6/linaro_image_tools/cmd_runner.py", line 100, in wait raise SubcommandNonZeroReturnValue(self._my_args, returncode) linaro_image_tools.cmd_runner.SubcommandNonZeroReturnValue: Sub process "['chroot', '/tmp/tmpaR5Ly6/rootfs/binary', 'linaro-hwpack-install', '--hwpack-version', '20101109-1', '--hwpack-arch', 'armel', '--hwpack-name', 'linaro-omap3', '/hwpack_linaro-omap3_20101109-1_armel_supported.tar.gz']" returned a non-zero value: 1 Regards, Amar Shankar ________________________________ DISCLAIMER: This email may contain confidential information and is intended only for the use of the specific individual(s) to which it is addressed. If you are not the intended recipient of this email, you are hereby notified that any unauthorized use, dissemination or copying of this email or the information contained in it or attached to it is strictly prohibited. If you received this message in error, please immediately notify the sender at Infotech and delete the original message.

12 years, 8 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev