linaro-dev February 2013

linaro-dev@lists.linaro.org

85 participants
82 discussions

[powerdebug,1/1] clock: support common clock framework

by Sanjay Singh Rawat

In common clock framework (merged in 3.8-rc1) the directory and attributes are changed, adapt to the new clock entries in debugfs. Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.com> --- clocks.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/clocks.c b/clocks.c index 2611a0d..95acf57 100644 --- a/clocks.c +++ b/clocks.c @@ -42,9 +42,19 @@ struct clock_info { int usecount; bool expanded; char *prefix; + int preparecount; + int enablecount; + int notifiercount; } *clocks_info; +enum clock_fw_type{ + CCF, /* common clock framework */ + OCF, /* old clock framework */ + MAX, +}; + static struct tree *clock_tree = NULL; +static int clock_fw; static int locate_debugfs(char *clk_path) { @@ -144,9 +154,18 @@ static inline int read_clock_cb(struct tree *t, void *data) { struct clock_info *clk = t->private; - file_read_value(t->path, "flags", "%x", &clk->flags); - file_read_value(t->path, "rate", "%d", &clk->rate); - file_read_value(t->path, "usecount", "%d", &clk->usecount); + if(clock_fw == CCF) { + file_read_value(t->path, "clk_flags", "%x", &clk->flags); + file_read_value(t->path, "clk_rate", "%d", &clk->rate); + file_read_value(t->path, "clk_prepare_count", "%d", &clk->preparecount); + file_read_value(t->path, "clk_enable_count", "%d", &clk->enablecount); + file_read_value(t->path, "clk_notifier_count", "%d", &clk->notifiercount); + } + else { + file_read_value(t->path, "flags", "%x", &clk->flags); + file_read_value(t->path, "rate", "%d", &clk->rate); + file_read_value(t->path, "usecount", "%d", &clk->usecount); + } return 0; } @@ -206,9 +225,17 @@ static char *clock_line(struct tree *t) if (asprintf(&clkrate, "%d%s", rate, clkunit) < 0) goto free_clkname; - if (asprintf(&clkline, "%-55s 0x%-16x %-12s %-9d %-8d", clkname, - clk->flags, clkrate, clk->usecount, t->nrchild) < 0) - goto free_clkrate; + if(clock_fw == CCF) { + if (asprintf(&clkline, "%-35s 0x%-8x %-12s %-10d %-11d %-15d %-14d %-10d", + clkname, clk->flags, clkrate, clk->usecount, t->nrchild, + clk->preparecount, clk->enablecount, clk->notifiercount) < 0) + goto free_clkrate; + } + else { + if (asprintf(&clkline, "%-55s 0x%-16x %-12s %-9d %-8d", + clkname, clk->flags, clkrate, clk->usecount, t->nrchild) < 0) + goto free_clkrate; + } free_clkrate: free(clkrate); @@ -259,9 +286,17 @@ static int clock_print_header(void) char *buf; int ret; - if (asprintf(&buf, "%-55s %-16s %-12s %-9s %-8s", + if(clock_fw == CCF) { + if (asprintf(&buf, "%-35s %-10s %-12s %-10s %-11s %-15s %-14s %-14s", + "Name", "Flags", "Rate", "Usecount", "Children", "Prepare_Count", + "Enable_Count", "Notifier_Count") < 0) + return -1; + } + else { + if (asprintf(&buf, "%-55s %-16s %-12s %-9s %-8s", "Name", "Flags", "Rate", "Usecount", "Children") < 0) return -1; + } ret = display_column_name(buf); @@ -384,17 +419,25 @@ static struct display_ops clock_ops = { */ int clock_init(void) { - char clk_dir_path[PATH_MAX]; + char clk_dir_path[MAX+1][PATH_MAX]; - if (locate_debugfs(clk_dir_path)) + if (locate_debugfs(clk_dir_path[CCF]) || locate_debugfs(clk_dir_path[OCF])) return -1; - sprintf(clk_dir_path, "%s/clock", clk_dir_path); - - if (access(clk_dir_path, F_OK)) + sprintf(clk_dir_path[CCF], "%s/clk", clk_dir_path[CCF]); + sprintf(clk_dir_path[OCF], "%s/clock", clk_dir_path[OCF]); + if (!access(clk_dir_path[CCF], F_OK)) { + clock_fw = CCF; + strcpy(clk_dir_path[MAX],clk_dir_path[CCF]); + } + else if(!access(clk_dir_path[OCF], F_OK)) { + clock_fw = OCF; + strcpy(clk_dir_path[MAX],clk_dir_path[OCF]); + } + else return -1; - clock_tree = tree_load(clk_dir_path, NULL, false); + clock_tree = tree_load(clk_dir_path[MAX], NULL, false); if (!clock_tree) return -1; -- 1.7.9.5

12 years, 12 months

[powerdebug,1/1] clock: support common clock framework

by Sanjay Singh Rawat

For common clock framework directory and attributes are changed, adapt to the new structure. Signed-off-by: Sanjay Singh Rawat <sanjay.rawat(a)linaro.com> --- clocks.c | 69 ++++++++++++++++++++++++++++++++++++++++++++++++++------------ 1 file changed, 56 insertions(+), 13 deletions(-) diff --git a/clocks.c b/clocks.c index 2611a0d..95acf57 100644 --- a/clocks.c +++ b/clocks.c @@ -42,9 +42,19 @@ struct clock_info { int usecount; bool expanded; char *prefix; + int preparecount; + int enablecount; + int notifiercount; } *clocks_info; +enum clock_fw_type{ + CCF, /* common clock framework */ + OCF, /* old clock framework */ + MAX, +}; + static struct tree *clock_tree = NULL; +static int clock_fw; static int locate_debugfs(char *clk_path) { @@ -144,9 +154,18 @@ static inline int read_clock_cb(struct tree *t, void *data) { struct clock_info *clk = t->private; - file_read_value(t->path, "flags", "%x", &clk->flags); - file_read_value(t->path, "rate", "%d", &clk->rate); - file_read_value(t->path, "usecount", "%d", &clk->usecount); + if(clock_fw == CCF) { + file_read_value(t->path, "clk_flags", "%x", &clk->flags); + file_read_value(t->path, "clk_rate", "%d", &clk->rate); + file_read_value(t->path, "clk_prepare_count", "%d", &clk->preparecount); + file_read_value(t->path, "clk_enable_count", "%d", &clk->enablecount); + file_read_value(t->path, "clk_notifier_count", "%d", &clk->notifiercount); + } + else { + file_read_value(t->path, "flags", "%x", &clk->flags); + file_read_value(t->path, "rate", "%d", &clk->rate); + file_read_value(t->path, "usecount", "%d", &clk->usecount); + } return 0; } @@ -206,9 +225,17 @@ static char *clock_line(struct tree *t) if (asprintf(&clkrate, "%d%s", rate, clkunit) < 0) goto free_clkname; - if (asprintf(&clkline, "%-55s 0x%-16x %-12s %-9d %-8d", clkname, - clk->flags, clkrate, clk->usecount, t->nrchild) < 0) - goto free_clkrate; + if(clock_fw == CCF) { + if (asprintf(&clkline, "%-35s 0x%-8x %-12s %-10d %-11d %-15d %-14d %-10d", + clkname, clk->flags, clkrate, clk->usecount, t->nrchild, + clk->preparecount, clk->enablecount, clk->notifiercount) < 0) + goto free_clkrate; + } + else { + if (asprintf(&clkline, "%-55s 0x%-16x %-12s %-9d %-8d", + clkname, clk->flags, clkrate, clk->usecount, t->nrchild) < 0) + goto free_clkrate; + } free_clkrate: free(clkrate); @@ -259,9 +286,17 @@ static int clock_print_header(void) char *buf; int ret; - if (asprintf(&buf, "%-55s %-16s %-12s %-9s %-8s", + if(clock_fw == CCF) { + if (asprintf(&buf, "%-35s %-10s %-12s %-10s %-11s %-15s %-14s %-14s", + "Name", "Flags", "Rate", "Usecount", "Children", "Prepare_Count", + "Enable_Count", "Notifier_Count") < 0) + return -1; + } + else { + if (asprintf(&buf, "%-55s %-16s %-12s %-9s %-8s", "Name", "Flags", "Rate", "Usecount", "Children") < 0) return -1; + } ret = display_column_name(buf); @@ -384,17 +419,25 @@ static struct display_ops clock_ops = { */ int clock_init(void) { - char clk_dir_path[PATH_MAX]; + char clk_dir_path[MAX+1][PATH_MAX]; - if (locate_debugfs(clk_dir_path)) + if (locate_debugfs(clk_dir_path[CCF]) || locate_debugfs(clk_dir_path[OCF])) return -1; - sprintf(clk_dir_path, "%s/clock", clk_dir_path); - - if (access(clk_dir_path, F_OK)) + sprintf(clk_dir_path[CCF], "%s/clk", clk_dir_path[CCF]); + sprintf(clk_dir_path[OCF], "%s/clock", clk_dir_path[OCF]); + if (!access(clk_dir_path[CCF], F_OK)) { + clock_fw = CCF; + strcpy(clk_dir_path[MAX],clk_dir_path[CCF]); + } + else if(!access(clk_dir_path[OCF], F_OK)) { + clock_fw = OCF; + strcpy(clk_dir_path[MAX],clk_dir_path[OCF]); + } + else return -1; - clock_tree = tree_load(clk_dir_path, NULL, false); + clock_tree = tree_load(clk_dir_path[MAX], NULL, false); if (!clock_tree) return -1; -- 1.7.9.5

12 years, 12 months

[PATCH v2 0/2] Add ST-Ericsson AB8500 HWMON driver

by Hongbo Zhang

Guenter, Please check this v2 patches, thanks. Anton Vorontsov and David Woodhouse, Please have a look at this [2/2] patch, thanks. v1 -> v2 changes: - Add Documentation/hwmon/abx500 and Documentation/hwmon/abx500 - Make devices which cannot report milli-Celsius invisible - Add temp5_crit interface - Re-work the old find_active_thresholds() to threshold_updated() - Reset updated_min_alarm and updated_max_alarm at the end of each loop - Update the hyst mechamisn to make it works as real hyst - Remove non-stand attributes - Re-order the operations sequence inside probe and remove functions - Update all the lock usages to eliminate race conditions - Make attibutes index starts from 0 also changes: - Since the old [1/2] "ARM: ux500: rename ab8500 to abx500 for hwmon driver" has been merged by Samuel, so won't send it again. - Add another new patch "ab8500_btemp: export two symblols" as [2/2] of this patch set. Hongbo Zhang (2): hwmon: add ST-Ericsson ABX500 hwmon driver ab8500_btemp: export two symblols Documentation/hwmon/ab8500 | 22 ++ Documentation/hwmon/abx500 | 26 +++ drivers/hwmon/Kconfig | 13 ++ drivers/hwmon/Makefile | 1 + drivers/hwmon/ab8500.c | 163 +++++++++++++ drivers/hwmon/abx500.c | 544 +++++++++++++++++++++++++++++++++++++++++++ drivers/hwmon/abx500.h | 84 +++++++ drivers/power/ab8500_btemp.c | 2 + 8 files changed, 855 insertions(+) create mode 100644 Documentation/hwmon/ab8500 create mode 100644 Documentation/hwmon/abx500 create mode 100644 drivers/hwmon/ab8500.c create mode 100644 drivers/hwmon/abx500.c create mode 100644 drivers/hwmon/abx500.h -- 1.8.0

12 years, 12 months

Test Result Summary of Calendar Week 6, 2013 for Linux Linaro ubuntu Quantal.

by Botao Sun

Calendar Week 6, 2013: Here is test result summary for Linux Linaro ubuntu Quantal image on following boards: 1) ARM Versatile Express A9; 2) Samsung Arndale; 3) TI Panda 4430; 4) TI Panda 4460; 5) ST Ericsson Snowball. Synopsis: ARM DS-5 works well on all boards except STE Snowball; Power Management test passed on both TI Panda 4430 & 4460; No display on Samsung Arndale & STE Snowball. 1. ARM Versatile Express A9 + Linux Linaro Quantal (Column J): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdFNmV… It keeps exactly same status as last test result: only "Halt" & "Device Tree" test failed, all other features work well. 2. Samsung Arndale + Linux Linaro Quantal (Column D): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AgB-fT5LL31CdGZJS… "Boot" & "Reboot" work well, HDMI display is unavailable, Power Management test is not pre-installed in image, but it's as expected, other features work well. 3. TI Panda 4430 + Linux Linaro Quantal (Column J): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEwwZ… ARM DS-5 backs to work, only "Device Tree" feature is unavailable, all others work well. Power Management test also passed on this image. 4. TI Panda 4460 + Linux Linaro Quantal (Column J): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdEwwZ… Only "Device Tree" test failed, all others work well. 5. ST Ericsson Snowball + Linux Linaro Quantal (Column J): https://docs.google.com/a/linaro.org/spreadsheet/ccc?key=0AroPySpr4FnEdFJ4X… "Halt" works, but many other features are unavailable, for example: HDMI, reboot, Ethernet, Device Tree and Power Management. For the previous week test summary (Linaro 13.01 Release), please refer to attachment. Thank you. Best Regards Botao Sun

12 years, 12 months

[PATCH] cpufreq: exynos: simplify .init() for setting policy->cpus

by Viresh Kumar

With the recent changes in cpufreq core, we just need to set mask of all possible cpus into policy->cpus. Rest would be done by core. Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/exynos-cpufreq.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c index 7012ea8..81eb84a 100644 --- a/drivers/cpufreq/exynos-cpufreq.c +++ b/drivers/cpufreq/exynos-cpufreq.c @@ -227,19 +227,7 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) /* set the transition latency value */ policy->cpuinfo.transition_latency = 100000; - /* - * EXYNOS4 multi-core processors has 2 cores - * that the frequency cannot be set independently. - * Each cpu is bound to the same speed. - * So the affected cpu is all of the cpus. - */ - if (num_online_cpus() == 1) { - cpumask_copy(policy->related_cpus, cpu_possible_mask); - cpumask_copy(policy->cpus, cpu_online_mask); - } else { - policy->shared_type = CPUFREQ_SHARED_TYPE_ANY; - cpumask_setall(policy->cpus); - } + cpumask_setall(policy->cpus); return cpufreq_frequency_table_cpuinfo(policy, exynos_info->freq_table); } -- 1.7.12.rc2.18.g61b472e

13 years

Agenda posted for Android Platform/Mobile Development Meeting

by Zach Pfeffer

We playing around with a new meeting format. We may split this meeting into 2, 30 min calls depending on how things go. Agenda: == Concall details == * https://wiki.linaro.org/Resources/ZipConferenceLine * Code: 6893745032 * Please try not to use the toll-free numbers if you can help it == Agenda == * Common * Discuss new meeting format, concall * Issues for ABS? * Platform * Connect topics * AOSP upstreaming, Arndale * Android Validation and Infrastructure * galaxynexus-aosp? * Ideas for making linux-linaro better * Vishal to send more agenda items * Mobile Development * Android optimization * big.LITTLE * Memory Hotplug * Android kernel feature upstreaminging * General Discussion * AOB Feel free to add more topics here or in https://wiki.linaro.org/Platform/Android/Meetings/2013-02-06. -- Zach Pfeffer Android Platform Team Lead, Linaro Platform Teams Linaro.org | Open source software for ARM SoCs Follow Linaro: http://www.facebook.com/pages/Linaro http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog

13 years

[PATCH 3/3] pm-qa: shced_mc: remove the obsolete sched_mc test

by Hongbo Zhang

The sched_mc test is obsolete now and should be removed, if you still want to use this test for some reason, use tag pm-qa-0.4.0 or earlier. Signed-off-by: Hongbo Zhang <hongbo.zhang(a)linaro.org> --- Makefile | 2 -- sched_mc/Android.mk | 18 ------------ sched_mc/Makefile | 25 ----------------- sched_mc/sched_01.sh | 32 ---------------------- sched_mc/sched_01.txt | 1 - sched_mc/sched_02.sh | 38 ------------------------- sched_mc/sched_02.txt | 1 - sched_mc/sched_03.sh | 33 ---------------------- sched_mc/sched_03.txt | 1 - sched_mc/sched_04.sh | 70 ----------------------------------------------- sched_mc/sched_04.txt | 1 - sched_mc/sched_sanity.sh | 35 ------------------------ sched_mc/sched_sanity.txt | 1 - 13 files changed, 258 deletions(-) delete mode 100644 sched_mc/Android.mk delete mode 100644 sched_mc/Makefile delete mode 100755 sched_mc/sched_01.sh delete mode 100644 sched_mc/sched_01.txt delete mode 100755 sched_mc/sched_02.sh delete mode 100644 sched_mc/sched_02.txt delete mode 100755 sched_mc/sched_03.sh delete mode 100644 sched_mc/sched_03.txt delete mode 100755 sched_mc/sched_04.sh delete mode 100644 sched_mc/sched_04.txt delete mode 100755 sched_mc/sched_sanity.sh delete mode 100644 sched_mc/sched_sanity.txt diff --git a/Makefile b/Makefile index fa979e0..52aa60d 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,6 @@ check: @(cd cpufreq; $(MAKE) check) @(cd cpuhotplug; $(MAKE) check) @(cd cpuidle; $(MAKE) check) - @(cd sched_mc; $(MAKE) check) # @(cd suspend; $(MAKE) check) @(cd thermal; $(MAKE) check) # @(cd powertop; $(MAKE) check) @@ -39,7 +38,6 @@ uncheck: @(cd cpufreq; $(MAKE) uncheck) @(cd cpuhotplug; $(MAKE) uncheck) @(cd cpuidle; $(MAKE) uncheck) - @(cd sched_mc; $(MAKE) uncheck) # @(cd suspend; $(MAKE) uncheck) @(cd thermal; $(MAKE) uncheck) diff --git a/sched_mc/Android.mk b/sched_mc/Android.mk deleted file mode 100644 index f9f9d90..0000000 --- a/sched_mc/Android.mk +++ /dev/null @@ -1,18 +0,0 @@ -include $(call all-subdir-makefiles) -LOCAL_PATH:= $(call my-dir) - -module_name = sched - -define $(module_name)_add_executable - include $(CLEAR_VARS) - LOCAL_MODULE_TAGS := optional - LOCAL_MODULE_CLASS := tests - LOCAL_MODULE := $1.sh - systemtarball: $1.sh - LOCAL_SRC_FILES := $1.sh - LOCAL_MODULE_PATH := $(TARGET_OUT_OPTIONAL_EXECUTABLES)/pm-qa/$(module_name)_mc - include $(BUILD_PREBUILT) -endef - -test_num := 01 02 03 04 -$(foreach item,$(test_num),$(eval $(call $(module_name)_add_executable, $(module_name)_$(item)))) diff --git a/sched_mc/Makefile b/sched_mc/Makefile deleted file mode 100644 index a90620c..0000000 --- a/sched_mc/Makefile +++ /dev/null @@ -1,25 +0,0 @@ -# -# PM-QA validation test suite for the power management on Linux -# -# Copyright (C) 2011, Linaro Limited. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# Contributors: -# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) -# - initial API and implementation -# - -include ../Test.mk \ No newline at end of file diff --git a/sched_mc/sched_01.sh b/sched_mc/sched_01.sh deleted file mode 100755 index d4414b6..0000000 --- a/sched_mc/sched_01.sh +++ /dev/null @@ -1,32 +0,0 @@ -#!/bin/bash -# -# PM-QA validation test suite for the power management on Linux -# -# Copyright (C) 2011, Linaro Limited. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# Contributors: -# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) -# - initial API and implementation -# - -# URL : https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/QA/Scripts#sched_… - -source ../include/functions.sh - -FILES="sched_mc_power_savings" - -check_sched_mc_files $FILES diff --git a/sched_mc/sched_01.txt b/sched_mc/sched_01.txt deleted file mode 100644 index 6783a3a..0000000 --- a/sched_mc/sched_01.txt +++ /dev/null @@ -1 +0,0 @@ -test the presence of the 'sched_mc_power_savings' file diff --git a/sched_mc/sched_02.sh b/sched_mc/sched_02.sh deleted file mode 100755 index c7cbc26..0000000 --- a/sched_mc/sched_02.sh +++ /dev/null @@ -1,38 +0,0 @@ -#!/bin/bash -# -# PM-QA validation test suite for the power management on Linux -# -# Copyright (C) 2011, Linaro Limited. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# Contributors: -# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) -# - initial API and implementation -# - -# URL : https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/QA/Scripts#sched_… - -source ../include/functions.sh - -check_physical_package_id() { - - local package_id=$CPU_PATH/$1/topology/physical_package_id - local val=$(cat $package_id) - - check "topology is enabled" "test \"$val\" != \"-1\"" -} - -for_each_cpu check_physical_package_id || exit 1 diff --git a/sched_mc/sched_02.txt b/sched_mc/sched_02.txt deleted file mode 100644 index 5493610..0000000 --- a/sched_mc/sched_02.txt +++ /dev/null @@ -1 +0,0 @@ -test the topology is implemented in the kernel diff --git a/sched_mc/sched_03.sh b/sched_mc/sched_03.sh deleted file mode 100755 index 6520ce5..0000000 --- a/sched_mc/sched_03.sh +++ /dev/null @@ -1,33 +0,0 @@ -#!/bin/bash -# -# PM-QA validation test suite for the power management on Linux -# -# Copyright (C) 2011, Linaro Limited. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# Contributors: -# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) -# - initial API and implementation -# - -# URL : https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/QA/Scripts#sched_… - -source ../include/functions.sh - -FILES="core_id core_siblings core_siblings_list physical_package_id \ -thread_siblings thread_siblings_list" - -for_each_cpu check_topology_files $FILES diff --git a/sched_mc/sched_03.txt b/sched_mc/sched_03.txt deleted file mode 100644 index b9e8d6f..0000000 --- a/sched_mc/sched_03.txt +++ /dev/null @@ -1 +0,0 @@ -test the topology files are present diff --git a/sched_mc/sched_04.sh b/sched_mc/sched_04.sh deleted file mode 100755 index f9266e8..0000000 --- a/sched_mc/sched_04.sh +++ /dev/null @@ -1,70 +0,0 @@ -#!/bin/bash -# -# PM-QA validation test suite for the power management on Linux -# -# Copyright (C) 2011, Linaro Limited. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# Contributors: -# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) -# - initial API and implementation -# - -# URL : https://wiki.linaro.org/WorkingGroups/PowerManagement/Doc/QA/Scripts#sched_… - -source ../include/functions.sh - -check_change() { - local val=$1 - local path=$2 - - echo $val > $path -} - -check_invalid_change() { - - local val=$1 - local path=$2 - - echo $val > $path - if [ "$?" != "0" ]; then - return 0 - fi - - return 1 -} - -check_sched_mc_change() { - - local path=$CPU_PATH/sched_mc_power_savings - local oldval=$(cat $path) - - check "setting value to 0" check_change 0 $path - check "setting value to 1" check_change 1 $path - check "setting value to 2" check_change 2 $path - check "setting invalid value to 3" check_invalid_change 3 $path - check "setting invalid value to -1" check_invalid_change -1 $path - - echo $oldval > $path -} - -if [ $(id -u) != 0 ]; then - log_skip "run as non-root" - exit 0 -fi - -# check_sched_mc_files sched_mc_power_savings || exit 1 -check_sched_mc_change diff --git a/sched_mc/sched_04.txt b/sched_mc/sched_04.txt deleted file mode 100644 index 7f5ed4a..0000000 --- a/sched_mc/sched_04.txt +++ /dev/null @@ -1 +0,0 @@ -test the change are effective for the 'sched_mc_power_savings' file diff --git a/sched_mc/sched_sanity.sh b/sched_mc/sched_sanity.sh deleted file mode 100755 index 1b1b58b..0000000 --- a/sched_mc/sched_sanity.sh +++ /dev/null @@ -1,35 +0,0 @@ -#!/bin/bash -# -# PM-QA validation test suite for the power management on Linux -# -# Copyright (C) 2011, Linaro Limited. -# -# This program is free software; you can redistribute it and/or -# modify it under the terms of the GNU General Public License -# as published by the Free Software Foundation; either version 2 -# of the License, or (at your option) any later version. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# You should have received a copy of the GNU General Public License -# along with this program; if not, write to the Free Software -# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. -# -# Contributors: -# Daniel Lezcano <daniel.lezcano(a)linaro.org> (IBM Corporation) -# - initial API and implementation -# - -source ../include/functions.sh - -check_sched_mc_sysfs_entry() { - - local filepath=$CPU_PATH/sched_mc_power_savings - - test -f $filepath && return 1 || return 0 -} - -check_sched_mc_sysfs_entry diff --git a/sched_mc/sched_sanity.txt b/sched_mc/sched_sanity.txt deleted file mode 100644 index c79c23e..0000000 --- a/sched_mc/sched_sanity.txt +++ /dev/null @@ -1 +0,0 @@ -sched_mc is not enabled. Skipping all sched_mc tests... -- 1.8.0

13 years

[PATCH 1/3] pm-qa: collecting seperated test switches into one central file.

by Hongbo Zhang

It is inconvenient for user to edit these seperated switches, so move them into one central file. Signed-off-by: Hongbo Zhang <hongbo.zhang(a)linaro.org> --- Switches | 11 +++++++++++ include/functions.sh | 2 ++ suspend/suspend_01.sh | 5 +---- suspend/suspend_02.sh | 5 +---- suspend/suspend_03.sh | 5 +---- suspend/suspend_04.sh | 5 +---- suspend/suspend_05.sh | 4 +--- thermal/thermal_06.sh | 4 +--- 8 files changed, 19 insertions(+), 22 deletions(-) create mode 100644 Switches diff --git a/Switches b/Switches new file mode 100644 index 0000000..3a46ffe --- /dev/null +++ b/Switches @@ -0,0 +1,11 @@ +# These are switches to enable/disable some tests. + +# Thermal tests +thermal_try_max=0 + +# Suspend tests +suspend_dbus=0 +suspend_pmsuspend=1 +suspend_mem=1 +suspend_ac=0 +suspend_power=0 diff --git a/include/functions.sh b/include/functions.sh index c39b6b7..7ee809b 100644 --- a/include/functions.sh +++ b/include/functions.sh @@ -23,6 +23,8 @@ # - initial API and implementation # +source ../Switches + CPU_PATH="/sys/devices/system/cpu" TEST_NAME=$(basename ${0%.sh}) PREFIX=$TEST_NAME diff --git a/suspend/suspend_01.sh b/suspend/suspend_01.sh index d67a66b..e591dc9 100755 --- a/suspend/suspend_01.sh +++ b/suspend/suspend_01.sh @@ -29,10 +29,7 @@ source ../include/functions.sh source ../include/suspend_functions.sh -# test_dbus: switch on/off this test -test_dbus=1 - -if [ "$test_dbus" -eq 0 ]; then +if [ "$suspend_dbus" -eq 0 ]; then log_skip "dbus message suspend test not enabled" exit 0 fi diff --git a/suspend/suspend_02.sh b/suspend/suspend_02.sh index 7e33624..5e41d08 100755 --- a/suspend/suspend_02.sh +++ b/suspend/suspend_02.sh @@ -29,10 +29,7 @@ source ../include/functions.sh source ../include/suspend_functions.sh -# test_pmsuspend: switch on/off this test -test_pmsuspend=1 - -if [ "$test_pmsuspend" -eq 0 ]; then +if [ "$suspend_pmsuspend" -eq 0 ]; then log_skip "pm-suspend test not enabled" exit 0 fi diff --git a/suspend/suspend_03.sh b/suspend/suspend_03.sh index 64f2fa1..b71966c 100755 --- a/suspend/suspend_03.sh +++ b/suspend/suspend_03.sh @@ -29,10 +29,7 @@ source ../include/functions.sh source ../include/suspend_functions.sh -# test_mem: switch on/off this test -test_mem=1 - -if [ "$test_mem" -eq 0 ]; then +if [ "$suspend_mem" -eq 0 ]; then log_skip "suspend to ram via sysfs not enabled" exit 0 fi diff --git a/suspend/suspend_04.sh b/suspend/suspend_04.sh index 9f85400..8947afd 100755 --- a/suspend/suspend_04.sh +++ b/suspend/suspend_04.sh @@ -29,10 +29,7 @@ source ../include/functions.sh source ../include/suspend_functions.sh -# test_ac: switch on/off this test -test_ac=0 - -if [ "$test_ac" -eq 0 ]; then +if [ "$suspend_ac" -eq 0 ]; then log_skip "suspend test involving ac power remove" exit 0 fi diff --git a/suspend/suspend_05.sh b/suspend/suspend_05.sh index 8604331..a87490c 100755 --- a/suspend/suspend_05.sh +++ b/suspend/suspend_05.sh @@ -29,11 +29,9 @@ source ../include/functions.sh source ../include/suspend_functions.sh -# test_power: switch on/off this test -test_power=0 args_power_sleep=60 -if [ "$test_power" -eq 0 ]; then +if [ "$suspend_power" -eq 0 ]; then log_skip "battery consumption test while suspend" exit 0 fi diff --git a/thermal/thermal_06.sh b/thermal/thermal_06.sh index 28fdaec..0084281 100755 --- a/thermal/thermal_06.sh +++ b/thermal/thermal_06.sh @@ -28,9 +28,7 @@ source ../include/functions.sh source ../include/thermal_functions.sh -# test_switch: switch on/off this test -test_switch=0 -if [ "$test_switch" -eq 0 ]; then +if [ "$thermal_try_max" -eq 0 ]; then log_skip "test of trip points being crossed" exit 0 fi -- 1.8.0

13 years

Re: [PATCH 0/2] cpufreq: cpufreq_driver_lock is hot on large systems

by Viresh Kumar

On Tue, Feb 5, 2013 at 6:37 AM, Rafael J. Wysocki <rjw(a)sisk.pl> wrote: > On Monday, February 04, 2013 04:45:11 PM Nathan Zimmer wrote: >> I am noticing the cpufreq_driver_lock is quite hot. >> On an idle 512 system perf shows me most of the system time is spent on this >> lock. This is quite signifigant as top shows 5% of time in system time. >> My solution was to first convert the lock to a rwlock and then to the rcu. >> >> >> Nathan Zimmer (2): >> cpufreq: Convert the cpufreq_driver_lock to a rwlock >> cpufreq: Convert the cpufreq_driver_lock to use the rcu >> >> drivers/cpufreq/cpufreq.c | 139 ++++++++++++++++++++++++++-------------------- >> 1 file changed, 79 insertions(+), 60 deletions(-) > > I like these changes. > > Viresh, anyone, any comments? Hi Nathan/Rafael, Even i liked the basic idea behind the patchset, but didn't like the way it is divided into patches. For me, it is highly discouraged to undo something that you added in the same patchset. And you did exactly the same thing. Patch 2 is revert of 1 + rcu stuff. So, i would expect a single patch, i.e. merge of both patches + rebased on latest stuff. -- viresh

13 years

big.LITTLE MP status Feb 5, 2013

by David Zinman

13 years

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

linaro-dev February 2013