On Sun, May 10, 2026 at 08:41:43PM +0200, Alexander A. Klimov wrote:
manager_sysfs_add_store() passes 6 pointers to sscanf(), but required latter to return 7 which always failed the operation. I corrected it to 6.
Signed-off-by: Alexander A. Klimov grandmaster@al2klimov.de
This needs a Fixes tag.
Fixes: 49b9137a6002 ("staging: greybus: audio: remove redundant slot field")
You need to add Pankaj Bharadiya pankaj.bharadiya@gmail.com to the CC list. Although that patch is from 10 years ago so it means no one is using this.
regards, dan carpenter
manager_sysfs_add_store() passes 6 pointers to sscanf(), but required latter to return 7 which always failed the operation. I corrected it to 6.
Fixes: 49b9137a6002 ("staging: greybus: audio: remove redundant slot field") Signed-off-by: Alexander A. Klimov grandmaster@al2klimov.de --- v2: added "Fixes:" to commit message v3: added all these v2/v3 lines here as requested by Greg KH v3: while on it, replaced title "Greybus audio protocols drivers:" ... v3: ... with "staging: greybus: audio:"
drivers/staging/greybus/audio_manager_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c index fcd518f954..ff323ca815 100644 --- a/drivers/staging/greybus/audio_manager_sysfs.c +++ b/drivers/staging/greybus/audio_manager_sysfs.c @@ -23,7 +23,7 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj, desc.name, &desc.vid, &desc.pid, &desc.intf_id, &desc.ip_devices, &desc.op_devices);
- if (num != 7) + if (num != 6) return -EINVAL;
num = gb_audio_manager_add(&desc);
On 5/12/26 2:15 PM, Alexander A. Klimov wrote:
manager_sysfs_add_store() passes 6 pointers to sscanf(), but required latter to return 7 which always failed the operation. I corrected it to 6.
Fixes: 49b9137a6002 ("staging: greybus: audio: remove redundant slot field") Signed-off-by: Alexander A. Klimov grandmaster@al2klimov.de
Looks good.
Reviewed-by: Alex Elder elder@riscstar.com
v2: added "Fixes:" to commit message v3: added all these v2/v3 lines here as requested by Greg KH v3: while on it, replaced title "Greybus audio protocols drivers:" ... v3: ... with "staging: greybus: audio:"
drivers/staging/greybus/audio_manager_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/ staging/greybus/audio_manager_sysfs.c index fcd518f954..ff323ca815 100644 --- a/drivers/staging/greybus/audio_manager_sysfs.c +++ b/drivers/staging/greybus/audio_manager_sysfs.c @@ -23,7 +23,7 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj, desc.name, &desc.vid, &desc.pid, &desc.intf_id, &desc.ip_devices, &desc.op_devices);
- if (num != 7) + if (num != 6) return -EINVAL;
num = gb_audio_manager_add(&desc);
On Tue, May 12, 2026 at 09:15:54PM +0200, Alexander A. Klimov wrote:
manager_sysfs_add_store() passes 6 pointers to sscanf(), but required latter to return 7 which always failed the operation. I corrected it to 6.
Fixes: 49b9137a6002 ("staging: greybus: audio: remove redundant slot field") Signed-off-by: Alexander A. Klimov grandmaster@al2klimov.de
v2: added "Fixes:" to commit message v3: added all these v2/v3 lines here as requested by Greg KH v3: while on it, replaced title "Greybus audio protocols drivers:" ... v3: ... with "staging: greybus: audio:"
drivers/staging/greybus/audio_manager_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/staging/greybus/audio_manager_sysfs.c index fcd518f954..ff323ca815 100644 --- a/drivers/staging/greybus/audio_manager_sysfs.c +++ b/drivers/staging/greybus/audio_manager_sysfs.c @@ -23,7 +23,7 @@ static ssize_t manager_sysfs_add_store(struct kobject *kobj, desc.name, &desc.vid, &desc.pid, &desc.intf_id, &desc.ip_devices, &desc.op_devices);
- if (num != 7)
if (num != 6) return -EINVAL;
num = gb_audio_manager_add(&desc);
-- 2.54.0
Does not apply to my tree :(
-
Alex Elder -
Alexander A. Klimov -
Greg Kroah-Hartman