On Thu, Feb 26, 2026 at 12:08:35AM +0530, Shubham Chakraborty wrote:
Fix checkpatch.pl warnings by adding comments to mutex and spinlocks, and fixing alignment to match open parenthesis.
Signed-off-by: Shubham Chakraborty chakrabortyshubham66@gmail.com
drivers/staging/greybus/uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..1d2c4ef70865 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected;
- spinlock_t read_lock;
- spinlock_t write_lock;
- spinlock_t read_lock; /* protects read operations */
This is really vague, but I wouldn't say it was accurate.
- spinlock_t write_lock; /* protects write operations */
Also really vague. What does "operations" mean in this context? But word "write" is correct at least.
struct async_icount iocount; struct async_icount oldcount; wait_queue_head_t wioctl;
- struct mutex mutex;
- struct mutex mutex; /* serializes port operations */
This comment is doesn't really add any value.
regards, dan carpenter