On Thu, Mar 12, 2026 at 12:11:04AM +0530, Rahul Joshi wrote:
The spinlock_t and struct mutex members in struct gb_tty lack comments describing what they protect, which is required by the kernel coding style.
Also fix the alignment of the wait_for_completion_timeout() call in gb_uart_wait_for_all_credits() to match the open parenthesis.
Signed-off-by: Rahul Joshi rj5547884@gmail.com
drivers/staging/greybus/uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..52a84a68049c 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected;
- spinlock_t read_lock;
- spinlock_t write_lock;
- spinlock_t read_lock; /* protects iocount and oldcount */
- spinlock_t write_lock; /* protects write_fifo and credits */
https://lore.kernel.org/all/aaFdxqxEUzZFVIqQ@stanley.mountain/
How on earth could you have come up with the exact same words here that someone else did? It feels like too large of a coincidence.
regards, dan carpenter