On Tue, Feb 03, 2026 at 04:22:54PM -0500, Neel Bullywon wrote:
Replaced sprintf() with sysfs_emit in the protocol_id_show() sysfs attribute func to prevent any potential buffer overflows
There are no buffer overflows here. buf is PAGE_SIZE so it's more than large enough. I like this change, but the commit message implies there is a potential buffer overflow and that's wrong.
Say something like: "This code is safe, but replace sprintf() with sysfs_emit() because we are trying to get rid of calls to sprintf() as part of kernel hardenning and sysfs_emit() is more appropriate in this context".
This is to ensure a kernel-wide migration to safer string formatting functions for sysfs handlers
This was compile-tested only (no VM/hardware used)
Don't put this sort of comment in the commit message. Put it under the --- cut off line.
Signed-off-by: Neel Bullywon neelb2403@gmail.com
^^^ Here.
regards, dan carpenter