[greybus-dev] Re: [PATCH 08/14] greybus: cpc: add and validate sequence numbers

On Fri Dec 12, 2025 at 11:13 AM EST, Damien Riégel wrote:

+void cpc_protocol_on_data(struct cpc_cport *cport, struct sk_buff *skb) +{

• [...]
• expected_seq = seq == cport->tcb.ack;
• if (expected_seq)

• cport->tcb.ack++;
  

• else

• dev_warn(cpc_hd_dev(cport->cpc_hd), "unexpected seq: %u, expected seq: %u\n", seq,
  

• 	 cport->tcb.ack);
  

• [...]

+}

This warning can occur somewhat often due to retransmissions. Perhaps we should change it to an `dev_info`.

Thanks,