Replaced sprintf() with sysfs_emit() in the protocol_id_show() sysfs attribute function. This code is safe, as replacing sprintf() with sysfs_emit() gets rid of calls to sprintf() as part of kernel hardening and sysfs_emit() is more appropriate in this context.
Signed-off-by: Neel Bullywon neelb2403@gmail.com --- This was compile-tested only (no VM/hardware used) --- drivers/staging/greybus/gbphy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/gbphy.c b/drivers/staging/greybus/gbphy.c index 60cf09a302a7..55f132b09cee 100644 --- a/drivers/staging/greybus/gbphy.c +++ b/drivers/staging/greybus/gbphy.c @@ -31,7 +31,7 @@ static ssize_t protocol_id_show(struct device *dev, { struct gbphy_device *gbphy_dev = to_gbphy_dev(dev);
- return sprintf(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); + return sysfs_emit(buf, "0x%02x\n", gbphy_dev->cport_desc->protocol_id); } static DEVICE_ATTR_RO(protocol_id);