[greybus-dev] Re: [PATCH] staging: greybus: uart: migrated from IDR to XArray API

On Tue, Feb 03, 2026 at 11:38:02PM -0500, Neel Bullywon wrote:

Replaced the IDR API with the XArray API for managing TTY minor numbers. This addresses the checkpatch warning about DEFINE_IDR being deprecated.

While I understand that some people might feel that xarrays are the bees-knees, for something "simple" like an idr, it's overkill, right?

This is "just" a unique integer that is used for a device name, leaving it as an idr should be just fine as there is no performance or storage issues with it as-is.

So while I'm all for using new apis for new code, unless all usages of idr is going to be replaced in the kernel with xarray, I don't really feel that this is needed to be done here, sorry.

thanks,

greg k-h