On Mon, Feb 02, 2026 at 03:32:42PM +0200, Eitan Collett wrote:
Adhere to Linux kernel coding style.
Reported by checkpatch:
CHECK: Unnecessary parentheses around 'w->id != snd_soc_dapm_aif_in' CHECK: Unnecessary parentheses around 'w->id != snd_soc_dapm_aif_out'
Signed-off-by: Eitan Collett eitan.collett@gmail.com
drivers/staging/greybus/audio_codec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/audio_codec.c b/drivers/staging/greybus/audio_codec.c index 444c53b4e08d..44aee8268d14 100644 --- a/drivers/staging/greybus/audio_codec.c +++ b/drivers/staging/greybus/audio_codec.c @@ -305,7 +305,7 @@ int gbaudio_module_update(struct gbaudio_codec_info *codec, dev_dbg(module->dev, "%s:Module update %s sequence\n", w->name, enable ? "Enable" : "Disable");
- if ((w->id != snd_soc_dapm_aif_in) && (w->id != snd_soc_dapm_aif_out)) {
- if (w->id != snd_soc_dapm_aif_in && w->id != snd_soc_dapm_aif_out) {
I hate this checkpatch "warning" sorry. Now you need to go and try to remember if && is higher priority than !=, right?
Please just leave this as-is.
thanks,
greg k-h