This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, master has been updated
via d2562fb0cb2c2b21b628b265ef24a6c8cbac9608 (commit)
from f4386378e466a519d8f97923ba43ea22dec1e933 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d2562fb0cb2c2b21b628b265ef24a6c8cbac9608
Author: Maxim Uvarov <maxim.uvarov(a)linaro.org>
Date: Tue May 16 16:09:27 2017 +0300
travis: move code style check to separate job
Move this check to separate job to better see which exactly
task was failed.
Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org>
Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org>
diff --git a/.travis.yml b/.travis.yml
index aa7ea010..e792af06 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -51,12 +51,28 @@ matrix:
- llvm-toolchain-precise-3.8
packages:
- clang-3.8
+ - compiler: gcc
+ addons:
+ apt:
+ sources:
+ - ubuntu-toolchain-r-test
+ packages:
+ - gcc
+ env: TEST="CHECKPATCH"
before_install:
- echo 1000 | sudo tee /proc/sys/vm/nr_hugepages
- sudo mkdir -p /mnt/huge
- sudo mount -t hugetlbfs nodev /mnt/huge
+ - if [ "$TEST" = "CHECKPATCH" ]; then
+ echo ${TRAVIS_COMMIT_RANGE};
+ ODP_PATCHES=`echo ${TRAVIS_COMMIT_RANGE} | sed 's/\.//'`;
+ if [ -z "${ODP_PATCHES}" ]; then env; exit 1; fi;
+ ./scripts/ci-checkpatches.sh ${ODP_PATCHES};
+ exit $?;
+ fi
+
- sudo apt-get -qq update
- sudo apt-get install automake autoconf libtool libssl-dev graphviz mscgen doxygen
- sudo apt-get install libpcap-dev linux-headers-`uname -r`
@@ -101,21 +117,6 @@ before_install:
- popd
script:
- - echo $TRAVIS_COMMIT_RANGE
- - ODP_PACHES=`echo $TRAVIS_COMMIT_RANGE | sed 's/\.//'`
-# Generate patches provided with $TRAVIS_COMMIT_RANGE.
-# In case of force push and range is broken validate only the latest commit if it's not merge commit.
- - git format-patch $ODP_PACHES;
- if [ $? -ne 0 ]; then
- git show --summary HEAD| grep -q '^Merge:';
- if [ $? -ne 0 ]; then
- git format-patch HEAD^;
- perl ./scripts/checkpatch.pl *.patch;
- fi;
- else
- perl ./scripts/checkpatch.pl *.patch;
- fi
-
- ./bootstrap
- ./configure
# doxygen does not trap on warnings, check for them here.
diff --git a/scripts/ci-checkpatches.sh b/scripts/ci-checkpatches.sh
new file mode 100755
index 00000000..cb1c4e65
--- /dev/null
+++ b/scripts/ci-checkpatches.sh
@@ -0,0 +1,17 @@
+#!/bin/bash
+
+PATCHES=$1
+echo "Run checkpatch for ${PATCHES}"
+# Generate patches provided with $1.
+# In case of force push and range is broken
+# validate only the latest commit if it's not merge commit.
+git format-patch ${PATCHES}
+if [ $? -ne 0 ]; then
+ git show --summary HEAD| grep -q '^Merge:';
+ if [ $? -ne 0 ]; then
+ git format-patch HEAD^;
+ perl ./scripts/checkpatch.pl *.patch;
+ fi;
+else
+ perl ./scripts/checkpatch.pl *.patch;
+fi
-----------------------------------------------------------------------
Summary of changes:
.travis.yml | 31 ++++++++++++++++---------------
scripts/ci-checkpatches.sh | 17 +++++++++++++++++
2 files changed, 33 insertions(+), 15 deletions(-)
create mode 100755 scripts/ci-checkpatches.sh
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, master has been updated
via f4386378e466a519d8f97923ba43ea22dec1e933 (commit)
from 3ca26420f0e06fdb1b2cb9192461dbc32a421de5 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit f4386378e466a519d8f97923ba43ea22dec1e933
Author: Bill Fischofer <bill.fischofer(a)linaro.org>
Date: Thu May 4 14:33:14 2017 -0500
scripts: checkpatch: update to allow additional exceptions
Update checkpatch.pl to avoid issuing warnings for use of externs,
volatile, or camelCase.
Signed-off-by: Bill Fischofer <bill.fischofer(a)linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org>
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 16316b92..1c27ac60 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -4273,7 +4273,7 @@ sub process {
$camelcase_file_seeded = 1;
}
}
- if (!defined $camelcase{$word}) {
+ if (!defined $camelcase{$word} && 0) {
$camelcase{$word} = 1;
CHK("CAMELCASE",
"Avoid CamelCase: <$word>\n" . $herecurr);
@@ -4620,7 +4620,7 @@ sub process {
# no volatiles please
my $asm_volatile = qr{\b(__asm__|asm)\s+(__volatile__|volatile)\b};
- if ($line =~ /\bvolatile\b/ && $line !~ /$asm_volatile/) {
+ if ($line =~ /\bvolatile\b/ && 0 && $line !~ /$asm_volatile/) {
WARN("VOLATILE",
"Use of volatile is usually wrong: see Documentation/volatile-considered-harmful.txt\n" . $herecurr);
}
@@ -5134,7 +5134,7 @@ sub process {
if (defined $cond) {
substr($s, 0, length($cond), '');
}
- if ($s =~ /^\s*;/ &&
+ if ($s =~ /^\s*;/ && 0 &&
$function_name ne 'uninitialized_var')
{
WARN("AVOID_EXTERNS",
-----------------------------------------------------------------------
Summary of changes:
scripts/checkpatch.pl | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, master has been updated
via b50cf14202528e986ae9a41721fae1e746078646 (commit)
from 3a8ba69bff8052cbe35dcca71ebda9b669dbf807 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b50cf14202528e986ae9a41721fae1e746078646
Author: Maxim Uvarov <maxim.uvarov(a)linaro.org>
Date: Thu May 11 01:14:29 2017 +0300
codecov: enable threshold for patches
thresholds for individual patches and for project
set in different places. Also drop status for not
visible diff changes. Test only patch and project.
https://github.com/codecov/support/wiki/Codecov-Yaml
Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org>
Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org>
diff --git a/.codecov.yml b/.codecov.yml
index 36270d61..327f6549 100644
--- a/.codecov.yml
+++ b/.codecov.yml
@@ -8,10 +8,16 @@ coverage:
range: "50...75"
status:
project:
- target: 70%
- threshold: 5%
- patch: yes
- changes: yes
+ default:
+ enabled: yes
+ target: 70%
+ threshold: 5%
+ patch:
+ default:
+ enabled: yes
+ target: 70%
+ threshold: 5%
+ changes: no
parsers:
gcov:
-----------------------------------------------------------------------
Summary of changes:
.codecov.yml | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, cloud-dev has been created
at f4c213cccc49b4b28557506ad19fba49b872d24f (commit)
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, api-next has been updated
via f4c213cccc49b4b28557506ad19fba49b872d24f (commit)
via 3a8ba69bff8052cbe35dcca71ebda9b669dbf807 (commit)
via 160f71a48b5891b49a84cc849f08c1ff99d26b3f (commit)
via 8b9783b7f5667b3a37f039222e06448af2eec070 (commit)
via 036f1d33b5d186a68748a5465713370b1c602545 (commit)
via 91f92891554b9c335e9f51f8ef574b74a37a11fb (commit)
via 86e5b478325a0f5422fc6edff9db168d44852d2e (commit)
via c1e962548f5082554bb52137765a258b3a29283c (commit)
via bd583923b29e5dddc4d1b9c6d0e0a513edb69496 (commit)
from 900dd9e2d3d2ae751ab2bc4e11dbd48ea7ed7030 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
-----------------------------------------------------------------------
Summary of changes:
.checkpatch.conf | 2 ++
configure.ac | 6 ++++--
helper/hashtable.c | 3 +--
helper/lineartable.c | 3 +--
platform/linux-generic/odp_crypto.c | 3 +++
platform/linux-generic/odp_rwlock.c | 9 +++++++--
platform/linux-generic/odp_schedule.c | 3 ++-
platform/linux-generic/odp_schedule_iquery.c | 2 +-
platform/linux-generic/odp_traffic_mngr.c | 4 ++--
test/common_plat/validation/api/lock/lock.c | 21 +++++++++++++++++++--
10 files changed, 42 insertions(+), 14 deletions(-)
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, master has been updated
via 3a8ba69bff8052cbe35dcca71ebda9b669dbf807 (commit)
from 160f71a48b5891b49a84cc849f08c1ff99d26b3f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3a8ba69bff8052cbe35dcca71ebda9b669dbf807
Author: Yi He <yi.he(a)linaro.org>
Date: Tue May 16 06:00:06 2017 +0300
checkpatch.conf: ignore PREFER_PRINTF, PREFER_SCANF
This is not the kernel, ignore these preferences
Signed-off-by: Yi He <yi.he(a)linaro.org>
Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org>
diff --git a/.checkpatch.conf b/.checkpatch.conf
index 1e7d6638..043551a4 100644
--- a/.checkpatch.conf
+++ b/.checkpatch.conf
@@ -6,5 +6,7 @@
--ignore=DEPRECATED_VARIABLE
--ignore=COMPARISON_TO_NULL
--ignore=BIT_MACRO
+--ignore=PREFER_PRINTF
+--ignore=PREFER_SCANF
--codespell
--codespellfile=/usr/share/codespell/dictionary.txt
-----------------------------------------------------------------------
Summary of changes:
.checkpatch.conf | 2 ++
1 file changed, 2 insertions(+)
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, master has been updated
via 160f71a48b5891b49a84cc849f08c1ff99d26b3f (commit)
from 8b9783b7f5667b3a37f039222e06448af2eec070 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 160f71a48b5891b49a84cc849f08c1ff99d26b3f
Author: Dmitriy Krot <globaxbiz(a)gmail.com>
Date: Fri May 12 03:00:13 2017 +0300
linux-gen: tm: fix wrr/wfq bug when weight=1
Usage of 0x10000 in the inverted weight calculation causes overflow of
uint16_t if weight=1. As a result of this bug, frame len used for virtual
finish time calculation is always zero, despite of packet size, so packets
from input with weight=1 always pass first.
Signed-off-by: Dmitriy Krot <globaxbiz(a)gmail.com>
Reviewed-and-tested-by: Bill Fischofer <bill.fischofer(a)linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org>
diff --git a/platform/linux-generic/odp_traffic_mngr.c b/platform/linux-generic/odp_traffic_mngr.c
index 4e9358b9..a93b3ba9 100644
--- a/platform/linux-generic/odp_traffic_mngr.c
+++ b/platform/linux-generic/odp_traffic_mngr.c
@@ -3238,7 +3238,7 @@ static void tm_sched_params_cvt_to(odp_tm_sched_params_t *odp_sched_params,
if (weight == 0)
inv_weight = 0;
else
- inv_weight = 0x10000 / weight;
+ inv_weight = 0xFFFF / weight;
tm_sched_params->sched_modes[priority] = sched_mode;
tm_sched_params->inverted_weights[priority] = inv_weight;
@@ -3254,7 +3254,7 @@ static void tm_sched_params_cvt_from(tm_sched_params_t *tm_sched_params,
for (priority = 0; priority < ODP_TM_MAX_PRIORITIES; priority++) {
sched_mode = tm_sched_params->sched_modes[priority];
inv_weight = tm_sched_params->inverted_weights[priority];
- weight = 0x10000 / inv_weight;
+ weight = 0xFFFF / inv_weight;
odp_sched_params->sched_modes[priority] = sched_mode;
odp_sched_params->sched_weights[priority] = weight;
-----------------------------------------------------------------------
Summary of changes:
platform/linux-generic/odp_traffic_mngr.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
hooks/post-receive
--
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "".
The branch, master has been updated
via 8b9783b7f5667b3a37f039222e06448af2eec070 (commit)
from 036f1d33b5d186a68748a5465713370b1c602545 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 8b9783b7f5667b3a37f039222e06448af2eec070
Author: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org>
Date: Wed May 10 02:47:11 2017 +0300
linux-generic: crypto: don't leak sessions if creation fails
We should free allocated session in odp_crypto_session_create() error
paths, so that the session is not leaked.
Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov(a)linaro.org>
Reviewed-by: Bill Fischofer <bill.fischofer(a)linaro.org>
Signed-off-by: Maxim Uvarov <maxim.uvarov(a)linaro.org>
diff --git a/platform/linux-generic/odp_crypto.c b/platform/linux-generic/odp_crypto.c
index b432f84a..c5473d95 100644
--- a/platform/linux-generic/odp_crypto.c
+++ b/platform/linux-generic/odp_crypto.c
@@ -678,6 +678,7 @@ odp_crypto_session_create(odp_crypto_session_param_t *param,
if (session->p.iv.data) {
if (session->p.iv.length > MAX_IV_LEN) {
ODP_DBG("Maximum IV length exceeded\n");
+ free_session(session);
return -1;
}
@@ -724,6 +725,7 @@ odp_crypto_session_create(odp_crypto_session_param_t *param,
/* Check result */
if (rc) {
*status = ODP_CRYPTO_SES_CREATE_ERR_INV_CIPHER;
+ free_session(session);
return -1;
}
@@ -763,6 +765,7 @@ odp_crypto_session_create(odp_crypto_session_param_t *param,
/* Check result */
if (rc) {
*status = ODP_CRYPTO_SES_CREATE_ERR_INV_AUTH;
+ free_session(session);
return -1;
}
-----------------------------------------------------------------------
Summary of changes:
platform/linux-generic/odp_crypto.c | 3 +++
1 file changed, 3 insertions(+)
hooks/post-receive
--