CoreSight

coresight@lists.linaro.org

7 participants
2454 discussions

KASAN use-after-free bug and a warning in etm4_cpu_pm_notify() with "arm,coresight-loses-context-with-cpu"

by Sai Prakash Ranjan

Hi, Since adding "arm,coresight-loses-context-with-cpu" property, have been seeing warnings during boot on QCOM SC7180, one is the kasan use-after-free warning in etm4_cpu_pm_notify() and the other warning also in etm4_cpu_pm_notify(). 1) KASAN use-after-free bug in etm4_cpu_pm_notify(): [ 8.574566] coresight etm0: CPU0: ETM v4.2 initialized [ 8.581920] BUG: KASAN: use-after-free in etm4_cpu_pm_notify+0x580/0x2024 [ 8.581925] Read of size 8 at addr ffffff813304f8c8 by task swapper/3/0 [ 8.581927] [ 8.581934] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G S W 5.4.28 #314 [ 8.587775] coresight etm1: CPU1: ETM v4.2 initialized [ 8.594195] Call trace: [ 8.594205] dump_backtrace+0x0/0x188 [ 8.594209] show_stack+0x20/0x2c [ 8.594216] dump_stack+0xdc/0x144 [ 8.594227] print_address_description+0x3c/0x494 [ 8.594232] __kasan_report+0x144/0x168 [ 8.601598] coresight etm2: CPU2: ETM v4.2 initialized [ 8.602563] kasan_report+0x10/0x18 [ 8.602568] check_memory_region+0x1a4/0x1b4 [ 8.602572] __kasan_check_read+0x18/0x24 [ 8.602577] etm4_cpu_pm_notify+0x580/0x2024 [ 8.665945] notifier_call_chain+0x5c/0x90 [ 8.670166] __atomic_notifier_call_chain+0x90/0xf8 [ 8.675182] cpu_pm_notify+0x40/0x6c [ 8.678858] cpu_pm_enter+0x38/0x80 [ 8.682451] psci_enter_idle_state+0x34/0x70 [ 8.686844] cpuidle_enter_state+0xb8/0x20c [ 8.691143] cpuidle_enter+0x38/0x4c [ 8.694820] call_cpuidle+0x3c/0x68 [ 8.698408] do_idle+0x1a0/0x280 [ 8.701729] cpu_startup_entry+0x24/0x28 [ 8.705768] secondary_start_kernel+0x15c/0x170 [ 8.710423] [ 8.711972] Allocated by task 242: [ 8.715473] __kasan_kmalloc+0xf0/0x1ac [ 8.719426] kasan_slab_alloc+0x14/0x1c [ 8.723375] __kmalloc_track_caller+0x23c/0x388 [ 8.728040] devm_kmalloc+0x38/0x94 [ 8.731632] etm4_probe+0x48/0x3c8 [ 8.735140] amba_probe+0xbc/0x158 [ 8.738645] really_probe+0x144/0x408 [ 8.742412] driver_probe_device+0x70/0x140 [ 8.746716] __device_attach_driver+0x9c/0x110 [ 8.751287] bus_for_each_drv+0x90/0xd8 [ 8.755236] __device_attach+0xb4/0x164 [ 8.759188] device_initial_probe+0x20/0x2c [ 8.763490] bus_probe_device+0x34/0x94 [ 8.767436] device_add+0x34c/0x3e0 [ 8.771029] amba_device_try_add+0x68/0x440 [ 8.775332] amba_deferred_retry_func+0x48/0xc8 [ 8.779997] process_one_work+0x344/0x648 [ 8.784127] worker_thread+0x2ac/0x47c [ 8.787987] kthread+0x128/0x138 [ 8.791313] ret_from_fork+0x10/0x18 [ 8.794993] [ 8.796532] Freed by task 242: [ 8.799684] __kasan_slab_free+0x15c/0x22c [ 8.803897] kasan_slab_free+0x10/0x1c [ 8.807761] kfree+0x25c/0x4bc [ 8.810913] release_nodes+0x240/0x2b0 [ 8.814767] devres_release_all+0x3c/0x54 [ 8.818887] really_probe+0x178/0x408 [ 8.822661] driver_probe_device+0x70/0x140 [ 8.826963] __device_attach_driver+0x9c/0x110 [ 8.831539] bus_for_each_drv+0x90/0xd8 [ 8.835487] __device_attach+0xb4/0x164 [ 8.839431] device_initial_probe+0x20/0x2c [ 8.843732] bus_probe_device+0x34/0x94 [ 8.847678] device_add+0x34c/0x3e0 [ 8.851274] amba_device_try_add+0x68/0x440 [ 8.855576] amba_deferred_retry_func+0x48/0xc8 [ 8.860240] process_one_work+0x344/0x648 [ 8.864366] worker_thread+0x2ac/0x47c [ 8.868228] kthread+0x128/0x138 [ 8.871557] ret_from_fork+0x10/0x18 [ 8.875231] [ 8.876782] The buggy address belongs to the object at ffffff813304f800 [ 8.876782] which belongs to the cache kmalloc-1k of size 1024 [ 8.889632] The buggy address is located 200 bytes inside of [ 8.889632] 1024-byte region [ffffff813304f800, ffffff813304fc00) [ 8.901761] The buggy address belongs to the page: [ 8.906695] page:ffffffff04ac1200 refcount:1 mapcount:0 mapping:ffffff8146c03800 index:0x0 compound_mapcount: 0 [ 8.917047] flags: 0x4000000000010200(slab|head) [ 8.921799] raw: 4000000000010200 dead000000000100 dead000000000122 ffffff8146c03800 [ 8.929753] raw: 0000000000000000 0000000000100010 00000001ffffffff 0000000000000000 [ 8.937703] page dumped because: kasan: bad access detected [ 8.943433] [ 8.944974] Memory state around the buggy address: [ 8.949903] ffffff813304f780: fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc fc [ 8.957320] ffffff813304f800: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 8.964742] >ffffff813304f880: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 8.972157] ^ [ 8.977886] ffffff813304f900: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 8.985298] ffffff813304f980: fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb fb [ 8.992713] ================================================================== [ 9.000577] coresight etm3: CPU3: ETM v4.2 initialized [ 9.006385] coresight etm4: CPU4: ETM v4.2 initialized [ 9.012203] coresight etm5: CPU5: ETM v4.2 initialized [ 9.018126] coresight etm6: CPU6: ETM v4.2 initialized [ 9.023906] coresight etm7: CPU7: ETM v4.2 initialized 2) WARN_ON_ONCE(drvdata->cpu != cpu) in etm4_cpu_pm_notify(): 6.219155] WARNING: CPU: 3 PID: 0 at v5.4/drivers/hwtracing/coresight/coresight-etm4x.c:1347 etm4_cpu_pm_notify+0x1708/0x1c24 [ 6.219156] Modules linked in: [ 6.219163] CPU: 3 PID: 0 Comm: swapper/3 Tainted: G S 5.4.35 #1 [ 6.219168] pstate: 20c00089 (nzCv daIf +PAN +UAO) [ 6.219171] pc : etm4_cpu_pm_notify+0x1708/0x1c24 [ 6.219176] lr : notifier_call_chain+0x58/0x90 [ 6.219178] sp : ffffffc010213d80 [ 6.219179] x29: ffffffc010213d90 x28: 0000000000000000 [ 6.219182] x27: ffffffe5b7106138 x26: ffffffe5b7412000 [ 6.219185] x25: ffffffe5b7412148 x24: 0000000000000001 [ 6.219188] x23: 0000000000000000 x22: 6b6b6b6b6b6b6b6b [ 6.219191] x21: 0000000000000002 x20: 0000000000000002 [ 6.219194] x19: ffffff816d8a1080 x18: 0000000000000000 [ 6.219197] x17: 0000000000000000 x16: 0000000000000000 [ 6.219200] x15: 0000000000000000 x14: ffffff8175f164c0 [ 6.219203] x13: ffffff8001d39000 x12: 00000000000000f0 [ 6.219206] x11: 0000000000000020 x10: 00000000ffffffff [ 6.219208] x9 : 0000000070732f69 x8 : 0000000000000003 [ 6.219211] x7 : 000000b2b5593519 x6 : 00000000003033ff [ 6.219214] x5 : 0000000000000000 x4 : 0000000000000700 [ 6.219217] x3 : 00000000ffffffff x2 : 0000000000000000 [ 6.219219] x1 : 0000000000000002 x0 : ffffffe5b74f2a28 [ 6.219223] Call trace: [ 6.219226] etm4_cpu_pm_notify+0x1708/0x1c24 [ 6.219228] notifier_call_chain+0x58/0x90 [ 6.219231] __atomic_notifier_call_chain+0x48/0x68 [ 6.219236] cpu_pm_notify+0x40/0x6c [ 6.219239] cpu_pm_exit+0x1c/0x24 [ 6.219242] psci_enter_idle_state+0x4c/0x70 [ 6.219246] cpuidle_enter_state+0xb8/0x204 [ 6.219249] cpuidle_enter+0x38/0x4c [ 6.219254] do_idle+0x1a4/0x2a8 [ 6.219257] cpu_startup_entry+0x24/0x28 [ 6.219262] secondary_start_kernel+0x148/0x154 [ 6.219264] ---[ end trace 41dac5fc09746c13 ]--- Thanks, Sai -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

5 years, 3 months

货运通知

by SF EXPRESS

5 years, 3 months

😷 Urgent COVID-19: PPE / Masks

by Rod

[DEFAULT_HEADER][ ]( # ) [ ]( # ) [ ]( http://r.ppequipment.online/mk/cl/f/Q7_aXUOX8cgwLqKksVVhwPlIe4bkVss-5V97llk… ) [ ]( # ) Hello, Could you please direct me to your PPE department, we are FDA approved company (FDA number 3016649392) . We can get a lot of PPE very quickly and large quantities as well. For LA stock we have and we can ship same day from Beverly Hills, CA, - KN95 5 Layers Masks (700,000 Masks) - KN95 4 Layers Masks (600,000 Masks) - 3Ply Disposable Masks (1.4 Million Masks) - Nitrile Gloves (1 Million Gloves) - Vinyl Gloves (20,000 Gloves) - Hand Sanitizers (40,000 100ML Bottles) For production, we can also ship ASAP for you: - Isolation Gowns (Production - 50,000 pcs a day) - Contactless Thermometer (10,000 each day) - Disposable Shoe Cover (Production - 50,000 pcs a day) - Disposable Head Cover (Production - 50,000 pcs a day) - Rapid Antibody Test Kits (FOB China) - Swabs (Production - 1M in a week) - Cotton Masks (Production - 100,000 pcs a day) - Custom branded masks (Production - 100,000 pcs a day) We can ship 7 Million masks in 5-7 days. We are FDA approved importer. As we all are very well aware, air space from China is not smooth these days but we are doing very good at pre-booking and getting things well on time as we are speeding production to save time. Please call me directly on 310 596 5555 or 310 800 6438 if you have any questions. Please click below for: [ Website ]( http://r.ppequipment.online/mk/cl/f/ctGnVGDZHPO7kQzXWuybsUX-f6iBHFoLCViD4F7… ) [ Catalog ]( http://r.ppequipment.online/mk/cl/f/oeKcofnjkHQxsSGm-xlkNYwDs5biBwS8JH0i8rK… ) Let me know if you have any questions. Thank you, -- Rod Saif - Director of Marketing The Dioz Group of Companies HQ: 8730 Wilshire Blvd, Penthouse Beverly Hills, CA 90211 Email: info(a)ppekits.us [ ]( # ) [ ]( # ) This email was sent to coresight(a)lists.linaro.org You received this email because you are registered with Alanic International [ Unsubscribe here ]( http://r.ppequipment.online/mk/un/29bDiRpZOmiCdNS-bykTf2FrtvmoD614sOLRE9EFh… ) [ ]( # ) © 2020 Alanic International

5 years, 3 months

Re: Urgent COVID-19: PPE / Masks

by Tony Beig

[DEFAULT_HEADER]Hello, I just wanted to reach out to you about the PPE stock we have in the USA (Los Angeles) right now. KN95 - 5 Layers - 300,000 KN95 - 4 Layers - 600,000 3Ply - 1.2 Million Take all or minimum 400,000 KN95 and 500,000 3Ply: $2.85 for KN95 and $.62 for 3Ply FOB LA. Individual price: KN95 - $2.95 3Ply - $.69 Masks are FDA Approved and very high quality and can be inspected at: Alanic International 8730 Wilshire Blvd, Penthouse Beverly Hills, CA 90211 Please call me on 310 596 5555 or 310 800 6438 or visit www.ppekits.net We can ship today or tomorrow. FDA Approved masks. We are FDA approved importer. Payment and P.O will be made to the company on FDA list. https://www.accessdata.fda.gov/scripts/cdrh/cfdocs/cfRL/rl.cfm?rid=246905 Photo: https://www.dropbox.com/s/26h70sbdip0zy91/FDA%20KN951.png?dl=0 Thanks Tony; [DEFAULT_FOOTER]

5 years, 4 months

OpenCSD library for a Multi-Threaded application

by subhasish Karmakar

Hi, Can I use OpenCSD library in a Multi-Threaded application? I maintain decode tree handle per thread. Code Example:/********* Initialization code *********/ ------------------------------ //dcdtree_handle_ and p_context is maintained per thread dcdtree_handle_ = ocsd_create_dcd_tree(OCSD_TRC_SRC_FRAME_FORMATTED, OCSD_DFRMTR_FRAME_MEM_ALIGN); ret = ocsd_dt_create_decoder(dcdtree_handle_, p_name, OCSD_CREATE_FLG_FULL_DECODER, p_cfg, &CSID); ret = ocsd_dt_attach_packet_callback( dcdtree_handle_, CSID, OCSD_C_API_CB_PKT_MON, (void *)packetMonitorCallBack, p_context); ret = ocsd_dt_set_gen_elem_outfn( dcdtree_handle_, genTraceElemCallBack, p_context); ------------------------------ /********* Packet Processing *********/ ------------------------------ //Each thread uses below function to process incoming CoreSight packet while ((bytes_done < (uint32_t)block_size) && (ret == OCSD_OK)) { if (OCSD_DATA_RESP_IS_CONT(dp_ret)) { dp_ret = ocsd_dt_process_data( dcdtree_handle_, OCSD_OP_DATA, block_index + bytes_done, block_size - bytes_done, ((uint8_t *)p_block) + bytes_done, &bytes_this_time); //Example code from ------------------------------ Kindly respond to my query. Thank you, Subhasish

5 years, 4 months

Urgent COVID-19: PPE / Masks

by Tony FB

[DEFAULT_HEADER]Hello, Could you please direct me to your PPE department, we are FDA approved company (FDA number 3016649392). We can get a lot of PPE very quickly and large quantity as well. For LA stock we have and we can ship same day from Beverly Hills, CA, KN95 5 Layers Masks (500,000 Masks) KN95 4 Layers Masks (600,000 Masks) 3Ply Disposable Masks (1.2 Million Masks) Nitrile Gloves (1.5 Million Gloves) Vinyl Gloves (40,000 Gloves) Hand Sanitizers (30,000 100ML Bottles) For production, we can also ship ASAP for you: Isolation Gowns (Production - 50,000 pcs a day) Contactless Thermometer (10,000 each day) Disposable Shoe Cover (Production - 50,000 pcs a day) Disposable Head Cover (Production - 50,000 pcs a day) Rapid Antibody Test Kits (FOB China) Swabs (Production - 1M in a week) Cotton Masks (Production - 100,000 pcs a day) Custom branded masks (Production - 100,000 pcs a day) We can ship 7 Million masks in 5-7 days. We are FDA approved importer. As we all are very well aware, air space from China is not smooth these days but we are doing very good at pre booking and getting things well on time as we are speeding production to save time. Please click below for: [ Website ]( http://r.ppe-supplier.online/mk/cl/f/wvi3huY_-DiOmAZEB2G5e8H3IhmSUGho1vCDP_… ) [ Catalogue ]( http://r.ppe-supplier.online/mk/cl/f/xLCsTuxlPTOLRl424k8ehdMB1O5iEERY-z5ZYB… ) [ Pricelist ]( http://r.ppe-supplier.online/mk/cl/f/hDhq7oa4siAdginIo3T3zmQM8lkHvg3UmnPJHk… ) Let me know if you have any questions. Thank you, Tony PPE Kits [ Website ]( http://r.ppe-supplier.online/mk/cl/f/yB-LyK7ptKZuRtwHnqVxN49u0WNEi-O0cb3Lbo… )[DEFAULT_FOOTER]

5 years, 4 months

[PATCH] coresight: etm4x: Add support for Neoverse N1 ETM

by Anurag Koul

Add PID for Arm Neoverse N1 ETM to the list of supported/known ETMs. Signed-off-by: Anurag Koul <anurag.koul(a)arm.com> --- drivers/hwtracing/coresight/coresight-etm4x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c index 0b2c7c7efacb..7443a2e4528d 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.c +++ b/drivers/hwtracing/coresight/coresight-etm4x.c @@ -1541,6 +1541,7 @@ static const struct amba_id etm4_ids[] = { CS_AMBA_ID(0x000bb95a), /* Cortex-A72 */ CS_AMBA_ID(0x000bb959), /* Cortex-A73 */ CS_AMBA_UCI_ID(0x000bb9da, uci_id_etm4),/* Cortex-A35 */ + CS_AMBA_UCI_ID(0x000bbd0c, uci_id_etm4),/* Neoverse N1 */ CS_AMBA_UCI_ID(0x000f0205, uci_id_etm4),/* Qualcomm Kryo */ CS_AMBA_UCI_ID(0x000f0211, uci_id_etm4),/* Qualcomm Kryo */ CS_AMBA_UCI_ID(0x000bb802, uci_id_etm4),/* Qualcomm Kryo 385 Cortex-A55 */ -- 2.17.1

5 years, 4 months

😷 COVID-19: Face Mask Stock

by Tony FB

Unable to view? Read it <http://tracking.ppe-kit.site/view?msgid=UGex5pFcqW97wGbQgpJNRQ2> Online Hello, I am following up to see, if you need anything. You can check ppekits.net for more products or also visit www.ppekits.net/supply for our catalogue. We are FDA approved importer and will guarantee your money and product delivery. Also just wanted to give you an idea about shipping, we can ship within few days approx: - 3 Ply (20 Million) - KN95 (2 Million) - Gloves (1M) - Faceshield (500K) - Hand Sanitizer (200K) - Thermometer (100K - Contactless) - Isolated Gowns (500K) and a lot more. We also have lot of stock in Los Angeles for Kn95, 3Ply and Gloves etc. We can send items via express or cargo air freight to get it to you or client ASAP. Please let me know if you would like to get on a call. If you have any questions now. Thanks -- Tony ppekits.net If you no longer wish to receive mail from us, you can <http://tracking.ppe-kit.site/tracking/unsubscribe?msgid=UGex5pFcqW97wGbQgpJ…> unsubscribe PERSONAL PROTECTIVE EQUIPMENT, 8730 Wilshire Blvd,, Los Angeles, CA, 90210, United States, https://www.emergencyessentials.co.uk / https://www.ppekits.net

5 years, 4 months

[RFC PATCH 0/5] Allow CoreSight to specify and select default sink

by Mike Leach

This patchset provides a proposed infrastructure to allow for the automatic selection of a sink during CoreSight tracing operations. Currently starting tracing using perf requires a sink selection on the command line:- sudo ./perf record -e cs_etm/@tmc_etr0/ --per-thread uname -a After this set the infrastructure will be able to select a default sink:- sudo ./perf record -e cs_etm// --per-thread uname -a This matches with the default operation provided with perf and intelpt. The CoreSight infrastructure is updated to allow the concept of a "principal sink". For any given source there could be multiple possible sinks available for selection. However, there are no good programmatic ways to determine the optimal sink for a given topolgy. For any given rule (e.g. first sink found, first ETR, last ETR), there exists a possible platform / topology that will not be suitable. Therefore, we select the principal sink using a property in the device tree. This allows the routine to select the best possible for the situation. The only rule for selecting such sinks, is that there should only be one principal sink marked for any given source, across all possible paths from that source to any sinks. (if this rule is violated then the first found will be used) Therefore to select a sink, we start with the source, and walk the child connections until a sink marked as a principal sink is found. Applied to Linux 5.7-rc1 (with dts updates 1,2), tested on Juno / DB410 Note A: Moving forward to topologies which have groups of sources going to dedicated sinks e.g. multisocket / multicluster where each socket / cluster has a sink, then multiple sinks can be marked as principal sink, one for each cluster. The same applies to 1:1 ETM:sink topolgy were each sink will be marked. Note B: The current set does not auto-select when using sysfs, but I believe this could easily be added. [1] https://lists.linaro.org/pipermail/coresight/2020-April/003819.html [2] https://lists.linaro.org/pipermail/coresight/2020-April/003821.html Mike Leach (5): coresight: Add principal sink handling to CoreSight base coresight: tmc: Add principal sink attribute detection coresight: etm: perf: Add default sink selection to etm perf perf: cs-etm: Allow no CoreSight sink to be specified on command line dt-bindings: arm: qcom: Add CoreSight principal sink select parameters arch/arm64/boot/dts/arm/juno-base.dtsi | 1 + arch/arm64/boot/dts/qcom/msm8916.dtsi | 1 + .../hwtracing/coresight/coresight-etm-perf.c | 20 +++++++++-- drivers/hwtracing/coresight/coresight-priv.h | 2 ++ drivers/hwtracing/coresight/coresight-tmc.c | 9 +++++ drivers/hwtracing/coresight/coresight.c | 34 +++++++++++++++++++ include/linux/coresight.h | 7 ++++ tools/perf/arch/arm/util/cs-etm.c | 6 ++-- 8 files changed, 74 insertions(+), 6 deletions(-) -- 2.17.1

5 years, 4 months

[PATCH] coresight: cti: Add power management to CTI driver

by Mike Leach

Add in CPU hotplug and CPU idle power management handling to CTI driver. Only CPU bound CTIs will register with the PM routines, to enable PM of CTI alongside PM of ETM devices. Need separate HP PM event CPUHP_AP_ARM_CORESIGHT_CTI_STARTING as events can only be registered once. Applies to Linux 5.7-rc1, tested on platforms Juno-r1 and DB410c. Signed-off-by: Mike Leach <mike.leach(a)linaro.org> --- drivers/hwtracing/coresight/coresight-cti.c | 163 +++++++++++++++++++- include/linux/cpuhotplug.h | 1 + 2 files changed, 156 insertions(+), 8 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-cti.c b/drivers/hwtracing/coresight/coresight-cti.c index aa6e0249bd70..31996a20ce69 100644 --- a/drivers/hwtracing/coresight/coresight-cti.c +++ b/drivers/hwtracing/coresight/coresight-cti.c @@ -5,6 +5,7 @@ */ #include <linux/property.h> +#include <linux/cpu_pm.h> #include "coresight-cti.h" /** @@ -27,6 +28,12 @@ static DEFINE_MUTEX(ect_mutex); #define csdev_to_cti_drvdata(csdev) \ dev_get_drvdata(csdev->dev.parent) +/* power management handling */ +static int nr_cti_cpu; + +/* quick lookup list for CPU bound CTIs when power handling */ +static struct cti_drvdata *cti_cpu_drvdata[NR_CPUS]; + /* * CTI naming. CTI bound to cores will have the name cti_cpu<N> where * N is the CPU ID. System CTIs will have the name cti_sys<I> where I @@ -36,7 +43,7 @@ static DEFINE_MUTEX(ect_mutex); */ DEFINE_CORESIGHT_DEVLIST(cti_sys_devs, "cti_sys"); -/* write set of regs to hardware - call with spinlock claimed */ +/* write set of regs to hardware - call with spinlock claimed / cpu context */ void cti_write_all_hw_regs(struct cti_drvdata *drvdata) { struct cti_config *config = &drvdata->config; @@ -73,7 +80,7 @@ static void cti_enable_hw_smp_call(void *info) } /* write regs to hardware and enable */ -static int cti_enable_hw(struct cti_drvdata *drvdata) +static int cti_enable_hw(struct cti_drvdata *drvdata, bool hp_re_enable) { struct cti_config *config = &drvdata->config; struct device *dev = &drvdata->csdev->dev; @@ -82,8 +89,11 @@ static int cti_enable_hw(struct cti_drvdata *drvdata) pm_runtime_get_sync(dev->parent); spin_lock(&drvdata->spinlock); - /* no need to do anything if enabled or unpowered*/ - if (config->hw_enabled || !config->hw_powered) + /* no need to do anything if enabled or unpowered */ + if (!hp_re_enable) { + if (config->hw_enabled || !config->hw_powered) + goto cti_state_unchanged; + } else if (!atomic_read(&drvdata->config.enable_req_count)) goto cti_state_unchanged; /* claim the device */ @@ -91,7 +101,7 @@ static int cti_enable_hw(struct cti_drvdata *drvdata) if (rc) goto cti_err_not_enabled; - if (drvdata->ctidev.cpu >= 0) { + if (drvdata->ctidev.cpu >= 0 && !hp_re_enable) { rc = smp_call_function_single(drvdata->ctidev.cpu, cti_enable_hw_smp_call, drvdata, 1); @@ -102,12 +112,15 @@ static int cti_enable_hw(struct cti_drvdata *drvdata) } config->hw_enabled = true; - atomic_inc(&drvdata->config.enable_req_count); + if (!hp_re_enable) + atomic_inc(&drvdata->config.enable_req_count); + spin_unlock(&drvdata->spinlock); return rc; cti_state_unchanged: - atomic_inc(&drvdata->config.enable_req_count); + if (!hp_re_enable) + atomic_inc(&drvdata->config.enable_req_count); /* cannot enable due to error */ cti_err_not_enabled: @@ -563,12 +576,127 @@ static void cti_remove_conn_xrefs(struct cti_drvdata *drvdata) } } +/** cti PM callbacks **/ +static int cti_cpu_pm_notify(struct notifier_block *nb, unsigned long cmd, + void *v) +{ + struct cti_drvdata *drvdata; + unsigned int cpu = smp_processor_id(); + + if (!cti_cpu_drvdata[cpu]) + return NOTIFY_OK; + + drvdata = cti_cpu_drvdata[cpu]; + + if (WARN_ON_ONCE(drvdata->ctidev.cpu != cpu)) + return NOTIFY_BAD; + + switch (cmd) { + case CPU_PM_ENTER: + /* CTI regs all static - we have a copy & nothing to save */ + drvdata->config.hw_powered = false; + if (drvdata->config.hw_enabled) + coresight_disclaim_device(drvdata->base); + break; + + case CPU_PM_ENTER_FAILED: + drvdata->config.hw_powered = true; + if (drvdata->config.hw_enabled) { + if (coresight_claim_device(drvdata->base)) + drvdata->config.hw_enabled = false; + } + break; + + case CPU_PM_EXIT: + /* write hardware registers to re-enable. */ + drvdata->config.hw_powered = true; + drvdata->config.hw_enabled = false; + + /* check enable reference count to enable HW */ + if (atomic_read(&drvdata->config.enable_req_count)) { + /* check we can claim the device as we re-power */ + if (coresight_claim_device(drvdata->base)) + return NOTIFY_OK; + + drvdata->config.hw_enabled = true; + cti_write_all_hw_regs(drvdata); + } + break; + default: + return NOTIFY_DONE; + } + + return NOTIFY_OK; +} + +static struct notifier_block cti_cpu_pm_nb = { + .notifier_call = cti_cpu_pm_notify, +}; + +static int cti_cpu_pm_register(void) +{ + if (IS_ENABLED(CONFIG_CPU_PM)) + return cpu_pm_register_notifier(&cti_cpu_pm_nb); + + return 0; +} + +static void cti_cpu_pm_unregister(void) +{ + if (IS_ENABLED(CONFIG_CPU_PM)) + cpu_pm_unregister_notifier(&cti_cpu_pm_nb); +} + +/* CPU HP handlers */ +static int cti_starting_cpu(unsigned int cpu) +{ + struct cti_drvdata *drvdata = cti_cpu_drvdata[cpu]; + + if (!drvdata) + return 0; + + spin_lock(&drvdata->spinlock); + drvdata->config.hw_powered = true; + spin_unlock(&drvdata->spinlock); + + cti_enable_hw(drvdata, true); + return 0; +} + +static int cti_dying_cpu(unsigned int cpu) +{ + struct cti_drvdata *drvdata = cti_cpu_drvdata[cpu]; + + if (!drvdata) + return 0; + + spin_lock(&drvdata->spinlock); + drvdata->config.hw_powered = false; + coresight_disclaim_device(drvdata->base); + spin_unlock(&drvdata->spinlock); + return 0; +} + +/* release PM registrations */ +static void cti_pm_release(struct cti_drvdata *drvdata) +{ + if (drvdata->ctidev.cpu >= 0) { + if (--nr_cti_cpu == 0) { + cti_cpu_pm_unregister(); + + cpuhp_remove_state_nocalls( + CPUHP_AP_ARM_CORESIGHT_CTI_STARTING); + } + cti_cpu_drvdata[drvdata->ctidev.cpu] = NULL; + } +} + /** cti ect operations **/ int cti_enable(struct coresight_device *csdev) { struct cti_drvdata *drvdata = csdev_to_cti_drvdata(csdev); - return cti_enable_hw(drvdata); + return cti_enable_hw(drvdata, false); } int cti_disable(struct coresight_device *csdev) @@ -598,6 +726,7 @@ static void cti_device_release(struct device *dev) mutex_lock(&ect_mutex); cti_remove_conn_xrefs(drvdata); + cti_pm_release(drvdata); /* remove from the list */ list_for_each_entry_safe(ect_item, ect_tmp, &ect_net, node) { @@ -673,6 +802,23 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) goto err_out; } + /* setup CPU power management handling for CPU bound CTI devices. */ + if (drvdata->ctidev.cpu >= 0) { + cti_cpu_drvdata[drvdata->ctidev.cpu] = drvdata; + if (!nr_cti_cpu++) { + cpus_read_lock(); + cpuhp_setup_state_nocalls_cpuslocked( + CPUHP_AP_ARM_CORESIGHT_CTI_STARTING, + "arm/coresight_cti:starting", + cti_starting_cpu, cti_dying_cpu); + + ret = cti_cpu_pm_register(); + cpus_read_unlock(); + if (ret) + goto err_out; + } + } + /* create dynamic attributes for connections */ ret = cti_create_cons_sysfs(dev, drvdata); if (ret) { @@ -711,6 +857,7 @@ static int cti_probe(struct amba_device *adev, const struct amba_id *id) return 0; err_out: + cti_pm_release(drvdata); return ret; } diff --git a/include/linux/cpuhotplug.h b/include/linux/cpuhotplug.h index 77d70b633531..6dc7332307ca 100644 --- a/include/linux/cpuhotplug.h +++ b/include/linux/cpuhotplug.h @@ -142,6 +142,7 @@ enum cpuhp_state { CPUHP_AP_ARM_XEN_STARTING, CPUHP_AP_ARM_KVMPV_STARTING, CPUHP_AP_ARM_CORESIGHT_STARTING, + CPUHP_AP_ARM_CORESIGHT_CTI_STARTING, CPUHP_AP_ARM64_ISNDEP_STARTING, CPUHP_AP_SMPCFD_DYING, CPUHP_AP_X86_TBOOT_DYING, -- 2.17.1

5 years, 4 months

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

CoreSight